nextcloud / server

apps/dav/lib/CardDAV/CardDavBackend.php

Doc Comments +8 added lines, -3 removed lines

@@ -101,7 +101,7 @@ 
 	/**
 	 * Return the number of address books for a principal
 	 *
-	 * @param $principalUri
+	 * @param string $principalUri
 	 * @return int
 	 */
 	public function getAddressBooksForUserCount($principalUri) {
@@ -234,7 +234,8 @@ 
 	}
 
 	/**
-	 * @param $addressBookUri
+	 * @param string $addressBookUri
+	 * @param string $principal
 	 * @return array|null
 	 */
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -916,6 +917,7 @@ 
 	 *   * readOnly - boolean
 	 *   * summary - Optional, a description for the share
 	 *
+	 * @param integer $addressBookId
 	 * @return array
 	 */
 	public function getShares($addressBookId) {
@@ -1015,7 +1017,7 @@ 
 
 	/**
 	 * For shared address books the sharee is set in the ACL of the address book
-	 * @param $addressBookId
+	 * @param integer $addressBookId
 	 * @param $acl
 	 * @return array
 	 */
@@ -1023,6 +1025,9 @@ 
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

apps/dav/lib/CalDAV/PublicCalendarRoot.php

Unused Use Statements -1 removed lines

@@ -21,7 +21,6 @@
 namespace OCA\DAV\CalDAV;
 
 use Sabre\DAV\Collection;
-use Sabre\DAV\Exception\NotFound;
 
 class PublicCalendarRoot extends Collection {
 

lib/private/AppFramework/Http/Output.php

Doc Comments +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
 	private $webRoot;
 
 	/**
-	 * @param $webRoot
+	 * @param string $webRoot
 	 */
 	public function __construct($webRoot) {
 		$this->webRoot = $webRoot;

apps/files_external/lib/Service/DBConfigService.php

Doc Comments +16 added lines

@@ -89,6 +89,9 @@ 
 		return $this->getMountsFromQuery($query);
 	}
 
+	/**
+	 * @param string $userId
+	 */
 	public function getMountsForUser($userId, $groupIds) {
 		$builder = $this->connection->getQueryBuilder();
 		$query = $builder->select(['m.mount_id', 'mount_point', 'storage_backend', 'auth_backend', 'priority', 'm.type'])
@@ -125,6 +128,10 @@ 
 		return $this->getMountsFromQuery($query);
 	}
 
+	/**
+	 * @param integer $type
+	 * @param string|null $value
+	 */
 	protected function getForQuery(IQueryBuilder $builder, $type, $value) {
 		$query = $builder->select(['m.mount_id', 'mount_point', 'storage_backend', 'auth_backend', 'priority', 'm.type'])
 			->from('external_mounts', 'm')
@@ -332,6 +339,9 @@ 
 		}
 	}
 
+	/**
+	 * @param integer $mountId
+	 */
 	public function addApplicable($mountId, $type, $value) {
 		$this->connection->insertIfNotExist('*PREFIX*external_applicable', [
 			'mount_id' => $mountId,
@@ -340,6 +350,9 @@ 
 		], ['mount_id', 'type', 'value']);
 	}
 
+	/**
+	 * @param integer $mountId
+	 */
 	public function removeApplicable($mountId, $type, $value) {
 		$builder = $this->connection->getQueryBuilder();
 		$query = $builder->delete('external_applicable')
@@ -473,6 +486,9 @@ 
 		return array_combine($keys, $values);
 	}
 
+	/**
+	 * @param string $value
+	 */
 	private function encryptValue($value) {
 		return $this->crypto->encrypt($value);
 	}

apps/federation/lib/AppInfo/Application.php

Unused Use Statements -3 removed lines

@@ -24,16 +24,13 @@
 
 namespace OCA\Federation\AppInfo;
 
-use OCA\Federation\API\OCSAuthAPI;
 use OCA\Federation\Controller\SettingsController;
 use OCA\Federation\DAV\FedAuth;
 use OCA\Federation\DbHandler;
 use OCA\Federation\Hooks;
 use OCA\Federation\Middleware\AddServerMiddleware;
 use OCA\Federation\SyncFederationAddressBooks;
-use OCA\Federation\SyncJob;
 use OCA\Federation\TrustedServers;
-use OCP\API;
 use OCP\App;
 use OCP\AppFramework\IAppContainer;
 use OCP\SabrePluginEvent;

lib/private/AppFramework/OCS/BaseResponse.php

Doc Comments +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 	/**
 	 * BaseResponse constructor.
 	 *
-	 * @param DataResponse|null $dataResponse
+	 * @param DataResponse $dataResponse
 	 * @param string $format
 	 * @param string|null $statusMessage
 	 * @param int|null $itemsCount

lib/private/Server.php

Doc Comments +2 added lines, -1 removed lines

@@ -1143,7 +1143,7 @@ 
 	 * Get the certificate manager for the user
 	 *
 	 * @param string $userId (optional) if not specified the current loggedin user is used, use null to get the system certificate manager
-	 * @return \OCP\ICertificateManager | null if $uid is null and no user is logged in
+	 * @return null|CertificateManager | null if $uid is null and no user is logged in
 	 */
 	public function getCertificateManager($userId = '') {
 		if ($userId === '') {
@@ -1464,6 +1464,7 @@ 
 	}
 
 	/**
+	 * @param string $app
 	 * @return \OCP\Files\IAppData
 	 */
 	public function getAppDataDir($app) {

lib/public/AppFramework/Http/Response.php

Doc Comments +2 added lines, -2 removed lines

@@ -226,7 +226,7 @@ 
 
 	/**
 	 * By default renders no output
-	 * @return null
+	 * @return string
 	 * @since 6.0.0
 	 */
 	public function render() {
@@ -259,7 +259,7 @@ 
 
 	/**
 	 * Get the currently used Content-Security-Policy
-	 * @return EmptyContentSecurityPolicy|null Used Content-Security-Policy or null if
+	 * @return ContentSecurityPolicy|null Used Content-Security-Policy or null if
 	 *                                    none specified.
 	 * @since 8.1.0
 	 */

apps/dav/lib/CalDAV/Publishing/PublishPlugin.php

Doc Comments +1 added lines, -1 removed lines

@@ -134,7 +134,7 @@
 	 * @param RequestInterface $request
 	 * @param ResponseInterface $response
 	 *
-	 * @return void|bool
+	 * @return null|false
 	 */
 	public function httpPost(RequestInterface $request, ResponseInterface $response) {
 		$path = $request->getPath();