Passed
Push — master ( 1ad063...0f7fb7 )
by Morris
22:31 queued 11:17
created
core/Command/Integrity/CheckApp.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
 	 */
70 70
 	protected function execute(InputInterface $input, OutputInterface $output): int {
71 71
 		$appid = $input->getArgument('appid');
72
-		$path = (string)$input->getOption('path');
72
+		$path = (string) $input->getOption('path');
73 73
 		$result = $this->checker->verifyAppSignature($appid, $path);
74 74
 		$this->writeArrayInOutputFormat($input, $output, $result);
75 75
 		if (count($result) > 0) {
Please login to merge, or discard this patch.
core/Command/Preview/Repair.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 		 * by default there could be 0-9 a-f and the old-multibucket folder which are all fine
117 117
 		 */
118 118
 		if ($total < 18) {
119
-			$directoryListing = array_filter($directoryListing, function ($dir) {
119
+			$directoryListing = array_filter($directoryListing, function($dir) {
120 120
 				if ($dir->getName() === 'old-multibucket') {
121 121
 					return false;
122 122
 				}
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
 				return 1;
222 222
 			}
223 223
 
224
-			$lockName = 'occ preview:repair lock ' . $oldPreviewFolder->getId();
224
+			$lockName = 'occ preview:repair lock '.$oldPreviewFolder->getId();
225 225
 			try {
226 226
 				$section1->writeln("         Locking \"$lockName\" …", OutputInterface::VERBOSITY_VERBOSE);
227 227
 				$this->lockingProvider->acquireLock($lockName, ILockingProvider::LOCK_EXCLUSIVE);
Please login to merge, or discard this patch.
core/Command/Db/ConvertType.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
 	}
284 284
 
285 285
 	protected function getTables(Connection $db) {
286
-		$filterExpression = '/^' . preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')) . '/';
286
+		$filterExpression = '/^'.preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')).'/';
287 287
 		$db->getConfiguration()->
288 288
 			setFilterSchemaAssetsExpression($filterExpression);
289 289
 		return $db->getSchemaManager()->listTableNames();
@@ -297,7 +297,7 @@  discard block
 block discarded – undo
297 297
 	 * @param OutputInterface $output
298 298
 	 */
299 299
 	protected function copyTable(Connection $fromDB, Connection $toDB, Table $table, InputInterface $input, OutputInterface $output) {
300
-		if ($table->getName() === $toDB->getPrefix() . 'migrations') {
300
+		if ($table->getName() === $toDB->getPrefix().'migrations') {
301 301
 			$output->writeln('<comment>Skipping migrations table because it was already filled by running the migrations</comment>');
302 302
 			return;
303 303
 		}
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
 
315 315
 		$numChunks = ceil($count / $chunkSize);
316 316
 		if ($numChunks > 1) {
317
-			$output->writeln('chunked query, ' . $numChunks . ' chunks');
317
+			$output->writeln('chunked query, '.$numChunks.' chunks');
318 318
 		}
319 319
 
320 320
 		$progress = new ProgressBar($output, $count);
Please login to merge, or discard this patch.
core/templates/installation.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
 <input type="hidden" name="install" value="true">
12 12
 	<?php if (count($_['errors']) > 0): ?>
13 13
 	<fieldset class="warning">
14
-		<legend><strong><?php p($l->t('Error'));?></strong></legend>
14
+		<legend><strong><?php p($l->t('Error')); ?></strong></legend>
15 15
 		<?php foreach ($_['errors'] as $err): ?>
16 16
 		<p>
17 17
 			<?php if (is_array($err)):?>
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
26 26
 	<?php endif; ?>
27 27
 	<?php if (!$_['htaccessWorking']): ?>
28 28
 	<fieldset class="warning">
29
-		<legend><strong><?php p($l->t('Security warning'));?></strong></legend>
30
-		<p><?php p($l->t('Your data directory and files are probably accessible from the internet because the .htaccess file does not work.'));?><br>
29
+		<legend><strong><?php p($l->t('Security warning')); ?></strong></legend>
30
+		<p><?php p($l->t('Your data directory and files are probably accessible from the internet because the .htaccess file does not work.')); ?><br>
31 31
 		<?php print_unescaped($l->t(
32 32
 			'For information how to properly configure your server, please see the <a href="%s" target="_blank" rel="noreferrer noopener">documentation</a>.',
33 33
 			[link_to_docs('admin-install')]
@@ -154,9 +154,9 @@  discard block
 block discarded – undo
154 154
 
155 155
 	<?php if (!$_['dbIsSet'] or count($_['errors']) > 0): ?>
156 156
 		<fieldset id="sqliteInformation" class="warning">
157
-			<legend><?php p($l->t('Performance warning'));?></legend>
158
-			<p><?php p($l->t('You chose SQLite as database.'));?></p>
159
-			<p><?php p($l->t('SQLite should only be used for minimal and development instances. For production we recommend a different database backend.'));?></p>
157
+			<legend><?php p($l->t('Performance warning')); ?></legend>
158
+			<p><?php p($l->t('You chose SQLite as database.')); ?></p>
159
+			<p><?php p($l->t('SQLite should only be used for minimal and development instances. For production we recommend a different database backend.')); ?></p>
160 160
 			<p><?php p($l->t('If you use clients for file syncing, the use of SQLite is highly discouraged.')); ?></p>
161 161
 		</fieldset>
162 162
 	<?php endif ?>
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
 
178 178
 	<p class="info">
179 179
 		<span class="icon-info-white"></span>
180
-		<?php p($l->t('Need help?'));?>
181
-		<a target="_blank" rel="noreferrer noopener" href="<?php p(link_to_docs('admin-install')); ?>"><?php p($l->t('See the documentation'));?> ↗</a>
180
+		<?php p($l->t('Need help?')); ?>
181
+		<a target="_blank" rel="noreferrer noopener" href="<?php p(link_to_docs('admin-install')); ?>"><?php p($l->t('See the documentation')); ?> ↗</a>
182 182
 	</p>
183 183
 </form>
Please login to merge, or discard this patch.
core/templates/layout.public.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
 	<meta charset="utf-8">
5 5
 	<title>
6 6
 		<?php
7
-		p(!empty($_['application'])?$_['application'].' - ':'');
7
+		p(!empty($_['application']) ? $_['application'].' - ' : '');
8 8
 		p($theme->getTitle());
9 9
 		?>
10 10
 	</title>
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
 	<?php } ?>
16 16
 	<meta name="apple-mobile-web-app-capable" content="yes">
17 17
 	<meta name="apple-mobile-web-app-status-bar-style" content="black">
18
-	<meta name="apple-mobile-web-app-title" content="<?php p((!empty($_['application']) && $_['appid'] !== 'files')? $_['application']:$theme->getTitle()); ?>">
18
+	<meta name="apple-mobile-web-app-title" content="<?php p((!empty($_['application']) && $_['appid'] !== 'files') ? $_['application'] : $theme->getTitle()); ?>">
19 19
 	<meta name="mobile-web-app-capable" content="yes">
20 20
 	<meta name="theme-color" content="<?php p($theme->getColorPrimary()); ?>">
21 21
 	<link rel="icon" href="<?php print_unescaped(image_path($_['appid'], 'favicon.ico')); /* IE11+ supports png */ ?>">
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 	<?php emit_script_loading_tags($_); ?>
28 28
 	<?php print_unescaped($_['headers']); ?>
29 29
 </head>
30
-<body id="<?php p($_['bodyid']);?>">
30
+<body id="<?php p($_['bodyid']); ?>">
31 31
 <?php include('layout.noscript.warning.php'); ?>
32 32
 <?php foreach ($_['initialStates'] as $app => $initialState) { ?>
33 33
 	<input type="hidden" id="initial-state-<?php p($app); ?>" value="<?php p(base64_encode($initialState)); ?>">
Please login to merge, or discard this patch.
core/templates/layout.user.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
 		<meta charset="utf-8">
5 5
 		<title>
6 6
 			<?php
7
-				p(!empty($_['application'])?$_['application'].' - ':'');
7
+				p(!empty($_['application']) ? $_['application'].' - ' : '');
8 8
 				p($theme->getTitle());
9 9
 			?>
10 10
 		</title>
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
 		<?php } ?>
16 16
 		<meta name="apple-mobile-web-app-capable" content="yes">
17 17
 		<meta name="apple-mobile-web-app-status-bar-style" content="black">
18
-		<meta name="apple-mobile-web-app-title" content="<?php p((!empty($_['application']) && $_['appid'] != 'files')? $_['application']:$theme->getTitle()); ?>">
18
+		<meta name="apple-mobile-web-app-title" content="<?php p((!empty($_['application']) && $_['appid'] != 'files') ? $_['application'] : $theme->getTitle()); ?>">
19 19
 		<meta name="mobile-web-app-capable" content="yes">
20 20
 		<meta name="theme-color" content="<?php p($theme->getColorPrimary()); ?>">
21 21
 		<link rel="icon" href="<?php print_unescaped(image_path($_['appid'], 'favicon.ico')); /* IE11+ supports png */ ?>">
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 		<?php emit_script_loading_tags($_); ?>
28 28
 		<?php print_unescaped($_['headers']); ?>
29 29
 	</head>
30
-	<body id="<?php p($_['bodyid']);?>">
30
+	<body id="<?php p($_['bodyid']); ?>">
31 31
 	<?php include 'layout.noscript.warning.php'; ?>
32 32
 
33 33
 		<?php foreach ($_['initialStates'] as $app => $initialState) { ?>
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 					id="nextcloud">
47 47
 					<div class="logo logo-icon">
48 48
 						<h1 class="hidden-visually">
49
-							<?php p($theme->getName()); ?> <?php p(!empty($_['application'])?$_['application']: $l->t('Apps')); ?>
49
+							<?php p($theme->getName()); ?> <?php p(!empty($_['application']) ? $_['application'] : $l->t('Apps')); ?>
50 50
 						</h1>
51 51
 					</div>
52 52
 				</a>
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
 										<?php if ($_['themingInvertMenu']) { ?>
62 62
 										<defs><filter id="invertMenuMain-<?php p($entry['id']); ?>"><feColorMatrix in="SourceGraphic" type="matrix" values="-1 0 0 0 1 0 -1 0 0 1 0 0 -1 0 1 0 0 0 1 0" /></filter></defs>
63 63
 										<?php } ?>
64
-										<image x="0" y="0" width="20" height="20" preserveAspectRatio="xMinYMin meet"<?php if ($_['themingInvertMenu']) { ?> filter="url(#invertMenuMain-<?php p($entry['id']); ?>)"<?php } ?> xlink:href="<?php print_unescaped($entry['icon'] . '?v=' . $_['versionHash']); ?>"  class="app-icon"></image>
64
+										<image x="0" y="0" width="20" height="20" preserveAspectRatio="xMinYMin meet"<?php if ($_['themingInvertMenu']) { ?> filter="url(#invertMenuMain-<?php p($entry['id']); ?>)"<?php } ?> xlink:href="<?php print_unescaped($entry['icon'].'?v='.$_['versionHash']); ?>"  class="app-icon"></image>
65 65
 									</svg>
66 66
 								<span>
67 67
 									<?php p($entry['name']); ?>
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 										aria-label="<?php p($entry['name']); ?>">
90 90
 										<svg width="16" height="16" viewBox="0 0 16 16" alt="">
91 91
 											<defs><filter id="invertMenuMore-<?php p($entry['id']); ?>"><feColorMatrix in="SourceGraphic" type="matrix" values="-1 0 0 0 1 0 -1 0 0 1 0 0 -1 0 1 0 0 0 1 0"></feColorMatrix></filter></defs>
92
-											<image x="0" y="0" width="16" height="16" preserveAspectRatio="xMinYMin meet" filter="url(#invertMenuMore-<?php p($entry['id']); ?>)" xlink:href="<?php print_unescaped($entry['icon'] . '?v=' . $_['versionHash']); ?>"  class="app-icon"></image>
92
+											<image x="0" y="0" width="16" height="16" preserveAspectRatio="xMinYMin meet" filter="url(#invertMenuMore-<?php p($entry['id']); ?>)" xlink:href="<?php print_unescaped($entry['icon'].'?v='.$_['versionHash']); ?>"  class="app-icon"></image>
93 93
 										</svg>
94 94
 										<span><?php p($entry['name']); ?></span>
95 95
 									</a>
@@ -107,14 +107,14 @@  discard block
 block discarded – undo
107 107
 				<div id="contactsmenu">
108 108
 					<div class="icon-contacts menutoggle" tabindex="0" role="button"
109 109
 					aria-haspopup="true" aria-controls="contactsmenu-menu" aria-expanded="false">
110
-						<span class="hidden-visually"><?php p($l->t('Contacts'));?></span>
110
+						<span class="hidden-visually"><?php p($l->t('Contacts')); ?></span>
111 111
 					</div>
112 112
 					<div id="contactsmenu-menu" class="menu"
113
-						aria-label="<?php p($l->t('Contacts menu'));?>"></div>
113
+						aria-label="<?php p($l->t('Contacts menu')); ?>"></div>
114 114
 				</div>
115 115
 				<div id="settings">
116 116
 					<div id="expand" tabindex="0" role="button" class="menutoggle"
117
-						aria-label="<?php p($l->t('Settings'));?>"
117
+						aria-label="<?php p($l->t('Settings')); ?>"
118 118
 						aria-haspopup="true" aria-controls="expanddiv" aria-expanded="false">
119 119
 						<div class="avatardiv<?php if ($_['userAvatarSet']) {
120 120
 				print_unescaped(' avatardiv-shown');
@@ -123,21 +123,21 @@  discard block
 block discarded – undo
123 123
 			} ?>">
124 124
 							<?php if ($_['userAvatarSet']): ?>
125 125
 								<img alt="" width="32" height="32"
126
-								src="<?php p(\OC::$server->getURLGenerator()->linkToRoute('core.avatar.getAvatar', ['userId' => $_['user_uid'], 'size' => 32, 'v' => $_['userAvatarVersion']]));?>"
127
-								srcset="<?php p(\OC::$server->getURLGenerator()->linkToRoute('core.avatar.getAvatar', ['userId' => $_['user_uid'], 'size' => 64, 'v' => $_['userAvatarVersion']]));?> 2x, <?php p(\OC::$server->getURLGenerator()->linkToRoute('core.avatar.getAvatar', ['userId' => $_['user_uid'], 'size' => 128, 'v' => $_['userAvatarVersion']]));?> 4x"
126
+								src="<?php p(\OC::$server->getURLGenerator()->linkToRoute('core.avatar.getAvatar', ['userId' => $_['user_uid'], 'size' => 32, 'v' => $_['userAvatarVersion']])); ?>"
127
+								srcset="<?php p(\OC::$server->getURLGenerator()->linkToRoute('core.avatar.getAvatar', ['userId' => $_['user_uid'], 'size' => 64, 'v' => $_['userAvatarVersion']])); ?> 2x, <?php p(\OC::$server->getURLGenerator()->linkToRoute('core.avatar.getAvatar', ['userId' => $_['user_uid'], 'size' => 128, 'v' => $_['userAvatarVersion']])); ?> 4x"
128 128
 								>
129 129
 							<?php endif; ?>
130 130
 						</div>
131 131
 						<div id="expandDisplayName" class="icon-settings-white"></div>
132 132
 					</div>
133 133
 					<nav class="settings-menu" id="expanddiv" style="display:none;"
134
-						aria-label="<?php p($l->t('Settings menu'));?>">
134
+						aria-label="<?php p($l->t('Settings menu')); ?>">
135 135
 					<ul>
136 136
 					<?php foreach ($_['settingsnavigation'] as $entry):?>
137 137
 						<li data-id="<?php p($entry['id']); ?>">
138 138
 							<a href="<?php print_unescaped($entry['href']); ?>"
139 139
 								<?php if ($entry["active"]): ?> class="active"<?php endif; ?>>
140
-								<img alt="" src="<?php print_unescaped($entry['icon'] . '?v=' . $_['versionHash']); ?>">
140
+								<img alt="" src="<?php print_unescaped($entry['icon'].'?v='.$_['versionHash']); ?>">
141 141
 								<?php p($entry['name']) ?>
142 142
 							</a>
143 143
 						</li>
Please login to merge, or discard this patch.
ocs/v1.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,8 +29,8 @@
 block discarded – undo
29 29
  *
30 30
  */
31 31
 
32
-require_once __DIR__ . '/../lib/versioncheck.php';
33
-require_once __DIR__ . '/../lib/base.php';
32
+require_once __DIR__.'/../lib/versioncheck.php';
33
+require_once __DIR__.'/../lib/base.php';
34 34
 
35 35
 if (\OCP\Util::needUpgrade()
36 36
 	|| \OC::$server->getConfig()->getSystemValueBool('maintenance')) {
Please login to merge, or discard this patch.
remote.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
  *
33 33
  */
34 34
 
35
-require_once __DIR__ . '/lib/versioncheck.php';
35
+require_once __DIR__.'/lib/versioncheck.php';
36 36
 
37 37
 use OCA\DAV\Connector\Sabre\ExceptionLoggerPlugin;
38 38
 use Sabre\DAV\Exception\ServiceUnavailable;
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 			// we shall not log on RemoteException
61 61
 			$server->addPlugin(new ExceptionLoggerPlugin('webdav', \OC::$server->getLogger()));
62 62
 		}
63
-		$server->on('beforeMethod:*', function () use ($e) {
63
+		$server->on('beforeMethod:*', function() use ($e) {
64 64
 			if ($e instanceof RemoteException) {
65 65
 				switch ($e->getCode()) {
66 66
 					case 503:
@@ -108,11 +108,11 @@  discard block
 block discarded – undo
108 108
 		return $services[$service];
109 109
 	}
110 110
 
111
-	return \OC::$server->getConfig()->getAppValue('core', 'remote_' . $service);
111
+	return \OC::$server->getConfig()->getAppValue('core', 'remote_'.$service);
112 112
 }
113 113
 
114 114
 try {
115
-	require_once __DIR__ . '/lib/base.php';
115
+	require_once __DIR__.'/lib/base.php';
116 116
 
117 117
 	// All resources served via the DAV endpoint should have the strictest possible
118 118
 	// policy. Exempted from this is the SabreDAV browser plugin which overwrites
@@ -153,17 +153,17 @@  discard block
 block discarded – undo
153 153
 
154 154
 	switch ($app) {
155 155
 		case 'core':
156
-			$file = OC::$SERVERROOT .'/'. $file;
156
+			$file = OC::$SERVERROOT.'/'.$file;
157 157
 			break;
158 158
 		default:
159 159
 			if (!\OC::$server->getAppManager()->isInstalled($app)) {
160
-				throw new RemoteException('App not installed: ' . $app);
160
+				throw new RemoteException('App not installed: '.$app);
161 161
 			}
162 162
 			OC_App::loadApp($app);
163
-			$file = OC_App::getAppPath($app) .'/'. $parts[1];
163
+			$file = OC_App::getAppPath($app).'/'.$parts[1];
164 164
 			break;
165 165
 	}
166
-	$baseuri = OC::$WEBROOT . '/remote.php/'.$service.'/';
166
+	$baseuri = OC::$WEBROOT.'/remote.php/'.$service.'/';
167 167
 	require_once $file;
168 168
 } catch (Exception $ex) {
169 169
 	handleException($ex);
Please login to merge, or discard this patch.
apps/files_trashbin/lib/Expiration.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 	/** @var bool */
52 52
 	private $canPurgeToSaveSpace;
53 53
 
54
-	public function __construct(IConfig $config,ITimeFactory $timeFactory) {
54
+	public function __construct(IConfig $config, ITimeFactory $timeFactory) {
55 55
 		$this->timeFactory = $timeFactory;
56 56
 		$this->setRetentionObligation($config->getSystemValue('trashbin_retention_obligation', 'auto'));
57 57
 	}
@@ -150,13 +150,13 @@  discard block
 block discarded – undo
150 150
 			$this->canPurgeToSaveSpace = true;
151 151
 		} elseif ($minValue !== 'auto' && $maxValue === 'auto') {
152 152
 			// Keep for X days but delete anytime if space needed
153
-			$this->minAge = (int)$minValue;
153
+			$this->minAge = (int) $minValue;
154 154
 			$this->maxAge = self::NO_OBLIGATION;
155 155
 			$this->canPurgeToSaveSpace = true;
156 156
 		} elseif ($minValue === 'auto' && $maxValue !== 'auto') {
157 157
 			// Delete anytime if space needed, Delete all older than max automatically
158 158
 			$this->minAge = self::NO_OBLIGATION;
159
-			$this->maxAge = (int)$maxValue;
159
+			$this->maxAge = (int) $maxValue;
160 160
 			$this->canPurgeToSaveSpace = true;
161 161
 		} elseif ($minValue !== 'auto' && $maxValue !== 'auto') {
162 162
 			// Delete all older than max OR older than min if space needed
@@ -166,8 +166,8 @@  discard block
 block discarded – undo
166 166
 				$maxValue = $minValue;
167 167
 			}
168 168
 
169
-			$this->minAge = (int)$minValue;
170
-			$this->maxAge = (int)$maxValue;
169
+			$this->minAge = (int) $minValue;
170
+			$this->maxAge = (int) $maxValue;
171 171
 			$this->canPurgeToSaveSpace = false;
172 172
 		}
173 173
 	}
Please login to merge, or discard this patch.