nextcloud / server

lib/public/Remote/IInstance.php

Indentation +32 added lines, -32 removed lines

@@ -27,40 +27,40 @@
  * @since 13.0.0
  */
 interface IInstance {
-	/**
-	 * @return string The url of the remote server without protocol
-	 *
-	 * @since 13.0.0
-	 */
-	public function getUrl();
+    /**
+     * @return string The url of the remote server without protocol
+     *
+     * @since 13.0.0
+     */
+    public function getUrl();
 
-	/**
-	 * @return string The of of the remote server with protocol
-	 *
-	 * @since 13.0.0
-	 */
-	public function getFullUrl();
+    /**
+     * @return string The of of the remote server with protocol
+     *
+     * @since 13.0.0
+     */
+    public function getFullUrl();
 
-	/**
-	 * @return string The full version string in '13.1.2.3' format
-	 *
-	 * @since 13.0.0
-	 */
-	public function getVersion();
+    /**
+     * @return string The full version string in '13.1.2.3' format
+     *
+     * @since 13.0.0
+     */
+    public function getVersion();
 
-	/**
-	 * @return string 'http' or 'https'
-	 *
-	 * @since 13.0.0
-	 */
-	public function getProtocol();
+    /**
+     * @return string 'http' or 'https'
+     *
+     * @since 13.0.0
+     */
+    public function getProtocol();
 
-	/**
-	 * Check that the remote server is installed and not in maintenance mode
-	 *
-	 * @since 13.0.0
-	 *
-	 * @return bool
-	 */
-	public function isActive();
+    /**
+     * Check that the remote server is installed and not in maintenance mode
+     *
+     * @since 13.0.0
+     *
+     * @return bool
+     */
+    public function isActive();
 }

lib/private/Remote/Api/ApiBase.php

Doc Comments +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
 	 * @param array $body
 	 * @param array $query
 	 * @param array $headers
-	 * @return resource|string
+	 * @return string
 	 * @throws \InvalidArgumentException
 	 */
 	protected function request($method, $url, array $body = [], array $query = [], array $headers = []) {

Indentation +61 added lines, -61 removed lines

@@ -26,72 +26,72 @@
 use OCP\Remote\IInstance;
 
 class ApiBase {
-	/** @var IInstance */
-	private $instance;
-	/** @var ICredentials */
-	private $credentials;
-	/** @var IClientService */
-	private $clientService;
+    /** @var IInstance */
+    private $instance;
+    /** @var ICredentials */
+    private $credentials;
+    /** @var IClientService */
+    private $clientService;
 
-	public function __construct(IInstance $instance, ICredentials $credentials, IClientService $clientService) {
-		$this->instance = $instance;
-		$this->credentials = $credentials;
-		$this->clientService = $clientService;
-	}
+    public function __construct(IInstance $instance, ICredentials $credentials, IClientService $clientService) {
+        $this->instance = $instance;
+        $this->credentials = $credentials;
+        $this->clientService = $clientService;
+    }
 
-	protected function getHttpClient() {
-		return $this->clientService->newClient();
-	}
+    protected function getHttpClient() {
+        return $this->clientService->newClient();
+    }
 
-	protected function addDefaultHeaders(array $headers) {
-		return array_merge([
-			'OCS-APIREQUEST' => 'true',
-			'Accept' => 'application/json'
-		], $headers);
-	}
+    protected function addDefaultHeaders(array $headers) {
+        return array_merge([
+            'OCS-APIREQUEST' => 'true',
+            'Accept' => 'application/json'
+        ], $headers);
+    }
 
-	/**
-	 * @param string $method
-	 * @param string $url
-	 * @param array $body
-	 * @param array $query
-	 * @param array $headers
-	 * @return resource|string
-	 * @throws \InvalidArgumentException
-	 */
-	protected function request($method, $url, array $body = [], array $query = [], array $headers = []) {
-		$fullUrl = trim($this->instance->getFullUrl(), '/') . '/' . $url;
-		$options = [
-			'query' => $query,
-			'headers' => $this->addDefaultHeaders($headers),
-			'auth' => [$this->credentials->getUsername(), $this->credentials->getPassword()]
-		];
-		if ($body) {
-			$options['body'] = $body;
-		}
+    /**
+     * @param string $method
+     * @param string $url
+     * @param array $body
+     * @param array $query
+     * @param array $headers
+     * @return resource|string
+     * @throws \InvalidArgumentException
+     */
+    protected function request($method, $url, array $body = [], array $query = [], array $headers = []) {
+        $fullUrl = trim($this->instance->getFullUrl(), '/') . '/' . $url;
+        $options = [
+            'query' => $query,
+            'headers' => $this->addDefaultHeaders($headers),
+            'auth' => [$this->credentials->getUsername(), $this->credentials->getPassword()]
+        ];
+        if ($body) {
+            $options['body'] = $body;
+        }
 
-		$client = $this->getHttpClient();
+        $client = $this->getHttpClient();
 
-		switch ($method) {
-			case 'get':
-				$response = $client->get($fullUrl, $options);
-				break;
-			case 'post':
-				$response = $client->post($fullUrl, $options);
-				break;
-			case 'put':
-				$response = $client->put($fullUrl, $options);
-				break;
-			case 'delete':
-				$response = $client->delete($fullUrl, $options);
-				break;
-			case 'options':
-				$response = $client->options($fullUrl, $options);
-				break;
-			default:
-				throw new \InvalidArgumentException('Invalid method ' . $method);
-		}
+        switch ($method) {
+            case 'get':
+                $response = $client->get($fullUrl, $options);
+                break;
+            case 'post':
+                $response = $client->post($fullUrl, $options);
+                break;
+            case 'put':
+                $response = $client->put($fullUrl, $options);
+                break;
+            case 'delete':
+                $response = $client->delete($fullUrl, $options);
+                break;
+            case 'options':
+                $response = $client->options($fullUrl, $options);
+                break;
+            default:
+                throw new \InvalidArgumentException('Invalid method ' . $method);
+        }
 
-		return $response->getBody();
-	}
+        return $response->getBody();
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -60,7 +60,7 @@ 
 	 * @throws \InvalidArgumentException
 	 */
 	protected function request($method, $url, array $body = [], array $query = [], array $headers = []) {
-		$fullUrl = trim($this->instance->getFullUrl(), '/') . '/' . $url;
+		$fullUrl = trim($this->instance->getFullUrl(), '/').'/'.$url;
 		$options = [
 			'query' => $query,
 			'headers' => $this->addDefaultHeaders($headers),
@@ -89,7 +89,7 @@ 
 				$response = $client->options($fullUrl, $options);
 				break;
 			default:
-				throw new \InvalidArgumentException('Invalid method ' . $method);
+				throw new \InvalidArgumentException('Invalid method '.$method);
 		}
 
 		return $response->getBody();

lib/private/Remote/Instance.php

Doc Comments +1 added lines, -1 removed lines

@@ -134,7 +134,7 @@
 
 	/**
 	 * @param string $url
-	 * @return bool|string
+	 * @return string
 	 */
 	private function downloadStatus($url) {
 		try {

Indentation +103 added lines, -103 removed lines

@@ -30,118 +30,118 @@
  * Provides some basic info about a remote Nextcloud instance
  */
 class Instance implements IInstance {
-	/** @var string */
-	private $url;
+    /** @var string */
+    private $url;
 
-	/** @var ICache */
-	private $cache;
+    /** @var ICache */
+    private $cache;
 
-	/** @var IClientService */
-	private $clientService;
+    /** @var IClientService */
+    private $clientService;
 
-	/** @var array|null */
-	private $status;
+    /** @var array|null */
+    private $status;
 
-	/**
-	 * @param string $url
-	 * @param ICache $cache
-	 * @param IClientService $clientService
-	 */
-	public function __construct($url, ICache $cache, IClientService $clientService) {
-		$url = str_replace('https://', '', $url);
-		$this->url = str_replace('http://', '', $url);
-		$this->cache = $cache;
-		$this->clientService = $clientService;
-	}
+    /**
+     * @param string $url
+     * @param ICache $cache
+     * @param IClientService $clientService
+     */
+    public function __construct($url, ICache $cache, IClientService $clientService) {
+        $url = str_replace('https://', '', $url);
+        $this->url = str_replace('http://', '', $url);
+        $this->cache = $cache;
+        $this->clientService = $clientService;
+    }
 
-	/**
-	 * @return string The url of the remote server without protocol
-	 */
-	public function getUrl() {
-		return $this->url;
-	}
+    /**
+     * @return string The url of the remote server without protocol
+     */
+    public function getUrl() {
+        return $this->url;
+    }
 
-	/**
-	 * @return string The of of the remote server with protocol
-	 */
-	public function getFullUrl() {
-		return $this->getProtocol() . '://' . $this->getUrl();
-	}
+    /**
+     * @return string The of of the remote server with protocol
+     */
+    public function getFullUrl() {
+        return $this->getProtocol() . '://' . $this->getUrl();
+    }
 
-	/**
-	 * @return string The full version string in '13.1.2.3' format
-	 */
-	public function getVersion() {
-		$status = $this->getStatus();
-		return $status['version'];
-	}
+    /**
+     * @return string The full version string in '13.1.2.3' format
+     */
+    public function getVersion() {
+        $status = $this->getStatus();
+        return $status['version'];
+    }
 
-	/**
-	 * @return string 'http' or 'https'
-	 */
-	public function getProtocol() {
-		$status = $this->getStatus();
-		return $status['protocol'];
-	}
+    /**
+     * @return string 'http' or 'https'
+     */
+    public function getProtocol() {
+        $status = $this->getStatus();
+        return $status['protocol'];
+    }
 
-	/**
-	 * Check that the remote server is installed and not in maintenance mode
-	 *
-	 * @return bool
-	 */
-	public function isActive() {
-		$status = $this->getStatus();
-		return $status['installed'] && !$status['maintenance'];
-	}
+    /**
+     * Check that the remote server is installed and not in maintenance mode
+     *
+     * @return bool
+     */
+    public function isActive() {
+        $status = $this->getStatus();
+        return $status['installed'] && !$status['maintenance'];
+    }
 
-	/**
-	 * @return array
-	 * @throws NotFoundException
-	 * @throws \Exception
-	 */
-	private function getStatus() {
-		if ($this->status) {
-			return $this->status;
-		}
-		$key = 'remote/' . $this->url . '/status';
-		$httpsKey = 'remote/' . $this->url . '/https';
-		$status = $this->cache->get($key);
-		if (!$status) {
-			$response = $this->downloadStatus('https://' . $this->getUrl() . '/status.php');
-			$protocol = 'https';
-			if (!$response) {
-				if ($status = $this->cache->get($httpsKey)) {
-					throw new \Exception('refusing to connect to remote instance(' . $this->url . ') over http that was previously accessible over https');
-				}
-				$response = $this->downloadStatus('http://' . $this->getUrl() . '/status.php');
-				$protocol = 'http';
-			} else {
-				$this->cache->set($httpsKey, true, 60 * 60 * 24 * 365);
-			}
-			$status = json_decode($response, true);
-			if ($status) {
-				$status['protocol'] = $protocol;
-			}
-			if ($status) {
-				$this->cache->set($key, $status, 5 * 60);
-				$this->status = $status;
-			} else {
-				throw new NotFoundException('Remote server not found at address ' . $this->url);
-			}
-		}
-		return $status;
-	}
+    /**
+     * @return array
+     * @throws NotFoundException
+     * @throws \Exception
+     */
+    private function getStatus() {
+        if ($this->status) {
+            return $this->status;
+        }
+        $key = 'remote/' . $this->url . '/status';
+        $httpsKey = 'remote/' . $this->url . '/https';
+        $status = $this->cache->get($key);
+        if (!$status) {
+            $response = $this->downloadStatus('https://' . $this->getUrl() . '/status.php');
+            $protocol = 'https';
+            if (!$response) {
+                if ($status = $this->cache->get($httpsKey)) {
+                    throw new \Exception('refusing to connect to remote instance(' . $this->url . ') over http that was previously accessible over https');
+                }
+                $response = $this->downloadStatus('http://' . $this->getUrl() . '/status.php');
+                $protocol = 'http';
+            } else {
+                $this->cache->set($httpsKey, true, 60 * 60 * 24 * 365);
+            }
+            $status = json_decode($response, true);
+            if ($status) {
+                $status['protocol'] = $protocol;
+            }
+            if ($status) {
+                $this->cache->set($key, $status, 5 * 60);
+                $this->status = $status;
+            } else {
+                throw new NotFoundException('Remote server not found at address ' . $this->url);
+            }
+        }
+        return $status;
+    }
 
-	/**
-	 * @param string $url
-	 * @return bool|string
-	 */
-	private function downloadStatus($url) {
-		try {
-			$request = $this->clientService->newClient()->get($url);
-			return $request->getBody();
-		} catch (\Exception $e) {
-			return false;
-		}
-	}
+    /**
+     * @param string $url
+     * @return bool|string
+     */
+    private function downloadStatus($url) {
+        try {
+            $request = $this->clientService->newClient()->get($url);
+            return $request->getBody();
+        } catch (\Exception $e) {
+            return false;
+        }
+    }
 }

Spacing +7 added lines, -7 removed lines

@@ -65,7 +65,7 @@ 
 	 * @return string The of of the remote server with protocol
 	 */
 	public function getFullUrl() {
-		return $this->getProtocol() . '://' . $this->getUrl();
+		return $this->getProtocol().'://'.$this->getUrl();
 	}
 
 	/**
@@ -103,17 +103,17 @@ 
 		if ($this->status) {
 			return $this->status;
 		}
-		$key = 'remote/' . $this->url . '/status';
-		$httpsKey = 'remote/' . $this->url . '/https';
+		$key = 'remote/'.$this->url.'/status';
+		$httpsKey = 'remote/'.$this->url.'/https';
 		$status = $this->cache->get($key);
 		if (!$status) {
-			$response = $this->downloadStatus('https://' . $this->getUrl() . '/status.php');
+			$response = $this->downloadStatus('https://'.$this->getUrl().'/status.php');
 			$protocol = 'https';
 			if (!$response) {
 				if ($status = $this->cache->get($httpsKey)) {
-					throw new \Exception('refusing to connect to remote instance(' . $this->url . ') over http that was previously accessible over https');
+					throw new \Exception('refusing to connect to remote instance('.$this->url.') over http that was previously accessible over https');
 				}
-				$response = $this->downloadStatus('http://' . $this->getUrl() . '/status.php');
+				$response = $this->downloadStatus('http://'.$this->getUrl().'/status.php');
 				$protocol = 'http';
 			} else {
 				$this->cache->set($httpsKey, true, 60 * 60 * 24 * 365);
@@ -126,7 +126,7 @@ 
 				$this->cache->set($key, $status, 5 * 60);
 				$this->status = $status;
 			} else {
-				throw new NotFoundException('Remote server not found at address ' . $this->url);
+				throw new NotFoundException('Remote server not found at address '.$this->url);
 			}
 		}
 		return $status;

lib/public/Remote/IInstanceFactory.php

Indentation +7 added lines, -7 removed lines

@@ -25,11 +25,11 @@
  * @since 13.0.0
  */
 interface IInstanceFactory {
-	/**
-	 * @param string $url
-	 * @return IInstance
-	 *
-	 * @since 13.0.0
-	 */
-	public function getInstance($url);
+    /**
+     * @param string $url
+     * @return IInstance
+     *
+     * @since 13.0.0
+     */
+    public function getInstance($url);
 }

lib/private/Remote/Api/ApiFactory.php

Indentation +8 added lines, -8 removed lines

@@ -28,14 +28,14 @@
 use OCP\Remote\IInstance;
 
 class ApiFactory implements IApiFactory {
-	/** @var IClientService */
-	private $clientService;
+    /** @var IClientService */
+    private $clientService;
 
-	public function __construct(IClientService $clientService) {
-		$this->clientService = $clientService;
-	}
+    public function __construct(IClientService $clientService) {
+        $this->clientService = $clientService;
+    }
 
-	public function getApiCollection(IInstance $instance, ICredentials $credentials) {
-		return new ApiCollection($instance, $credentials, $this->clientService);
-	}
+    public function getApiCollection(IInstance $instance, ICredentials $credentials) {
+        return new ApiCollection($instance, $credentials, $this->clientService);
+    }
 }

lib/private/Remote/Api/ApiCollection.php

Indentation +17 added lines, -17 removed lines

@@ -28,24 +28,24 @@
 use OCP\Remote\IInstance;
 
 class ApiCollection implements IApiCollection {
-	/** @var IInstance */
-	private $instance;
-	/** @var ICredentials */
-	private $credentials;
-	/** @var IClientService */
-	private $clientService;
+    /** @var IInstance */
+    private $instance;
+    /** @var ICredentials */
+    private $credentials;
+    /** @var IClientService */
+    private $clientService;
 
-	public function __construct(IInstance $instance, ICredentials $credentials, IClientService $clientService) {
-		$this->instance = $instance;
-		$this->credentials = $credentials;
-		$this->clientService = $clientService;
-	}
+    public function __construct(IInstance $instance, ICredentials $credentials, IClientService $clientService) {
+        $this->instance = $instance;
+        $this->credentials = $credentials;
+        $this->clientService = $clientService;
+    }
 
-	public function getCapabilitiesApi() {
-		return new OCS($this->instance, $this->credentials, $this->clientService);
-	}
+    public function getCapabilitiesApi() {
+        return new OCS($this->instance, $this->credentials, $this->clientService);
+    }
 
-	public function getUserApi() {
-		return new OCS($this->instance, $this->credentials, $this->clientService);
-	}
+    public function getUserApi() {
+        return new OCS($this->instance, $this->credentials, $this->clientService);
+    }
 }

lib/private/Remote/Api/OCS.php

Indentation +54 added lines, -54 removed lines

@@ -30,61 +30,61 @@
 use OCP\Remote\Api\IUserApi;
 
 class OCS extends ApiBase implements ICapabilitiesApi, IUserApi {
-	/**
-	 * @param string $method
-	 * @param string $url
-	 * @param array $body
-	 * @param array $query
-	 * @param array $headers
-	 * @return array
-	 * @throws ForbiddenException
-	 * @throws NotFoundException
-	 * @throws \Exception
-	 */
-	protected function request($method, $url, array $body = [], array $query = [], array $headers = []) {
-		try {
-			$response = json_decode(parent::request($method, '/ocs/v2.php/' . $url, $body, $query, $headers), true);
-		} catch (ClientException $e) {
-			if ($e->getResponse()->getStatusCode() === 404) {
-				throw new NotFoundException();
-			} else if ($e->getResponse()->getStatusCode() === 403 || $e->getResponse()->getStatusCode() === 401) {
-				throw new ForbiddenException();
-			} else {
-				throw $e;
-			}
-		}
-		if (!isset($response['ocs']) || !isset($response['ocs']['meta'])) {
-			throw new \Exception('Invalid ocs response');
-		}
-		if ($response['ocs']['meta']['statuscode'] === API::RESPOND_UNAUTHORISED) {
-			throw new ForbiddenException();
-		}
-		if ($response['ocs']['meta']['statuscode'] === API::RESPOND_NOT_FOUND) {
-			throw new NotFoundException();
-		}
-		if ($response['ocs']['meta']['status'] !== 'ok') {
-			throw new \Exception('Unknown ocs error ' . $response['ocs']['meta']['message']);
-		}
+    /**
+     * @param string $method
+     * @param string $url
+     * @param array $body
+     * @param array $query
+     * @param array $headers
+     * @return array
+     * @throws ForbiddenException
+     * @throws NotFoundException
+     * @throws \Exception
+     */
+    protected function request($method, $url, array $body = [], array $query = [], array $headers = []) {
+        try {
+            $response = json_decode(parent::request($method, '/ocs/v2.php/' . $url, $body, $query, $headers), true);
+        } catch (ClientException $e) {
+            if ($e->getResponse()->getStatusCode() === 404) {
+                throw new NotFoundException();
+            } else if ($e->getResponse()->getStatusCode() === 403 || $e->getResponse()->getStatusCode() === 401) {
+                throw new ForbiddenException();
+            } else {
+                throw $e;
+            }
+        }
+        if (!isset($response['ocs']) || !isset($response['ocs']['meta'])) {
+            throw new \Exception('Invalid ocs response');
+        }
+        if ($response['ocs']['meta']['statuscode'] === API::RESPOND_UNAUTHORISED) {
+            throw new ForbiddenException();
+        }
+        if ($response['ocs']['meta']['statuscode'] === API::RESPOND_NOT_FOUND) {
+            throw new NotFoundException();
+        }
+        if ($response['ocs']['meta']['status'] !== 'ok') {
+            throw new \Exception('Unknown ocs error ' . $response['ocs']['meta']['message']);
+        }
 
-		return $response['ocs']['data'];
-	}
+        return $response['ocs']['data'];
+    }
 
-	public function getUser($userId) {
-		$result = $this->request('get', 'cloud/users/' . $userId);
-		$keys = ['id', 'email', 'displayname', 'phone', 'address', 'website', 'groups', 'language', 'quota'];
-		foreach ($keys as $key) {
-			if (!isset($result[$key])) {
-				throw new \Exception('Invalid user response, expected field ' . $key . ' not found');
-			}
-		}
-		return new User($result);
-	}
+    public function getUser($userId) {
+        $result = $this->request('get', 'cloud/users/' . $userId);
+        $keys = ['id', 'email', 'displayname', 'phone', 'address', 'website', 'groups', 'language', 'quota'];
+        foreach ($keys as $key) {
+            if (!isset($result[$key])) {
+                throw new \Exception('Invalid user response, expected field ' . $key . ' not found');
+            }
+        }
+        return new User($result);
+    }
 
-	/**
-	 * @return array The capabilities in the form of [$appId => [$capability => $value]]
-	 */
-	public function getCapabilities() {
-		$result = $this->request('get', 'cloud/capabilities');
-		return $result['capabilities'];
-	}
+    /**
+     * @return array The capabilities in the form of [$appId => [$capability => $value]]
+     */
+    public function getCapabilities() {
+        $result = $this->request('get', 'cloud/capabilities');
+        return $result['capabilities'];
+    }
 }

Spacing +4 added lines, -4 removed lines

@@ -43,7 +43,7 @@ 
 	 */
 	protected function request($method, $url, array $body = [], array $query = [], array $headers = []) {
 		try {
-			$response = json_decode(parent::request($method, '/ocs/v2.php/' . $url, $body, $query, $headers), true);
+			$response = json_decode(parent::request($method, '/ocs/v2.php/'.$url, $body, $query, $headers), true);
 		} catch (ClientException $e) {
 			if ($e->getResponse()->getStatusCode() === 404) {
 				throw new NotFoundException();
@@ -63,18 +63,18 @@ 
 			throw new NotFoundException();
 		}
 		if ($response['ocs']['meta']['status'] !== 'ok') {
-			throw new \Exception('Unknown ocs error ' . $response['ocs']['meta']['message']);
+			throw new \Exception('Unknown ocs error '.$response['ocs']['meta']['message']);
 		}
 
 		return $response['ocs']['data'];
 	}
 
 	public function getUser($userId) {
-		$result = $this->request('get', 'cloud/users/' . $userId);
+		$result = $this->request('get', 'cloud/users/'.$userId);
 		$keys = ['id', 'email', 'displayname', 'phone', 'address', 'website', 'groups', 'language', 'quota'];
 		foreach ($keys as $key) {
 			if (!isset($result[$key])) {
-				throw new \Exception('Invalid user response, expected field ' . $key . ' not found');
+				throw new \Exception('Invalid user response, expected field '.$key.' not found');
 			}
 		}
 		return new User($result);

lib/private/Remote/InstanceFactory.php

Indentation +11 added lines, -11 removed lines

@@ -27,17 +27,17 @@
 use OCP\Remote\IInstanceFactory;
 
 class InstanceFactory implements IInstanceFactory {
-	/** @var ICache */
-	private $cache;
-	/** @var IClientService */
-	private $clientService;
+    /** @var ICache */
+    private $cache;
+    /** @var IClientService */
+    private $clientService;
 
-	public function __construct(ICache $cache, IClientService $clientService) {
-		$this->cache = $cache;
-		$this->clientService = $clientService;
-	}
+    public function __construct(ICache $cache, IClientService $clientService) {
+        $this->cache = $cache;
+        $this->clientService = $clientService;
+    }
 
-	public function getInstance($url) {
-		return new Instance($url, $this->cache, $this->clientService);
-	}
+    public function getInstance($url) {
+        return new Instance($url, $this->cache, $this->clientService);
+    }
 }