Completed
Pull Request — master (#8327)
by Robin
17:10
created
lib/private/Files/Cache/Cache.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -410,6 +410,9 @@  discard block
 block discarded – undo
410 410
 		}
411 411
 	}
412 412
 
413
+	/**
414
+	 * @param string $path
415
+	 */
413 416
 	private function getParentPath($path) {
414 417
 		$parent = dirname($path);
415 418
 		if ($parent === '.') {
@@ -629,7 +632,7 @@  discard block
 block discarded – undo
629 632
 	 *
630 633
 	 * @param string $mimetype either a full mimetype to search ('text/plain') or only the first part of a mimetype ('image')
631 634
 	 *        where it will search for all mimetypes in the group ('image/*')
632
-	 * @return ICacheEntry[] an array of cache entries where the mimetype matches the search
635
+	 * @return CacheEntry[] an array of cache entries where the mimetype matches the search
633 636
 	 */
634 637
 	public function searchByMime($mimetype) {
635 638
 		if (strpos($mimetype, '/')) {
Please login to merge, or discard this patch.
lib/private/App/AppManager.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 	/**
122 122
 	 * List all installed apps
123 123
 	 *
124
-	 * @return string[]
124
+	 * @return integer[]
125 125
 	 */
126 126
 	public function getInstalledApps() {
127 127
 		return array_keys($this->getInstalledAppsValues());
@@ -382,6 +382,9 @@  discard block
 block discarded – undo
382 382
 		return in_array($appId, $this->shippedApps, true);
383 383
 	}
384 384
 
385
+	/**
386
+	 * @param string $appId
387
+	 */
385 388
 	private function isAlwaysEnabled($appId) {
386 389
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
387 390
 		return in_array($appId, $alwaysEnabled, true);
Please login to merge, or discard this patch.
lib/private/Template/JSResourceLocator.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -30,6 +30,9 @@  discard block
 block discarded – undo
30 30
 	/** @var JSCombiner */
31 31
 	protected $jsCombiner;
32 32
 
33
+	/**
34
+	 * @param string $theme
35
+	 */
33 36
 	public function __construct(\OCP\ILogger $logger, $theme, array $core_map, array $party_map, JSCombiner $JSCombiner) {
34 37
 		parent::__construct($logger, $theme, $core_map, $party_map);
35 38
 
@@ -91,6 +94,9 @@  discard block
 block discarded – undo
91 94
 	public function doFindTheme($script) {
92 95
 	}
93 96
 
97
+	/**
98
+	 * @param string $file
99
+	 */
94 100
 	protected function cacheAndAppendCombineJsonIfExist($root, $file, $app = 'core') {
95 101
 		if (is_file($root.'/'.$file)) {
96 102
 			if ($this->jsCombiner->process($root, $file, $app)) {
Please login to merge, or discard this patch.
apps/dav/lib/Avatars/AvatarHome.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -98,6 +98,9 @@
 block discarded – undo
98 98
 		throw new Forbidden('Permission denied to delete this folder');
99 99
 	}
100 100
 
101
+	/**
102
+	 * @return string
103
+	 */
101 104
 	public function getName() {
102 105
 		list(,$name) = Uri\split($this->principalInfo['uri']);
103 106
 		return $name;
Please login to merge, or discard this patch.
apps/dav/lib/Migration/CalDAVRemoveEmptyValue.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -97,6 +97,9 @@
 block discarded – undo
97 97
 		}
98 98
 	}
99 99
 
100
+	/**
101
+	 * @param string $pattern
102
+	 */
100 103
 	protected function getInvalidObjects($pattern) {
101 104
 		$query = $this->db->getQueryBuilder();
102 105
 		$query->select(['calendarid', 'uri'])
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/Search/Xml/Request/CalendarSearchReport.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
 	 * the next element.
80 80
 	 *
81 81
 	 * @param Reader $reader
82
-	 * @return mixed
82
+	 * @return CalendarSearchReport
83 83
 	 */
84 84
 	static function xmlDeserialize(Reader $reader) {
85 85
 		$elems = $reader->parseInnerTree([
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/SyncService.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -163,7 +163,6 @@  discard block
 block discarded – undo
163 163
 	/**
164 164
 	 * @param string $url
165 165
 	 * @param string $userName
166
-	 * @param string $addressBookUrl
167 166
 	 * @param string $sharedSecret
168 167
 	 * @return Client
169 168
 	 */
@@ -301,7 +300,7 @@  discard block
 block discarded – undo
301 300
 	}
302 301
 
303 302
 	/**
304
-	 * @return array|null
303
+	 * @return string
305 304
 	 */
306 305
 	public function getLocalSystemAddressBook() {
307 306
 		if (is_null($this->localSystemAddressBook)) {
Please login to merge, or discard this patch.
lib/private/AppFramework/Utility/ControllerMethodReflector.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
 	private $parameters = [];
38 38
 
39 39
 	/**
40
-	 * @param object $object an object or classname
40
+	 * @param \OCP\AppFramework\Controller $object an object or classname
41 41
 	 * @param string $method the method which we want to inspect
42 42
 	 */
43 43
 	public function reflect($object, $method){
Please login to merge, or discard this patch.
apps/sharebymail/lib/ShareByMailProvider.php 1 patch
Doc Comments   +5 added lines, -4 removed lines patch added patch discarded remove patch
@@ -276,10 +276,10 @@  discard block
 block discarded – undo
276 276
 	 * publish activity if a file/folder was shared by mail
277 277
 	 *
278 278
 	 * @param $subject
279
-	 * @param $parameters
280
-	 * @param $affectedUser
279
+	 * @param string[] $parameters
280
+	 * @param string $affectedUser
281 281
 	 * @param $fileId
282
-	 * @param $filePath
282
+	 * @param string $filePath
283 283
 	 */
284 284
 	protected function publishActivity($subject, $parameters, $affectedUser, $fileId, $filePath) {
285 285
 		$event = $this->activityManager->generateEvent();
@@ -557,6 +557,7 @@  discard block
 block discarded – undo
557 557
 	 * @param string $uidOwner
558 558
 	 * @param int $permissions
559 559
 	 * @param string $token
560
+	 * @param string $password
560 561
 	 * @return int
561 562
 	 */
562 563
 	protected function addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $uidOwner, $permissions, $token, $password) {
@@ -950,7 +951,7 @@  discard block
 block discarded – undo
950 951
 	/**
951 952
 	 * get database row of a give share
952 953
 	 *
953
-	 * @param $id
954
+	 * @param integer $id
954 955
 	 * @return array
955 956
 	 * @throws ShareNotFound
956 957
 	 */
Please login to merge, or discard this patch.