Passed
Push — master ( 2ddf3c...43b333 )
by Lukas
16:47 queued 12s
created
lib/public/AppFramework/Db/QBMapper.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 		// build the fields
126 126
 		foreach ($properties as $property => $updated) {
127 127
 			$column = $entity->propertyToColumn($property);
128
-			$getter = 'get' . ucfirst($property);
128
+			$getter = 'get'.ucfirst($property);
129 129
 			$value = $entity->$getter();
130 130
 
131 131
 			$type = $this->getParameterTypeForProperty($entity, $property);
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
 		// build the fields
197 197
 		foreach ($properties as $property => $updated) {
198 198
 			$column = $entity->propertyToColumn($property);
199
-			$getter = 'get' . ucfirst($property);
199
+			$getter = 'get'.ucfirst($property);
200 200
 			$value = $entity->$getter();
201 201
 
202 202
 			$type = $this->getParameterTypeForProperty($entity, $property);
@@ -226,11 +226,11 @@  discard block
 block discarded – undo
226 226
 	protected function getParameterTypeForProperty(Entity $entity, string $property): int {
227 227
 		$types = $entity->getFieldTypes();
228 228
 
229
-		if (!isset($types[ $property ])) {
229
+		if (!isset($types[$property])) {
230 230
 			return IQueryBuilder::PARAM_STR;
231 231
 		}
232 232
 
233
-		switch ($types[ $property ]) {
233
+		switch ($types[$property]) {
234 234
 			case 'int':
235 235
 			case 'integer':
236 236
 				return IQueryBuilder::PARAM_INT;
@@ -289,8 +289,8 @@  discard block
 block discarded – undo
289 289
 	 * @since 14.0.0
290 290
 	 */
291 291
 	private function buildDebugMessage(string $msg, IQueryBuilder $sql): string {
292
-		return $msg .
293
-			': query "' . $sql->getSQL() . '"; ';
292
+		return $msg.
293
+			': query "'.$sql->getSQL().'"; ';
294 294
 	}
295 295
 
296 296
 
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
 	 * @since 14.0.0
305 305
 	 */
306 306
 	protected function mapRowToEntity(array $row): Entity {
307
-		return \call_user_func($this->entityClass .'::fromRow', $row);
307
+		return \call_user_func($this->entityClass.'::fromRow', $row);
308 308
 	}
309 309
 
310 310
 
Please login to merge, or discard this patch.
apps/sharebymail/lib/ShareByMailProvider.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
 
218 218
 		$password = $passwordEvent->getPassword();
219 219
 		if ($password === null) {
220
-			$password = $this->secureRandom->generate(8, ISecureRandom::CHAR_LOWER . ISecureRandom::CHAR_UPPER . ISecureRandom::CHAR_DIGITS);
220
+			$password = $this->secureRandom->generate(8, ISecureRandom::CHAR_LOWER.ISecureRandom::CHAR_UPPER.ISecureRandom::CHAR_DIGITS);
221 221
 		}
222 222
 
223 223
 		return $password;
@@ -388,7 +388,7 @@  discard block
 block discarded – undo
388 388
 		$text = $this->l->t('%1$s shared »%2$s« with you.', [$initiatorDisplayName, $filename]);
389 389
 
390 390
 		$emailTemplate->addBodyText(
391
-			htmlspecialchars($text . ' ' . $this->l->t('Click the button below to open it.')),
391
+			htmlspecialchars($text.' '.$this->l->t('Click the button below to open it.')),
392 392
 			$text
393 393
 		);
394 394
 		$emailTemplate->addBodyButton(
@@ -417,7 +417,7 @@  discard block
 block discarded – undo
417 417
 		$initiatorEmail = $initiatorUser->getEMailAddress();
418 418
 		if ($this->settingsManager->replyToInitiator() && $initiatorEmail !== null) {
419 419
 			$message->setReplyTo([$initiatorEmail => $initiatorDisplayName]);
420
-			$emailTemplate->addFooter($instanceName . ($this->defaults->getSlogan() !== '' ? ' - ' . $this->defaults->getSlogan() : ''));
420
+			$emailTemplate->addFooter($instanceName.($this->defaults->getSlogan() !== '' ? ' - '.$this->defaults->getSlogan() : ''));
421 421
 		} else {
422 422
 			$emailTemplate->addFooter();
423 423
 		}
@@ -481,7 +481,7 @@  discard block
 block discarded – undo
481 481
 		$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
482 482
 		if ($this->settingsManager->replyToInitiator() && $initiatorEmailAddress !== null) {
483 483
 			$message->setReplyTo([$initiatorEmailAddress => $initiatorDisplayName]);
484
-			$emailTemplate->addFooter($instanceName . ' - ' . $this->defaults->getSlogan());
484
+			$emailTemplate->addFooter($instanceName.' - '.$this->defaults->getSlogan());
485 485
 		} else {
486 486
 			$emailTemplate->addFooter();
487 487
 		}
@@ -541,7 +541,7 @@  discard block
 block discarded – undo
541 541
 		$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
542 542
 		if ($this->settingsManager->replyToInitiator() && $initiatorEmailAddress !== null) {
543 543
 			$message->setReplyTo([$initiatorEmailAddress => $initiatorDisplayName]);
544
-			$emailTemplate->addFooter($instanceName . ' - ' . $this->defaults->getSlogan());
544
+			$emailTemplate->addFooter($instanceName.' - '.$this->defaults->getSlogan());
545 545
 		} else {
546 546
 			$emailTemplate->addFooter();
547 547
 		}
@@ -677,7 +677,7 @@  discard block
 block discarded – undo
677 677
 			->setValue('password', $qb->createNamedParameter($password))
678 678
 			->setValue('password_by_talk', $qb->createNamedParameter($sendPasswordByTalk, IQueryBuilder::PARAM_BOOL))
679 679
 			->setValue('stime', $qb->createNamedParameter(time()))
680
-			->setValue('hide_download', $qb->createNamedParameter((int)$hideDownload, IQueryBuilder::PARAM_INT));
680
+			->setValue('hide_download', $qb->createNamedParameter((int) $hideDownload, IQueryBuilder::PARAM_INT));
681 681
 
682 682
 		if ($expirationTime !== null) {
683 683
 			$qb->setValue('expiration', $qb->createNamedParameter($expirationTime, IQueryBuilder::PARAM_DATE));
@@ -723,7 +723,7 @@  discard block
 block discarded – undo
723 723
 			->set('password_by_talk', $qb->createNamedParameter($share->getSendPasswordByTalk(), IQueryBuilder::PARAM_BOOL))
724 724
 			->set('expiration', $qb->createNamedParameter($share->getExpirationDate(), IQueryBuilder::PARAM_DATE))
725 725
 			->set('note', $qb->createNamedParameter($share->getNote()))
726
-			->set('hide_download', $qb->createNamedParameter((int)$share->getHideDownload(), IQueryBuilder::PARAM_INT))
726
+			->set('hide_download', $qb->createNamedParameter((int) $share->getHideDownload(), IQueryBuilder::PARAM_INT))
727 727
 			->execute();
728 728
 
729 729
 		if ($originalShare->getNote() !== $share->getNote() && $share->getNote() !== '') {
@@ -969,21 +969,21 @@  discard block
 block discarded – undo
969 969
 	 */
970 970
 	protected function createShareObject($data) {
971 971
 		$share = new Share($this->rootFolder, $this->userManager);
972
-		$share->setId((int)$data['id'])
973
-			->setShareType((int)$data['share_type'])
974
-			->setPermissions((int)$data['permissions'])
972
+		$share->setId((int) $data['id'])
973
+			->setShareType((int) $data['share_type'])
974
+			->setPermissions((int) $data['permissions'])
975 975
 			->setTarget($data['file_target'])
976
-			->setMailSend((bool)$data['mail_send'])
976
+			->setMailSend((bool) $data['mail_send'])
977 977
 			->setNote($data['note'])
978 978
 			->setToken($data['token']);
979 979
 
980 980
 		$shareTime = new \DateTime();
981
-		$shareTime->setTimestamp((int)$data['stime']);
981
+		$shareTime->setTimestamp((int) $data['stime']);
982 982
 		$share->setShareTime($shareTime);
983 983
 		$share->setSharedWith($data['share_with']);
984 984
 		$share->setPassword($data['password']);
985
-		$share->setSendPasswordByTalk((bool)$data['password_by_talk']);
986
-		$share->setHideDownload((bool)$data['hide_download']);
985
+		$share->setSendPasswordByTalk((bool) $data['password_by_talk']);
986
+		$share->setHideDownload((bool) $data['hide_download']);
987 987
 
988 988
 		if ($data['uid_initiator'] !== null) {
989 989
 			$share->setShareOwner($data['uid_owner']);
@@ -991,7 +991,7 @@  discard block
 block discarded – undo
991 991
 		} else {
992 992
 			//OLD SHARE
993 993
 			$share->setSharedBy($data['uid_owner']);
994
-			$path = $this->getNode($share->getSharedBy(), (int)$data['file_source']);
994
+			$path = $this->getNode($share->getSharedBy(), (int) $data['file_source']);
995 995
 
996 996
 			$owner = $path->getOwner();
997 997
 			$share->setShareOwner($owner->getUID());
@@ -1004,7 +1004,7 @@  discard block
 block discarded – undo
1004 1004
 			}
1005 1005
 		}
1006 1006
 
1007
-		$share->setNodeId((int)$data['file_source']);
1007
+		$share->setNodeId((int) $data['file_source']);
1008 1008
 		$share->setNodeType($data['item_type']);
1009 1009
 
1010 1010
 		$share->setProviderId($this->identifier());
@@ -1121,7 +1121,7 @@  discard block
 block discarded – undo
1121 1121
 			);
1122 1122
 		}
1123 1123
 
1124
-		$qb->innerJoin('s', 'filecache' ,'f', $qb->expr()->eq('s.file_source', 'f.fileid'));
1124
+		$qb->innerJoin('s', 'filecache', 'f', $qb->expr()->eq('s.file_source', 'f.fileid'));
1125 1125
 		$qb->andWhere($qb->expr()->eq('f.parent', $qb->createNamedParameter($node->getId())));
1126 1126
 
1127 1127
 		$qb->orderBy('id');
Please login to merge, or discard this patch.
apps/federatedfilesharing/lib/FederatedShareProvider.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
 		if ($remoteShare) {
220 220
 			try {
221 221
 				$ownerCloudId = $this->cloudIdManager->getCloudId($remoteShare['owner'], $remoteShare['remote']);
222
-				$shareId = $this->addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $ownerCloudId->getId(), $permissions, 'tmp_token_' . time(), $shareType);
222
+				$shareId = $this->addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $ownerCloudId->getId(), $permissions, 'tmp_token_'.time(), $shareType);
223 223
 				$share->setId($shareId);
224 224
 				[$token, $remoteId] = $this->askOwnerToReShare($shareWith, $share, $shareId);
225 225
 				// remote share was create successfully if we get a valid token as return
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
 		$result = $qResult->fetchAll();
353 353
 		$qResult->closeCursor();
354 354
 
355
-		if (isset($result[0]) && (int)$result[0]['remote_id'] > 0) {
355
+		if (isset($result[0]) && (int) $result[0]['remote_id'] > 0) {
356 356
 			return $result[0];
357 357
 		}
358 358
 
@@ -483,7 +483,7 @@  discard block
 block discarded – undo
483 483
 	public function getRemoteId(IShare $share): string {
484 484
 		$query = $this->dbConnection->getQueryBuilder();
485 485
 		$query->select('remote_id')->from('federated_reshares')
486
-			->where($query->expr()->eq('share_id', $query->createNamedParameter((int)$share->getId())));
486
+			->where($query->expr()->eq('share_id', $query->createNamedParameter((int) $share->getId())));
487 487
 		$result = $query->execute();
488 488
 		$data = $result->fetch();
489 489
 		$result->closeCursor();
@@ -492,7 +492,7 @@  discard block
 block discarded – undo
492 492
 			throw new ShareNotFound();
493 493
 		}
494 494
 
495
-		return (string)$data['remote_id'];
495
+		return (string) $data['remote_id'];
496 496
 	}
497 497
 
498 498
 	/**
@@ -650,7 +650,7 @@  discard block
 block discarded – undo
650 650
 			);
651 651
 		}
652 652
 
653
-		$qb->innerJoin('s', 'filecache' ,'f', $qb->expr()->eq('s.file_source', 'f.fileid'));
653
+		$qb->innerJoin('s', 'filecache', 'f', $qb->expr()->eq('s.file_source', 'f.fileid'));
654 654
 		$qb->andWhere($qb->expr()->eq('f.parent', $qb->createNamedParameter($node->getId())));
655 655
 
656 656
 		$qb->orderBy('id');
@@ -737,7 +737,7 @@  discard block
 block discarded – undo
737 737
 		$cursor->closeCursor();
738 738
 
739 739
 		if ($data === false) {
740
-			throw new ShareNotFound('Can not find share with ID: ' . $id);
740
+			throw new ShareNotFound('Can not find share with ID: '.$id);
741 741
 		}
742 742
 
743 743
 		try {
@@ -881,15 +881,15 @@  discard block
 block discarded – undo
881 881
 	 */
882 882
 	private function createShareObject($data) {
883 883
 		$share = new Share($this->rootFolder, $this->userManager);
884
-		$share->setId((int)$data['id'])
885
-			->setShareType((int)$data['share_type'])
886
-			->setPermissions((int)$data['permissions'])
884
+		$share->setId((int) $data['id'])
885
+			->setShareType((int) $data['share_type'])
886
+			->setPermissions((int) $data['permissions'])
887 887
 			->setTarget($data['file_target'])
888
-			->setMailSend((bool)$data['mail_send'])
888
+			->setMailSend((bool) $data['mail_send'])
889 889
 			->setToken($data['token']);
890 890
 
891 891
 		$shareTime = new \DateTime();
892
-		$shareTime->setTimestamp((int)$data['stime']);
892
+		$shareTime->setTimestamp((int) $data['stime']);
893 893
 		$share->setShareTime($shareTime);
894 894
 		$share->setSharedWith($data['share_with']);
895 895
 
@@ -899,13 +899,13 @@  discard block
 block discarded – undo
899 899
 		} else {
900 900
 			//OLD SHARE
901 901
 			$share->setSharedBy($data['uid_owner']);
902
-			$path = $this->getNode($share->getSharedBy(), (int)$data['file_source']);
902
+			$path = $this->getNode($share->getSharedBy(), (int) $data['file_source']);
903 903
 
904 904
 			$owner = $path->getOwner();
905 905
 			$share->setShareOwner($owner->getUID());
906 906
 		}
907 907
 
908
-		$share->setNodeId((int)$data['file_source']);
908
+		$share->setNodeId((int) $data['file_source']);
909 909
 		$share->setNodeType($data['item_type']);
910 910
 
911 911
 		$share->setProviderId($this->identifier());
Please login to merge, or discard this patch.