Passed
Push — master ( ff0ccc...d70d90 )
by Maxence
15:36 queued 11s
created
apps/files_external/lib/Command/Option.php 1 patch
Indentation   +44 added lines, -44 removed lines patch added patch discarded remove patch
@@ -28,50 +28,50 @@
 block discarded – undo
28 28
 use Symfony\Component\Console\Output\OutputInterface;
29 29
 
30 30
 class Option extends Config {
31
-	protected function configure() {
32
-		$this
33
-			->setName('files_external:option')
34
-			->setDescription('Manage mount options for a mount')
35
-			->addArgument(
36
-				'mount_id',
37
-				InputArgument::REQUIRED,
38
-				'The id of the mount to edit'
39
-			)->addArgument(
40
-				'key',
41
-				InputArgument::REQUIRED,
42
-				'key of the mount option to set/get'
43
-			)->addArgument(
44
-				'value',
45
-				InputArgument::OPTIONAL,
46
-				'value to set the mount option to, when no value is provided the existing value will be printed'
47
-			);
48
-	}
31
+    protected function configure() {
32
+        $this
33
+            ->setName('files_external:option')
34
+            ->setDescription('Manage mount options for a mount')
35
+            ->addArgument(
36
+                'mount_id',
37
+                InputArgument::REQUIRED,
38
+                'The id of the mount to edit'
39
+            )->addArgument(
40
+                'key',
41
+                InputArgument::REQUIRED,
42
+                'key of the mount option to set/get'
43
+            )->addArgument(
44
+                'value',
45
+                InputArgument::OPTIONAL,
46
+                'value to set the mount option to, when no value is provided the existing value will be printed'
47
+            );
48
+    }
49 49
 
50
-	/**
51
-	 * @param StorageConfig $mount
52
-	 * @param string $key
53
-	 * @param OutputInterface $output
54
-	 */
55
-	protected function getOption(StorageConfig $mount, $key, OutputInterface $output) {
56
-		$value = $mount->getMountOption($key);
57
-		if (!is_string($value)) { // show bools and objects correctly
58
-			$value = json_encode($value);
59
-		}
60
-		$output->writeln($value);
61
-	}
50
+    /**
51
+     * @param StorageConfig $mount
52
+     * @param string $key
53
+     * @param OutputInterface $output
54
+     */
55
+    protected function getOption(StorageConfig $mount, $key, OutputInterface $output) {
56
+        $value = $mount->getMountOption($key);
57
+        if (!is_string($value)) { // show bools and objects correctly
58
+            $value = json_encode($value);
59
+        }
60
+        $output->writeln($value);
61
+    }
62 62
 
63
-	/**
64
-	 * @param StorageConfig $mount
65
-	 * @param string $key
66
-	 * @param string $value
67
-	 * @param OutputInterface $output
68
-	 */
69
-	protected function setOption(StorageConfig $mount, $key, $value, OutputInterface $output) {
70
-		$decoded = json_decode($value, true);
71
-		if (!is_null($decoded)) {
72
-			$value = $decoded;
73
-		}
74
-		$mount->setMountOption($key, $value);
75
-		$this->globalService->updateStorage($mount);
76
-	}
63
+    /**
64
+     * @param StorageConfig $mount
65
+     * @param string $key
66
+     * @param string $value
67
+     * @param OutputInterface $output
68
+     */
69
+    protected function setOption(StorageConfig $mount, $key, $value, OutputInterface $output) {
70
+        $decoded = json_decode($value, true);
71
+        if (!is_null($decoded)) {
72
+            $value = $decoded;
73
+        }
74
+        $mount->setMountOption($key, $value);
75
+        $this->globalService->updateStorage($mount);
76
+    }
77 77
 }
Please login to merge, or discard this patch.
apps/files_external/lib/Command/Backends.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -71,14 +71,14 @@  discard block
 block discarded – undo
71 71
 		$backend = $input->getArgument('backend');
72 72
 		if ($type) {
73 73
 			if (!isset($data[$type])) {
74
-				$output->writeln('<error>Invalid type "' . $type . '". Possible values are "authentication" or "storage"</error>');
74
+				$output->writeln('<error>Invalid type "'.$type.'". Possible values are "authentication" or "storage"</error>');
75 75
 				return 1;
76 76
 			}
77 77
 			$data = $data[$type];
78 78
 
79 79
 			if ($backend) {
80 80
 				if (!isset($data[$backend])) {
81
-					$output->writeln('<error>Unknown backend "' . $backend . '" of type  "' . $type . '"</error>');
81
+					$output->writeln('<error>Unknown backend "'.$backend.'" of type  "'.$type.'"</error>');
82 82
 					return 1;
83 83
 				}
84 84
 				$data = $data[$backend];
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 			$result['storage_class'] = $backend->getStorageClass();
100 100
 			$authBackends = $this->backendService->getAuthMechanismsByScheme(array_keys($backend->getAuthSchemes()));
101 101
 			$result['supported_authentication_backends'] = array_keys($authBackends);
102
-			$authConfig = array_map(function (AuthMechanism $auth) {
102
+			$authConfig = array_map(function(AuthMechanism $auth) {
103 103
 				return $this->serializeAuthBackend($auth)['configuration'];
104 104
 			}, $authBackends);
105 105
 			$result['authentication_configuration'] = array_combine(array_keys($authBackends), $authConfig);
@@ -112,10 +112,10 @@  discard block
 block discarded – undo
112 112
 	 * @return string[]
113 113
 	 */
114 114
 	private function formatConfiguration(array $parameters) {
115
-		$configuration = array_filter($parameters, function (DefinitionParameter $parameter) {
115
+		$configuration = array_filter($parameters, function(DefinitionParameter $parameter) {
116 116
 			return $parameter->getType() !== DefinitionParameter::VALUE_HIDDEN;
117 117
 		});
118
-		return array_map(function (DefinitionParameter $parameter) {
118
+		return array_map(function(DefinitionParameter $parameter) {
119 119
 			return $parameter->getTypeName();
120 120
 		}, $configuration);
121 121
 	}
Please login to merge, or discard this patch.
Indentation   +78 added lines, -78 removed lines patch added patch discarded remove patch
@@ -33,92 +33,92 @@
 block discarded – undo
33 33
 use Symfony\Component\Console\Output\OutputInterface;
34 34
 
35 35
 class Backends extends Base {
36
-	/** @var BackendService */
37
-	private $backendService;
36
+    /** @var BackendService */
37
+    private $backendService;
38 38
 
39
-	public function __construct(BackendService $backendService
40
-	) {
41
-		parent::__construct();
39
+    public function __construct(BackendService $backendService
40
+    ) {
41
+        parent::__construct();
42 42
 
43
-		$this->backendService = $backendService;
44
-	}
43
+        $this->backendService = $backendService;
44
+    }
45 45
 
46
-	protected function configure() {
47
-		$this
48
-			->setName('files_external:backends')
49
-			->setDescription('Show available authentication and storage backends')
50
-			->addArgument(
51
-				'type',
52
-				InputArgument::OPTIONAL,
53
-				'only show backends of a certain type. Possible values are "authentication" or "storage"'
54
-			)->addArgument(
55
-				'backend',
56
-				InputArgument::OPTIONAL,
57
-				'only show information of a specific backend'
58
-			);
59
-		parent::configure();
60
-	}
46
+    protected function configure() {
47
+        $this
48
+            ->setName('files_external:backends')
49
+            ->setDescription('Show available authentication and storage backends')
50
+            ->addArgument(
51
+                'type',
52
+                InputArgument::OPTIONAL,
53
+                'only show backends of a certain type. Possible values are "authentication" or "storage"'
54
+            )->addArgument(
55
+                'backend',
56
+                InputArgument::OPTIONAL,
57
+                'only show information of a specific backend'
58
+            );
59
+        parent::configure();
60
+    }
61 61
 
62
-	protected function execute(InputInterface $input, OutputInterface $output): int {
63
-		$authBackends = $this->backendService->getAuthMechanisms();
64
-		$storageBackends = $this->backendService->getBackends();
62
+    protected function execute(InputInterface $input, OutputInterface $output): int {
63
+        $authBackends = $this->backendService->getAuthMechanisms();
64
+        $storageBackends = $this->backendService->getBackends();
65 65
 
66
-		$data = [
67
-			'authentication' => array_map([$this, 'serializeAuthBackend'], $authBackends),
68
-			'storage' => array_map([$this, 'serializeAuthBackend'], $storageBackends)
69
-		];
66
+        $data = [
67
+            'authentication' => array_map([$this, 'serializeAuthBackend'], $authBackends),
68
+            'storage' => array_map([$this, 'serializeAuthBackend'], $storageBackends)
69
+        ];
70 70
 
71
-		$type = $input->getArgument('type');
72
-		$backend = $input->getArgument('backend');
73
-		if ($type) {
74
-			if (!isset($data[$type])) {
75
-				$output->writeln('<error>Invalid type "' . $type . '". Possible values are "authentication" or "storage"</error>');
76
-				return 1;
77
-			}
78
-			$data = $data[$type];
71
+        $type = $input->getArgument('type');
72
+        $backend = $input->getArgument('backend');
73
+        if ($type) {
74
+            if (!isset($data[$type])) {
75
+                $output->writeln('<error>Invalid type "' . $type . '". Possible values are "authentication" or "storage"</error>');
76
+                return 1;
77
+            }
78
+            $data = $data[$type];
79 79
 
80
-			if ($backend) {
81
-				if (!isset($data[$backend])) {
82
-					$output->writeln('<error>Unknown backend "' . $backend . '" of type  "' . $type . '"</error>');
83
-					return 1;
84
-				}
85
-				$data = $data[$backend];
86
-			}
87
-		}
80
+            if ($backend) {
81
+                if (!isset($data[$backend])) {
82
+                    $output->writeln('<error>Unknown backend "' . $backend . '" of type  "' . $type . '"</error>');
83
+                    return 1;
84
+                }
85
+                $data = $data[$backend];
86
+            }
87
+        }
88 88
 
89
-		$this->writeArrayInOutputFormat($input, $output, $data);
90
-		return 0;
91
-	}
89
+        $this->writeArrayInOutputFormat($input, $output, $data);
90
+        return 0;
91
+    }
92 92
 
93
-	private function serializeAuthBackend(\JsonSerializable $backend) {
94
-		$data = $backend->jsonSerialize();
95
-		$result = [
96
-			'name' => $data['name'],
97
-			'identifier' => $data['identifier'],
98
-			'configuration' => $this->formatConfiguration($data['configuration'])
99
-		];
100
-		if ($backend instanceof Backend) {
101
-			$result['storage_class'] = $backend->getStorageClass();
102
-			$authBackends = $this->backendService->getAuthMechanismsByScheme(array_keys($backend->getAuthSchemes()));
103
-			$result['supported_authentication_backends'] = array_keys($authBackends);
104
-			$authConfig = array_map(function (AuthMechanism $auth) {
105
-				return $this->serializeAuthBackend($auth)['configuration'];
106
-			}, $authBackends);
107
-			$result['authentication_configuration'] = array_combine(array_keys($authBackends), $authConfig);
108
-		}
109
-		return $result;
110
-	}
93
+    private function serializeAuthBackend(\JsonSerializable $backend) {
94
+        $data = $backend->jsonSerialize();
95
+        $result = [
96
+            'name' => $data['name'],
97
+            'identifier' => $data['identifier'],
98
+            'configuration' => $this->formatConfiguration($data['configuration'])
99
+        ];
100
+        if ($backend instanceof Backend) {
101
+            $result['storage_class'] = $backend->getStorageClass();
102
+            $authBackends = $this->backendService->getAuthMechanismsByScheme(array_keys($backend->getAuthSchemes()));
103
+            $result['supported_authentication_backends'] = array_keys($authBackends);
104
+            $authConfig = array_map(function (AuthMechanism $auth) {
105
+                return $this->serializeAuthBackend($auth)['configuration'];
106
+            }, $authBackends);
107
+            $result['authentication_configuration'] = array_combine(array_keys($authBackends), $authConfig);
108
+        }
109
+        return $result;
110
+    }
111 111
 
112
-	/**
113
-	 * @param DefinitionParameter[] $parameters
114
-	 * @return string[]
115
-	 */
116
-	private function formatConfiguration(array $parameters) {
117
-		$configuration = array_filter($parameters, function (DefinitionParameter $parameter) {
118
-			return $parameter->getType() !== DefinitionParameter::VALUE_HIDDEN;
119
-		});
120
-		return array_map(function (DefinitionParameter $parameter) {
121
-			return $parameter->getTypeName();
122
-		}, $configuration);
123
-	}
112
+    /**
113
+     * @param DefinitionParameter[] $parameters
114
+     * @return string[]
115
+     */
116
+    private function formatConfiguration(array $parameters) {
117
+        $configuration = array_filter($parameters, function (DefinitionParameter $parameter) {
118
+            return $parameter->getType() !== DefinitionParameter::VALUE_HIDDEN;
119
+        });
120
+        return array_map(function (DefinitionParameter $parameter) {
121
+            return $parameter->getTypeName();
122
+        }, $configuration);
123
+    }
124 124
 }
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/LegacyDependencyCheckPolyfill.php 1 patch
Indentation   +34 added lines, -34 removed lines patch added patch discarded remove patch
@@ -29,43 +29,43 @@
 block discarded – undo
29 29
  */
30 30
 trait LegacyDependencyCheckPolyfill {
31 31
 
32
-	/**
33
-	 * @return string
34
-	 */
35
-	abstract public function getStorageClass();
32
+    /**
33
+     * @return string
34
+     */
35
+    abstract public function getStorageClass();
36 36
 
37
-	/**
38
-	 * Check if object is valid for use
39
-	 *
40
-	 * @return MissingDependency[] Unsatisfied dependencies
41
-	 */
42
-	public function checkDependencies() {
43
-		$ret = [];
37
+    /**
38
+     * Check if object is valid for use
39
+     *
40
+     * @return MissingDependency[] Unsatisfied dependencies
41
+     */
42
+    public function checkDependencies() {
43
+        $ret = [];
44 44
 
45
-		$result = call_user_func([$this->getStorageClass(), 'checkDependencies']);
46
-		if ($result !== true) {
47
-			if (!is_array($result)) {
48
-				$result = [$result];
49
-			}
50
-			foreach ($result as $key => $value) {
51
-				if (!($value instanceof MissingDependency)) {
52
-					$module = null;
53
-					$message = null;
54
-					if (is_numeric($key)) {
55
-						$module = $value;
56
-					} else {
57
-						$module = $key;
58
-						$message = $value;
59
-					}
60
-					$value = new MissingDependency($module, $this);
61
-					$value->setMessage($message);
62
-				}
63
-				$ret[] = $value;
64
-			}
65
-		}
45
+        $result = call_user_func([$this->getStorageClass(), 'checkDependencies']);
46
+        if ($result !== true) {
47
+            if (!is_array($result)) {
48
+                $result = [$result];
49
+            }
50
+            foreach ($result as $key => $value) {
51
+                if (!($value instanceof MissingDependency)) {
52
+                    $module = null;
53
+                    $message = null;
54
+                    if (is_numeric($key)) {
55
+                        $module = $value;
56
+                    } else {
57
+                        $module = $key;
58
+                        $message = $value;
59
+                    }
60
+                    $value = new MissingDependency($module, $this);
61
+                    $value->setMessage($message);
62
+                }
63
+                $ret[] = $value;
64
+            }
65
+        }
66 66
 
67
-		return $ret;
68
-	}
67
+        return $ret;
68
+    }
69 69
 
70 70
 }
71 71
 
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/DefinitionParameter.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -140,7 +140,7 @@
 block discarded – undo
140 140
 	 * @return bool
141 141
 	 */
142 142
 	public function isFlagSet($flag) {
143
-		return (bool)($this->flags & $flag);
143
+		return (bool) ($this->flags & $flag);
144 144
 	}
145 145
 
146 146
 	/**
Please login to merge, or discard this patch.
Indentation   +185 added lines, -185 removed lines patch added patch discarded remove patch
@@ -27,189 +27,189 @@
 block discarded – undo
27 27
  * Parameter for an external storage definition
28 28
  */
29 29
 class DefinitionParameter implements \JsonSerializable {
30
-	// placeholder value for password fields, when the client updates a storage configuration
31
-	// placeholder values are ignored and the field is left unmodified
32
-	public const UNMODIFIED_PLACEHOLDER = '__unmodified__';
33
-
34
-	/** Value constants */
35
-	public const VALUE_TEXT = 0;
36
-	public const VALUE_BOOLEAN = 1;
37
-	public const VALUE_PASSWORD = 2;
38
-	public const VALUE_HIDDEN = 3;
39
-
40
-	/** Flag constants */
41
-	public const FLAG_NONE = 0;
42
-	public const FLAG_OPTIONAL = 1;
43
-	public const FLAG_USER_PROVIDED = 2;
44
-
45
-	/** @var string name of parameter */
46
-	private $name;
47
-
48
-	/** @var string human-readable parameter text */
49
-	private $text;
50
-
51
-	/** @var string human-readable parameter tooltip */
52
-	private $tooltip = '';
53
-
54
-	/** @var int value type, see self::VALUE_* constants */
55
-	private $type = self::VALUE_TEXT;
56
-
57
-	/** @var int flags, see self::FLAG_* constants */
58
-	private $flags = self::FLAG_NONE;
59
-
60
-	/**
61
-	 * @param string $name
62
-	 * @param string $text
63
-	 */
64
-	public function __construct($name, $text) {
65
-		$this->name = $name;
66
-		$this->text = $text;
67
-	}
68
-
69
-	/**
70
-	 * @return string
71
-	 */
72
-	public function getName() {
73
-		return $this->name;
74
-	}
75
-
76
-	/**
77
-	 * @return string
78
-	 */
79
-	public function getText() {
80
-		return $this->text;
81
-	}
82
-
83
-	/**
84
-	 * Get value type
85
-	 *
86
-	 * @return int
87
-	 */
88
-	public function getType() {
89
-		return $this->type;
90
-	}
91
-
92
-	/**
93
-	 * Set value type
94
-	 *
95
-	 * @param int $type
96
-	 * @return self
97
-	 */
98
-	public function setType($type) {
99
-		$this->type = $type;
100
-		return $this;
101
-	}
102
-
103
-	/**
104
-	 * @return string
105
-	 */
106
-	public function getTypeName() {
107
-		switch ($this->type) {
108
-			case self::VALUE_BOOLEAN:
109
-				return 'boolean';
110
-			case self::VALUE_TEXT:
111
-				return 'text';
112
-			case self::VALUE_PASSWORD:
113
-				return 'password';
114
-			default:
115
-				return 'unknown';
116
-		}
117
-	}
118
-
119
-	/**
120
-	 * @return int
121
-	 */
122
-	public function getFlags() {
123
-		return $this->flags;
124
-	}
125
-
126
-	/**
127
-	 * @param int $flags
128
-	 * @return self
129
-	 */
130
-	public function setFlags($flags) {
131
-		$this->flags = $flags;
132
-		return $this;
133
-	}
134
-
135
-	/**
136
-	 * @param int $flag
137
-	 * @return self
138
-	 */
139
-	public function setFlag($flag) {
140
-		$this->flags |= $flag;
141
-		return $this;
142
-	}
143
-
144
-	/**
145
-	 * @param int $flag
146
-	 * @return bool
147
-	 */
148
-	public function isFlagSet($flag) {
149
-		return (bool)($this->flags & $flag);
150
-	}
151
-
152
-	/**
153
-	 * @return string
154
-	 */
155
-	public function getTooltip(): string {
156
-		return $this->tooltip;
157
-	}
158
-
159
-	/**
160
-	 * @param string $tooltip
161
-	 * @return self
162
-	 */
163
-	public function setTooltip(string $tooltip) {
164
-		$this->tooltip = $tooltip;
165
-		return $this;
166
-	}
167
-
168
-	/**
169
-	 * Serialize into JSON for client-side JS
170
-	 */
171
-	public function jsonSerialize(): array {
172
-		return [
173
-			'value' => $this->getText(),
174
-			'flags' => $this->getFlags(),
175
-			'type' => $this->getType(),
176
-			'tooltip' => $this->getTooltip(),
177
-		];
178
-	}
179
-
180
-	public function isOptional() {
181
-		return $this->isFlagSet(self::FLAG_OPTIONAL) || $this->isFlagSet(self::FLAG_USER_PROVIDED);
182
-	}
183
-
184
-	/**
185
-	 * Validate a parameter value against this
186
-	 * Convert type as necessary
187
-	 *
188
-	 * @param mixed $value Value to check
189
-	 * @return bool success
190
-	 */
191
-	public function validateValue(&$value) {
192
-		switch ($this->getType()) {
193
-			case self::VALUE_BOOLEAN:
194
-				if (!is_bool($value)) {
195
-					switch ($value) {
196
-						case 'true':
197
-							$value = true;
198
-							break;
199
-						case 'false':
200
-							$value = false;
201
-							break;
202
-						default:
203
-							return false;
204
-					}
205
-				}
206
-				break;
207
-			default:
208
-				if (!$value && !$this->isOptional()) {
209
-					return false;
210
-				}
211
-				break;
212
-		}
213
-		return true;
214
-	}
30
+    // placeholder value for password fields, when the client updates a storage configuration
31
+    // placeholder values are ignored and the field is left unmodified
32
+    public const UNMODIFIED_PLACEHOLDER = '__unmodified__';
33
+
34
+    /** Value constants */
35
+    public const VALUE_TEXT = 0;
36
+    public const VALUE_BOOLEAN = 1;
37
+    public const VALUE_PASSWORD = 2;
38
+    public const VALUE_HIDDEN = 3;
39
+
40
+    /** Flag constants */
41
+    public const FLAG_NONE = 0;
42
+    public const FLAG_OPTIONAL = 1;
43
+    public const FLAG_USER_PROVIDED = 2;
44
+
45
+    /** @var string name of parameter */
46
+    private $name;
47
+
48
+    /** @var string human-readable parameter text */
49
+    private $text;
50
+
51
+    /** @var string human-readable parameter tooltip */
52
+    private $tooltip = '';
53
+
54
+    /** @var int value type, see self::VALUE_* constants */
55
+    private $type = self::VALUE_TEXT;
56
+
57
+    /** @var int flags, see self::FLAG_* constants */
58
+    private $flags = self::FLAG_NONE;
59
+
60
+    /**
61
+     * @param string $name
62
+     * @param string $text
63
+     */
64
+    public function __construct($name, $text) {
65
+        $this->name = $name;
66
+        $this->text = $text;
67
+    }
68
+
69
+    /**
70
+     * @return string
71
+     */
72
+    public function getName() {
73
+        return $this->name;
74
+    }
75
+
76
+    /**
77
+     * @return string
78
+     */
79
+    public function getText() {
80
+        return $this->text;
81
+    }
82
+
83
+    /**
84
+     * Get value type
85
+     *
86
+     * @return int
87
+     */
88
+    public function getType() {
89
+        return $this->type;
90
+    }
91
+
92
+    /**
93
+     * Set value type
94
+     *
95
+     * @param int $type
96
+     * @return self
97
+     */
98
+    public function setType($type) {
99
+        $this->type = $type;
100
+        return $this;
101
+    }
102
+
103
+    /**
104
+     * @return string
105
+     */
106
+    public function getTypeName() {
107
+        switch ($this->type) {
108
+            case self::VALUE_BOOLEAN:
109
+                return 'boolean';
110
+            case self::VALUE_TEXT:
111
+                return 'text';
112
+            case self::VALUE_PASSWORD:
113
+                return 'password';
114
+            default:
115
+                return 'unknown';
116
+        }
117
+    }
118
+
119
+    /**
120
+     * @return int
121
+     */
122
+    public function getFlags() {
123
+        return $this->flags;
124
+    }
125
+
126
+    /**
127
+     * @param int $flags
128
+     * @return self
129
+     */
130
+    public function setFlags($flags) {
131
+        $this->flags = $flags;
132
+        return $this;
133
+    }
134
+
135
+    /**
136
+     * @param int $flag
137
+     * @return self
138
+     */
139
+    public function setFlag($flag) {
140
+        $this->flags |= $flag;
141
+        return $this;
142
+    }
143
+
144
+    /**
145
+     * @param int $flag
146
+     * @return bool
147
+     */
148
+    public function isFlagSet($flag) {
149
+        return (bool)($this->flags & $flag);
150
+    }
151
+
152
+    /**
153
+     * @return string
154
+     */
155
+    public function getTooltip(): string {
156
+        return $this->tooltip;
157
+    }
158
+
159
+    /**
160
+     * @param string $tooltip
161
+     * @return self
162
+     */
163
+    public function setTooltip(string $tooltip) {
164
+        $this->tooltip = $tooltip;
165
+        return $this;
166
+    }
167
+
168
+    /**
169
+     * Serialize into JSON for client-side JS
170
+     */
171
+    public function jsonSerialize(): array {
172
+        return [
173
+            'value' => $this->getText(),
174
+            'flags' => $this->getFlags(),
175
+            'type' => $this->getType(),
176
+            'tooltip' => $this->getTooltip(),
177
+        ];
178
+    }
179
+
180
+    public function isOptional() {
181
+        return $this->isFlagSet(self::FLAG_OPTIONAL) || $this->isFlagSet(self::FLAG_USER_PROVIDED);
182
+    }
183
+
184
+    /**
185
+     * Validate a parameter value against this
186
+     * Convert type as necessary
187
+     *
188
+     * @param mixed $value Value to check
189
+     * @return bool success
190
+     */
191
+    public function validateValue(&$value) {
192
+        switch ($this->getType()) {
193
+            case self::VALUE_BOOLEAN:
194
+                if (!is_bool($value)) {
195
+                    switch ($value) {
196
+                        case 'true':
197
+                            $value = true;
198
+                            break;
199
+                        case 'false':
200
+                            $value = false;
201
+                            break;
202
+                        default:
203
+                            return false;
204
+                    }
205
+                }
206
+                break;
207
+            default:
208
+                if (!$value && !$this->isOptional()) {
209
+                    return false;
210
+                }
211
+                break;
212
+        }
213
+        return true;
214
+    }
215 215
 }
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Auth/Password/SessionCredentials.php 2 patches
Indentation   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -39,31 +39,31 @@
 block discarded – undo
39 39
  */
40 40
 class SessionCredentials extends AuthMechanism {
41 41
 
42
-	/** @var CredentialsStore */
43
-	private $credentialsStore;
42
+    /** @var CredentialsStore */
43
+    private $credentialsStore;
44 44
 
45
-	public function __construct(IL10N $l, CredentialsStore $credentialsStore) {
46
-		$this->credentialsStore = $credentialsStore;
45
+    public function __construct(IL10N $l, CredentialsStore $credentialsStore) {
46
+        $this->credentialsStore = $credentialsStore;
47 47
 
48
-		$this->setIdentifier('password::sessioncredentials')
49
-			->setScheme(self::SCHEME_PASSWORD)
50
-			->setText($l->t('Log-in credentials, save in session'))
51
-			->addParameters([]);
52
-	}
48
+        $this->setIdentifier('password::sessioncredentials')
49
+            ->setScheme(self::SCHEME_PASSWORD)
50
+            ->setText($l->t('Log-in credentials, save in session'))
51
+            ->addParameters([]);
52
+    }
53 53
 
54
-	public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
55
-		try {
56
-			$credentials = $this->credentialsStore->getLoginCredentials();
57
-		} catch (CredentialsUnavailableException $e) {
58
-			throw new InsufficientDataForMeaningfulAnswerException('No session credentials saved');
59
-		}
54
+    public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
55
+        try {
56
+            $credentials = $this->credentialsStore->getLoginCredentials();
57
+        } catch (CredentialsUnavailableException $e) {
58
+            throw new InsufficientDataForMeaningfulAnswerException('No session credentials saved');
59
+        }
60 60
 
61
-		$storage->setBackendOption('user', $credentials->getLoginName());
62
-		$storage->setBackendOption('password', $credentials->getPassword());
63
-	}
61
+        $storage->setBackendOption('user', $credentials->getLoginName());
62
+        $storage->setBackendOption('password', $credentials->getPassword());
63
+    }
64 64
 
65
-	public function wrapStorage(Storage $storage) {
66
-		return new SessionStorageWrapper(['storage' => $storage]);
67
-	}
65
+    public function wrapStorage(Storage $storage) {
66
+        return new SessionStorageWrapper(['storage' => $storage]);
67
+    }
68 68
 
69 69
 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
 			->addParameters([]);
52 52
 	}
53 53
 
54
-	public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
54
+	public function manipulateStorageConfig(StorageConfig & $storage, IUser $user = null) {
55 55
 		try {
56 56
 			$credentials = $this->credentialsStore->getLoginCredentials();
57 57
 		} catch (CredentialsUnavailableException $e) {
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Auth/Password/GlobalAuth.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
 		]);
71 71
 	}
72 72
 
73
-	public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
73
+	public function manipulateStorageConfig(StorageConfig & $storage, IUser $user = null) {
74 74
 		if ($storage->getType() === StorageConfig::MOUNT_TYPE_ADMIN) {
75 75
 			$uid = '';
76 76
 		} elseif (is_null($user)) {
Please login to merge, or discard this patch.
Indentation   +42 added lines, -42 removed lines patch added patch discarded remove patch
@@ -36,53 +36,53 @@
 block discarded – undo
36 36
  * Global Username and Password
37 37
  */
38 38
 class GlobalAuth extends AuthMechanism {
39
-	public const CREDENTIALS_IDENTIFIER = 'password::global';
39
+    public const CREDENTIALS_IDENTIFIER = 'password::global';
40 40
 
41
-	/** @var ICredentialsManager */
42
-	protected $credentialsManager;
41
+    /** @var ICredentialsManager */
42
+    protected $credentialsManager;
43 43
 
44
-	public function __construct(IL10N $l, ICredentialsManager $credentialsManager) {
45
-		$this->credentialsManager = $credentialsManager;
44
+    public function __construct(IL10N $l, ICredentialsManager $credentialsManager) {
45
+        $this->credentialsManager = $credentialsManager;
46 46
 
47
-		$this
48
-			->setIdentifier('password::global')
49
-			->setVisibility(BackendService::VISIBILITY_DEFAULT)
50
-			->setScheme(self::SCHEME_PASSWORD)
51
-			->setText($l->t('Global credentials'));
52
-	}
47
+        $this
48
+            ->setIdentifier('password::global')
49
+            ->setVisibility(BackendService::VISIBILITY_DEFAULT)
50
+            ->setScheme(self::SCHEME_PASSWORD)
51
+            ->setText($l->t('Global credentials'));
52
+    }
53 53
 
54
-	public function getAuth($uid) {
55
-		$auth = $this->credentialsManager->retrieve($uid, self::CREDENTIALS_IDENTIFIER);
56
-		if (!is_array($auth)) {
57
-			return [
58
-				'user' => '',
59
-				'password' => ''
60
-			];
61
-		} else {
62
-			return $auth;
63
-		}
64
-	}
54
+    public function getAuth($uid) {
55
+        $auth = $this->credentialsManager->retrieve($uid, self::CREDENTIALS_IDENTIFIER);
56
+        if (!is_array($auth)) {
57
+            return [
58
+                'user' => '',
59
+                'password' => ''
60
+            ];
61
+        } else {
62
+            return $auth;
63
+        }
64
+    }
65 65
 
66
-	public function saveAuth($uid, $user, $password) {
67
-		$this->credentialsManager->store($uid, self::CREDENTIALS_IDENTIFIER, [
68
-			'user' => $user,
69
-			'password' => $password
70
-		]);
71
-	}
66
+    public function saveAuth($uid, $user, $password) {
67
+        $this->credentialsManager->store($uid, self::CREDENTIALS_IDENTIFIER, [
68
+            'user' => $user,
69
+            'password' => $password
70
+        ]);
71
+    }
72 72
 
73
-	public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
74
-		if ($storage->getType() === StorageConfig::MOUNT_TYPE_ADMIN) {
75
-			$uid = '';
76
-		} elseif (is_null($user)) {
77
-			throw new InsufficientDataForMeaningfulAnswerException('No credentials saved');
78
-		} else {
79
-			$uid = $user->getUID();
80
-		}
81
-		$credentials = $this->credentialsManager->retrieve($uid, self::CREDENTIALS_IDENTIFIER);
73
+    public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
74
+        if ($storage->getType() === StorageConfig::MOUNT_TYPE_ADMIN) {
75
+            $uid = '';
76
+        } elseif (is_null($user)) {
77
+            throw new InsufficientDataForMeaningfulAnswerException('No credentials saved');
78
+        } else {
79
+            $uid = $user->getUID();
80
+        }
81
+        $credentials = $this->credentialsManager->retrieve($uid, self::CREDENTIALS_IDENTIFIER);
82 82
 
83
-		if (is_array($credentials)) {
84
-			$storage->setBackendOption('user', $credentials['user']);
85
-			$storage->setBackendOption('password', $credentials['password']);
86
-		}
87
-	}
83
+        if (is_array($credentials)) {
84
+            $storage->setBackendOption('user', $credentials['user']);
85
+            $storage->setBackendOption('password', $credentials['password']);
86
+        }
87
+    }
88 88
 }
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Auth/IUserProvided.php 1 patch
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -28,10 +28,10 @@
 block discarded – undo
28 28
  * For auth mechanisms where the user needs to provide credentials
29 29
  */
30 30
 interface IUserProvided {
31
-	/**
32
-	 * @param IUser $user the user for which to save the user provided options
33
-	 * @param int $mountId the mount id to save the options for
34
-	 * @param array $options the user provided options
35
-	 */
36
-	public function saveBackendOptions(IUser $user, $mountId, array $options);
31
+    /**
32
+     * @param IUser $user the user for which to save the user provided options
33
+     * @param int $mountId the mount id to save the options for
34
+     * @param array $options the user provided options
35
+     */
36
+    public function saveBackendOptions(IUser $user, $mountId, array $options);
37 37
 }
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Auth/PublicKey/RSA.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
 		;
58 58
 	}
59 59
 
60
-	public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
60
+	public function manipulateStorageConfig(StorageConfig & $storage, IUser $user = null) {
61 61
 		$auth = new RSACrypt();
62 62
 		$auth->setPassword($this->config->getSystemValue('secret', ''));
63 63
 		if (!$auth->loadKey($storage->getBackendOption('private_key'))) {
Please login to merge, or discard this patch.
Indentation   +40 added lines, -40 removed lines patch added patch discarded remove patch
@@ -36,51 +36,51 @@
 block discarded – undo
36 36
  */
37 37
 class RSA extends AuthMechanism {
38 38
 
39
-	/** @var IConfig */
40
-	private $config;
39
+    /** @var IConfig */
40
+    private $config;
41 41
 
42
-	public function __construct(IL10N $l, IConfig $config) {
43
-		$this->config = $config;
42
+    public function __construct(IL10N $l, IConfig $config) {
43
+        $this->config = $config;
44 44
 
45
-		$this
46
-			->setIdentifier('publickey::rsa')
47
-			->setScheme(self::SCHEME_PUBLICKEY)
48
-			->setText($l->t('RSA public key'))
49
-			->addParameters([
50
-				new DefinitionParameter('user', $l->t('Username')),
51
-				new DefinitionParameter('public_key', $l->t('Public key')),
52
-				(new DefinitionParameter('private_key', 'private_key'))
53
-					->setType(DefinitionParameter::VALUE_HIDDEN),
54
-			])
55
-			->addCustomJs('public_key')
56
-		;
57
-	}
45
+        $this
46
+            ->setIdentifier('publickey::rsa')
47
+            ->setScheme(self::SCHEME_PUBLICKEY)
48
+            ->setText($l->t('RSA public key'))
49
+            ->addParameters([
50
+                new DefinitionParameter('user', $l->t('Username')),
51
+                new DefinitionParameter('public_key', $l->t('Public key')),
52
+                (new DefinitionParameter('private_key', 'private_key'))
53
+                    ->setType(DefinitionParameter::VALUE_HIDDEN),
54
+            ])
55
+            ->addCustomJs('public_key')
56
+        ;
57
+    }
58 58
 
59
-	public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
60
-		$auth = new RSACrypt();
61
-		$auth->setPassword($this->config->getSystemValue('secret', ''));
62
-		if (!$auth->loadKey($storage->getBackendOption('private_key'))) {
63
-			throw new \RuntimeException('unable to load private key');
64
-		}
65
-		$storage->setBackendOption('public_key_auth', $auth);
66
-	}
59
+    public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
60
+        $auth = new RSACrypt();
61
+        $auth->setPassword($this->config->getSystemValue('secret', ''));
62
+        if (!$auth->loadKey($storage->getBackendOption('private_key'))) {
63
+            throw new \RuntimeException('unable to load private key');
64
+        }
65
+        $storage->setBackendOption('public_key_auth', $auth);
66
+    }
67 67
 
68
-	/**
69
-	 * Generate a keypair
70
-	 *
71
-	 * @param int $keyLenth
72
-	 * @return array ['privatekey' => $privateKey, 'publickey' => $publicKey]
73
-	 */
74
-	public function createKey($keyLength) {
75
-		$rsa = new RSACrypt();
76
-		$rsa->setPublicKeyFormat(RSACrypt::PUBLIC_FORMAT_OPENSSH);
77
-		$rsa->setPassword($this->config->getSystemValue('secret', ''));
68
+    /**
69
+     * Generate a keypair
70
+     *
71
+     * @param int $keyLenth
72
+     * @return array ['privatekey' => $privateKey, 'publickey' => $publicKey]
73
+     */
74
+    public function createKey($keyLength) {
75
+        $rsa = new RSACrypt();
76
+        $rsa->setPublicKeyFormat(RSACrypt::PUBLIC_FORMAT_OPENSSH);
77
+        $rsa->setPassword($this->config->getSystemValue('secret', ''));
78 78
 
79
-		if ($keyLength !== 1024 && $keyLength !== 2048 && $keyLength !== 4096) {
80
-			$keyLength = 1024;
81
-		}
79
+        if ($keyLength !== 1024 && $keyLength !== 2048 && $keyLength !== 4096) {
80
+            $keyLength = 1024;
81
+        }
82 82
 
83
-		return $rsa->createKey($keyLength);
84
-	}
83
+        return $rsa->createKey($keyLength);
84
+    }
85 85
 
86 86
 }
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Config/IBackendProvider.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -30,10 +30,10 @@
 block discarded – undo
30 30
  */
31 31
 interface IBackendProvider {
32 32
 
33
-	/**
34
-	 * @since 9.1.0
35
-	 * @return Backend[]
36
-	 */
37
-	public function getBackends();
33
+    /**
34
+     * @since 9.1.0
35
+     * @return Backend[]
36
+     */
37
+    public function getBackends();
38 38
 
39 39
 }
Please login to merge, or discard this patch.