Passed
Push — master ( f0dd71...c56a27 )
by Christoph
11:49 queued 12s
created
lib/private/Federation/CloudIdManager.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
 	 */
81 81
 	public function getCloudId(string $user, string $remote): ICloudId {
82 82
 		// TODO check what the correct url is for remote (asking the remote)
83
-		return new CloudId($user. '@' . $remote, $user, $remote);
83
+		return new CloudId($user.'@'.$remote, $user, $remote);
84 84
 	}
85 85
 
86 86
 	/**
Please login to merge, or discard this patch.
lib/private/OCS/DiscoveryService.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 	public function discover(string $remote, string $service, bool $skipCache = false): array {
66 66
 		// Check the cache first
67 67
 		if ($skipCache === false) {
68
-			$cacheData = $this->cache->get($remote . '#' . $service);
68
+			$cacheData = $this->cache->get($remote.'#'.$service);
69 69
 			if ($cacheData) {
70 70
 				$data = json_decode($cacheData, true);
71 71
 				if (\is_array($data)) {
@@ -78,11 +78,11 @@  discard block
 block discarded – undo
78 78
 
79 79
 		// query the remote server for available services
80 80
 		try {
81
-			$response = $this->client->get($remote . '/ocs-provider/', [
81
+			$response = $this->client->get($remote.'/ocs-provider/', [
82 82
 				'timeout' => 10,
83 83
 				'connect_timeout' => 10,
84 84
 			]);
85
-			if($response->getStatusCode() === Http::STATUS_OK) {
85
+			if ($response->getStatusCode() === Http::STATUS_OK) {
86 86
 				$decodedServices = json_decode($response->getBody(), true);
87 87
 				if (\is_array($decodedServices)) {
88 88
 					$discoveredServices = $this->getEndpoints($decodedServices, $service);
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 		}
94 94
 
95 95
 		// Write into cache
96
-		$this->cache->set($remote . '#' . $service, json_encode($discoveredServices), 60*60*24);
96
+		$this->cache->set($remote.'#'.$service, json_encode($discoveredServices), 60 * 60 * 24);
97 97
 		return $discoveredServices;
98 98
 	}
99 99
 
@@ -108,9 +108,9 @@  discard block
 block discarded – undo
108 108
 
109 109
 		$discoveredServices = [];
110 110
 
111
-		if(isset($decodedServices['services'][$service]['endpoints'])) {
111
+		if (isset($decodedServices['services'][$service]['endpoints'])) {
112 112
 			foreach ($decodedServices['services'][$service]['endpoints'] as $endpoint => $url) {
113
-				if($this->isSafeUrl($url)) {
113
+				if ($this->isSafeUrl($url)) {
114 114
 					$discoveredServices[$endpoint] = $url;
115 115
 				}
116 116
 			}
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
 	 * @return bool
128 128
 	 */
129 129
 	protected function isSafeUrl(string $url): bool {
130
-		return (bool)preg_match('/^[\/\.\-A-Za-z0-9]+$/', $url);
130
+		return (bool) preg_match('/^[\/\.\-A-Za-z0-9]+$/', $url);
131 131
 	}
132 132
 
133 133
 }
Please login to merge, or discard this patch.
lib/private/IntegrityCheck/Helpers/FileAccessHelper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -61,8 +61,8 @@  discard block
 block discarded – undo
61 61
 	 */
62 62
 	public function file_put_contents(string $filename, string $data): int {
63 63
 		$bytesWritten = @file_put_contents($filename, $data);
64
-		if ($bytesWritten === false || $bytesWritten !== \strlen($data)){
65
-			throw new \Exception('Failed to write into ' . $filename);
64
+		if ($bytesWritten === false || $bytesWritten !== \strlen($data)) {
65
+			throw new \Exception('Failed to write into '.$filename);
66 66
 		}
67 67
 		return $bytesWritten;
68 68
 	}
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 	 */
82 82
 	public function assertDirectoryExists(string $path) {
83 83
 		if (!is_dir($path)) {
84
-			throw new \Exception('Directory ' . $path . ' does not exist.');
84
+			throw new \Exception('Directory '.$path.' does not exist.');
85 85
 		}
86 86
 	}
87 87
 }
Please login to merge, or discard this patch.
lib/private/IntegrityCheck/Helpers/AppLocator.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
 	 */
41 41
 	public function getAppPath(string $appId): string {
42 42
 		$path = \OC_App::getAppPath($appId);
43
-		if($path === false) {
43
+		if ($path === false) {
44 44
 
45 45
 			throw new \Exception('App not found');
46 46
 		}
Please login to merge, or discard this patch.
lib/private/SystemTag/SystemTagManager.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -139,14 +139,14 @@  discard block
 block discarded – undo
139 139
 			->from(self::TAG_TABLE);
140 140
 
141 141
 		if (!\is_null($visibilityFilter)) {
142
-			$query->andWhere($query->expr()->eq('visibility', $query->createNamedParameter((int)$visibilityFilter)));
142
+			$query->andWhere($query->expr()->eq('visibility', $query->createNamedParameter((int) $visibilityFilter)));
143 143
 		}
144 144
 
145 145
 		if (!empty($nameSearchPattern)) {
146 146
 			$query->andWhere(
147 147
 				$query->expr()->like(
148 148
 					'name',
149
-					$query->createNamedParameter('%' . $this->connection->escapeLikeParameter($nameSearchPattern). '%')
149
+					$query->createNamedParameter('%'.$this->connection->escapeLikeParameter($nameSearchPattern).'%')
150 150
 				)
151 151
 			);
152 152
 		}
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
 		$result->closeCursor();
181 181
 		if (!$row) {
182 182
 			throw new TagNotFoundException(
183
-				'Tag ("' . $tagName . '", '. $userVisible . ', ' . $userAssignable . ') does not exist'
183
+				'Tag ("'.$tagName.'", '.$userVisible.', '.$userAssignable.') does not exist'
184 184
 			);
185 185
 		}
186 186
 
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
 			$query->execute();
204 204
 		} catch (UniqueConstraintViolationException $e) {
205 205
 			throw new TagAlreadyExistsException(
206
-				'Tag ("' . $tagName . '", '. $userVisible . ', ' . $userAssignable . ') already exists',
206
+				'Tag ("'.$tagName.'", '.$userVisible.', '.$userAssignable.') already exists',
207 207
 				0,
208 208
 				$e
209 209
 			);
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
 		$tagId = $query->getLastInsertId();
213 213
 
214 214
 		$tag = new SystemTag(
215
-			(string)$tagId,
215
+			(string) $tagId,
216 216
 			$tagName,
217 217
 			$userVisible,
218 218
 			$userAssignable
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
 			}
265 265
 		} catch (UniqueConstraintViolationException $e) {
266 266
 			throw new TagAlreadyExistsException(
267
-				'Tag ("' . $tagName . '", '. $userVisible . ', ' . $userAssignable . ') already exists',
267
+				'Tag ("'.$tagName.'", '.$userVisible.', '.$userAssignable.') already exists',
268 268
 				0,
269 269
 				$e
270 270
 			);
@@ -371,7 +371,7 @@  discard block
 block discarded – undo
371 371
 	}
372 372
 
373 373
 	private function createSystemTagFromRow($row) {
374
-		return new SystemTag((string)$row['id'], $row['name'], (bool)$row['visibility'], (bool)$row['editable']);
374
+		return new SystemTag((string) $row['id'], $row['name'], (bool) $row['visibility'], (bool) $row['editable']);
375 375
 	}
376 376
 
377 377
 	/**
Please login to merge, or discard this patch.
lib/private/Session/CryptoSessionData.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 	public function __destruct() {
70 70
 		try {
71 71
 			$this->close();
72
-		} catch (SessionNotAvailableException $e){
72
+		} catch (SessionNotAvailableException $e) {
73 73
 			// This exception can occur if session is already closed
74 74
 			// So it is safe to ignore it and let the garbage collector to proceed
75 75
 		}
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 	 * @return string|null Either the value or null
106 106
 	 */
107 107
 	public function get(string $key) {
108
-		if(isset($this->sessionValues[$key])) {
108
+		if (isset($this->sessionValues[$key])) {
109 109
 			return $this->sessionValues[$key];
110 110
 		}
111 111
 
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 	 * Close the session and release the lock, also writes all changed data in batch
172 172
 	 */
173 173
 	public function close() {
174
-		if($this->isModified) {
174
+		if ($this->isModified) {
175 175
 			$encryptedValue = $this->crypto->encrypt(json_encode($this->sessionValues), $this->passphrase);
176 176
 			$this->session->set(self::encryptedSessionName, $encryptedValue);
177 177
 			$this->isModified = false;
Please login to merge, or discard this patch.
lib/private/Session/Internal.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -170,12 +170,12 @@
 block discarded – undo
170 170
 	 */
171 171
 	private function invoke(string $functionName, array $parameters = [], bool $silence = false) {
172 172
 		try {
173
-			if($silence) {
173
+			if ($silence) {
174 174
 				return @call_user_func_array($functionName, $parameters);
175 175
 			} else {
176 176
 				return call_user_func_array($functionName, $parameters);
177 177
 			}
178
-		} catch(\Error $e) {
178
+		} catch (\Error $e) {
179 179
 			$this->trapError($e->getCode(), $e->getMessage());
180 180
 		}
181 181
 	}
Please login to merge, or discard this patch.
lib/private/Security/IdentityProof/Signer.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 	 * @return bool
82 82
 	 */
83 83
 	public function verify(array $data): bool {
84
-		if(isset($data['message'])
84
+		if (isset($data['message'])
85 85
 			&& isset($data['signature'])
86 86
 			&& isset($data['message']['signer'])
87 87
 		) {
@@ -89,9 +89,9 @@  discard block
 block discarded – undo
89 89
 			$userId = substr($data['message']['signer'], 0, $location);
90 90
 
91 91
 			$user = $this->userManager->get($userId);
92
-			if($user !== null) {
92
+			if ($user !== null) {
93 93
 				$key = $this->keyManager->getKey($user);
94
-				return (bool)openssl_verify(
94
+				return (bool) openssl_verify(
95 95
 					json_encode($data['message']),
96 96
 					base64_decode($data['signature']),
97 97
 					$key->getPublic(),
Please login to merge, or discard this patch.
lib/private/Security/SecureRandom.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@
 block discarded – undo
76 76
 		$maxCharIndex = \strlen($characters) - 1;
77 77
 		$randomString = '';
78 78
 
79
-		while($length > 0) {
79
+		while ($length > 0) {
80 80
 			$randomNumber = \random_int(0, $maxCharIndex);
81 81
 			$randomString .= $characters[$randomNumber];
82 82
 			$length--;
Please login to merge, or discard this patch.