Completed
Pull Request — master (#8630)
by Blizzz
25:22 queued 01:35
created
lib/private/App/AppStore/Bundles/EducationBundle.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 	 * {@inheritDoc}
28 28
 	 */
29 29
 	public function getName() {
30
-		return (string)$this->l10n->t('Education Edition');
30
+		return (string) $this->l10n->t('Education Edition');
31 31
 	}
32 32
 
33 33
 	/**
Please login to merge, or discard this patch.
apps/files_sharing/lib/AppInfo/Application.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 		/**
52 52
 		 * Controllers
53 53
 		 */
54
-		$container->registerService('ShareController', function (SimpleContainer $c) use ($server) {
54
+		$container->registerService('ShareController', function(SimpleContainer $c) use ($server) {
55 55
 			$federatedSharingApp = new \OCA\FederatedFileSharing\AppInfo\Application();
56 56
 			return new ShareController(
57 57
 				$c->query('AppName'),
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 				$server->query(Defaults::class)
72 72
 			);
73 73
 		});
74
-		$container->registerService('ExternalSharesController', function (SimpleContainer $c) {
74
+		$container->registerService('ExternalSharesController', function(SimpleContainer $c) {
75 75
 			return new ExternalSharesController(
76 76
 				$c->query('AppName'),
77 77
 				$c->query('Request'),
@@ -83,13 +83,13 @@  discard block
 block discarded – undo
83 83
 		/**
84 84
 		 * Core class wrappers
85 85
 		 */
86
-		$container->registerService('HttpClientService', function (SimpleContainer $c) use ($server) {
86
+		$container->registerService('HttpClientService', function(SimpleContainer $c) use ($server) {
87 87
 			return $server->getHTTPClientService();
88 88
 		});
89
-		$container->registerService(ICloudIdManager::class, function (SimpleContainer $c) use ($server) {
89
+		$container->registerService(ICloudIdManager::class, function(SimpleContainer $c) use ($server) {
90 90
 			return $server->getCloudIdManager();
91 91
 		});
92
-		$container->registerService('ExternalManager', function (SimpleContainer $c) use ($server) {
92
+		$container->registerService('ExternalManager', function(SimpleContainer $c) use ($server) {
93 93
 			$user = $server->getUserSession()->getUser();
94 94
 			$uid = $user ? $user->getUID() : null;
95 95
 			return new \OCA\Files_Sharing\External\Manager(
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 		/**
108 108
 		 * Middleware
109 109
 		 */
110
-		$container->registerService('SharingCheckMiddleware', function (SimpleContainer $c) use ($server) {
110
+		$container->registerService('SharingCheckMiddleware', function(SimpleContainer $c) use ($server) {
111 111
 			return new SharingCheckMiddleware(
112 112
 				$c->query('AppName'),
113 113
 				$server->getConfig(),
@@ -118,14 +118,14 @@  discard block
 block discarded – undo
118 118
 			);
119 119
 		});
120 120
 
121
-		$container->registerService('OCSShareAPIMiddleware', function (SimpleContainer $c) use ($server) {
121
+		$container->registerService('OCSShareAPIMiddleware', function(SimpleContainer $c) use ($server) {
122 122
 			return new OCSShareAPIMiddleware(
123 123
 				$server->getShareManager(),
124 124
 				$server->getL10N($c->query('AppName'))
125 125
 			);
126 126
 		});
127 127
 
128
-		$container->registerService(ShareInfoMiddleware::class, function () use ($server) {
128
+		$container->registerService(ShareInfoMiddleware::class, function() use ($server) {
129 129
 			return new ShareInfoMiddleware(
130 130
 				$server->getShareManager()
131 131
 			);
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 		$container->registerMiddleWare('OCSShareAPIMiddleware');
137 137
 		$container->registerMiddleWare(ShareInfoMiddleware::class);
138 138
 
139
-		$container->registerService('MountProvider', function (IContainer $c) {
139
+		$container->registerService('MountProvider', function(IContainer $c) {
140 140
 			/** @var \OCP\IServerContainer $server */
141 141
 			$server = $c->query('ServerContainer');
142 142
 			return new MountProvider(
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 			);
147 147
 		});
148 148
 
149
-		$container->registerService('ExternalMountProvider', function (IContainer $c) {
149
+		$container->registerService('ExternalMountProvider', function(IContainer $c) {
150 150
 			/** @var \OCP\IServerContainer $server */
151 151
 			$server = $c->query('ServerContainer');
152 152
 			return new \OCA\Files_Sharing\External\MountProvider(
Please login to merge, or discard this patch.
core/templates/403.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 // @codeCoverageIgnoreStart
3
-if(!isset($_)) {//standalone  page is not supported anymore - redirect to /
3
+if (!isset($_)) {//standalone  page is not supported anymore - redirect to /
4 4
 	require_once '../../lib/base.php';
5 5
 
6 6
 	$urlGenerator = \OC::$server->getURLGenerator();
7
-	header('Location: ' . $urlGenerator->getAbsoluteURL('/'));
7
+	header('Location: '.$urlGenerator->getAbsoluteURL('/'));
8 8
 	exit;
9 9
 }
10 10
 // @codeCoverageIgnoreEnd
11 11
 ?>
12 12
 <ul>
13 13
 	<li class='error'>
14
-		<?php p($l->t( 'Access forbidden' )); ?><br>
15
-		<p class='hint'><?php if(isset($_['file'])) p($_['file'])?></p>
14
+		<?php p($l->t('Access forbidden')); ?><br>
15
+		<p class='hint'><?php if (isset($_['file'])) p($_['file'])?></p>
16 16
 	</li>
17 17
 </ul>
Please login to merge, or discard this patch.
core/templates/404.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@
 block discarded – undo
3 3
 /** @var $l \OCP\IL10N */
4 4
 /** @var $theme OCP\Defaults */
5 5
 // @codeCoverageIgnoreStart
6
-if(!isset($_)) {//standalone  page is not supported anymore - redirect to /
6
+if (!isset($_)) {//standalone  page is not supported anymore - redirect to /
7 7
 	require_once '../../lib/base.php';
8 8
 
9 9
 	$urlGenerator = \OC::$server->getURLGenerator();
10
-	header('Location: ' . $urlGenerator->getAbsoluteURL('/'));
10
+	header('Location: '.$urlGenerator->getAbsoluteURL('/'));
11 11
 	exit;
12 12
 }
13 13
 // @codeCoverageIgnoreEnd
Please login to merge, or discard this patch.
lib/private/Preview/Office.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -41,20 +41,20 @@
 block discarded – undo
41 41
 
42 42
 		$tmpDir = \OC::$server->getTempManager()->getTempBaseDir();
43 43
 
44
-		$defaultParameters = ' -env:UserInstallation=file://' . escapeshellarg($tmpDir . '/owncloud-' . \OC_Util::getInstanceId() . '/') . ' --headless --nologo --nofirststartwizard --invisible --norestore --convert-to pdf --outdir ';
44
+		$defaultParameters = ' -env:UserInstallation=file://'.escapeshellarg($tmpDir.'/owncloud-'.\OC_Util::getInstanceId().'/').' --headless --nologo --nofirststartwizard --invisible --norestore --convert-to pdf --outdir ';
45 45
 		$clParameters = \OC::$server->getConfig()->getSystemValue('preview_office_cl_parameters', $defaultParameters);
46 46
 
47
-		$exec = $this->cmd . $clParameters . escapeshellarg($tmpDir) . ' ' . escapeshellarg($absPath);
47
+		$exec = $this->cmd.$clParameters.escapeshellarg($tmpDir).' '.escapeshellarg($absPath);
48 48
 
49 49
 		shell_exec($exec);
50 50
 
51 51
 		//create imagick object from pdf
52 52
 		$pdfPreview = null;
53 53
 		try {
54
-			list($dirname, , , $filename) = array_values(pathinfo($absPath));
55
-			$pdfPreview = $dirname . '/' . $filename . '.pdf';
54
+			list($dirname,,, $filename) = array_values(pathinfo($absPath));
55
+			$pdfPreview = $dirname.'/'.$filename.'.pdf';
56 56
 
57
-			$pdf = new \imagick($pdfPreview . '[0]');
57
+			$pdf = new \imagick($pdfPreview.'[0]');
58 58
 			$pdf->setImageFormat('jpg');
59 59
 		} catch (\Exception $e) {
60 60
 			unlink($absPath);
Please login to merge, or discard this patch.
lib/private/Security/IdentityProof/Manager.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 	 */
123 123
 	public function getKey(IUser $user) {
124 124
 		$uid = $user->getUID();
125
-		return $this->retrieveKey('user-' . $uid);
125
+		return $this->retrieveKey('user-'.$uid);
126 126
 	}
127 127
 
128 128
 	/**
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 		if ($instanceId === null) {
137 137
 			throw new \RuntimeException('no instance id!');
138 138
 		}
139
-		return $this->retrieveKey('system-' . $instanceId);
139
+		return $this->retrieveKey('system-'.$instanceId);
140 140
 	}
141 141
 
142 142
 
Please login to merge, or discard this patch.
lib/private/DB/QueryBuilder/FunctionBuilder/PgSqlFunctionBuilder.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,6 +25,6 @@
 block discarded – undo
25 25
 
26 26
 class PgSqlFunctionBuilder extends FunctionBuilder {
27 27
 	public function concat($x, $y) {
28
-		return new QueryFunction('(' . $this->helper->quoteColumnName($x) . ' || ' . $this->helper->quoteColumnName($y) . ')');
28
+		return new QueryFunction('('.$this->helper->quoteColumnName($x).' || '.$this->helper->quoteColumnName($y).')');
29 29
 	}
30 30
 }
Please login to merge, or discard this patch.
lib/private/DB/QueryBuilder/FunctionBuilder/SqliteFunctionBuilder.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,6 +25,6 @@
 block discarded – undo
25 25
 
26 26
 class SqliteFunctionBuilder extends FunctionBuilder {
27 27
 	public function concat($x, $y) {
28
-		return new QueryFunction('(' . $this->helper->quoteColumnName($x) . ' || ' . $this->helper->quoteColumnName($y) . ')');
28
+		return new QueryFunction('('.$this->helper->quoteColumnName($x).' || '.$this->helper->quoteColumnName($y).')');
29 29
 	}
30 30
 }
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/Directory.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 				// exit if we can't create a new file and we don't updatable existing file
126 126
 				$chunkInfo = \OC_FileChunking::decodeName($name);
127 127
 				if (!$this->fileView->isCreatable($this->path) &&
128
-					!$this->fileView->isUpdatable($this->path . '/' . $chunkInfo['name'])
128
+					!$this->fileView->isUpdatable($this->path.'/'.$chunkInfo['name'])
129 129
 				) {
130 130
 					throw new \Sabre\DAV\Exception\Forbidden();
131 131
 				}
@@ -139,9 +139,9 @@  discard block
 block discarded – undo
139 139
 
140 140
 			$this->fileView->verifyPath($this->path, $name);
141 141
 
142
-			$path = $this->fileView->getAbsolutePath($this->path) . '/' . $name;
142
+			$path = $this->fileView->getAbsolutePath($this->path).'/'.$name;
143 143
 			// in case the file already exists/overwriting
144
-			$info = $this->fileView->getFileInfo($this->path . '/' . $name);
144
+			$info = $this->fileView->getFileInfo($this->path.'/'.$name);
145 145
 			if (!$info) {
146 146
 				// use a dummy FileInfo which is acceptable here since it will be refreshed after the put is complete
147 147
 				$info = new \OC\Files\FileInfo($path, null, null, [], null);
@@ -176,9 +176,9 @@  discard block
 block discarded – undo
176 176
 			}
177 177
 
178 178
 			$this->fileView->verifyPath($this->path, $name);
179
-			$newPath = $this->path . '/' . $name;
179
+			$newPath = $this->path.'/'.$name;
180 180
 			if (!$this->fileView->mkdir($newPath)) {
181
-				throw new \Sabre\DAV\Exception\Forbidden('Could not create directory ' . $newPath);
181
+				throw new \Sabre\DAV\Exception\Forbidden('Could not create directory '.$newPath);
182 182
 			}
183 183
 		} catch (\OCP\Files\StorageNotAvailableException $e) {
184 184
 			throw new \Sabre\DAV\Exception\ServiceUnavailable($e->getMessage());
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
 			throw new NotFound();
208 208
 		}
209 209
 
210
-		$path = $this->path . '/' . $name;
210
+		$path = $this->path.'/'.$name;
211 211
 		if (is_null($info)) {
212 212
 			try {
213 213
 				$this->fileView->verifyPath($this->path, $name);
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 		}
223 223
 
224 224
 		if (!$info) {
225
-			throw new \Sabre\DAV\Exception\NotFound('File with name ' . $path . ' could not be located');
225
+			throw new \Sabre\DAV\Exception\NotFound('File with name '.$path.' could not be located');
226 226
 		}
227 227
 
228 228
 		if ($info['mimetype'] === 'httpd/unix-directory') {
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
 		// (required old code) instead of "updateFile".
282 282
 		//
283 283
 		// TODO: resolve chunk file name here and implement "updateFile"
284
-		$path = $this->path . '/' . $name;
284
+		$path = $this->path.'/'.$name;
285 285
 		return $this->fileView->file_exists($path);
286 286
 
287 287
 	}
@@ -376,7 +376,7 @@  discard block
 block discarded – undo
376 376
 			throw new ServiceUnavailable('filesystem not setup');
377 377
 		}
378 378
 
379
-		$destinationPath = $this->getPath() . '/' . $targetName;
379
+		$destinationPath = $this->getPath().'/'.$targetName;
380 380
 
381 381
 
382 382
 		$targetNodeExists = $this->childExists($targetName);
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
 		// at getNodeForPath we also check the path for isForbiddenFileOrDir
385 385
 		// with that we have covered both source and destination
386 386
 		if ($sourceNode instanceof Directory && $targetNodeExists) {
387
-			throw new \Sabre\DAV\Exception\Forbidden('Could not copy directory ' . $sourceNode->getName() . ', target exists');
387
+			throw new \Sabre\DAV\Exception\Forbidden('Could not copy directory '.$sourceNode->getName().', target exists');
388 388
 		}
389 389
 
390 390
 		list($sourceDir,) = \Sabre\Uri\split($sourceNode->getPath());
Please login to merge, or discard this patch.