nextcloud / server

apps/dav/lib/HookManager.php

Unused Use Statements -1 removed lines

@@ -28,7 +28,6 @@
 use OCP\IUserManager;
 use OCP\Util;
 use Symfony\Component\EventDispatcher\EventDispatcher;
-use Symfony\Component\EventDispatcher\GenericEvent;
 
 class HookManager {
 

apps/files_sharing/lib/Cache.php

Doc Comments +3 added lines

@@ -110,6 +110,9 @@
 		return parent::moveFromCache($sourceCache, $sourcePath, $targetPath);
 	}
 
+	/**
+	 * @param ICacheEntry $entry
+	 */
 	protected function formatCacheEntry($entry) {
 		$path = isset($entry['path']) ? $entry['path'] : '';
 		$entry = parent::formatCacheEntry($entry);

Unused Use Statements -1 removed lines

@@ -36,7 +36,6 @@
 use OCA\Files_Sharing\ISharedStorage;
 use OCP\Constants;
 use OCP\Files\Cache\ICacheEntry;
-use OCP\Files\Storage\IStorage;
 use OCP\Lock\ILockingProvider;
 
 /**

lib/private/Files/Cache/Wrapper/CacheJail.php

Doc Comments +3 added lines

@@ -194,6 +194,9 @@
 		return $this->cache->getStatus($this->getSourcePath($file));
 	}
 
+	/**
+	 * @param ICacheEntry[] $results
+	 */
 	private function formatSearchResults($results) {
 		$results = array_filter($results, array($this, 'filterCacheEntry'));
 		$results = array_values($results);

apps/files_sharing/lib/SharedStorage.php

Unused Use Statements -1 removed lines

@@ -32,7 +32,6 @@
 namespace OCA\Files_Sharing;
 
 use OC\Files\Filesystem;
-use OC\Files\Cache\FailedCache;
 use OC\Files\Storage\FailedStorage;
 use OCP\Constants;
 use OCP\Files\Cache\ICacheEntry;

apps/files_sharing/lib/Controller/ShareesAPIController.php

Doc Comments +4 added lines, -1 removed lines

@@ -350,7 +350,7 @@ 
 	 * split user and remote from federated cloud id
 	 *
 	 * @param string $address federated share address
-	 * @return array [user, remoteURL]
+	 * @return string[] [user, remoteURL]
 	 * @throws \Exception
 	 */
 	public function splitUserRemote($address) {
@@ -625,6 +625,9 @@ 
 		return $result;
 	}
 
+	/**
+	 * @param string $search
+	 */
 	protected function getLookup($search) {
 		$client = $this->clientService->newClient();
 

apps/dav/lib/CalDAV/CalDavBackend.php

Doc Comments +9 added lines, -3 removed lines

@@ -158,7 +158,7 @@ 
 	 *
 	 * By default this excludes the automatically generated birthday calendar
 	 *
-	 * @param $principalUri
+	 * @param string $principalUri
 	 * @param bool $excludeBirthday
 	 * @return int
 	 */
@@ -304,6 +304,9 @@ 
 		return array_values($calendars);
 	}
 
+	/**
+	 * @param string $principalUri
+	 */
 	public function getUsersOwnCalendars($principalUri) {
 		$principalUri = $this->convertPrincipal($principalUri, true);
 		$fields = array_values($this->propertyMap);
@@ -878,7 +881,7 @@ 
 	 * calendar-data. If the result of a subsequent GET to this object is not
 	 * the exact same as this request body, you should omit the ETag.
 	 *
-	 * @param mixed $calendarId
+	 * @param integer $calendarId
 	 * @param string $objectUri
 	 * @param string $calendarData
 	 * @return string
@@ -1370,7 +1373,7 @@ 
 	 * @param string $principalUri
 	 * @param string $uri
 	 * @param array $properties
-	 * @return mixed
+	 * @return integer
 	 */
 	function createSubscription($principalUri, $uri, array $properties) {
 
@@ -1783,6 +1786,9 @@ 
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

lib/private/Files/Storage/Wrapper/Encryption.php

Doc Comments +2 added lines, -2 removed lines

@@ -984,7 +984,7 @@ 
 	/**
 	 * check if path points to a files version
 	 *
-	 * @param $path
+	 * @param string $path
 	 * @return bool
 	 */
 	protected function isVersion($path) {
@@ -995,7 +995,7 @@ 
 	/**
 	 * check if the given storage should be encrypted or not
 	 *
-	 * @param $path
+	 * @param string $path
 	 * @return bool
 	 */
 	protected function shouldEncrypt($path) {

apps/dav/lib/AppInfo/Application.php

Unused Use Statements -1 removed lines

@@ -25,7 +25,6 @@
 namespace OCA\DAV\AppInfo;
 
 use OCA\DAV\CalDAV\Activity\Backend;
-use OCA\DAV\CalDAV\Activity\Extension;
 use OCA\DAV\CalDAV\Activity\Provider\Event;
 use OCA\DAV\CalDAV\BirthdayService;
 use OCA\DAV\Capabilities;

apps/provisioning_api/lib/Controller/UsersController.php

Unused Use Statements -1 removed lines

@@ -30,7 +30,6 @@
 use OCP\AppFramework\Http\Response;
 use OCP\AppFramework\OCS\OCSException;
 use OCP\AppFramework\OCS\OCSForbiddenException;
-use OCP\AppFramework\OCS\OCSNotFoundException;
 use OCP\AppFramework\OCSController;
 use OCP\IRequest;
 use OCP\AppFramework\Middleware;