Completed
Pull Request — master (#9345)
by Björn
23:58
created
lib/private/Avatar.php 1 patch
Doc Comments   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
 	 * Generate png avatar from svg with Imagick
302 302
 	 * 
303 303
 	 * @param int $size
304
-	 * @return string|boolean
304
+	 * @return string
305 305
 	 */
306 306
 	private function generateAvatarFromSvg(int $size) {
307 307
 		if (!extension_loaded('imagick')) {
@@ -387,6 +387,7 @@  discard block
 block discarded – undo
387 387
 	 * Calculate steps between two Colors
388 388
 	 * @param object Color $steps start color
389 389
 	 * @param object Color $ends end color
390
+	 * @param integer $steps
390 391
 	 * @return array [r,g,b] steps for each color to go from $steps to $ends
391 392
 	 */
392 393
 	private function stepCalc($steps, $ends) {
@@ -399,8 +400,9 @@  discard block
 block discarded – undo
399 400
 
400 401
 	/**
401 402
 	 * Convert a string to an integer evenly
402
-	 * @param string $hash the text to parse
403
-	 * @param int $maximum the maximum range
403
+	 * @param integer $steps
404
+	 * @param Color $color1
405
+	 * @param Color $color2
404 406
 	 * @return int between 0 and $maximum
405 407
 	 */
406 408
 	private function mixPalette($steps, $color1, $color2) {
Please login to merge, or discard this patch.
apps/files_sharing/lib/External/Manager.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
 	 *
325 325
 	 * @param string $remoteDomain
326 326
 	 * @param string $token
327
-	 * @param $remoteId id of the share
327
+	 * @param integer $remoteId id of the share
328 328
 	 * @param string $feedback
329 329
 	 * @return bool
330 330
 	 */
@@ -421,6 +421,9 @@  discard block
 block discarded – undo
421 421
 		return $result;
422 422
 	}
423 423
 
424
+	/**
425
+	 * @param string $mountPoint
426
+	 */
424 427
 	public function removeShare($mountPoint) {
425 428
 
426 429
 		$mountPointObj = $this->mountManager->find($mountPoint);
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/AnonymousOptionsPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
 
48 48
 	/**
49 49
 	 * @throws \Sabre\DAV\Exception\Forbidden
50
-	 * @return bool
50
+	 * @return false|null
51 51
 	 */
52 52
 	public function handleAnonymousOptions(RequestInterface $request, ResponseInterface $response) {
53 53
 		if ($request->getMethod() === 'OPTIONS' && $request->getPath() === '') {
Please login to merge, or discard this patch.
settings/Controller/AppSettingsController.php 1 patch
Doc Comments   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -238,7 +238,6 @@  discard block
 block discarded – undo
238 238
 	/**
239 239
 	 * Get all available apps in a category
240 240
 	 *
241
-	 * @param string $category
242 241
 	 * @return JSONResponse
243 242
 	 * @throws \Exception
244 243
 	 */
@@ -415,7 +414,7 @@  discard block
 block discarded – undo
415 414
 	 * apps will be enabled for specific groups only if $groups is defined
416 415
 	 *
417 416
 	 * @PasswordConfirmationRequired
418
-	 * @param array $appIds
417
+	 * @param string[] $appIds
419 418
 	 * @param array $groups
420 419
 	 * @return JSONResponse
421 420
 	 */
@@ -479,7 +478,7 @@  discard block
 block discarded – undo
479 478
 	/**
480 479
 	 * @PasswordConfirmationRequired
481 480
 	 *
482
-	 * @param array $appIds
481
+	 * @param string[] $appIds
483 482
 	 * @return JSONResponse
484 483
 	 */
485 484
 	public function disableApps(array $appIds): JSONResponse {
Please login to merge, or discard this patch.
apps/federatedfilesharing/lib/Controller/RequestHandlerController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -450,7 +450,7 @@
 block discarded – undo
450 450
 	/**
451 451
 	 * translate Nextcloud permissions to OCM Permissions
452 452
 	 *
453
-	 * @param $ncPermissions
453
+	 * @param integer $ncPermissions
454 454
 	 * @return array
455 455
 	 */
456 456
 	protected function ncPermissions2ocmPermissions($ncPermissions) {
Please login to merge, or discard this patch.
apps/files_sharing/lib/External/Storage.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -407,7 +407,7 @@
 block discarded – undo
407 407
 	/**
408 408
 	 * calculate default permissions in case no permissions are provided
409 409
 	 *
410
-	 * @param $path
410
+	 * @param string $path
411 411
 	 * @return int
412 412
 	 */
413 413
 	protected function getDefaultPermissions($path) {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/FilesPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -450,7 +450,7 @@
 block discarded – undo
450 450
 	/**
451 451
 	 * translate Nextcloud permissions to OCM Permissions
452 452
 	 *
453
-	 * @param $ncPermissions
453
+	 * @param integer $ncPermissions
454 454
 	 * @return array
455 455
 	 */
456 456
 	protected function ncPermissions2ocmPermissions($ncPermissions) {
Please login to merge, or discard this patch.
apps/federatedfilesharing/lib/ocm/CloudFederationProviderFiles.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 	 * share received from another server
143 143
 	 *
144 144
 	 * @param ICloudFederationShare $share
145
-	 * @return string provider specific unique ID of the share
145
+	 * @return integer provider specific unique ID of the share
146 146
 	 *
147 147
 	 * @throws ProviderCouldNotAddShareException
148 148
 	 * @throws \OCP\AppFramework\QueryException
@@ -766,7 +766,7 @@  discard block
 block discarded – undo
766 766
 	/**
767 767
 	 * get the supported share types, e.g. "user", "group", etc.
768 768
 	 *
769
-	 * @return array
769
+	 * @return string[]
770 770
 	 *
771 771
 	 * @since 14.0.0
772 772
 	 */
Please login to merge, or discard this patch.