Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 40 | class DefaultTokenProvider implements IProvider { |
||
| 41 | |||
| 42 | /** @var DefaultTokenMapper */ |
||
| 43 | private $mapper; |
||
| 44 | |||
| 45 | /** @var ICrypto */ |
||
| 46 | private $crypto; |
||
| 47 | |||
| 48 | /** @var IConfig */ |
||
| 49 | private $config; |
||
| 50 | |||
| 51 | /** @var ILogger $logger */ |
||
| 52 | private $logger; |
||
| 53 | |||
| 54 | /** @var ITimeFactory $time */ |
||
| 55 | private $time; |
||
| 56 | |||
| 57 | /** |
||
| 58 | * @param DefaultTokenMapper $mapper |
||
| 59 | * @param ICrypto $crypto |
||
| 60 | * @param IConfig $config |
||
| 61 | * @param ILogger $logger |
||
| 62 | * @param ITimeFactory $time |
||
| 63 | */ |
||
| 64 | View Code Duplication | public function __construct(DefaultTokenMapper $mapper, |
|
| 75 | |||
| 76 | /** |
||
| 77 | * Create and persist a new token |
||
| 78 | * |
||
| 79 | * @param string $token |
||
| 80 | * @param string $uid |
||
| 81 | * @param string $loginName |
||
| 82 | * @param string|null $password |
||
| 83 | * @param string $name |
||
| 84 | * @param int $type token type |
||
| 85 | * @param int $remember whether the session token should be used for remember-me |
||
| 86 | * @return IToken |
||
| 87 | */ |
||
| 88 | public function generateToken(string $token, |
||
| 113 | |||
| 114 | /** |
||
| 115 | * Save the updated token |
||
| 116 | * |
||
| 117 | * @param IToken $token |
||
| 118 | * @throws InvalidTokenException |
||
| 119 | */ |
||
| 120 | public function updateToken(IToken $token) { |
||
| 126 | |||
| 127 | /** |
||
| 128 | * Update token activity timestamp |
||
| 129 | * |
||
| 130 | * @throws InvalidTokenException |
||
| 131 | * @param IToken $token |
||
| 132 | */ |
||
| 133 | View Code Duplication | public function updateTokenActivity(IToken $token) { |
|
| 145 | |||
| 146 | public function getTokenByUser(string $uid): array { |
||
| 149 | |||
| 150 | /** |
||
| 151 | * Get a token by token |
||
| 152 | * |
||
| 153 | * @param string $tokenId |
||
| 154 | * @throws InvalidTokenException |
||
| 155 | * @throws ExpiredTokenException |
||
| 156 | * @return IToken |
||
| 157 | */ |
||
| 158 | View Code Duplication | public function getToken(string $tokenId): IToken { |
|
| 171 | |||
| 172 | /** |
||
| 173 | * Get a token by token id |
||
| 174 | * |
||
| 175 | * @param int $tokenId |
||
| 176 | * @throws InvalidTokenException |
||
| 177 | * @throws ExpiredTokenException |
||
| 178 | * @return IToken |
||
| 179 | */ |
||
| 180 | View Code Duplication | public function getTokenById(int $tokenId): IToken { |
|
| 193 | |||
| 194 | /** |
||
| 195 | * @param string $oldSessionId |
||
| 196 | * @param string $sessionId |
||
| 197 | * @throws InvalidTokenException |
||
| 198 | */ |
||
| 199 | public function renewSessionToken(string $oldSessionId, string $sessionId) { |
||
| 217 | |||
| 218 | /** |
||
| 219 | * @param IToken $savedToken |
||
| 220 | * @param string $tokenId session token |
||
| 221 | * @throws InvalidTokenException |
||
| 222 | * @throws PasswordlessTokenException |
||
| 223 | * @return string |
||
| 224 | */ |
||
| 225 | public function getPassword(IToken $savedToken, string $tokenId): string { |
||
| 232 | |||
| 233 | /** |
||
| 234 | * Encrypt and set the password of the given token |
||
| 235 | * |
||
| 236 | * @param IToken $token |
||
| 237 | * @param string $tokenId |
||
| 238 | * @param string $password |
||
| 239 | * @throws InvalidTokenException |
||
| 240 | */ |
||
| 241 | public function setPassword(IToken $token, string $tokenId, string $password) { |
||
| 249 | |||
| 250 | /** |
||
| 251 | * Invalidate (delete) the given session token |
||
| 252 | * |
||
| 253 | * @param string $token |
||
| 254 | */ |
||
| 255 | public function invalidateToken(string $token) { |
||
| 258 | |||
| 259 | public function invalidateTokenById(string $uid, int $id) { |
||
| 262 | |||
| 263 | /** |
||
| 264 | * Invalidate (delete) old session tokens |
||
| 265 | */ |
||
| 266 | View Code Duplication | public function invalidateOldTokens() { |
|
| 274 | |||
| 275 | /** |
||
| 276 | * Rotate the token. Usefull for for example oauth tokens |
||
| 277 | * |
||
| 278 | * @param IToken $token |
||
| 279 | * @param string $oldTokenId |
||
| 280 | * @param string $newTokenId |
||
| 281 | * @return IToken |
||
| 282 | */ |
||
| 283 | public function rotate(IToken $token, string $oldTokenId, string $newTokenId): IToken { |
||
| 296 | |||
| 297 | /** |
||
| 298 | * @param string $token |
||
| 299 | * @return string |
||
| 300 | */ |
||
| 301 | private function hashToken(string $token): string { |
||
| 305 | |||
| 306 | /** |
||
| 307 | * Encrypt the given password |
||
| 308 | * |
||
| 309 | * The token is used as key |
||
| 310 | * |
||
| 311 | * @param string $password |
||
| 312 | * @param string $token |
||
| 313 | * @return string encrypted password |
||
| 314 | */ |
||
| 315 | private function encryptPassword(string $password, string $token): string { |
||
| 319 | |||
| 320 | /** |
||
| 321 | * Decrypt the given password |
||
| 322 | * |
||
| 323 | * The token is used as key |
||
| 324 | * |
||
| 325 | * @param string $password |
||
| 326 | * @param string $token |
||
| 327 | * @throws InvalidTokenException |
||
| 328 | * @return string the decrypted key |
||
| 329 | */ |
||
| 330 | View Code Duplication | private function decryptPassword(string $password, string $token): string { |
|
| 340 | |||
| 341 | public function markPasswordInvalid(IToken $token, string $tokenId) { |
||
| 349 | |||
| 350 | public function updatePasswords(string $uid, string $password) { |
||
| 353 | } |
||
| 354 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: