Provider::search() - Code Metrics - Inspection of "Merge pull request #9222 from nextcloud/feature/no..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8255fa...61397e )

by Morris

created 2018-07-25 18:30 UTC

Provider::search() B

↳ Parent: Provider

Complexity

Conditions	8
Paths	13

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
nc	13
nop	1
dl	0
loc	52
rs	7.8028
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * @copyright Copyright (c) 2018 Joas Schilling <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Comments\Search;

use OCP\Comments\IComment;
use OCP\Files\Folder;
use OCP\Files\Node;
use OCP\Files\NotFoundException;
use OCP\IUser;

class Provider extends \OCP\Search\Provider {

	/**
	 * Search for $query
	 *
	 * @param string $query
	 * @return array An array of OCP\Search\Result's
	 * @since 7.0.0
	 */
	public function search($query): array {
		$cm = \OC::$server->getCommentsManager();
		$us = \OC::$server->getUserSession();

		$user = $us->getUser();
		if (!$user instanceof IUser) {
			return [];
		}
		$uf = \OC::$server->getUserFolder($user->getUID());

		if ($uf === null) {
			return [];
		}

		$result = [];
		$numComments = 50;
		$offset = 0;

		while (\count($result) < $numComments) {
			/** @var IComment[] $comments */
			$comments = $cm->search($query, 'files', '', 'comment', $offset, $numComments);

			foreach ($comments as $comment) {
				if ($comment->getActorType() !== 'users') {
					continue;
				}

				$displayName = $cm->resolveDisplayName('user', $comment->getActorId());

				try {
					$file = $this->getFileForComment($uf, $comment);
					$result[] = new Result($query,
						$comment,
						$displayName,
						$file->getPath()
					);
				} catch (NotFoundException $e) {
					continue;
				}
			}

			if (\count($comments) < $numComments) {
				// Didn't find more comments when we tried to get, so there are no more comments.
				return $result;
			}

			$offset += $numComments;
			$numComments = 50 - \count($result);
		}

		return $result;
	}

	/**
	 * @param Folder $userFolder
	 * @param IComment $comment
	 * @return Node
	 * @throws NotFoundException
	 */
	protected function getFileForComment(Folder $userFolder, IComment $comment): Node {
		$nodes = $userFolder->getById((int) $comment->getObjectId());
		if (empty($nodes)) {
			throw new NotFoundException('File not found');
		}

		return array_shift($nodes);
	}
}


1			<?php
2			/**
3			* @copyright Copyright (c) 2018 Joas Schilling <[email protected]>
4			*
5			* @license GNU AGPL version 3 or any later version
6			*
7			* This program is free software: you can redistribute it and/or modify
8			* it under the terms of the GNU Affero General Public License as
9			* published by the Free Software Foundation, either version 3 of the
10			* License, or (at your option) any later version.
11			*
12			* This program is distributed in the hope that it will be useful,
13			* but WITHOUT ANY WARRANTY; without even the implied warranty of
14			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			* GNU Affero General Public License for more details.
16			*
17			* You should have received a copy of the GNU Affero General Public License
18			* along with this program. If not, see <http://www.gnu.org/licenses/>.
19			*
20			*/
21
22			namespace OCA\Comments\Search;
23
24			use OCP\Comments\IComment;
25			use OCP\Files\Folder;
26			use OCP\Files\Node;
27			use OCP\Files\NotFoundException;
28			use OCP\IUser;
29
30			class Provider extends \OCP\Search\Provider {
31
32			/**
33			* Search for $query
34			*
35			* @param string $query
36			* @return array An array of OCP\Search\Result's
37			* @since 7.0.0
38			*/
39			public function search($query): array {
40			$cm = \OC::$server->getCommentsManager();
41			$us = \OC::$server->getUserSession();
42
43			$user = $us->getUser();
44			if (!$user instanceof IUser) {
45			return [];
46			}
47			$uf = \OC::$server->getUserFolder($user->getUID());
48
49			if ($uf === null) {
50			return [];
51			}
52
53			$result = [];
54			$numComments = 50;
55			$offset = 0;
56
57			while (\count($result) < $numComments) {
58			/** @var IComment[] $comments */
59			$comments = $cm->search($query, 'files', '', 'comment', $offset, $numComments);
60
61			foreach ($comments as $comment) {
62			if ($comment->getActorType() !== 'users') {
63			continue;
64			}
65
66			$displayName = $cm->resolveDisplayName('user', $comment->getActorId());
67
68			try {
69			$file = $this->getFileForComment($uf, $comment);
70			$result[] = new Result($query,
71			$comment,
72			$displayName,
73			$file->getPath()
74			);
75			} catch (NotFoundException $e) {
76			continue;
77			}
78			}
79
80			if (\count($comments) < $numComments) {
81			// Didn't find more comments when we tried to get, so there are no more comments.
82			return $result;
83			}
84
85			$offset += $numComments;
86			$numComments = 50 - \count($result);
87			}
88
89			return $result;
90			}
91
92			/**
93			* @param Folder $userFolder
94			* @param IComment $comment
95			* @return Node
96			* @throws NotFoundException
97			*/
98			protected function getFileForComment(Folder $userFolder, IComment $comment): Node {
99			$nodes = $userFolder->getById((int) $comment->getObjectId());
100			if (empty($nodes)) {
101			throw new NotFoundException('File not found');
102			}
103
104			return array_shift($nodes);
105			}
106			}
107

nextcloud / server

Push — master ( 8255fa...61397e )

Provider::search() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like