nextcloud / server

apps/cloud_federation_api/lib/Controller/RequestHandlerController.php

Doc Comments -1 removed lines

@@ -106,7 +106,6 @@
 	 * @param string $ownerDisplayName display name of the user who shared the item
 	 * @param string $sharedBy provider specific UID of the user who shared the resource
 	 * @param string $sharedByDisplayName display name of the user who shared the resource
-	 * @param string $sharedSecret use to authenticate accross servers
 	 * @param array $protocol (e,.g. ['name' => 'webdav', 'options' => ['username' => 'john', 'permissions' => 31]])
 	 * @param string $shareType ('group' or 'user' share)
 	 * @param $resourceType ('file', 'calendar',...)

Braces +1 added lines, -2 removed lines

@@ -247,8 +247,7 @@
 			return new JSONResponse($e->getReturnMessage(), Http::STATUS_BAD_REQUEST);
 		} catch (AuthenticationFailedException $e) {
 			return new JSONResponse(["message" => "RESOURCE_NOT_FOUND"], Http::STATUS_FORBIDDEN);
-		}
-		catch (\Exception $e) {
+		} catch (\Exception $e) {
 			return new JSONResponse(
 				['message' => 'Internal error at ' . $this->urlGenerator->getBaseUrl()],
 				Http::STATUS_BAD_REQUEST

lib/public/Federation/Exceptions/AuthenticationFailedException.php

Doc Comments -1 removed lines

@@ -28,7 +28,6 @@
 	/**
 	 * BadRequestException constructor.
 	 *
-	 * @param array $missingParameters
 	 */
 	public function __construct() {
 		$l = \OC::$server->getL10N('federation');

apps/files_sharing/lib/External/Manager.php

Doc Comments +4 added lines, -1 removed lines

@@ -324,7 +324,7 @@ 
 	 *
 	 * @param string $remoteDomain
 	 * @param string $token
-	 * @param $remoteId id of the share
+	 * @param integer $remoteId id of the share
 	 * @param string $feedback
 	 * @return bool
 	 */
@@ -421,6 +421,9 @@ 
 		return $result;
 	}
 
+	/**
+	 * @param string $mountPoint
+	 */
 	public function removeShare($mountPoint) {
 
 		$mountPointObj = $this->mountManager->find($mountPoint);

apps/federatedfilesharing/lib/Notifications.php

Doc Comments +7 added lines, -7 removed lines

@@ -184,7 +184,7 @@ 
 	 * @param string $remote url
 	 * @param int $id share id
 	 * @param string $token
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public function sendRemoteUnShare($remote, $id, $token) {
 		$this->sendUpdateToRemote($remote, $id, $token, 'unshare');
@@ -196,7 +196,7 @@ 
 	 * @param string $remote url
 	 * @param int $id share id
 	 * @param string $token
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public function sendRevokeShare($remote, $id, $token) {
 		$this->sendUpdateToRemote($remote, $id, $token, 'reshare_undo');
@@ -209,7 +209,7 @@ 
 	 * @param int $remoteId
 	 * @param string $token
 	 * @param int $permissions
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public function sendPermissionChange($remote, $remoteId, $token, $permissions) {
 		$this->sendUpdateToRemote($remote, $remoteId, $token, 'permissions', ['permissions' => $permissions]);
@@ -330,8 +330,8 @@ 
 	/**
 	 * try old federated sharing API if the OCM api doesn't work
 	 *
-	 * @param $remoteDomain
-	 * @param $urlSuffix
+	 * @param string $remoteDomain
+	 * @param string $urlSuffix
 	 * @param array $fields
 	 * @return mixed
 	 * @throws \Exception
@@ -395,9 +395,9 @@ 
 	/**
 	 * send action regarding federated sharing to the remote server using the OCM API
 	 *
-	 * @param $remoteDomain
+	 * @param string $remoteDomain
 	 * @param $fields
-	 * @param $action
+	 * @param string $action
 	 *
 	 * @return bool
 	 */

apps/federatedfilesharing/lib/ocm/CloudFederationProviderFiles.php

Doc Comments +5 added lines, -2 removed lines

@@ -144,7 +144,7 @@ 
 	 * share received from another server
 	 *
 	 * @param ICloudFederationShare $share
-	 * @return string provider specific unique ID of the share
+	 * @return integer provider specific unique ID of the share
 	 *
 	 * @throws ProviderCouldNotAddShareException
 	 * @throws \OCP\AppFramework\QueryException
@@ -469,6 +469,9 @@ 
 		return [];
 	}
 
+	/**
+	 * @param string $id
+	 */
 	private function unshare($id, $notification) {
 		error_log("new unshare!");
 		if (!$this->isS2SEnabled(true)) {
@@ -546,7 +549,7 @@ 
 	/**
 	 * recipient of a share request to re-share the file with another user
 	 *
-	 * @param $id
+	 * @param string $id
 	 * @param $notification
 	 * @return array
 	 * @throws AuthenticationFailedException