Passed
Push — master ( 8113df...5a27e5 )
by Morris
27:51 queued 12:24
created
apps/user_ldap/lib/LDAPProviderFactory.php 1 patch
Indentation   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -28,32 +28,32 @@
 block discarded – undo
28 28
 use OCA\User_LDAP\Mapping\UserMapping;
29 29
 
30 30
 class LDAPProviderFactory implements ILDAPProviderFactory {
31
-	/**
32
-	 * Server container
33
-	 *
34
-	 * @var IServerContainer
35
-	 */
36
-	private $serverContainer;
31
+    /**
32
+     * Server container
33
+     *
34
+     * @var IServerContainer
35
+     */
36
+    private $serverContainer;
37 37
 	
38
-	/**
39
-	 * Constructor for the LDAP provider factory
40
-	 *
41
-	 * @param IServerContainer $serverContainer server container
42
-	 */
43
-	public function __construct(IServerContainer $serverContainer) {
44
-		$this->serverContainer = $serverContainer;
45
-	}
38
+    /**
39
+     * Constructor for the LDAP provider factory
40
+     *
41
+     * @param IServerContainer $serverContainer server container
42
+     */
43
+    public function __construct(IServerContainer $serverContainer) {
44
+        $this->serverContainer = $serverContainer;
45
+    }
46 46
 	
47
-	/**
48
-	 * creates and returns an instance of the ILDAPProvider
49
-	 *
50
-	 * @return OCP\LDAP\ILDAPProvider
51
-	 */
52
-	public function getLDAPProvider() {
53
-		$dbConnection = $this->serverContainer->getDatabaseConnection();
54
-		$userMapping = new UserMapping($dbConnection);
55
-		return new LDAPProvider($this->serverContainer, new Helper($this->serverContainer->getConfig()),
56
-					new DeletedUsersIndex($this->serverContainer->getConfig(), 
57
-					$dbConnection, $userMapping));
58
-	}
47
+    /**
48
+     * creates and returns an instance of the ILDAPProvider
49
+     *
50
+     * @return OCP\LDAP\ILDAPProvider
51
+     */
52
+    public function getLDAPProvider() {
53
+        $dbConnection = $this->serverContainer->getDatabaseConnection();
54
+        $userMapping = new UserMapping($dbConnection);
55
+        return new LDAPProvider($this->serverContainer, new Helper($this->serverContainer->getConfig()),
56
+                    new DeletedUsersIndex($this->serverContainer->getConfig(), 
57
+                    $dbConnection, $userMapping));
58
+    }
59 59
 }
Please login to merge, or discard this patch.
apps/user_ldap/appinfo/routes.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
 $application->registerRoutes($this, [
42 42
 	'ocs' => [
43 43
 		['name' => 'ConfigAPI#create', 'url' => '/api/v1/config', 'verb' => 'POST'],
44
-		['name' => 'ConfigAPI#show',   'url' => '/api/v1/config/{configID}', 'verb' => 'GET'],
44
+		['name' => 'ConfigAPI#show', 'url' => '/api/v1/config/{configID}', 'verb' => 'GET'],
45 45
 		['name' => 'ConfigAPI#modify', 'url' => '/api/v1/config/{configID}', 'verb' => 'PUT'],
46 46
 		['name' => 'ConfigAPI#delete', 'url' => '/api/v1/config/{configID}', 'verb' => 'DELETE'],
47 47
 	]
Please login to merge, or discard this patch.
Indentation   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -23,36 +23,36 @@
 block discarded – undo
23 23
 
24 24
 /** @var $this \OCP\Route\IRouter */
25 25
 $this->create('user_ldap_ajax_clearMappings', 'ajax/clearMappings.php')
26
-	->actionInclude('user_ldap/ajax/clearMappings.php');
26
+    ->actionInclude('user_ldap/ajax/clearMappings.php');
27 27
 $this->create('user_ldap_ajax_deleteConfiguration', 'ajax/deleteConfiguration.php')
28
-	->actionInclude('user_ldap/ajax/deleteConfiguration.php');
28
+    ->actionInclude('user_ldap/ajax/deleteConfiguration.php');
29 29
 $this->create('user_ldap_ajax_getConfiguration', 'ajax/getConfiguration.php')
30
-	->actionInclude('user_ldap/ajax/getConfiguration.php');
30
+    ->actionInclude('user_ldap/ajax/getConfiguration.php');
31 31
 $this->create('user_ldap_ajax_getNewServerConfigPrefix', 'ajax/getNewServerConfigPrefix.php')
32
-	->actionInclude('user_ldap/ajax/getNewServerConfigPrefix.php');
32
+    ->actionInclude('user_ldap/ajax/getNewServerConfigPrefix.php');
33 33
 $this->create('user_ldap_ajax_setConfiguration', 'ajax/setConfiguration.php')
34
-	->actionInclude('user_ldap/ajax/setConfiguration.php');
34
+    ->actionInclude('user_ldap/ajax/setConfiguration.php');
35 35
 $this->create('user_ldap_ajax_testConfiguration', 'ajax/testConfiguration.php')
36
-	->actionInclude('user_ldap/ajax/testConfiguration.php');
36
+    ->actionInclude('user_ldap/ajax/testConfiguration.php');
37 37
 $this->create('user_ldap_ajax_wizard', 'ajax/wizard.php')
38
-	->actionInclude('user_ldap/ajax/wizard.php');
38
+    ->actionInclude('user_ldap/ajax/wizard.php');
39 39
 
40 40
 $application = new \OCP\AppFramework\App('user_ldap');
41 41
 $application->registerRoutes($this, [
42
-	'ocs' => [
43
-		['name' => 'ConfigAPI#create', 'url' => '/api/v1/config', 'verb' => 'POST'],
44
-		['name' => 'ConfigAPI#show',   'url' => '/api/v1/config/{configID}', 'verb' => 'GET'],
45
-		['name' => 'ConfigAPI#modify', 'url' => '/api/v1/config/{configID}', 'verb' => 'PUT'],
46
-		['name' => 'ConfigAPI#delete', 'url' => '/api/v1/config/{configID}', 'verb' => 'DELETE'],
47
-	]
42
+    'ocs' => [
43
+        ['name' => 'ConfigAPI#create', 'url' => '/api/v1/config', 'verb' => 'POST'],
44
+        ['name' => 'ConfigAPI#show',   'url' => '/api/v1/config/{configID}', 'verb' => 'GET'],
45
+        ['name' => 'ConfigAPI#modify', 'url' => '/api/v1/config/{configID}', 'verb' => 'PUT'],
46
+        ['name' => 'ConfigAPI#delete', 'url' => '/api/v1/config/{configID}', 'verb' => 'DELETE'],
47
+    ]
48 48
 ]);
49 49
 
50 50
 $application = new OCA\User_LDAP\AppInfo\Application();
51 51
 $application->registerRoutes($this, [
52
-	'routes' => [
53
-		['name' => 'renewPassword#tryRenewPassword', 'url' => '/renewpassword', 'verb' => 'POST'],
54
-		['name' => 'renewPassword#showRenewPasswordForm', 'url' => '/renewpassword/{user}', 'verb' => 'GET'],
55
-		['name' => 'renewPassword#cancel', 'url' => '/renewpassword/cancel', 'verb' => 'GET'],
56
-		['name' => 'renewPassword#showLoginFormInvalidPassword', 'url' => '/renewpassword/invalidlogin/{user}', 'verb' => 'GET'],
57
-	]
52
+    'routes' => [
53
+        ['name' => 'renewPassword#tryRenewPassword', 'url' => '/renewpassword', 'verb' => 'POST'],
54
+        ['name' => 'renewPassword#showRenewPasswordForm', 'url' => '/renewpassword/{user}', 'verb' => 'GET'],
55
+        ['name' => 'renewPassword#cancel', 'url' => '/renewpassword/cancel', 'verb' => 'GET'],
56
+        ['name' => 'renewPassword#showLoginFormInvalidPassword', 'url' => '/renewpassword/invalidlogin/{user}', 'verb' => 'GET'],
57
+    ]
58 58
 ]);
Please login to merge, or discard this patch.
apps/files_external/templates/settings.php 4 patches
Switch Indentation   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -41,44 +41,44 @@
 block discarded – undo
41 41
 		$is_optional = $parameter->isFlagSet(DefinitionParameter::FLAG_OPTIONAL);
42 42
 
43 43
 		switch ($parameter->getType()) {
44
-		case DefinitionParameter::VALUE_PASSWORD: ?>
45
-			<?php if ($is_optional) { $classes[] = 'optional'; } ?>
46
-			<input type="password"
44
+		    case DefinitionParameter::VALUE_PASSWORD: ?>
45
+    			<?php if ($is_optional) { $classes[] = 'optional'; } ?>
46
+    			<input type="password"
47 47
 				<?php if (!empty($classes)): ?> class="<?php p(implode(' ', $classes)); ?>"<?php endif; ?>
48
-				data-parameter="<?php p($parameter->getName()); ?>"
48
+    				data-parameter="<?php p($parameter->getName()); ?>"
49 49
 				value="<?php p($value); ?>"
50 50
 				placeholder="<?php p($placeholder); ?>"
51 51
 			/>
52 52
 			<?php
53
-			break;
54
-		case DefinitionParameter::VALUE_BOOLEAN: ?>
55
-			<?php $checkboxId = uniqid("checkbox_"); ?>
53
+			    break;
54
+		    case DefinitionParameter::VALUE_BOOLEAN: ?>
55
+    			<?php $checkboxId = uniqid("checkbox_"); ?>
56 56
 			<div>
57 57
 			<label>
58 58
 			<input type="checkbox"
59 59
 				id="<?php p($checkboxId); ?>"
60 60
 				<?php if (!empty($classes)): ?> class="checkbox <?php p(implode(' ', $classes)); ?>"<?php endif; ?>
61
-				data-parameter="<?php p($parameter->getName()); ?>"
61
+    				data-parameter="<?php p($parameter->getName()); ?>"
62 62
 				<?php if ($value === true): ?> checked="checked"<?php endif; ?>
63
-			/>
63
+    			/>
64 64
 			<?php p($placeholder); ?>
65 65
 			</label>
66 66
 			</div>
67 67
 			<?php
68
-			break;
69
-		case DefinitionParameter::VALUE_HIDDEN: ?>
70
-			<input type="hidden"
68
+			    break;
69
+		    case DefinitionParameter::VALUE_HIDDEN: ?>
70
+    			<input type="hidden"
71 71
 				<?php if (!empty($classes)): ?> class="<?php p(implode(' ', $classes)); ?>"<?php endif; ?>
72
-				data-parameter="<?php p($parameter->getName()); ?>"
72
+    				data-parameter="<?php p($parameter->getName()); ?>"
73 73
 				value="<?php p($value); ?>"
74 74
 			/>
75 75
 			<?php
76
-			break;
77
-		default: ?>
78
-			<?php if ($is_optional) { $classes[] = 'optional'; } ?>
79
-			<input type="text"
76
+			    break;
77
+		    default: ?>
78
+    			<?php if ($is_optional) { $classes[] = 'optional'; } ?>
79
+    			<input type="text"
80 80
 				<?php if (!empty($classes)): ?> class="<?php p(implode(' ', $classes)); ?>"<?php endif; ?>
81
-				data-parameter="<?php p($parameter->getName()); ?>"
81
+    				data-parameter="<?php p($parameter->getName()); ?>"
82 82
 				value="<?php p($value); ?>"
83 83
 				placeholder="<?php p($placeholder); ?>"
84 84
 			/>
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -93,7 +93,7 @@
 block discarded – undo
93 93
 	<h2><?php p($l->t('No external storage configured or you don\'t have the permission to configure them')); ?></h2>
94 94
 </div>
95 95
 
96
-<form data-can-create="<?php echo $canCreateMounts?'true':'false' ?>" id="files_external" class="section" data-encryption-enabled="<?php echo $_['encryptionEnabled']?'true': 'false'; ?>">
96
+<form data-can-create="<?php echo $canCreateMounts ? 'true' : 'false' ?>" id="files_external" class="section" data-encryption-enabled="<?php echo $_['encryptionEnabled'] ? 'true' : 'false'; ?>">
97 97
 	<h2 data-anchor-name="external-storage"><?php p($l->t('External storages')); ?></h2>
98 98
 	<p class="settings-hint"><?php p($l->t('External storage enables you to mount external storage services and devices as secondary Nextcloud storage devices. You may also allow users to mount their own external storage services.')); ?></p>
99 99
 	<?php if (isset($_['dependencies']) and ($_['dependencies'] !== '') and $canCreateMounts) print_unescaped(''.$_['dependencies'].''); ?>
Please login to merge, or discard this patch.
Braces   +24 added lines, -6 removed lines patch added patch discarded remove patch
@@ -96,7 +96,10 @@  discard block
 block discarded – undo
96 96
 <form data-can-create="<?php echo $canCreateMounts?'true':'false' ?>" id="files_external" class="section" data-encryption-enabled="<?php echo $_['encryptionEnabled']?'true': 'false'; ?>">
97 97
 	<h2 data-anchor-name="external-storage"><?php p($l->t('External storages')); ?></h2>
98 98
 	<p class="settings-hint"><?php p($l->t('External storage enables you to mount external storage services and devices as secondary Nextcloud storage devices. You may also allow users to mount their own external storage services.')); ?></p>
99
-	<?php if (isset($_['dependencies']) and ($_['dependencies'] !== '') and $canCreateMounts) print_unescaped(''.$_['dependencies'].''); ?>
99
+	<?php if (isset($_['dependencies']) and ($_['dependencies'] !== '') and $canCreateMounts) {
100
+    print_unescaped(''.$_['dependencies'].'');
101
+}
102
+?>
100 103
 	<table id="externalStorage" class="grid" data-admin='<?php print_unescaped(json_encode($_['visibilityType'] === BackendService::VISIBILITY_ADMIN)); ?>'>
101 104
 		<thead>
102 105
 			<tr>
@@ -105,7 +108,10 @@  discard block
 block discarded – undo
105 108
 				<th><?php p($l->t('External storage')); ?></th>
106 109
 				<th><?php p($l->t('Authentication')); ?></th>
107 110
 				<th><?php p($l->t('Configuration')); ?></th>
108
-				<?php if ($_['visibilityType'] === BackendService::VISIBILITY_ADMIN) print_unescaped('<th>'.$l->t('Available for').'</th>'); ?>
111
+				<?php if ($_['visibilityType'] === BackendService::VISIBILITY_ADMIN) {
112
+    print_unescaped('<th>'.$l->t('Available for').'</th>');
113
+}
114
+?>
109 115
 				<th>&nbsp;</th>
110 116
 				<th>&nbsp;</th>
111 117
 				<th>&nbsp;</th>
@@ -138,7 +144,10 @@  discard block
 block discarded – undo
138 144
 							});
139 145
 						?>
140 146
 						<?php foreach ($sortedBackends as $backend): ?>
141
-							<?php if ($backend->getDeprecateTo()) continue; // ignore deprecated backends ?>
147
+							<?php if ($backend->getDeprecateTo()) {
148
+    continue;
149
+}
150
+// ignore deprecated backends ?>
142 151
 							<option value="<?php p($backend->getIdentifier()); ?>"><?php p($backend->getText()); ?></option>
143 152
 						<?php endforeach; ?>
144 153
 					</select>
@@ -163,7 +172,10 @@  discard block
 block discarded – undo
163 172
 
164 173
 	<?php if ($_['visibilityType'] === BackendService::VISIBILITY_ADMIN): ?>
165 174
 		<input type="checkbox" name="allowUserMounting" id="allowUserMounting" class="checkbox"
166
-			value="1" <?php if ($_['allowUserMounting']) print_unescaped(' checked="checked"'); ?> />
175
+			value="1" <?php if ($_['allowUserMounting']) {
176
+    print_unescaped(' checked="checked"');
177
+}
178
+?> />
167 179
 		<label for="allowUserMounting"><?php p($l->t('Allow users to mount external storage')); ?></label> <span id="userMountingMsg" class="msg"></span>
168 180
 
169 181
 		<p id="userMountingBackends"<?php if (!$_['allowUserMounting']): ?> class="hidden"<?php endif; ?>>
@@ -175,8 +187,14 @@  discard block
 block discarded – undo
175 187
 			<?php $i = 0; foreach ($userBackends as $backend): ?>
176 188
 				<?php if ($deprecateTo = $backend->getDeprecateTo()): ?>
177 189
 					<input type="hidden" id="allowUserMountingBackends<?php p($i); ?>" name="allowUserMountingBackends[]" value="<?php p($backend->getIdentifier()); ?>" data-deprecate-to="<?php p($deprecateTo->getIdentifier()); ?>" />
178
-				<?php else: ?>
179
-					<input type="checkbox" id="allowUserMountingBackends<?php p($i); ?>" class="checkbox" name="allowUserMountingBackends[]" value="<?php p($backend->getIdentifier()); ?>" <?php if ($backend->isVisibleFor(BackendService::VISIBILITY_PERSONAL)) print_unescaped(' checked="checked"'); ?> />
190
+				<?php else {
191
+    : ?>
192
+					<input type="checkbox" id="allowUserMountingBackends<?php p($i);
193
+}
194
+?>" class="checkbox" name="allowUserMountingBackends[]" value="<?php p($backend->getIdentifier()); ?>" <?php if ($backend->isVisibleFor(BackendService::VISIBILITY_PERSONAL)) {
195
+    print_unescaped(' checked="checked"');
196
+}
197
+?> />
180 198
 					<label for="allowUserMountingBackends<?php p($i); ?>"><?php p($backend->getText()); ?></label> <br />
181 199
 				<?php endif; ?>
182 200
 				<?php $i++; ?>
Please login to merge, or discard this patch.
Indentation   +60 added lines, -60 removed lines patch added patch discarded remove patch
@@ -1,51 +1,51 @@  discard block
 block discarded – undo
1 1
 <?php
2
-	use \OCA\Files_External\Lib\Backend\Backend;
3
-	use \OCA\Files_External\Lib\Auth\AuthMechanism;
4
-	use \OCA\Files_External\Lib\DefinitionParameter;
5
-	use \OCA\Files_External\Service\BackendService;
2
+    use \OCA\Files_External\Lib\Backend\Backend;
3
+    use \OCA\Files_External\Lib\Auth\AuthMechanism;
4
+    use \OCA\Files_External\Lib\DefinitionParameter;
5
+    use \OCA\Files_External\Service\BackendService;
6 6
 
7
-	$canCreateMounts = $_['visibilityType'] === BackendService::VISIBILITY_ADMIN || $_['allowUserMounting'];
7
+    $canCreateMounts = $_['visibilityType'] === BackendService::VISIBILITY_ADMIN || $_['allowUserMounting'];
8 8
 
9
-	$l->t("Enable encryption");
10
-	$l->t("Enable previews");
11
-	$l->t("Enable sharing");
12
-	$l->t("Check for changes");
13
-	$l->t("Never");
14
-	$l->t("Once every direct access");
15
-	$l->t('Read only');
9
+    $l->t("Enable encryption");
10
+    $l->t("Enable previews");
11
+    $l->t("Enable sharing");
12
+    $l->t("Check for changes");
13
+    $l->t("Never");
14
+    $l->t("Once every direct access");
15
+    $l->t('Read only');
16 16
 
17
-	script('files_external', [
18
-		'settings',
19
-		'templates'
20
-	]);
21
-	style('files_external', 'settings');
17
+    script('files_external', [
18
+        'settings',
19
+        'templates'
20
+    ]);
21
+    style('files_external', 'settings');
22 22
 
23
-	// load custom JS
24
-	foreach ($_['backends'] as $backend) {
25
-		/** @var Backend $backend */
26
-		$scripts = $backend->getCustomJs();
27
-		foreach ($scripts as $script) {
28
-			script('files_external', $script);
29
-		}
30
-	}
31
-	foreach ($_['authMechanisms'] as $authMechanism) {
32
-		/** @var AuthMechanism $authMechanism */
33
-		$scripts = $authMechanism->getCustomJs();
34
-		foreach ($scripts as $script) {
35
-			script('files_external', $script);
36
-		}
37
-	}
23
+    // load custom JS
24
+    foreach ($_['backends'] as $backend) {
25
+        /** @var Backend $backend */
26
+        $scripts = $backend->getCustomJs();
27
+        foreach ($scripts as $script) {
28
+            script('files_external', $script);
29
+        }
30
+    }
31
+    foreach ($_['authMechanisms'] as $authMechanism) {
32
+        /** @var AuthMechanism $authMechanism */
33
+        $scripts = $authMechanism->getCustomJs();
34
+        foreach ($scripts as $script) {
35
+            script('files_external', $script);
36
+        }
37
+    }
38 38
 
39
-	function writeParameterInput($parameter, $options, $classes = []) {
40
-		$value = '';
41
-		if (isset($options[$parameter->getName()])) {
42
-			$value = $options[$parameter->getName()];
43
-		}
44
-		$placeholder = $parameter->getText();
45
-		$is_optional = $parameter->isFlagSet(DefinitionParameter::FLAG_OPTIONAL);
39
+    function writeParameterInput($parameter, $options, $classes = []) {
40
+        $value = '';
41
+        if (isset($options[$parameter->getName()])) {
42
+            $value = $options[$parameter->getName()];
43
+        }
44
+        $placeholder = $parameter->getText();
45
+        $is_optional = $parameter->isFlagSet(DefinitionParameter::FLAG_OPTIONAL);
46 46
 
47
-		switch ($parameter->getType()) {
48
-		case DefinitionParameter::VALUE_PASSWORD: ?>
47
+        switch ($parameter->getType()) {
48
+        case DefinitionParameter::VALUE_PASSWORD: ?>
49 49
 			<?php if ($is_optional) { $classes[] = 'optional'; } ?>
50 50
 			<input type="password"
51 51
 				<?php if (!empty($classes)): ?> class="<?php p(implode(' ', $classes)); ?>"<?php endif; ?>
@@ -54,8 +54,8 @@  discard block
 block discarded – undo
54 54
 				placeholder="<?php p($placeholder); ?>"
55 55
 			/>
56 56
 			<?php
57
-			break;
58
-		case DefinitionParameter::VALUE_BOOLEAN: ?>
57
+            break;
58
+        case DefinitionParameter::VALUE_BOOLEAN: ?>
59 59
 			<?php $checkboxId = uniqid("checkbox_"); ?>
60 60
 			<div>
61 61
 			<label>
@@ -69,16 +69,16 @@  discard block
 block discarded – undo
69 69
 			</label>
70 70
 			</div>
71 71
 			<?php
72
-			break;
73
-		case DefinitionParameter::VALUE_HIDDEN: ?>
72
+            break;
73
+        case DefinitionParameter::VALUE_HIDDEN: ?>
74 74
 			<input type="hidden"
75 75
 				<?php if (!empty($classes)): ?> class="<?php p(implode(' ', $classes)); ?>"<?php endif; ?>
76 76
 				data-parameter="<?php p($parameter->getName()); ?>"
77 77
 				value="<?php p($value); ?>"
78 78
 			/>
79 79
 			<?php
80
-			break;
81
-		default: ?>
80
+            break;
81
+        default: ?>
82 82
 			<?php if ($is_optional) { $classes[] = 'optional'; } ?>
83 83
 			<input type="text"
84 84
 				<?php if (!empty($classes)): ?> class="<?php p(implode(' ', $classes)); ?>"<?php endif; ?>
@@ -87,8 +87,8 @@  discard block
 block discarded – undo
87 87
 				placeholder="<?php p($placeholder); ?>"
88 88
 			/>
89 89
 			<?php
90
-		}
91
-	}
90
+        }
91
+    }
92 92
 ?>
93 93
 
94 94
 <div id="emptycontent" class="hidden">
@@ -133,13 +133,13 @@  discard block
 block discarded – undo
133 133
 							<?php p($l->t('Add storage')); ?>
134 134
 						</option>
135 135
 						<?php
136
-							$sortedBackends = array_filter($_['backends'], function($backend) use ($_) {
137
-								return $backend->isVisibleFor($_['visibilityType']);
138
-							});
139
-							uasort($sortedBackends, function($a, $b) {
140
-								return strcasecmp($a->getText(), $b->getText());
141
-							});
142
-						?>
136
+                            $sortedBackends = array_filter($_['backends'], function($backend) use ($_) {
137
+                                return $backend->isVisibleFor($_['visibilityType']);
138
+                            });
139
+                            uasort($sortedBackends, function($a, $b) {
140
+                                return strcasecmp($a->getText(), $b->getText());
141
+                            });
142
+                        ?>
143 143
 						<?php foreach ($sortedBackends as $backend): ?>
144 144
 							<?php if ($backend->getDeprecateTo()) continue; // ignore deprecated backends ?>
145 145
 							<option value="<?php p($backend->getIdentifier()); ?>"><?php p($backend->getText()); ?></option>
@@ -171,10 +171,10 @@  discard block
 block discarded – undo
171 171
 
172 172
 		<p id="userMountingBackends"<?php if (!$_['allowUserMounting']): ?> class="hidden"<?php endif; ?>>
173 173
 			<?php
174
-				$userBackends = array_filter($_['backends'], function($backend) {
175
-					return $backend->isAllowedVisibleFor(BackendService::VISIBILITY_PERSONAL);
176
-				});
177
-			?>
174
+                $userBackends = array_filter($_['backends'], function($backend) {
175
+                    return $backend->isAllowedVisibleFor(BackendService::VISIBILITY_PERSONAL);
176
+                });
177
+            ?>
178 178
 			<?php $i = 0; foreach ($userBackends as $backend): ?>
179 179
 				<?php if ($deprecateTo = $backend->getDeprecateTo()): ?>
180 180
 					<input type="hidden" id="allowUserMountingBackends<?php p($i); ?>" name="allowUserMountingBackends[]" value="<?php p($backend->getIdentifier()); ?>" data-deprecate-to="<?php p($deprecateTo->getIdentifier()); ?>" />
Please login to merge, or discard this patch.
apps/files_external/ajax/applicable.php 2 patches
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -30,23 +30,23 @@
 block discarded – undo
30 30
 $limit = null;
31 31
 $offset = null;
32 32
 if (isset($_GET['pattern'])) {
33
-	$pattern = (string)$_GET['pattern'];
33
+    $pattern = (string)$_GET['pattern'];
34 34
 }
35 35
 if (isset($_GET['limit'])) {
36
-	$limit = (int)$_GET['limit'];
36
+    $limit = (int)$_GET['limit'];
37 37
 }
38 38
 if (isset($_GET['offset'])) {
39
-	$offset = (int)$_GET['offset'];
39
+    $offset = (int)$_GET['offset'];
40 40
 }
41 41
 
42 42
 $groups = [];
43 43
 foreach (\OC::$server->getGroupManager()->search($pattern, $limit, $offset) as $group) {
44
-	$groups[$group->getGID()] = $group->getGID();
44
+    $groups[$group->getGID()] = $group->getGID();
45 45
 }
46 46
 
47 47
 $users = [];
48 48
 foreach (\OC::$server->getUserManager()->searchDisplayName($pattern, $limit, $offset) as $user) {
49
-	$users[$user->getUID()] = $user->getDisplayName();
49
+    $users[$user->getUID()] = $user->getDisplayName();
50 50
 }
51 51
 
52 52
 $results = array('groups' => $groups, 'users' => $users);
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,13 +30,13 @@
 block discarded – undo
30 30
 $limit = null;
31 31
 $offset = null;
32 32
 if (isset($_GET['pattern'])) {
33
-	$pattern = (string)$_GET['pattern'];
33
+	$pattern = (string) $_GET['pattern'];
34 34
 }
35 35
 if (isset($_GET['limit'])) {
36
-	$limit = (int)$_GET['limit'];
36
+	$limit = (int) $_GET['limit'];
37 37
 }
38 38
 if (isset($_GET['offset'])) {
39
-	$offset = (int)$_GET['offset'];
39
+	$offset = (int) $_GET['offset'];
40 40
 }
41 41
 
42 42
 $groups = [];
Please login to merge, or discard this patch.
apps/files_external/lib/Service/ImportLegacyStoragesService.php 1 patch
Indentation   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -24,25 +24,25 @@
 block discarded – undo
24 24
 namespace OCA\Files_External\Service;
25 25
 
26 26
 class ImportLegacyStoragesService extends LegacyStoragesService {
27
-	private $data;
27
+    private $data;
28 28
 
29
-	/**
30
-	 * @param BackendService $backendService
31
-	 */
32
-	public function __construct(BackendService $backendService) {
33
-		$this->backendService = $backendService;
34
-	}
29
+    /**
30
+     * @param BackendService $backendService
31
+     */
32
+    public function __construct(BackendService $backendService) {
33
+        $this->backendService = $backendService;
34
+    }
35 35
 
36
-	public function setData($data) {
37
-		$this->data = $data;
38
-	}
36
+    public function setData($data) {
37
+        $this->data = $data;
38
+    }
39 39
 
40
-	/**
41
-	 * Read legacy config data
42
-	 *
43
-	 * @return array list of mount configs
44
-	 */
45
-	protected function readLegacyConfig() {
46
-		return $this->data;
47
-	}
40
+    /**
41
+     * Read legacy config data
42
+     *
43
+     * @return array list of mount configs
44
+     */
45
+    protected function readLegacyConfig() {
46
+        return $this->data;
47
+    }
48 48
 }
Please login to merge, or discard this patch.
apps/files_external/lib/Service/UserGlobalStoragesService.php 2 patches
Indentation   +163 added lines, -163 removed lines patch added patch discarded remove patch
@@ -34,167 +34,167 @@
 block discarded – undo
34 34
  */
35 35
 class UserGlobalStoragesService extends GlobalStoragesService {
36 36
 
37
-	use UserTrait;
38
-
39
-	/** @var IGroupManager */
40
-	protected $groupManager;
41
-
42
-	/**
43
-	 * @param BackendService $backendService
44
-	 * @param DBConfigService $dbConfig
45
-	 * @param IUserSession $userSession
46
-	 * @param IGroupManager $groupManager
47
-	 * @param IUserMountCache $userMountCache
48
-	 */
49
-	public function __construct(
50
-		BackendService $backendService,
51
-		DBConfigService $dbConfig,
52
-		IUserSession $userSession,
53
-		IGroupManager $groupManager,
54
-		IUserMountCache $userMountCache
55
-	) {
56
-		parent::__construct($backendService, $dbConfig, $userMountCache);
57
-		$this->userSession = $userSession;
58
-		$this->groupManager = $groupManager;
59
-	}
60
-
61
-	/**
62
-	 * Replace config hash ID with real IDs, for migrating legacy storages
63
-	 *
64
-	 * @param StorageConfig[] $storages Storages with real IDs
65
-	 * @param StorageConfig[] $storagesWithConfigHash Storages with config hash IDs
66
-	 */
67
-	protected function setRealStorageIds(array &$storages, array $storagesWithConfigHash) {
68
-		// as a read-only view, storage IDs don't need to be real
69
-		foreach ($storagesWithConfigHash as $storage) {
70
-			$storages[$storage->getId()] = $storage;
71
-		}
72
-	}
73
-
74
-	protected function readDBConfig() {
75
-		$userMounts = $this->dbConfig->getAdminMountsFor(DBConfigService::APPLICABLE_TYPE_USER, $this->getUser()->getUID());
76
-		$globalMounts = $this->dbConfig->getAdminMountsFor(DBConfigService::APPLICABLE_TYPE_GLOBAL, null);
77
-		$groups = $this->groupManager->getUserGroupIds($this->getUser());
78
-		if (is_array($groups) && count($groups) !== 0) {
79
-			$groupMounts = $this->dbConfig->getAdminMountsForMultiple(DBConfigService::APPLICABLE_TYPE_GROUP, $groups);
80
-		} else {
81
-			$groupMounts = [];
82
-		}
83
-		return array_merge($userMounts, $groupMounts, $globalMounts);
84
-	}
85
-
86
-	public function addStorage(StorageConfig $newStorage) {
87
-		throw new \DomainException('UserGlobalStoragesService writing disallowed');
88
-	}
89
-
90
-	public function updateStorage(StorageConfig $updatedStorage) {
91
-		throw new \DomainException('UserGlobalStoragesService writing disallowed');
92
-	}
93
-
94
-	/**
95
-	 * @param integer $id
96
-	 */
97
-	public function removeStorage($id) {
98
-		throw new \DomainException('UserGlobalStoragesService writing disallowed');
99
-	}
100
-
101
-	/**
102
-	 * Get unique storages, in case two are defined with the same mountpoint
103
-	 * Higher priority storages take precedence
104
-	 *
105
-	 * @return StorageConfig[]
106
-	 */
107
-	public function getUniqueStorages() {
108
-		$storages = $this->getStorages();
109
-
110
-		$storagesByMountpoint = [];
111
-		foreach ($storages as $storage) {
112
-			$storagesByMountpoint[$storage->getMountPoint()][] = $storage;
113
-		}
114
-
115
-		$result = [];
116
-		foreach ($storagesByMountpoint as $storageList) {
117
-			$storage = array_reduce($storageList, function ($carry, $item) {
118
-				if (isset($carry)) {
119
-					$carryPriorityType = $this->getPriorityType($carry);
120
-					$itemPriorityType = $this->getPriorityType($item);
121
-					if ($carryPriorityType > $itemPriorityType) {
122
-						return $carry;
123
-					} elseif ($carryPriorityType === $itemPriorityType) {
124
-						if ($carry->getPriority() > $item->getPriority()) {
125
-							return $carry;
126
-						}
127
-					}
128
-				}
129
-				return $item;
130
-			});
131
-			$result[$storage->getID()] = $storage;
132
-		}
133
-
134
-		return $result;
135
-	}
136
-
137
-	/**
138
-	 * Get a priority 'type', where a bigger number means higher priority
139
-	 * user applicable > group applicable > 'all'
140
-	 *
141
-	 * @param StorageConfig $storage
142
-	 * @return int
143
-	 */
144
-	protected function getPriorityType(StorageConfig $storage) {
145
-		$applicableUsers = $storage->getApplicableUsers();
146
-		$applicableGroups = $storage->getApplicableGroups();
147
-
148
-		if ($applicableUsers && $applicableUsers[0] !== 'all') {
149
-			return 2;
150
-		}
151
-		if ($applicableGroups) {
152
-			return 1;
153
-		}
154
-		return 0;
155
-	}
156
-
157
-	protected function isApplicable(StorageConfig $config) {
158
-		$applicableUsers = $config->getApplicableUsers();
159
-		$applicableGroups = $config->getApplicableGroups();
160
-
161
-		if (count($applicableUsers) === 0 && count($applicableGroups) === 0) {
162
-			return true;
163
-		}
164
-		if (in_array($this->getUser()->getUID(), $applicableUsers, true)) {
165
-			return true;
166
-		}
167
-		$groupIds = $this->groupManager->getUserGroupIds($this->getUser());
168
-		foreach ($groupIds as $groupId) {
169
-			if (in_array($groupId, $applicableGroups, true)) {
170
-				return true;
171
-			}
172
-		}
173
-		return false;
174
-	}
175
-
176
-
177
-	/**
178
-	 * Gets all storages for the user, admin, personal, global, etc
179
-	 *
180
-	 * @return StorageConfig[] array of storage configs
181
-	 */
182
-	public function getAllStoragesForUser() {
183
-		if (is_null($this->getUser())) {
184
-			return [];
185
-		}
186
-		$groupIds = $this->groupManager->getUserGroupIds($this->getUser());
187
-		$mounts = $this->dbConfig->getMountsForUser($this->getUser()->getUID(), $groupIds);
188
-		$configs = array_map([$this, 'getStorageConfigFromDBMount'], $mounts);
189
-		$configs = array_filter($configs, function ($config) {
190
-			return $config instanceof StorageConfig;
191
-		});
192
-
193
-		$keys = array_map(function (StorageConfig $config) {
194
-			return $config->getId();
195
-		}, $configs);
196
-
197
-		$storages = array_combine($keys, $configs);
198
-		return array_filter($storages, [$this, 'validateStorage']);
199
-	}
37
+    use UserTrait;
38
+
39
+    /** @var IGroupManager */
40
+    protected $groupManager;
41
+
42
+    /**
43
+     * @param BackendService $backendService
44
+     * @param DBConfigService $dbConfig
45
+     * @param IUserSession $userSession
46
+     * @param IGroupManager $groupManager
47
+     * @param IUserMountCache $userMountCache
48
+     */
49
+    public function __construct(
50
+        BackendService $backendService,
51
+        DBConfigService $dbConfig,
52
+        IUserSession $userSession,
53
+        IGroupManager $groupManager,
54
+        IUserMountCache $userMountCache
55
+    ) {
56
+        parent::__construct($backendService, $dbConfig, $userMountCache);
57
+        $this->userSession = $userSession;
58
+        $this->groupManager = $groupManager;
59
+    }
60
+
61
+    /**
62
+     * Replace config hash ID with real IDs, for migrating legacy storages
63
+     *
64
+     * @param StorageConfig[] $storages Storages with real IDs
65
+     * @param StorageConfig[] $storagesWithConfigHash Storages with config hash IDs
66
+     */
67
+    protected function setRealStorageIds(array &$storages, array $storagesWithConfigHash) {
68
+        // as a read-only view, storage IDs don't need to be real
69
+        foreach ($storagesWithConfigHash as $storage) {
70
+            $storages[$storage->getId()] = $storage;
71
+        }
72
+    }
73
+
74
+    protected function readDBConfig() {
75
+        $userMounts = $this->dbConfig->getAdminMountsFor(DBConfigService::APPLICABLE_TYPE_USER, $this->getUser()->getUID());
76
+        $globalMounts = $this->dbConfig->getAdminMountsFor(DBConfigService::APPLICABLE_TYPE_GLOBAL, null);
77
+        $groups = $this->groupManager->getUserGroupIds($this->getUser());
78
+        if (is_array($groups) && count($groups) !== 0) {
79
+            $groupMounts = $this->dbConfig->getAdminMountsForMultiple(DBConfigService::APPLICABLE_TYPE_GROUP, $groups);
80
+        } else {
81
+            $groupMounts = [];
82
+        }
83
+        return array_merge($userMounts, $groupMounts, $globalMounts);
84
+    }
85
+
86
+    public function addStorage(StorageConfig $newStorage) {
87
+        throw new \DomainException('UserGlobalStoragesService writing disallowed');
88
+    }
89
+
90
+    public function updateStorage(StorageConfig $updatedStorage) {
91
+        throw new \DomainException('UserGlobalStoragesService writing disallowed');
92
+    }
93
+
94
+    /**
95
+     * @param integer $id
96
+     */
97
+    public function removeStorage($id) {
98
+        throw new \DomainException('UserGlobalStoragesService writing disallowed');
99
+    }
100
+
101
+    /**
102
+     * Get unique storages, in case two are defined with the same mountpoint
103
+     * Higher priority storages take precedence
104
+     *
105
+     * @return StorageConfig[]
106
+     */
107
+    public function getUniqueStorages() {
108
+        $storages = $this->getStorages();
109
+
110
+        $storagesByMountpoint = [];
111
+        foreach ($storages as $storage) {
112
+            $storagesByMountpoint[$storage->getMountPoint()][] = $storage;
113
+        }
114
+
115
+        $result = [];
116
+        foreach ($storagesByMountpoint as $storageList) {
117
+            $storage = array_reduce($storageList, function ($carry, $item) {
118
+                if (isset($carry)) {
119
+                    $carryPriorityType = $this->getPriorityType($carry);
120
+                    $itemPriorityType = $this->getPriorityType($item);
121
+                    if ($carryPriorityType > $itemPriorityType) {
122
+                        return $carry;
123
+                    } elseif ($carryPriorityType === $itemPriorityType) {
124
+                        if ($carry->getPriority() > $item->getPriority()) {
125
+                            return $carry;
126
+                        }
127
+                    }
128
+                }
129
+                return $item;
130
+            });
131
+            $result[$storage->getID()] = $storage;
132
+        }
133
+
134
+        return $result;
135
+    }
136
+
137
+    /**
138
+     * Get a priority 'type', where a bigger number means higher priority
139
+     * user applicable > group applicable > 'all'
140
+     *
141
+     * @param StorageConfig $storage
142
+     * @return int
143
+     */
144
+    protected function getPriorityType(StorageConfig $storage) {
145
+        $applicableUsers = $storage->getApplicableUsers();
146
+        $applicableGroups = $storage->getApplicableGroups();
147
+
148
+        if ($applicableUsers && $applicableUsers[0] !== 'all') {
149
+            return 2;
150
+        }
151
+        if ($applicableGroups) {
152
+            return 1;
153
+        }
154
+        return 0;
155
+    }
156
+
157
+    protected function isApplicable(StorageConfig $config) {
158
+        $applicableUsers = $config->getApplicableUsers();
159
+        $applicableGroups = $config->getApplicableGroups();
160
+
161
+        if (count($applicableUsers) === 0 && count($applicableGroups) === 0) {
162
+            return true;
163
+        }
164
+        if (in_array($this->getUser()->getUID(), $applicableUsers, true)) {
165
+            return true;
166
+        }
167
+        $groupIds = $this->groupManager->getUserGroupIds($this->getUser());
168
+        foreach ($groupIds as $groupId) {
169
+            if (in_array($groupId, $applicableGroups, true)) {
170
+                return true;
171
+            }
172
+        }
173
+        return false;
174
+    }
175
+
176
+
177
+    /**
178
+     * Gets all storages for the user, admin, personal, global, etc
179
+     *
180
+     * @return StorageConfig[] array of storage configs
181
+     */
182
+    public function getAllStoragesForUser() {
183
+        if (is_null($this->getUser())) {
184
+            return [];
185
+        }
186
+        $groupIds = $this->groupManager->getUserGroupIds($this->getUser());
187
+        $mounts = $this->dbConfig->getMountsForUser($this->getUser()->getUID(), $groupIds);
188
+        $configs = array_map([$this, 'getStorageConfigFromDBMount'], $mounts);
189
+        $configs = array_filter($configs, function ($config) {
190
+            return $config instanceof StorageConfig;
191
+        });
192
+
193
+        $keys = array_map(function (StorageConfig $config) {
194
+            return $config->getId();
195
+        }, $configs);
196
+
197
+        $storages = array_combine($keys, $configs);
198
+        return array_filter($storages, [$this, 'validateStorage']);
199
+    }
200 200
 }
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 
115 115
 		$result = [];
116 116
 		foreach ($storagesByMountpoint as $storageList) {
117
-			$storage = array_reduce($storageList, function ($carry, $item) {
117
+			$storage = array_reduce($storageList, function($carry, $item) {
118 118
 				if (isset($carry)) {
119 119
 					$carryPriorityType = $this->getPriorityType($carry);
120 120
 					$itemPriorityType = $this->getPriorityType($item);
@@ -186,11 +186,11 @@  discard block
 block discarded – undo
186 186
 		$groupIds = $this->groupManager->getUserGroupIds($this->getUser());
187 187
 		$mounts = $this->dbConfig->getMountsForUser($this->getUser()->getUID(), $groupIds);
188 188
 		$configs = array_map([$this, 'getStorageConfigFromDBMount'], $mounts);
189
-		$configs = array_filter($configs, function ($config) {
189
+		$configs = array_filter($configs, function($config) {
190 190
 			return $config instanceof StorageConfig;
191 191
 		});
192 192
 
193
-		$keys = array_map(function (StorageConfig $config) {
193
+		$keys = array_map(function(StorageConfig $config) {
194 194
 			return $config->getId();
195 195
 		}, $configs);
196 196
 
Please login to merge, or discard this patch.
apps/files_external/lib/Service/GlobalStoragesService.php 2 patches
Indentation   +147 added lines, -147 removed lines patch added patch discarded remove patch
@@ -35,151 +35,151 @@
 block discarded – undo
35 35
  * Service class to manage global external storages
36 36
  */
37 37
 class GlobalStoragesService extends StoragesService {
38
-	/**
39
-	 * Triggers $signal for all applicable users of the given
40
-	 * storage
41
-	 *
42
-	 * @param StorageConfig $storage storage data
43
-	 * @param string $signal signal to trigger
44
-	 */
45
-	protected function triggerHooks(StorageConfig $storage, $signal) {
46
-		// FIXME: Use as expression in empty once PHP 5.4 support is dropped
47
-		$applicableUsers = $storage->getApplicableUsers();
48
-		$applicableGroups = $storage->getApplicableGroups();
49
-		if (empty($applicableUsers) && empty($applicableGroups)) {
50
-			// raise for user "all"
51
-			$this->triggerApplicableHooks(
52
-				$signal,
53
-				$storage->getMountPoint(),
54
-				\OC_Mount_Config::MOUNT_TYPE_USER,
55
-				['all']
56
-			);
57
-			return;
58
-		}
59
-
60
-		$this->triggerApplicableHooks(
61
-			$signal,
62
-			$storage->getMountPoint(),
63
-			\OC_Mount_Config::MOUNT_TYPE_USER,
64
-			$applicableUsers
65
-		);
66
-		$this->triggerApplicableHooks(
67
-			$signal,
68
-			$storage->getMountPoint(),
69
-			\OC_Mount_Config::MOUNT_TYPE_GROUP,
70
-			$applicableGroups
71
-		);
72
-	}
73
-
74
-	/**
75
-	 * Triggers signal_create_mount or signal_delete_mount to
76
-	 * accommodate for additions/deletions in applicableUsers
77
-	 * and applicableGroups fields.
78
-	 *
79
-	 * @param StorageConfig $oldStorage old storage config
80
-	 * @param StorageConfig $newStorage new storage config
81
-	 */
82
-	protected function triggerChangeHooks(StorageConfig $oldStorage, StorageConfig $newStorage) {
83
-		// if mount point changed, it's like a deletion + creation
84
-		if ($oldStorage->getMountPoint() !== $newStorage->getMountPoint()) {
85
-			$this->triggerHooks($oldStorage, Filesystem::signal_delete_mount);
86
-			$this->triggerHooks($newStorage, Filesystem::signal_create_mount);
87
-			return;
88
-		}
89
-
90
-		$userAdditions = array_diff($newStorage->getApplicableUsers(), $oldStorage->getApplicableUsers());
91
-		$userDeletions = array_diff($oldStorage->getApplicableUsers(), $newStorage->getApplicableUsers());
92
-		$groupAdditions = array_diff($newStorage->getApplicableGroups(), $oldStorage->getApplicableGroups());
93
-		$groupDeletions = array_diff($oldStorage->getApplicableGroups(), $newStorage->getApplicableGroups());
94
-
95
-		// FIXME: Use as expression in empty once PHP 5.4 support is dropped
96
-		// if no applicable were set, raise a signal for "all"
97
-		$oldApplicableUsers = $oldStorage->getApplicableUsers();
98
-		$oldApplicableGroups = $oldStorage->getApplicableGroups();
99
-		if (empty($oldApplicableUsers) && empty($oldApplicableGroups)) {
100
-			$this->triggerApplicableHooks(
101
-				Filesystem::signal_delete_mount,
102
-				$oldStorage->getMountPoint(),
103
-				\OC_Mount_Config::MOUNT_TYPE_USER,
104
-				['all']
105
-			);
106
-		}
107
-
108
-		// trigger delete for removed users
109
-		$this->triggerApplicableHooks(
110
-			Filesystem::signal_delete_mount,
111
-			$oldStorage->getMountPoint(),
112
-			\OC_Mount_Config::MOUNT_TYPE_USER,
113
-			$userDeletions
114
-		);
115
-
116
-		// trigger delete for removed groups
117
-		$this->triggerApplicableHooks(
118
-			Filesystem::signal_delete_mount,
119
-			$oldStorage->getMountPoint(),
120
-			\OC_Mount_Config::MOUNT_TYPE_GROUP,
121
-			$groupDeletions
122
-		);
123
-
124
-		// and now add the new users
125
-		$this->triggerApplicableHooks(
126
-			Filesystem::signal_create_mount,
127
-			$newStorage->getMountPoint(),
128
-			\OC_Mount_Config::MOUNT_TYPE_USER,
129
-			$userAdditions
130
-		);
131
-
132
-		// and now add the new groups
133
-		$this->triggerApplicableHooks(
134
-			Filesystem::signal_create_mount,
135
-			$newStorage->getMountPoint(),
136
-			\OC_Mount_Config::MOUNT_TYPE_GROUP,
137
-			$groupAdditions
138
-		);
139
-
140
-		// FIXME: Use as expression in empty once PHP 5.4 support is dropped
141
-		// if no applicable, raise a signal for "all"
142
-		$newApplicableUsers = $newStorage->getApplicableUsers();
143
-		$newApplicableGroups = $newStorage->getApplicableGroups();
144
-		if (empty($newApplicableUsers) && empty($newApplicableGroups)) {
145
-			$this->triggerApplicableHooks(
146
-				Filesystem::signal_create_mount,
147
-				$newStorage->getMountPoint(),
148
-				\OC_Mount_Config::MOUNT_TYPE_USER,
149
-				['all']
150
-			);
151
-		}
152
-	}
153
-
154
-	/**
155
-	 * Get the visibility type for this controller, used in validation
156
-	 *
157
-	 * @return string BackendService::VISIBILITY_* constants
158
-	 */
159
-	public function getVisibilityType() {
160
-		return BackendService::VISIBILITY_ADMIN;
161
-	}
162
-
163
-	protected function isApplicable(StorageConfig $config) {
164
-		return true;
165
-	}
166
-
167
-	/**
168
-	 * Get all configured admin and personal mounts
169
-	 *
170
-	 * @return array map of storage id to storage config
171
-	 */
172
-	public function getStorageForAllUsers() {
173
-		$mounts = $this->dbConfig->getAllMounts();
174
-		$configs = array_map([$this, 'getStorageConfigFromDBMount'], $mounts);
175
-		$configs = array_filter($configs, function ($config) {
176
-			return $config instanceof StorageConfig;
177
-		});
178
-
179
-		$keys = array_map(function (StorageConfig $config) {
180
-			return $config->getId();
181
-		}, $configs);
182
-
183
-		return array_combine($keys, $configs);
184
-	}
38
+    /**
39
+     * Triggers $signal for all applicable users of the given
40
+     * storage
41
+     *
42
+     * @param StorageConfig $storage storage data
43
+     * @param string $signal signal to trigger
44
+     */
45
+    protected function triggerHooks(StorageConfig $storage, $signal) {
46
+        // FIXME: Use as expression in empty once PHP 5.4 support is dropped
47
+        $applicableUsers = $storage->getApplicableUsers();
48
+        $applicableGroups = $storage->getApplicableGroups();
49
+        if (empty($applicableUsers) && empty($applicableGroups)) {
50
+            // raise for user "all"
51
+            $this->triggerApplicableHooks(
52
+                $signal,
53
+                $storage->getMountPoint(),
54
+                \OC_Mount_Config::MOUNT_TYPE_USER,
55
+                ['all']
56
+            );
57
+            return;
58
+        }
59
+
60
+        $this->triggerApplicableHooks(
61
+            $signal,
62
+            $storage->getMountPoint(),
63
+            \OC_Mount_Config::MOUNT_TYPE_USER,
64
+            $applicableUsers
65
+        );
66
+        $this->triggerApplicableHooks(
67
+            $signal,
68
+            $storage->getMountPoint(),
69
+            \OC_Mount_Config::MOUNT_TYPE_GROUP,
70
+            $applicableGroups
71
+        );
72
+    }
73
+
74
+    /**
75
+     * Triggers signal_create_mount or signal_delete_mount to
76
+     * accommodate for additions/deletions in applicableUsers
77
+     * and applicableGroups fields.
78
+     *
79
+     * @param StorageConfig $oldStorage old storage config
80
+     * @param StorageConfig $newStorage new storage config
81
+     */
82
+    protected function triggerChangeHooks(StorageConfig $oldStorage, StorageConfig $newStorage) {
83
+        // if mount point changed, it's like a deletion + creation
84
+        if ($oldStorage->getMountPoint() !== $newStorage->getMountPoint()) {
85
+            $this->triggerHooks($oldStorage, Filesystem::signal_delete_mount);
86
+            $this->triggerHooks($newStorage, Filesystem::signal_create_mount);
87
+            return;
88
+        }
89
+
90
+        $userAdditions = array_diff($newStorage->getApplicableUsers(), $oldStorage->getApplicableUsers());
91
+        $userDeletions = array_diff($oldStorage->getApplicableUsers(), $newStorage->getApplicableUsers());
92
+        $groupAdditions = array_diff($newStorage->getApplicableGroups(), $oldStorage->getApplicableGroups());
93
+        $groupDeletions = array_diff($oldStorage->getApplicableGroups(), $newStorage->getApplicableGroups());
94
+
95
+        // FIXME: Use as expression in empty once PHP 5.4 support is dropped
96
+        // if no applicable were set, raise a signal for "all"
97
+        $oldApplicableUsers = $oldStorage->getApplicableUsers();
98
+        $oldApplicableGroups = $oldStorage->getApplicableGroups();
99
+        if (empty($oldApplicableUsers) && empty($oldApplicableGroups)) {
100
+            $this->triggerApplicableHooks(
101
+                Filesystem::signal_delete_mount,
102
+                $oldStorage->getMountPoint(),
103
+                \OC_Mount_Config::MOUNT_TYPE_USER,
104
+                ['all']
105
+            );
106
+        }
107
+
108
+        // trigger delete for removed users
109
+        $this->triggerApplicableHooks(
110
+            Filesystem::signal_delete_mount,
111
+            $oldStorage->getMountPoint(),
112
+            \OC_Mount_Config::MOUNT_TYPE_USER,
113
+            $userDeletions
114
+        );
115
+
116
+        // trigger delete for removed groups
117
+        $this->triggerApplicableHooks(
118
+            Filesystem::signal_delete_mount,
119
+            $oldStorage->getMountPoint(),
120
+            \OC_Mount_Config::MOUNT_TYPE_GROUP,
121
+            $groupDeletions
122
+        );
123
+
124
+        // and now add the new users
125
+        $this->triggerApplicableHooks(
126
+            Filesystem::signal_create_mount,
127
+            $newStorage->getMountPoint(),
128
+            \OC_Mount_Config::MOUNT_TYPE_USER,
129
+            $userAdditions
130
+        );
131
+
132
+        // and now add the new groups
133
+        $this->triggerApplicableHooks(
134
+            Filesystem::signal_create_mount,
135
+            $newStorage->getMountPoint(),
136
+            \OC_Mount_Config::MOUNT_TYPE_GROUP,
137
+            $groupAdditions
138
+        );
139
+
140
+        // FIXME: Use as expression in empty once PHP 5.4 support is dropped
141
+        // if no applicable, raise a signal for "all"
142
+        $newApplicableUsers = $newStorage->getApplicableUsers();
143
+        $newApplicableGroups = $newStorage->getApplicableGroups();
144
+        if (empty($newApplicableUsers) && empty($newApplicableGroups)) {
145
+            $this->triggerApplicableHooks(
146
+                Filesystem::signal_create_mount,
147
+                $newStorage->getMountPoint(),
148
+                \OC_Mount_Config::MOUNT_TYPE_USER,
149
+                ['all']
150
+            );
151
+        }
152
+    }
153
+
154
+    /**
155
+     * Get the visibility type for this controller, used in validation
156
+     *
157
+     * @return string BackendService::VISIBILITY_* constants
158
+     */
159
+    public function getVisibilityType() {
160
+        return BackendService::VISIBILITY_ADMIN;
161
+    }
162
+
163
+    protected function isApplicable(StorageConfig $config) {
164
+        return true;
165
+    }
166
+
167
+    /**
168
+     * Get all configured admin and personal mounts
169
+     *
170
+     * @return array map of storage id to storage config
171
+     */
172
+    public function getStorageForAllUsers() {
173
+        $mounts = $this->dbConfig->getAllMounts();
174
+        $configs = array_map([$this, 'getStorageConfigFromDBMount'], $mounts);
175
+        $configs = array_filter($configs, function ($config) {
176
+            return $config instanceof StorageConfig;
177
+        });
178
+
179
+        $keys = array_map(function (StorageConfig $config) {
180
+            return $config->getId();
181
+        }, $configs);
182
+
183
+        return array_combine($keys, $configs);
184
+    }
185 185
 }
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -172,11 +172,11 @@
 block discarded – undo
172 172
 	public function getStorageForAllUsers() {
173 173
 		$mounts = $this->dbConfig->getAllMounts();
174 174
 		$configs = array_map([$this, 'getStorageConfigFromDBMount'], $mounts);
175
-		$configs = array_filter($configs, function ($config) {
175
+		$configs = array_filter($configs, function($config) {
176 176
 			return $config instanceof StorageConfig;
177 177
 		});
178 178
 
179
-		$keys = array_map(function (StorageConfig $config) {
179
+		$keys = array_map(function(StorageConfig $config) {
180 180
 			return $config->getId();
181 181
 		}, $configs);
182 182
 
Please login to merge, or discard this patch.
apps/files_external/lib/Service/UserLegacyStoragesService.php 1 patch
Indentation   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -29,28 +29,28 @@
 block discarded – undo
29 29
  * Read user defined mounts from the legacy mount.json
30 30
  */
31 31
 class UserLegacyStoragesService extends LegacyStoragesService {
32
-	/**
33
-	 * @var IUserSession
34
-	 */
35
-	private $userSession;
32
+    /**
33
+     * @var IUserSession
34
+     */
35
+    private $userSession;
36 36
 
37
-	/**
38
-	 * @param BackendService $backendService
39
-	 * @param IUserSession $userSession
40
-	 */
41
-	public function __construct(BackendService $backendService, IUserSession $userSession) {
42
-		$this->backendService = $backendService;
43
-		$this->userSession = $userSession;
44
-	}
37
+    /**
38
+     * @param BackendService $backendService
39
+     * @param IUserSession $userSession
40
+     */
41
+    public function __construct(BackendService $backendService, IUserSession $userSession) {
42
+        $this->backendService = $backendService;
43
+        $this->userSession = $userSession;
44
+    }
45 45
 
46
-	/**
47
-	 * Read legacy config data
48
-	 *
49
-	 * @return array list of storage configs
50
-	 */
51
-	protected function readLegacyConfig() {
52
-		// read user config
53
-		$user = $this->userSession->getUser()->getUID();
54
-		return \OC_Mount_Config::readData($user);
55
-	}
46
+    /**
47
+     * Read legacy config data
48
+     *
49
+     * @return array list of storage configs
50
+     */
51
+    protected function readLegacyConfig() {
52
+        // read user config
53
+        $user = $this->userSession->getUser()->getUID();
54
+        return \OC_Mount_Config::readData($user);
55
+    }
56 56
 }
Please login to merge, or discard this patch.
apps/files_external/lib/Service/UserTrait.php 1 patch
Indentation   +37 added lines, -37 removed lines patch added patch discarded remove patch
@@ -30,46 +30,46 @@
 block discarded – undo
30 30
  */
31 31
 trait UserTrait {
32 32
 
33
-	/** @var IUserSession */
34
-	protected $userSession;
33
+    /** @var IUserSession */
34
+    protected $userSession;
35 35
 
36
-	/**
37
-	 * User override
38
-	 *
39
-	 * @var IUser|null
40
-	 */
41
-	private $user = null;
36
+    /**
37
+     * User override
38
+     *
39
+     * @var IUser|null
40
+     */
41
+    private $user = null;
42 42
 
43
-	/**
44
-	 * @return IUser|null
45
-	 */
46
-	protected function getUser() {
47
-		if ($this->user) {
48
-			return $this->user;
49
-		}
50
-		return $this->userSession->getUser();
51
-	}
43
+    /**
44
+     * @return IUser|null
45
+     */
46
+    protected function getUser() {
47
+        if ($this->user) {
48
+            return $this->user;
49
+        }
50
+        return $this->userSession->getUser();
51
+    }
52 52
 
53
-	/**
54
-	 * Override the user from the session
55
-	 * Unset with ->resetUser() when finished!
56
-	 *
57
-	 * @param IUser
58
-	 * @return self
59
-	 */
60
-	public function setUser(IUser $user) {
61
-		$this->user = $user;
62
-		return $this;
63
-	}
53
+    /**
54
+     * Override the user from the session
55
+     * Unset with ->resetUser() when finished!
56
+     *
57
+     * @param IUser
58
+     * @return self
59
+     */
60
+    public function setUser(IUser $user) {
61
+        $this->user = $user;
62
+        return $this;
63
+    }
64 64
 
65
-	/**
66
-	 * Reset the user override
67
-	 *
68
-	 * @return self
69
-	 */
70
-	public function resetUser() {
71
-		$this->user = null;
72
-		return $this;
73
-	}
65
+    /**
66
+     * Reset the user override
67
+     *
68
+     * @return self
69
+     */
70
+    public function resetUser() {
71
+        $this->user = null;
72
+        return $this;
73
+    }
74 74
 }
75 75
 
Please login to merge, or discard this patch.