Completed
Push — stable13 ( 61f20e...fb2de4 )
by Roeland
11:34 queued 10s
created
lib/private/Share20/Manager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -1100,6 +1100,9 @@
 block discarded – undo
1100 1100
 		return $share;
1101 1101
 	}
1102 1102
 
1103
+	/**
1104
+	 * @param \OCP\Share\IShare $share
1105
+	 */
1103 1106
 	protected function checkExpireDate($share) {
1104 1107
 		if ($share->getExpirationDate() !== null &&
1105 1108
 			$share->getExpirationDate() <= new \DateTime()) {
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/SyncService.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -163,7 +163,6 @@  discard block
 block discarded – undo
163 163
 	/**
164 164
 	 * @param string $url
165 165
 	 * @param string $userName
166
-	 * @param string $addressBookUrl
167 166
 	 * @param string $sharedSecret
168 167
 	 * @return Client
169 168
 	 */
@@ -301,7 +300,7 @@  discard block
 block discarded – undo
301 300
 	}
302 301
 
303 302
 	/**
304
-	 * @return array|null
303
+	 * @return string
305 304
 	 */
306 305
 	public function getLocalSystemAddressBook() {
307 306
 		if (is_null($this->localSystemAddressBook)) {
Please login to merge, or discard this patch.
lib/private/AppFramework/Utility/ControllerMethodReflector.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
 	private $parameters = [];
38 38
 
39 39
 	/**
40
-	 * @param object $object an object or classname
40
+	 * @param \OCP\AppFramework\Controller $object an object or classname
41 41
 	 * @param string $method the method which we want to inspect
42 42
 	 */
43 43
 	public function reflect($object, $method){
Please login to merge, or discard this patch.
apps/sharebymail/lib/ShareByMailProvider.php 1 patch
Doc Comments   +5 added lines, -4 removed lines patch added patch discarded remove patch
@@ -276,10 +276,10 @@  discard block
 block discarded – undo
276 276
 	 * publish activity if a file/folder was shared by mail
277 277
 	 *
278 278
 	 * @param $subject
279
-	 * @param $parameters
280
-	 * @param $affectedUser
279
+	 * @param string[] $parameters
280
+	 * @param string $affectedUser
281 281
 	 * @param $fileId
282
-	 * @param $filePath
282
+	 * @param string $filePath
283 283
 	 */
284 284
 	protected function publishActivity($subject, $parameters, $affectedUser, $fileId, $filePath) {
285 285
 		$event = $this->activityManager->generateEvent();
@@ -557,6 +557,7 @@  discard block
 block discarded – undo
557 557
 	 * @param string $uidOwner
558 558
 	 * @param int $permissions
559 559
 	 * @param string $token
560
+	 * @param string $password
560 561
 	 * @return int
561 562
 	 */
562 563
 	protected function addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $uidOwner, $permissions, $token, $password) {
@@ -950,7 +951,7 @@  discard block
 block discarded – undo
950 951
 	/**
951 952
 	 * get database row of a give share
952 953
 	 *
953
-	 * @param $id
954
+	 * @param integer $id
954 955
 	 * @return array
955 956
 	 * @throws ShareNotFound
956 957
 	 */
Please login to merge, or discard this patch.
lib/private/BackgroundJob/JobList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -320,7 +320,7 @@
 block discarded – undo
320 320
 
321 321
 	/**
322 322
 	 * @param IJob $job
323
-	 * @param $timeTaken
323
+	 * @param integer $timeTaken
324 324
 	 */
325 325
 	public function setExecutionTime(IJob $job, $timeTaken) {
326 326
 		$query = $this->connection->getQueryBuilder();
Please login to merge, or discard this patch.
lib/private/Updater.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -431,7 +431,7 @@
 block discarded – undo
431 431
 	}
432 432
 
433 433
 	/**
434
-	 * @param array $disabledApps
434
+	 * @param string[] $disabledApps
435 435
 	 * @throws \Exception
436 436
 	 */
437 437
 	private function upgradeAppStoreApps(array $disabledApps) {
Please login to merge, or discard this patch.
lib/private/Diagnostics/Query.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,6 +48,9 @@  discard block
 block discarded – undo
48 48
 		$this->stack = $stack;
49 49
 	}
50 50
 
51
+	/**
52
+	 * @param double $time
53
+	 */
51 54
 	public function end($time) {
52 55
 		$this->end = $time;
53 56
 	}
@@ -67,7 +70,7 @@  discard block
 block discarded – undo
67 70
 	}
68 71
 
69 72
 	/**
70
-	 * @return float
73
+	 * @return integer
71 74
 	 */
72 75
 	public function getStart() {
73 76
 		return $this->start;
Please login to merge, or discard this patch.
apps/theming/lib/Util.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 	/**
72 72
 	 * get color for on-page elements:
73 73
 	 * theme color by default, grey if theme color is to bright
74
-	 * @param $color
74
+	 * @param string $color
75 75
 	 * @return string
76 76
 	 */
77 77
 	public function elementColor($color) {
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 
115 115
 	/**
116 116
 	 * @param $app string app name
117
-	 * @return string|ISimpleFile path to app icon / file of logo
117
+	 * @return string path to app icon / file of logo
118 118
 	 */
119 119
 	public function getAppIcon($app) {
120 120
 		$app = str_replace(array('\0', '/', '\\', '..'), '', $app);
@@ -190,8 +190,8 @@  discard block
 block discarded – undo
190 190
 	/**
191 191
 	 * replace default color with a custom one
192 192
 	 *
193
-	 * @param $svg string content of a svg file
194
-	 * @param $color string color to match
193
+	 * @param string $svg string content of a svg file
194
+	 * @param string $color string color to match
195 195
 	 * @return string
196 196
 	 */
197 197
 	public function colorizeSvg($svg, $color) {
Please login to merge, or discard this patch.
lib/private/Settings/Manager.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -265,6 +265,9 @@  discard block
 block discarded – undo
265 265
 		return $this->mapper->has($table, $className);
266 266
 	}
267 267
 
268
+	/**
269
+	 * @param string $type
270
+	 */
268 271
 	private function setupSettingsEntry($settingsClassName, $type) {
269 272
 		if (!class_exists($settingsClassName)) {
270 273
 			$this->log->debug('Could not find ' . $type . ' section class ' . $settingsClassName);
@@ -294,6 +297,9 @@  discard block
 block discarded – undo
294 297
 		}
295 298
 	}
296 299
 
300
+	/**
301
+	 * @param string $type
302
+	 */
297 303
 	private function getSectionTableForType($type) {
298 304
 		if($type === 'admin') {
299 305
 			return Mapper::TABLE_ADMIN_SECTIONS;
Please login to merge, or discard this patch.