nextcloud / server

lib/private/Log.php

Spacing +1 added lines, -1 removed lines

@@ -217,7 +217,7 @@
 		// interpolate $message as defined in PSR-3
 		$replace = [];
 		foreach ($context as $key => $val) {
-			$replace['{' . $key . '}'] = $val;
+			$replace['{'.$key.'}'] = $val;
 		}
 		$message = strtr($message, $replace);
 

Indentation +321 added lines, -321 removed lines

@@ -56,325 +56,325 @@
  */
 class Log implements ILogger, IDataLogger {
 
-	/** @var IWriter */
-	private $logger;
-
-	/** @var SystemConfig */
-	private $config;
-
-	/** @var boolean|null cache the result of the log condition check for the request */
-	private $logConditionSatisfied = null;
-
-	/** @var Normalizer */
-	private $normalizer;
-
-	/** @var IRegistry */
-	private $crashReporters;
-
-	/**
-	 * @param IWriter $logger The logger that should be used
-	 * @param SystemConfig $config the system config object
-	 * @param Normalizer|null $normalizer
-	 * @param IRegistry|null $registry
-	 */
-	public function __construct(IWriter $logger, SystemConfig $config = null, $normalizer = null, IRegistry $registry = null) {
-		// FIXME: Add this for backwards compatibility, should be fixed at some point probably
-		if ($config === null) {
-			$config = \OC::$server->getSystemConfig();
-		}
-
-		$this->config = $config;
-		$this->logger = $logger;
-		if ($normalizer === null) {
-			$this->normalizer = new Normalizer();
-		} else {
-			$this->normalizer = $normalizer;
-		}
-		$this->crashReporters = $registry;
-	}
-
-	/**
-	 * System is unusable.
-	 *
-	 * @param string $message
-	 * @param array $context
-	 * @return void
-	 */
-	public function emergency(string $message, array $context = []) {
-		$this->log(ILogger::FATAL, $message, $context);
-	}
-
-	/**
-	 * Action must be taken immediately.
-	 *
-	 * Example: Entire website down, database unavailable, etc. This should
-	 * trigger the SMS alerts and wake you up.
-	 *
-	 * @param string $message
-	 * @param array $context
-	 * @return void
-	 */
-	public function alert(string $message, array $context = []) {
-		$this->log(ILogger::ERROR, $message, $context);
-	}
-
-	/**
-	 * Critical conditions.
-	 *
-	 * Example: Application component unavailable, unexpected exception.
-	 *
-	 * @param string $message
-	 * @param array $context
-	 * @return void
-	 */
-	public function critical(string $message, array $context = []) {
-		$this->log(ILogger::ERROR, $message, $context);
-	}
-
-	/**
-	 * Runtime errors that do not require immediate action but should typically
-	 * be logged and monitored.
-	 *
-	 * @param string $message
-	 * @param array $context
-	 * @return void
-	 */
-	public function error(string $message, array $context = []) {
-		$this->log(ILogger::ERROR, $message, $context);
-	}
-
-	/**
-	 * Exceptional occurrences that are not errors.
-	 *
-	 * Example: Use of deprecated APIs, poor use of an API, undesirable things
-	 * that are not necessarily wrong.
-	 *
-	 * @param string $message
-	 * @param array $context
-	 * @return void
-	 */
-	public function warning(string $message, array $context = []) {
-		$this->log(ILogger::WARN, $message, $context);
-	}
-
-	/**
-	 * Normal but significant events.
-	 *
-	 * @param string $message
-	 * @param array $context
-	 * @return void
-	 */
-	public function notice(string $message, array $context = []) {
-		$this->log(ILogger::INFO, $message, $context);
-	}
-
-	/**
-	 * Interesting events.
-	 *
-	 * Example: User logs in, SQL logs.
-	 *
-	 * @param string $message
-	 * @param array $context
-	 * @return void
-	 */
-	public function info(string $message, array $context = []) {
-		$this->log(ILogger::INFO, $message, $context);
-	}
-
-	/**
-	 * Detailed debug information.
-	 *
-	 * @param string $message
-	 * @param array $context
-	 * @return void
-	 */
-	public function debug(string $message, array $context = []) {
-		$this->log(ILogger::DEBUG, $message, $context);
-	}
-
-
-	/**
-	 * Logs with an arbitrary level.
-	 *
-	 * @param int $level
-	 * @param string $message
-	 * @param array $context
-	 * @return void
-	 */
-	public function log(int $level, string $message, array $context = []) {
-		$minLevel = $this->getLogLevel($context);
-
-		array_walk($context, [$this->normalizer, 'format']);
-
-		$app = $context['app'] ?? 'no app in context';
-
-		// interpolate $message as defined in PSR-3
-		$replace = [];
-		foreach ($context as $key => $val) {
-			$replace['{' . $key . '}'] = $val;
-		}
-		$message = strtr($message, $replace);
-
-		try {
-			if ($level >= $minLevel) {
-				$this->writeLog($app, $message, $level);
-
-				if ($this->crashReporters !== null) {
-					$messageContext = array_merge(
-						$context,
-						[
-							'level' => $level
-						]
-					);
-					$this->crashReporters->delegateMessage($message, $messageContext);
-				}
-			} else {
-				if ($this->crashReporters !== null) {
-					$this->crashReporters->delegateBreadcrumb($message, 'log', $context);
-				}
-			}
-		} catch (\Throwable $e) {
-			// make sure we dont hard crash if logging fails
-		}
-	}
-
-	private function getLogLevel($context) {
-		$logCondition = $this->config->getValue('log.condition', []);
-
-		/**
-		 * check for a special log condition - this enables an increased log on
-		 * a per request/user base
-		 */
-		if ($this->logConditionSatisfied === null) {
-			// default to false to just process this once per request
-			$this->logConditionSatisfied = false;
-			if (!empty($logCondition)) {
-
-				// check for secret token in the request
-				if (isset($logCondition['shared_secret'])) {
-					$request = \OC::$server->getRequest();
-
-					if ($request->getMethod() === 'PUT' &&
-						strpos($request->getHeader('Content-Type'), 'application/x-www-form-urlencoded') === false &&
-						strpos($request->getHeader('Content-Type'), 'application/json') === false) {
-						$logSecretRequest = '';
-					} else {
-						$logSecretRequest = $request->getParam('log_secret', '');
-					}
-
-					// if token is found in the request change set the log condition to satisfied
-					if ($request && hash_equals($logCondition['shared_secret'], $logSecretRequest)) {
-						$this->logConditionSatisfied = true;
-					}
-				}
-
-				// check for user
-				if (isset($logCondition['users'])) {
-					$user = \OC::$server->getUserSession()->getUser();
-
-					// if the user matches set the log condition to satisfied
-					if ($user !== null && in_array($user->getUID(), $logCondition['users'], true)) {
-						$this->logConditionSatisfied = true;
-					}
-				}
-			}
-		}
-
-		// if log condition is satisfied change the required log level to DEBUG
-		if ($this->logConditionSatisfied) {
-			return ILogger::DEBUG;
-		}
-
-		if (isset($context['app'])) {
-			$app = $context['app'];
-
-			/**
-			 * check log condition based on the context of each log message
-			 * once this is met -> change the required log level to debug
-			 */
-			if (!empty($logCondition)
-				&& isset($logCondition['apps'])
-				&& in_array($app, $logCondition['apps'], true)) {
-				return ILogger::DEBUG;
-			}
-		}
-
-		return min($this->config->getValue('loglevel', ILogger::WARN), ILogger::FATAL);
-	}
-
-	/**
-	 * Logs an exception very detailed
-	 *
-	 * @param \Exception|\Throwable $exception
-	 * @param array $context
-	 * @return void
-	 * @since 8.2.0
-	 */
-	public function logException(\Throwable $exception, array $context = []) {
-		$app = $context['app'] ?? 'no app in context';
-		$level = $context['level'] ?? ILogger::ERROR;
-
-		$serializer = new ExceptionSerializer($this->config);
-		$data = $serializer->serializeException($exception);
-		$data['CustomMessage'] = $context['message'] ?? '--';
-
-		$minLevel = $this->getLogLevel($context);
-
-		array_walk($context, [$this->normalizer, 'format']);
-
-		try {
-			if ($level >= $minLevel) {
-				if (!$this->logger instanceof IFileBased) {
-					$data = json_encode($data, JSON_PARTIAL_OUTPUT_ON_ERROR | JSON_UNESCAPED_SLASHES);
-				}
-				$this->writeLog($app, $data, $level);
-			}
-
-			$context['level'] = $level;
-			if (!is_null($this->crashReporters)) {
-				$this->crashReporters->delegateReport($exception, $context);
-			}
-		} catch (\Throwable $e) {
-			// make sure we dont hard crash if logging fails
-		}
-	}
-
-	public function logData(string $message, array $data, array $context = []): void {
-		$app = $context['app'] ?? 'no app in context';
-		$level = $context['level'] ?? ILogger::ERROR;
-
-		$minLevel = $this->getLogLevel($context);
-
-		array_walk($context, [$this->normalizer, 'format']);
-
-		try {
-			if ($level >= $minLevel) {
-				$data['message'] = $message;
-				if (!$this->logger instanceof IFileBased) {
-					$data = json_encode($data, JSON_PARTIAL_OUTPUT_ON_ERROR | JSON_UNESCAPED_SLASHES);
-				}
-				$this->writeLog($app, $data, $level);
-			}
-
-			$context['level'] = $level;
-		} catch (\Throwable $e) {
-			// make sure we dont hard crash if logging fails
-		}
-	}
-
-	/**
-	 * @param string $app
-	 * @param string|array $entry
-	 * @param int $level
-	 */
-	protected function writeLog(string $app, $entry, int $level) {
-		$this->logger->write($app, $entry, $level);
-	}
-
-	public function getLogPath():string {
-		if ($this->logger instanceof IFileBased) {
-			return $this->logger->getLogFilePath();
-		}
-		throw new \RuntimeException('Log implementation has no path');
-	}
+    /** @var IWriter */
+    private $logger;
+
+    /** @var SystemConfig */
+    private $config;
+
+    /** @var boolean|null cache the result of the log condition check for the request */
+    private $logConditionSatisfied = null;
+
+    /** @var Normalizer */
+    private $normalizer;
+
+    /** @var IRegistry */
+    private $crashReporters;
+
+    /**
+     * @param IWriter $logger The logger that should be used
+     * @param SystemConfig $config the system config object
+     * @param Normalizer|null $normalizer
+     * @param IRegistry|null $registry
+     */
+    public function __construct(IWriter $logger, SystemConfig $config = null, $normalizer = null, IRegistry $registry = null) {
+        // FIXME: Add this for backwards compatibility, should be fixed at some point probably
+        if ($config === null) {
+            $config = \OC::$server->getSystemConfig();
+        }
+
+        $this->config = $config;
+        $this->logger = $logger;
+        if ($normalizer === null) {
+            $this->normalizer = new Normalizer();
+        } else {
+            $this->normalizer = $normalizer;
+        }
+        $this->crashReporters = $registry;
+    }
+
+    /**
+     * System is unusable.
+     *
+     * @param string $message
+     * @param array $context
+     * @return void
+     */
+    public function emergency(string $message, array $context = []) {
+        $this->log(ILogger::FATAL, $message, $context);
+    }
+
+    /**
+     * Action must be taken immediately.
+     *
+     * Example: Entire website down, database unavailable, etc. This should
+     * trigger the SMS alerts and wake you up.
+     *
+     * @param string $message
+     * @param array $context
+     * @return void
+     */
+    public function alert(string $message, array $context = []) {
+        $this->log(ILogger::ERROR, $message, $context);
+    }
+
+    /**
+     * Critical conditions.
+     *
+     * Example: Application component unavailable, unexpected exception.
+     *
+     * @param string $message
+     * @param array $context
+     * @return void
+     */
+    public function critical(string $message, array $context = []) {
+        $this->log(ILogger::ERROR, $message, $context);
+    }
+
+    /**
+     * Runtime errors that do not require immediate action but should typically
+     * be logged and monitored.
+     *
+     * @param string $message
+     * @param array $context
+     * @return void
+     */
+    public function error(string $message, array $context = []) {
+        $this->log(ILogger::ERROR, $message, $context);
+    }
+
+    /**
+     * Exceptional occurrences that are not errors.
+     *
+     * Example: Use of deprecated APIs, poor use of an API, undesirable things
+     * that are not necessarily wrong.
+     *
+     * @param string $message
+     * @param array $context
+     * @return void
+     */
+    public function warning(string $message, array $context = []) {
+        $this->log(ILogger::WARN, $message, $context);
+    }
+
+    /**
+     * Normal but significant events.
+     *
+     * @param string $message
+     * @param array $context
+     * @return void
+     */
+    public function notice(string $message, array $context = []) {
+        $this->log(ILogger::INFO, $message, $context);
+    }
+
+    /**
+     * Interesting events.
+     *
+     * Example: User logs in, SQL logs.
+     *
+     * @param string $message
+     * @param array $context
+     * @return void
+     */
+    public function info(string $message, array $context = []) {
+        $this->log(ILogger::INFO, $message, $context);
+    }
+
+    /**
+     * Detailed debug information.
+     *
+     * @param string $message
+     * @param array $context
+     * @return void
+     */
+    public function debug(string $message, array $context = []) {
+        $this->log(ILogger::DEBUG, $message, $context);
+    }
+
+
+    /**
+     * Logs with an arbitrary level.
+     *
+     * @param int $level
+     * @param string $message
+     * @param array $context
+     * @return void
+     */
+    public function log(int $level, string $message, array $context = []) {
+        $minLevel = $this->getLogLevel($context);
+
+        array_walk($context, [$this->normalizer, 'format']);
+
+        $app = $context['app'] ?? 'no app in context';
+
+        // interpolate $message as defined in PSR-3
+        $replace = [];
+        foreach ($context as $key => $val) {
+            $replace['{' . $key . '}'] = $val;
+        }
+        $message = strtr($message, $replace);
+
+        try {
+            if ($level >= $minLevel) {
+                $this->writeLog($app, $message, $level);
+
+                if ($this->crashReporters !== null) {
+                    $messageContext = array_merge(
+                        $context,
+                        [
+                            'level' => $level
+                        ]
+                    );
+                    $this->crashReporters->delegateMessage($message, $messageContext);
+                }
+            } else {
+                if ($this->crashReporters !== null) {
+                    $this->crashReporters->delegateBreadcrumb($message, 'log', $context);
+                }
+            }
+        } catch (\Throwable $e) {
+            // make sure we dont hard crash if logging fails
+        }
+    }
+
+    private function getLogLevel($context) {
+        $logCondition = $this->config->getValue('log.condition', []);
+
+        /**
+         * check for a special log condition - this enables an increased log on
+         * a per request/user base
+         */
+        if ($this->logConditionSatisfied === null) {
+            // default to false to just process this once per request
+            $this->logConditionSatisfied = false;
+            if (!empty($logCondition)) {
+
+                // check for secret token in the request
+                if (isset($logCondition['shared_secret'])) {
+                    $request = \OC::$server->getRequest();
+
+                    if ($request->getMethod() === 'PUT' &&
+                        strpos($request->getHeader('Content-Type'), 'application/x-www-form-urlencoded') === false &&
+                        strpos($request->getHeader('Content-Type'), 'application/json') === false) {
+                        $logSecretRequest = '';
+                    } else {
+                        $logSecretRequest = $request->getParam('log_secret', '');
+                    }
+
+                    // if token is found in the request change set the log condition to satisfied
+                    if ($request && hash_equals($logCondition['shared_secret'], $logSecretRequest)) {
+                        $this->logConditionSatisfied = true;
+                    }
+                }
+
+                // check for user
+                if (isset($logCondition['users'])) {
+                    $user = \OC::$server->getUserSession()->getUser();
+
+                    // if the user matches set the log condition to satisfied
+                    if ($user !== null && in_array($user->getUID(), $logCondition['users'], true)) {
+                        $this->logConditionSatisfied = true;
+                    }
+                }
+            }
+        }
+
+        // if log condition is satisfied change the required log level to DEBUG
+        if ($this->logConditionSatisfied) {
+            return ILogger::DEBUG;
+        }
+
+        if (isset($context['app'])) {
+            $app = $context['app'];
+
+            /**
+             * check log condition based on the context of each log message
+             * once this is met -> change the required log level to debug
+             */
+            if (!empty($logCondition)
+                && isset($logCondition['apps'])
+                && in_array($app, $logCondition['apps'], true)) {
+                return ILogger::DEBUG;
+            }
+        }
+
+        return min($this->config->getValue('loglevel', ILogger::WARN), ILogger::FATAL);
+    }
+
+    /**
+     * Logs an exception very detailed
+     *
+     * @param \Exception|\Throwable $exception
+     * @param array $context
+     * @return void
+     * @since 8.2.0
+     */
+    public function logException(\Throwable $exception, array $context = []) {
+        $app = $context['app'] ?? 'no app in context';
+        $level = $context['level'] ?? ILogger::ERROR;
+
+        $serializer = new ExceptionSerializer($this->config);
+        $data = $serializer->serializeException($exception);
+        $data['CustomMessage'] = $context['message'] ?? '--';
+
+        $minLevel = $this->getLogLevel($context);
+
+        array_walk($context, [$this->normalizer, 'format']);
+
+        try {
+            if ($level >= $minLevel) {
+                if (!$this->logger instanceof IFileBased) {
+                    $data = json_encode($data, JSON_PARTIAL_OUTPUT_ON_ERROR | JSON_UNESCAPED_SLASHES);
+                }
+                $this->writeLog($app, $data, $level);
+            }
+
+            $context['level'] = $level;
+            if (!is_null($this->crashReporters)) {
+                $this->crashReporters->delegateReport($exception, $context);
+            }
+        } catch (\Throwable $e) {
+            // make sure we dont hard crash if logging fails
+        }
+    }
+
+    public function logData(string $message, array $data, array $context = []): void {
+        $app = $context['app'] ?? 'no app in context';
+        $level = $context['level'] ?? ILogger::ERROR;
+
+        $minLevel = $this->getLogLevel($context);
+
+        array_walk($context, [$this->normalizer, 'format']);
+
+        try {
+            if ($level >= $minLevel) {
+                $data['message'] = $message;
+                if (!$this->logger instanceof IFileBased) {
+                    $data = json_encode($data, JSON_PARTIAL_OUTPUT_ON_ERROR | JSON_UNESCAPED_SLASHES);
+                }
+                $this->writeLog($app, $data, $level);
+            }
+
+            $context['level'] = $level;
+        } catch (\Throwable $e) {
+            // make sure we dont hard crash if logging fails
+        }
+    }
+
+    /**
+     * @param string $app
+     * @param string|array $entry
+     * @param int $level
+     */
+    protected function writeLog(string $app, $entry, int $level) {
+        $this->logger->write($app, $entry, $level);
+    }
+
+    public function getLogPath():string {
+        if ($this->logger instanceof IFileBased) {
+            return $this->logger->getLogFilePath();
+        }
+        throw new \RuntimeException('Log implementation has no path');
+    }
 }

lib/public/SystemTag/SystemTagsEntityEvent.php

Spacing +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
 	 */
 	public function addEntityCollection(string $name, \Closure $entityExistsFunction) {
 		if (isset($this->collections[$name])) {
-			throw new \OutOfBoundsException('Duplicate entity name "' . $name . '"');
+			throw new \OutOfBoundsException('Duplicate entity name "'.$name.'"');
 		}
 
 		$this->collections[$name] = $entityExistsFunction;

Indentation +40 added lines, -40 removed lines

@@ -37,49 +37,49 @@
  */
 class SystemTagsEntityEvent extends Event {
 
-	/**
-	 * @deprecated 22.0.0
-	 */
-	public const EVENT_ENTITY = 'OCP\SystemTag\ISystemTagManager::registerEntity';
+    /**
+     * @deprecated 22.0.0
+     */
+    public const EVENT_ENTITY = 'OCP\SystemTag\ISystemTagManager::registerEntity';
 
-	/** @var string */
-	protected $event;
-	/** @var \Closure[] */
-	protected $collections;
+    /** @var string */
+    protected $event;
+    /** @var \Closure[] */
+    protected $collections;
 
-	/**
-	 * SystemTagsEntityEvent constructor.
-	 *
-	 * @param string $event
-	 * @since 9.1.0
-	 */
-	public function __construct(string $event) {
-		$this->event = $event;
-		$this->collections = [];
-	}
+    /**
+     * SystemTagsEntityEvent constructor.
+     *
+     * @param string $event
+     * @since 9.1.0
+     */
+    public function __construct(string $event) {
+        $this->event = $event;
+        $this->collections = [];
+    }
 
-	/**
-	 * @param string $name
-	 * @param \Closure $entityExistsFunction The closure should take one
-	 *                 argument, which is the id of the entity, that tags
-	 *                 should be handled for. The return should then be bool,
-	 *                 depending on whether tags are allowed (true) or not.
-	 * @throws \OutOfBoundsException when the entity name is already taken
-	 * @since 9.1.0
-	 */
-	public function addEntityCollection(string $name, \Closure $entityExistsFunction) {
-		if (isset($this->collections[$name])) {
-			throw new \OutOfBoundsException('Duplicate entity name "' . $name . '"');
-		}
+    /**
+     * @param string $name
+     * @param \Closure $entityExistsFunction The closure should take one
+     *                 argument, which is the id of the entity, that tags
+     *                 should be handled for. The return should then be bool,
+     *                 depending on whether tags are allowed (true) or not.
+     * @throws \OutOfBoundsException when the entity name is already taken
+     * @since 9.1.0
+     */
+    public function addEntityCollection(string $name, \Closure $entityExistsFunction) {
+        if (isset($this->collections[$name])) {
+            throw new \OutOfBoundsException('Duplicate entity name "' . $name . '"');
+        }
 
-		$this->collections[$name] = $entityExistsFunction;
-	}
+        $this->collections[$name] = $entityExistsFunction;
+    }
 
-	/**
-	 * @return \Closure[]
-	 * @since 9.1.0
-	 */
-	public function getEntityCollections(): array {
-		return $this->collections;
-	}
+    /**
+     * @return \Closure[]
+     * @since 9.1.0
+     */
+    public function getEntityCollections(): array {
+        return $this->collections;
+    }
 }

lib/private/Log/Errorlog.php

Indentation +9 added lines, -9 removed lines

@@ -29,14 +29,14 @@
 
 class Errorlog implements IWriter {
 
-	/**
-	 * write a message in the log
-	 * @param string $app
-	 * @param string $message
-	 * @param int $level
-	 */
-	public function write(string $app, $message, int $level) {
-		error_log('[owncloud]['.$app.']['.$level.'] '.$message);
-	}
+    /**
+     * write a message in the log
+     * @param string $app
+     * @param string $message
+     * @param int $level
+     */
+    public function write(string $app, $message, int $level) {
+        error_log('[owncloud]['.$app.']['.$level.'] '.$message);
+    }
 }
 

lib/public/Log/IWriter.php

Indentation +4 added lines, -4 removed lines

@@ -30,8 +30,8 @@
  * @since 14.0.0
  */
 interface IWriter {
-	/**
-	 * @since 14.0.0
-	 */
-	public function write(string $app, $message, int $level);
+    /**
+     * @since 14.0.0
+     */
+    public function write(string $app, $message, int $level);
 }

lib/private/DateTimeZone.php

Spacing +4 added lines, -4 removed lines

@@ -65,7 +65,7 @@ 
 		try {
 			return new \DateTimeZone($timeZone);
 		} catch (\Exception $e) {
-			\OCP\Util::writeLog('datetimezone', 'Failed to created DateTimeZone "' . $timeZone . "'", ILogger::DEBUG);
+			\OCP\Util::writeLog('datetimezone', 'Failed to created DateTimeZone "'.$timeZone."'", ILogger::DEBUG);
 			return new \DateTimeZone($this->getDefaultTimeZone());
 		}
 	}
@@ -86,9 +86,9 @@ 
 			// so a positive offset means negative timeZone
 			// and the other way around.
 			if ($offset > 0) {
-				$timeZone = 'Etc/GMT-' . $offset;
+				$timeZone = 'Etc/GMT-'.$offset;
 			} else {
-				$timeZone = 'Etc/GMT+' . abs($offset);
+				$timeZone = 'Etc/GMT+'.abs($offset);
 			}
 
 			return new \DateTimeZone($timeZone);
@@ -110,7 +110,7 @@ 
 			}
 
 			// No timezone found, fallback to UTC
-			\OCP\Util::writeLog('datetimezone', 'Failed to find DateTimeZone for offset "' . $offset . "'", ILogger::DEBUG);
+			\OCP\Util::writeLog('datetimezone', 'Failed to find DateTimeZone for offset "'.$offset."'", ILogger::DEBUG);
 			return new \DateTimeZone($this->getDefaultTimeZone());
 		}
 	}

Indentation +86 added lines, -86 removed lines

@@ -30,100 +30,100 @@
 use OCP\ISession;
 
 class DateTimeZone implements IDateTimeZone {
-	/** @var IConfig */
-	protected $config;
+    /** @var IConfig */
+    protected $config;
 
-	/** @var ISession */
-	protected $session;
+    /** @var ISession */
+    protected $session;
 
-	/**
-	 * Constructor
-	 *
-	 * @param IConfig $config
-	 * @param ISession $session
-	 */
-	public function __construct(IConfig $config, ISession $session) {
-		$this->config = $config;
-		$this->session = $session;
-	}
+    /**
+     * Constructor
+     *
+     * @param IConfig $config
+     * @param ISession $session
+     */
+    public function __construct(IConfig $config, ISession $session) {
+        $this->config = $config;
+        $this->session = $session;
+    }
 
-	/**
-	 * Get the timezone of the current user, based on his session information and config data
-	 *
-	 * @param bool|int $timestamp
-	 * @return \DateTimeZone
-	 */
-	public function getTimeZone($timestamp = false) {
-		$timeZone = $this->config->getUserValue($this->session->get('user_id'), 'core', 'timezone', null);
-		if ($timeZone === null) {
-			if ($this->session->exists('timezone')) {
-				return $this->guessTimeZoneFromOffset($this->session->get('timezone'), $timestamp);
-			}
-			$timeZone = $this->getDefaultTimeZone();
-		}
+    /**
+     * Get the timezone of the current user, based on his session information and config data
+     *
+     * @param bool|int $timestamp
+     * @return \DateTimeZone
+     */
+    public function getTimeZone($timestamp = false) {
+        $timeZone = $this->config->getUserValue($this->session->get('user_id'), 'core', 'timezone', null);
+        if ($timeZone === null) {
+            if ($this->session->exists('timezone')) {
+                return $this->guessTimeZoneFromOffset($this->session->get('timezone'), $timestamp);
+            }
+            $timeZone = $this->getDefaultTimeZone();
+        }
 
-		try {
-			return new \DateTimeZone($timeZone);
-		} catch (\Exception $e) {
-			\OCP\Util::writeLog('datetimezone', 'Failed to created DateTimeZone "' . $timeZone . "'", ILogger::DEBUG);
-			return new \DateTimeZone($this->getDefaultTimeZone());
-		}
-	}
+        try {
+            return new \DateTimeZone($timeZone);
+        } catch (\Exception $e) {
+            \OCP\Util::writeLog('datetimezone', 'Failed to created DateTimeZone "' . $timeZone . "'", ILogger::DEBUG);
+            return new \DateTimeZone($this->getDefaultTimeZone());
+        }
+    }
 
-	/**
-	 * Guess the DateTimeZone for a given offset
-	 *
-	 * We first try to find a Etc/GMT* timezone, if that does not exist,
-	 * we try to find it manually, before falling back to UTC.
-	 *
-	 * @param mixed $offset
-	 * @param bool|int $timestamp
-	 * @return \DateTimeZone
-	 */
-	protected function guessTimeZoneFromOffset($offset, $timestamp) {
-		try {
-			// Note: the timeZone name is the inverse to the offset,
-			// so a positive offset means negative timeZone
-			// and the other way around.
-			if ($offset > 0) {
-				$timeZone = 'Etc/GMT-' . $offset;
-			} else {
-				$timeZone = 'Etc/GMT+' . abs($offset);
-			}
+    /**
+     * Guess the DateTimeZone for a given offset
+     *
+     * We first try to find a Etc/GMT* timezone, if that does not exist,
+     * we try to find it manually, before falling back to UTC.
+     *
+     * @param mixed $offset
+     * @param bool|int $timestamp
+     * @return \DateTimeZone
+     */
+    protected function guessTimeZoneFromOffset($offset, $timestamp) {
+        try {
+            // Note: the timeZone name is the inverse to the offset,
+            // so a positive offset means negative timeZone
+            // and the other way around.
+            if ($offset > 0) {
+                $timeZone = 'Etc/GMT-' . $offset;
+            } else {
+                $timeZone = 'Etc/GMT+' . abs($offset);
+            }
 
-			return new \DateTimeZone($timeZone);
-		} catch (\Exception $e) {
-			// If the offset has no Etc/GMT* timezone,
-			// we try to guess one timezone that has the same offset
-			foreach (\DateTimeZone::listIdentifiers() as $timeZone) {
-				$dtz = new \DateTimeZone($timeZone);
-				$dateTime = new \DateTime();
+            return new \DateTimeZone($timeZone);
+        } catch (\Exception $e) {
+            // If the offset has no Etc/GMT* timezone,
+            // we try to guess one timezone that has the same offset
+            foreach (\DateTimeZone::listIdentifiers() as $timeZone) {
+                $dtz = new \DateTimeZone($timeZone);
+                $dateTime = new \DateTime();
 
-				if ($timestamp !== false) {
-					$dateTime->setTimestamp($timestamp);
-				}
+                if ($timestamp !== false) {
+                    $dateTime->setTimestamp($timestamp);
+                }
 
-				$dtOffset = $dtz->getOffset($dateTime);
-				if ($dtOffset == 3600 * $offset) {
-					return $dtz;
-				}
-			}
+                $dtOffset = $dtz->getOffset($dateTime);
+                if ($dtOffset == 3600 * $offset) {
+                    return $dtz;
+                }
+            }
 
-			// No timezone found, fallback to UTC
-			\OCP\Util::writeLog('datetimezone', 'Failed to find DateTimeZone for offset "' . $offset . "'", ILogger::DEBUG);
-			return new \DateTimeZone($this->getDefaultTimeZone());
-		}
-	}
+            // No timezone found, fallback to UTC
+            \OCP\Util::writeLog('datetimezone', 'Failed to find DateTimeZone for offset "' . $offset . "'", ILogger::DEBUG);
+            return new \DateTimeZone($this->getDefaultTimeZone());
+        }
+    }
 
-	/**
-	 * Get the default timezone of the server
-	 *
-	 * Falls back to UTC if it is not yet set.
-	 *
-	 * @return string
-	 */
-	protected function getDefaultTimeZone() {
-		$serverTimeZone = date_default_timezone_get();
-		return $serverTimeZone ?: 'UTC';
-	}
+    /**
+     * Get the default timezone of the server
+     *
+     * Falls back to UTC if it is not yet set.
+     *
+     * @return string
+     */
+    protected function getDefaultTimeZone() {
+        $serverTimeZone = date_default_timezone_get();
+        return $serverTimeZone ?: 'UTC';
+    }
 }

lib/public/Log/RotationTrait.php

Indentation +32 added lines, -32 removed lines

@@ -32,40 +32,40 @@
  */
 trait RotationTrait {
 
-	/**
-	 * @var string
-	 * @since 14.0.0
-	 */
-	protected $filePath;
+    /**
+     * @var string
+     * @since 14.0.0
+     */
+    protected $filePath;
 
-	/**
-	 * @var int
-	 * @since 14.0.0
-	 */
-	protected $maxSize;
+    /**
+     * @var int
+     * @since 14.0.0
+     */
+    protected $maxSize;
 
-	/**
-	 * @return string the resulting new filepath
-	 * @since 14.0.0
-	 */
-	protected function rotate():string {
-		$rotatedFile = $this->filePath.'.1';
-		rename($this->filePath, $rotatedFile);
-		return $rotatedFile;
-	}
+    /**
+     * @return string the resulting new filepath
+     * @since 14.0.0
+     */
+    protected function rotate():string {
+        $rotatedFile = $this->filePath.'.1';
+        rename($this->filePath, $rotatedFile);
+        return $rotatedFile;
+    }
 
-	/**
-	 * @return bool
-	 * @since 14.0.0
-	 */
-	protected function shouldRotateBySize():bool {
-		if ((int)$this->maxSize > 0) {
-			$filesize = @filesize($this->filePath);
-			if ($filesize >= (int)$this->maxSize) {
-				return true;
-			}
-		}
-		return false;
-	}
+    /**
+     * @return bool
+     * @since 14.0.0
+     */
+    protected function shouldRotateBySize():bool {
+        if ((int)$this->maxSize > 0) {
+            $filesize = @filesize($this->filePath);
+            if ($filesize >= (int)$this->maxSize) {
+                return true;
+            }
+        }
+        return false;
+    }
 
 }

Spacing +2 added lines, -2 removed lines

@@ -59,9 +59,9 @@
 	 * @since 14.0.0
 	 */
 	protected function shouldRotateBySize():bool {
-		if ((int)$this->maxSize > 0) {
+		if ((int) $this->maxSize > 0) {
 			$filesize = @filesize($this->filePath);
-			if ($filesize >= (int)$this->maxSize) {
+			if ($filesize >= (int) $this->maxSize) {
 				return true;
 			}
 		}

ocm-provider/index.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
  */
 
 
-require_once __DIR__ . '/../lib/base.php';
+require_once __DIR__.'/../lib/base.php';
 
 header('Content-Type: application/json');
 

Indentation +7 added lines, -7 removed lines

@@ -29,12 +29,12 @@
 $isEnabled = $server->getAppManager()->isEnabledForUser('cloud_federation_api');
 
 if ($isEnabled) {
-	// Make sure the routes are loaded
-	\OC_App::loadApp('cloud_federation_api');
-	$capabilities = new OCA\CloudFederationAPI\Capabilities($server->getURLGenerator());
-	header('Content-Type: application/json');
-	echo json_encode($capabilities->getCapabilities()['ocm']);
+    // Make sure the routes are loaded
+    \OC_App::loadApp('cloud_federation_api');
+    $capabilities = new OCA\CloudFederationAPI\Capabilities($server->getURLGenerator());
+    header('Content-Type: application/json');
+    echo json_encode($capabilities->getCapabilities()['ocm']);
 } else {
-	header($_SERVER["SERVER_PROTOCOL"]." 501 Not Implemented", true, 501);
-	exit("501 Not Implemented");
+    header($_SERVER["SERVER_PROTOCOL"]." 501 Not Implemented", true, 501);
+    exit("501 Not Implemented");
 }

lib/public/Federation/Exceptions/ProviderDoesNotExistsException.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
 	 */
 	public function __construct($providerId) {
 		$l = \OC::$server->getL10N('federation');
-		$message = 'Cloud Federation Provider with ID: "' . $providerId . '" does not exist.';
+		$message = 'Cloud Federation Provider with ID: "'.$providerId.'" does not exist.';
 		$hint = $l->t('Cloud Federation Provider with ID: "%s" does not exist.', [$providerId]);
 		parent::__construct($message, $hint);
 	}

Indentation +13 added lines, -13 removed lines

@@ -32,18 +32,18 @@
  */
 class ProviderDoesNotExistsException extends HintException {
 
-	/**
-	 * ProviderDoesNotExistsException constructor.
-	 *
-	 * @since 14.0.0
-	 *
-	 * @param string $providerId cloud federation provider ID
-	 */
-	public function __construct($providerId) {
-		$l = \OC::$server->getL10N('federation');
-		$message = 'Cloud Federation Provider with ID: "' . $providerId . '" does not exist.';
-		$hint = $l->t('Cloud Federation Provider with ID: "%s" does not exist.', [$providerId]);
-		parent::__construct($message, $hint);
-	}
+    /**
+     * ProviderDoesNotExistsException constructor.
+     *
+     * @since 14.0.0
+     *
+     * @param string $providerId cloud federation provider ID
+     */
+    public function __construct($providerId) {
+        $l = \OC::$server->getL10N('federation');
+        $message = 'Cloud Federation Provider with ID: "' . $providerId . '" does not exist.';
+        $hint = $l->t('Cloud Federation Provider with ID: "%s" does not exist.', [$providerId]);
+        parent::__construct($message, $hint);
+    }
 
 }

core/Command/Db/Migrations/GenerateCommand.php

Spacing +5 added lines, -5 removed lines

@@ -113,7 +113,7 @@ 
 		$appName = $input->getArgument('app');
 		$version = $input->getArgument('version');
 
-		if (!preg_match('/^\d{1,16}$/',$version)) {
+		if (!preg_match('/^\d{1,16}$/', $version)) {
 			$output->writeln('<error>The given version is invalid. Only 0-9 are allowed (max. 16 digits)</error>');
 			return 1;
 		}
@@ -121,7 +121,7 @@ 
 		$ms = new MigrationService($appName, $this->connection, new ConsoleOutput($output));
 
 		$date = date('YmdHis');
-		$path = $this->generateMigration($ms, 'Version' . $version . 'Date' . $date);
+		$path = $this->generateMigration($ms, 'Version'.$version.'Date'.$date);
 
 		$output->writeln("New migration class has been generated to <info>$path</info>");
 		return 0;
@@ -151,7 +151,7 @@ 
 			$appName = $context->getWordAtIndex($context->getWordIndex() - 1);
 
 			$version = explode('.', $this->appManager->getAppVersion($appName));
-			return [$version[0] . sprintf('%1$03d', $version[1])];
+			return [$version[0].sprintf('%1$03d', $version[1])];
 		}
 
 		return [];
@@ -165,7 +165,7 @@ 
 	 */
 	protected function generateMigration(MigrationService $ms, $className, $schemaBody = '') {
 		if ($schemaBody === '') {
-			$schemaBody = "\t\t" . 'return null;';
+			$schemaBody = "\t\t".'return null;';
 		}
 
 
@@ -183,7 +183,7 @@ 
 		$dir = $ms->getMigrationsDirectory();
 
 		$this->ensureMigrationDirExists($dir);
-		$path = $dir . '/' . $className . '.php';
+		$path = $dir.'/'.$className.'.php';
 
 		if (file_put_contents($path, $code) === false) {
 			throw new RuntimeException('Failed to generate new migration step.');

Indentation +127 added lines, -127 removed lines

@@ -38,8 +38,8 @@ 
 use Symfony\Component\Console\Output\OutputInterface;
 
 class GenerateCommand extends Command implements CompletionAwareInterface {
-	protected static $_templateSimple =
-		'<?php
+    protected static $_templateSimple =
+        '<?php
 
 declare(strict_types=1);
 
@@ -83,129 +83,129 @@ 
 }
 ';
 
-	/** @var Connection */
-	protected $connection;
-
-	/** @var IAppManager */
-	protected $appManager;
-
-	/**
-	 * @param Connection $connection
-	 * @param IAppManager $appManager
-	 */
-	public function __construct(Connection $connection, IAppManager $appManager) {
-		$this->connection = $connection;
-		$this->appManager = $appManager;
-
-		parent::__construct();
-	}
-
-	protected function configure() {
-		$this
-			->setName('migrations:generate')
-			->addArgument('app', InputArgument::REQUIRED, 'Name of the app this migration command shall work on')
-			->addArgument('version', InputArgument::REQUIRED, 'Major version of this app, to allow versions on parallel development branches')
-		;
-
-		parent::configure();
-	}
-
-	public function execute(InputInterface $input, OutputInterface $output): int {
-		$appName = $input->getArgument('app');
-		$version = $input->getArgument('version');
-
-		if (!preg_match('/^\d{1,16}$/',$version)) {
-			$output->writeln('<error>The given version is invalid. Only 0-9 are allowed (max. 16 digits)</error>');
-			return 1;
-		}
-
-		$ms = new MigrationService($appName, $this->connection, new ConsoleOutput($output));
-
-		$date = date('YmdHis');
-		$path = $this->generateMigration($ms, 'Version' . $version . 'Date' . $date);
-
-		$output->writeln("New migration class has been generated to <info>$path</info>");
-		return 0;
-	}
-
-	/**
-	 * @param string $optionName
-	 * @param CompletionContext $context
-	 * @return string[]
-	 */
-	public function completeOptionValues($optionName, CompletionContext $context) {
-		return [];
-	}
-
-	/**
-	 * @param string $argumentName
-	 * @param CompletionContext $context
-	 * @return string[]
-	 */
-	public function completeArgumentValues($argumentName, CompletionContext $context) {
-		if ($argumentName === 'app') {
-			$allApps = \OC_App::getAllApps();
-			return array_diff($allApps, \OC_App::getEnabledApps(true, true));
-		}
-
-		if ($argumentName === 'version') {
-			$appName = $context->getWordAtIndex($context->getWordIndex() - 1);
-
-			$version = explode('.', $this->appManager->getAppVersion($appName));
-			return [$version[0] . sprintf('%1$03d', $version[1])];
-		}
-
-		return [];
-	}
-
-	/**
-	 * @param MigrationService $ms
-	 * @param string $className
-	 * @param string $schemaBody
-	 * @return string
-	 */
-	protected function generateMigration(MigrationService $ms, $className, $schemaBody = '') {
-		if ($schemaBody === '') {
-			$schemaBody = "\t\t" . 'return null;';
-		}
-
-
-		$placeHolders = [
-			'{{namespace}}',
-			'{{classname}}',
-			'{{schemabody}}',
-		];
-		$replacements = [
-			$ms->getMigrationsNamespace(),
-			$className,
-			$schemaBody,
-		];
-		$code = str_replace($placeHolders, $replacements, self::$_templateSimple);
-		$dir = $ms->getMigrationsDirectory();
-
-		$this->ensureMigrationDirExists($dir);
-		$path = $dir . '/' . $className . '.php';
-
-		if (file_put_contents($path, $code) === false) {
-			throw new RuntimeException('Failed to generate new migration step.');
-		}
-
-		return $path;
-	}
-
-	protected function ensureMigrationDirExists($directory) {
-		if (file_exists($directory) && is_dir($directory)) {
-			return;
-		}
-
-		if (file_exists($directory)) {
-			throw new \RuntimeException("Could not create folder \"$directory\"");
-		}
-
-		$this->ensureMigrationDirExists(dirname($directory));
-
-		if (!@mkdir($directory) && !is_dir($directory)) {
-			throw new \RuntimeException("Could not create folder \"$directory\"");
-		}
-	}
+    /** @var Connection */
+    protected $connection;
+
+    /** @var IAppManager */
+    protected $appManager;
+
+    /**
+     * @param Connection $connection
+     * @param IAppManager $appManager
+     */
+    public function __construct(Connection $connection, IAppManager $appManager) {
+        $this->connection = $connection;
+        $this->appManager = $appManager;
+
+        parent::__construct();
+    }
+
+    protected function configure() {
+        $this
+            ->setName('migrations:generate')
+            ->addArgument('app', InputArgument::REQUIRED, 'Name of the app this migration command shall work on')
+            ->addArgument('version', InputArgument::REQUIRED, 'Major version of this app, to allow versions on parallel development branches')
+        ;
+
+        parent::configure();
+    }
+
+    public function execute(InputInterface $input, OutputInterface $output): int {
+        $appName = $input->getArgument('app');
+        $version = $input->getArgument('version');
+
+        if (!preg_match('/^\d{1,16}$/',$version)) {
+            $output->writeln('<error>The given version is invalid. Only 0-9 are allowed (max. 16 digits)</error>');
+            return 1;
+        }
+
+        $ms = new MigrationService($appName, $this->connection, new ConsoleOutput($output));
+
+        $date = date('YmdHis');
+        $path = $this->generateMigration($ms, 'Version' . $version . 'Date' . $date);
+
+        $output->writeln("New migration class has been generated to <info>$path</info>");
+        return 0;
+    }
+
+    /**
+     * @param string $optionName
+     * @param CompletionContext $context
+     * @return string[]
+     */
+    public function completeOptionValues($optionName, CompletionContext $context) {
+        return [];
+    }
+
+    /**
+     * @param string $argumentName
+     * @param CompletionContext $context
+     * @return string[]
+     */
+    public function completeArgumentValues($argumentName, CompletionContext $context) {
+        if ($argumentName === 'app') {
+            $allApps = \OC_App::getAllApps();
+            return array_diff($allApps, \OC_App::getEnabledApps(true, true));
+        }
+
+        if ($argumentName === 'version') {
+            $appName = $context->getWordAtIndex($context->getWordIndex() - 1);
+
+            $version = explode('.', $this->appManager->getAppVersion($appName));
+            return [$version[0] . sprintf('%1$03d', $version[1])];
+        }
+
+        return [];
+    }
+
+    /**
+     * @param MigrationService $ms
+     * @param string $className
+     * @param string $schemaBody
+     * @return string
+     */
+    protected function generateMigration(MigrationService $ms, $className, $schemaBody = '') {
+        if ($schemaBody === '') {
+            $schemaBody = "\t\t" . 'return null;';
+        }
+
+
+        $placeHolders = [
+            '{{namespace}}',
+            '{{classname}}',
+            '{{schemabody}}',
+        ];
+        $replacements = [
+            $ms->getMigrationsNamespace(),
+            $className,
+            $schemaBody,
+        ];
+        $code = str_replace($placeHolders, $replacements, self::$_templateSimple);
+        $dir = $ms->getMigrationsDirectory();
+
+        $this->ensureMigrationDirExists($dir);
+        $path = $dir . '/' . $className . '.php';
+
+        if (file_put_contents($path, $code) === false) {
+            throw new RuntimeException('Failed to generate new migration step.');
+        }
+
+        return $path;
+    }
+
+    protected function ensureMigrationDirExists($directory) {
+        if (file_exists($directory) && is_dir($directory)) {
+            return;
+        }
+
+        if (file_exists($directory)) {
+            throw new \RuntimeException("Could not create folder \"$directory\"");
+        }
+
+        $this->ensureMigrationDirExists(dirname($directory));
+
+        if (!@mkdir($directory) && !is_dir($directory)) {
+            throw new \RuntimeException("Could not create folder \"$directory\"");
+        }
+    }
 }