Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 30 | class TrashFolderFile implements IFile, ITrash { |
||
| 31 | /** @var string */ |
||
| 32 | private $root; |
||
| 33 | |||
| 34 | /** @var string */ |
||
| 35 | private $userId; |
||
| 36 | |||
| 37 | /** @var FileInfo */ |
||
| 38 | private $data; |
||
| 39 | |||
| 40 | /** @var string */ |
||
| 41 | private $location; |
||
| 42 | |||
| 43 | View Code Duplication | public function __construct(string $root, |
|
| 52 | |||
| 53 | public function put($data) { |
||
| 56 | |||
| 57 | public function get() { |
||
| 60 | |||
| 61 | public function getContentType(): string { |
||
| 64 | |||
| 65 | public function getETag(): string { |
||
| 68 | |||
| 69 | public function getSize(): int { |
||
| 72 | |||
| 73 | public function delete() { |
||
| 76 | |||
| 77 | public function getName(): string { |
||
| 80 | |||
| 81 | public function setName($name) { |
||
| 84 | |||
| 85 | public function getLastModified(): int { |
||
| 88 | |||
| 89 | public function restore(): bool { |
||
| 92 | |||
| 93 | public function getFilename(): string { |
||
| 96 | |||
| 97 | public function getOriginalLocation(): string { |
||
| 100 | |||
| 101 | public function getDeletionTime(): int { |
||
| 104 | } |
||
| 105 |