nextcloud / server

lib/private/Lock/DBLockingProvider.php

Spacing +2 added lines, -2 removed lines

@@ -113,7 +113,7 @@ 
 			->from('file_locks')
 			->where($query->expr()->eq('key', $query->createNamedParameter($path)));
 		$result = $query->executeQuery();
-		$lockValue = (int)$result->fetchOne();
+		$lockValue = (int) $result->fetchOne();
 		if ($type === self::LOCK_SHARED) {
 			if ($this->isLocallyLocked($path)) {
 				// if we have a shared lock we kept open locally but it's released we always have at least 1 shared lock in the db
@@ -247,7 +247,7 @@ 
 		}
 		// since we keep shared locks we need to manually clean those
 		$lockedPaths = array_keys($this->sharedLocks);
-		$lockedPaths = array_filter($lockedPaths, function ($path) {
+		$lockedPaths = array_filter($lockedPaths, function($path) {
 			return $this->sharedLocks[$path];
 		});
 

Indentation +219 added lines, -219 removed lines

@@ -18,223 +18,223 @@
  * Locking provider that stores the locks in the database
  */
 class DBLockingProvider extends AbstractLockingProvider {
-	private array $sharedLocks = [];
-
-	public function __construct(
-		private IDBConnection $connection,
-		private ITimeFactory $timeFactory,
-		int $ttl = 3600,
-		private bool $cacheSharedLocks = true,
-	) {
-		parent::__construct($ttl);
-	}
-
-	/**
-	 * Check if we have an open shared lock for a path
-	 */
-	protected function isLocallyLocked(string $path): bool {
-		return isset($this->sharedLocks[$path]) && $this->sharedLocks[$path];
-	}
-
-	/** @inheritDoc */
-	protected function markAcquire(string $path, int $targetType): void {
-		parent::markAcquire($path, $targetType);
-		if ($this->cacheSharedLocks) {
-			if ($targetType === self::LOCK_SHARED) {
-				$this->sharedLocks[$path] = true;
-			}
-		}
-	}
-
-	/**
-	 * Change the type of an existing tracked lock
-	 */
-	protected function markChange(string $path, int $targetType): void {
-		parent::markChange($path, $targetType);
-		if ($this->cacheSharedLocks) {
-			if ($targetType === self::LOCK_SHARED) {
-				$this->sharedLocks[$path] = true;
-			} elseif ($targetType === self::LOCK_EXCLUSIVE) {
-				$this->sharedLocks[$path] = false;
-			}
-		}
-	}
-
-	/**
-	 * Insert a file locking row if it does not exists.
-	 */
-	protected function initLockField(string $path, int $lock = 0): int {
-		$expire = $this->getExpireTime();
-		return $this->connection->insertIgnoreConflict('file_locks', [
-			'key' => $path,
-			'lock' => $lock,
-			'ttl' => $expire
-		]);
-	}
-
-	protected function getExpireTime(): int {
-		return $this->timeFactory->getTime() + $this->ttl;
-	}
-
-	/** @inheritDoc */
-	public function isLocked(string $path, int $type): bool {
-		if ($this->hasAcquiredLock($path, $type)) {
-			return true;
-		}
-		$query = $this->connection->getQueryBuilder();
-		$query->select('lock')
-			->from('file_locks')
-			->where($query->expr()->eq('key', $query->createNamedParameter($path)));
-		$result = $query->executeQuery();
-		$lockValue = (int)$result->fetchOne();
-		if ($type === self::LOCK_SHARED) {
-			if ($this->isLocallyLocked($path)) {
-				// if we have a shared lock we kept open locally but it's released we always have at least 1 shared lock in the db
-				return $lockValue > 1;
-			} else {
-				return $lockValue > 0;
-			}
-		} elseif ($type === self::LOCK_EXCLUSIVE) {
-			return $lockValue === -1;
-		} else {
-			return false;
-		}
-	}
-
-	/** @inheritDoc */
-	public function acquireLock(string $path, int $type, ?string $readablePath = null): void {
-		$expire = $this->getExpireTime();
-		if ($type === self::LOCK_SHARED) {
-			if (!$this->isLocallyLocked($path)) {
-				$result = $this->initLockField($path, 1);
-				if ($result <= 0) {
-					$query = $this->connection->getQueryBuilder();
-					$query->update('file_locks')
-						->set('lock', $query->func()->add('lock', $query->createNamedParameter(1, IQueryBuilder::PARAM_INT)))
-						->set('ttl', $query->createNamedParameter($expire))
-						->where($query->expr()->eq('key', $query->createNamedParameter($path)))
-						->andWhere($query->expr()->gte('lock', $query->createNamedParameter(0, IQueryBuilder::PARAM_INT)));
-					$result = $query->executeStatement();
-				}
-			} else {
-				$result = 1;
-			}
-		} else {
-			$existing = 0;
-			if ($this->hasAcquiredLock($path, ILockingProvider::LOCK_SHARED) === false && $this->isLocallyLocked($path)) {
-				$existing = 1;
-			}
-			$result = $this->initLockField($path, -1);
-			if ($result <= 0) {
-				$query = $this->connection->getQueryBuilder();
-				$query->update('file_locks')
-					->set('lock', $query->createNamedParameter(-1, IQueryBuilder::PARAM_INT))
-					->set('ttl', $query->createNamedParameter($expire, IQueryBuilder::PARAM_INT))
-					->where($query->expr()->eq('key', $query->createNamedParameter($path)))
-					->andWhere($query->expr()->eq('lock', $query->createNamedParameter($existing)));
-				$result = $query->executeStatement();
-			}
-		}
-		if ($result !== 1) {
-			throw new LockedException($path, null, null, $readablePath);
-		}
-		$this->markAcquire($path, $type);
-	}
-
-	/** @inheritDoc */
-	public function releaseLock(string $path, int $type): void {
-		$this->markRelease($path, $type);
-
-		// we keep shared locks till the end of the request so we can re-use them
-		if ($type === self::LOCK_EXCLUSIVE) {
-			$qb = $this->connection->getQueryBuilder();
-			$qb->update('file_locks')
-				->set('lock', $qb->createNamedParameter(0, IQueryBuilder::PARAM_INT))
-				->where($qb->expr()->eq('key', $qb->createNamedParameter($path)))
-				->andWhere($qb->expr()->eq('lock', $qb->createNamedParameter(-1, IQueryBuilder::PARAM_INT)));
-			$qb->executeStatement();
-		} elseif (!$this->cacheSharedLocks) {
-			$qb = $this->connection->getQueryBuilder();
-			$qb->update('file_locks')
-				->set('lock', $qb->func()->subtract('lock', $qb->createNamedParameter(1, IQueryBuilder::PARAM_INT)))
-				->where($qb->expr()->eq('key', $qb->createNamedParameter($path)))
-				->andWhere($qb->expr()->gt('lock', $qb->createNamedParameter(0, IQueryBuilder::PARAM_INT)));
-			$qb->executeStatement();
-		}
-	}
-
-	/** @inheritDoc */
-	public function changeLock(string $path, int $targetType): void {
-		$expire = $this->getExpireTime();
-		if ($targetType === self::LOCK_SHARED) {
-			$qb = $this->connection->getQueryBuilder();
-			$result = $qb->update('file_locks')
-				->set('lock', $qb->createNamedParameter(1, IQueryBuilder::PARAM_INT))
-				->set('ttl', $qb->createNamedParameter($expire, IQueryBuilder::PARAM_INT))
-				->where($qb->expr()->andX(
-					$qb->expr()->eq('key', $qb->createNamedParameter($path)),
-					$qb->expr()->eq('lock', $qb->createNamedParameter(-1, IQueryBuilder::PARAM_INT))
-				))->executeStatement();
-		} else {
-			// since we only keep one shared lock in the db we need to check if we have more then one shared lock locally manually
-			if (isset($this->acquiredLocks['shared'][$path]) && $this->acquiredLocks['shared'][$path] > 1) {
-				throw new LockedException($path);
-			}
-			$qb = $this->connection->getQueryBuilder();
-			$result = $qb->update('file_locks')
-				->set('lock', $qb->createNamedParameter(-1, IQueryBuilder::PARAM_INT))
-				->set('ttl', $qb->createNamedParameter($expire, IQueryBuilder::PARAM_INT))
-				->where($qb->expr()->andX(
-					$qb->expr()->eq('key', $qb->createNamedParameter($path)),
-					$qb->expr()->eq('lock', $qb->createNamedParameter(1, IQueryBuilder::PARAM_INT))
-				))->executeStatement();
-		}
-		if ($result !== 1) {
-			throw new LockedException($path);
-		}
-		$this->markChange($path, $targetType);
-	}
-
-	/** @inheritDoc */
-	public function cleanExpiredLocks(): void {
-		$expire = $this->timeFactory->getTime();
-		try {
-			$qb = $this->connection->getQueryBuilder();
-			$qb->delete('file_locks')
-				->where($qb->expr()->lt('ttl', $qb->createNamedParameter($expire, IQueryBuilder::PARAM_INT)))
-				->executeStatement();
-		} catch (\Exception $e) {
-			// If the table is missing, the clean up was successful
-			if ($this->connection->tableExists('file_locks')) {
-				throw $e;
-			}
-		}
-	}
-
-	/** @inheritDoc */
-	public function releaseAll(): void {
-		parent::releaseAll();
-
-		if (!$this->cacheSharedLocks) {
-			return;
-		}
-		// since we keep shared locks we need to manually clean those
-		$lockedPaths = array_keys($this->sharedLocks);
-		$lockedPaths = array_filter($lockedPaths, function ($path) {
-			return $this->sharedLocks[$path];
-		});
-
-		$chunkedPaths = array_chunk($lockedPaths, 100);
-
-		$qb = $this->connection->getQueryBuilder();
-		$qb->update('file_locks')
-			->set('lock', $qb->func()->subtract('lock', $qb->expr()->literal(1)))
-			->where($qb->expr()->in('key', $qb->createParameter('chunk')))
-			->andWhere($qb->expr()->gt('lock', new Literal(0)));
-
-		foreach ($chunkedPaths as $chunk) {
-			$qb->setParameter('chunk', $chunk, IQueryBuilder::PARAM_STR_ARRAY);
-			$qb->executeStatement();
-		}
-	}
+    private array $sharedLocks = [];
+
+    public function __construct(
+        private IDBConnection $connection,
+        private ITimeFactory $timeFactory,
+        int $ttl = 3600,
+        private bool $cacheSharedLocks = true,
+    ) {
+        parent::__construct($ttl);
+    }
+
+    /**
+     * Check if we have an open shared lock for a path
+     */
+    protected function isLocallyLocked(string $path): bool {
+        return isset($this->sharedLocks[$path]) && $this->sharedLocks[$path];
+    }
+
+    /** @inheritDoc */
+    protected function markAcquire(string $path, int $targetType): void {
+        parent::markAcquire($path, $targetType);
+        if ($this->cacheSharedLocks) {
+            if ($targetType === self::LOCK_SHARED) {
+                $this->sharedLocks[$path] = true;
+            }
+        }
+    }
+
+    /**
+     * Change the type of an existing tracked lock
+     */
+    protected function markChange(string $path, int $targetType): void {
+        parent::markChange($path, $targetType);
+        if ($this->cacheSharedLocks) {
+            if ($targetType === self::LOCK_SHARED) {
+                $this->sharedLocks[$path] = true;
+            } elseif ($targetType === self::LOCK_EXCLUSIVE) {
+                $this->sharedLocks[$path] = false;
+            }
+        }
+    }
+
+    /**
+     * Insert a file locking row if it does not exists.
+     */
+    protected function initLockField(string $path, int $lock = 0): int {
+        $expire = $this->getExpireTime();
+        return $this->connection->insertIgnoreConflict('file_locks', [
+            'key' => $path,
+            'lock' => $lock,
+            'ttl' => $expire
+        ]);
+    }
+
+    protected function getExpireTime(): int {
+        return $this->timeFactory->getTime() + $this->ttl;
+    }
+
+    /** @inheritDoc */
+    public function isLocked(string $path, int $type): bool {
+        if ($this->hasAcquiredLock($path, $type)) {
+            return true;
+        }
+        $query = $this->connection->getQueryBuilder();
+        $query->select('lock')
+            ->from('file_locks')
+            ->where($query->expr()->eq('key', $query->createNamedParameter($path)));
+        $result = $query->executeQuery();
+        $lockValue = (int)$result->fetchOne();
+        if ($type === self::LOCK_SHARED) {
+            if ($this->isLocallyLocked($path)) {
+                // if we have a shared lock we kept open locally but it's released we always have at least 1 shared lock in the db
+                return $lockValue > 1;
+            } else {
+                return $lockValue > 0;
+            }
+        } elseif ($type === self::LOCK_EXCLUSIVE) {
+            return $lockValue === -1;
+        } else {
+            return false;
+        }
+    }
+
+    /** @inheritDoc */
+    public function acquireLock(string $path, int $type, ?string $readablePath = null): void {
+        $expire = $this->getExpireTime();
+        if ($type === self::LOCK_SHARED) {
+            if (!$this->isLocallyLocked($path)) {
+                $result = $this->initLockField($path, 1);
+                if ($result <= 0) {
+                    $query = $this->connection->getQueryBuilder();
+                    $query->update('file_locks')
+                        ->set('lock', $query->func()->add('lock', $query->createNamedParameter(1, IQueryBuilder::PARAM_INT)))
+                        ->set('ttl', $query->createNamedParameter($expire))
+                        ->where($query->expr()->eq('key', $query->createNamedParameter($path)))
+                        ->andWhere($query->expr()->gte('lock', $query->createNamedParameter(0, IQueryBuilder::PARAM_INT)));
+                    $result = $query->executeStatement();
+                }
+            } else {
+                $result = 1;
+            }
+        } else {
+            $existing = 0;
+            if ($this->hasAcquiredLock($path, ILockingProvider::LOCK_SHARED) === false && $this->isLocallyLocked($path)) {
+                $existing = 1;
+            }
+            $result = $this->initLockField($path, -1);
+            if ($result <= 0) {
+                $query = $this->connection->getQueryBuilder();
+                $query->update('file_locks')
+                    ->set('lock', $query->createNamedParameter(-1, IQueryBuilder::PARAM_INT))
+                    ->set('ttl', $query->createNamedParameter($expire, IQueryBuilder::PARAM_INT))
+                    ->where($query->expr()->eq('key', $query->createNamedParameter($path)))
+                    ->andWhere($query->expr()->eq('lock', $query->createNamedParameter($existing)));
+                $result = $query->executeStatement();
+            }
+        }
+        if ($result !== 1) {
+            throw new LockedException($path, null, null, $readablePath);
+        }
+        $this->markAcquire($path, $type);
+    }
+
+    /** @inheritDoc */
+    public function releaseLock(string $path, int $type): void {
+        $this->markRelease($path, $type);
+
+        // we keep shared locks till the end of the request so we can re-use them
+        if ($type === self::LOCK_EXCLUSIVE) {
+            $qb = $this->connection->getQueryBuilder();
+            $qb->update('file_locks')
+                ->set('lock', $qb->createNamedParameter(0, IQueryBuilder::PARAM_INT))
+                ->where($qb->expr()->eq('key', $qb->createNamedParameter($path)))
+                ->andWhere($qb->expr()->eq('lock', $qb->createNamedParameter(-1, IQueryBuilder::PARAM_INT)));
+            $qb->executeStatement();
+        } elseif (!$this->cacheSharedLocks) {
+            $qb = $this->connection->getQueryBuilder();
+            $qb->update('file_locks')
+                ->set('lock', $qb->func()->subtract('lock', $qb->createNamedParameter(1, IQueryBuilder::PARAM_INT)))
+                ->where($qb->expr()->eq('key', $qb->createNamedParameter($path)))
+                ->andWhere($qb->expr()->gt('lock', $qb->createNamedParameter(0, IQueryBuilder::PARAM_INT)));
+            $qb->executeStatement();
+        }
+    }
+
+    /** @inheritDoc */
+    public function changeLock(string $path, int $targetType): void {
+        $expire = $this->getExpireTime();
+        if ($targetType === self::LOCK_SHARED) {
+            $qb = $this->connection->getQueryBuilder();
+            $result = $qb->update('file_locks')
+                ->set('lock', $qb->createNamedParameter(1, IQueryBuilder::PARAM_INT))
+                ->set('ttl', $qb->createNamedParameter($expire, IQueryBuilder::PARAM_INT))
+                ->where($qb->expr()->andX(
+                    $qb->expr()->eq('key', $qb->createNamedParameter($path)),
+                    $qb->expr()->eq('lock', $qb->createNamedParameter(-1, IQueryBuilder::PARAM_INT))
+                ))->executeStatement();
+        } else {
+            // since we only keep one shared lock in the db we need to check if we have more then one shared lock locally manually
+            if (isset($this->acquiredLocks['shared'][$path]) && $this->acquiredLocks['shared'][$path] > 1) {
+                throw new LockedException($path);
+            }
+            $qb = $this->connection->getQueryBuilder();
+            $result = $qb->update('file_locks')
+                ->set('lock', $qb->createNamedParameter(-1, IQueryBuilder::PARAM_INT))
+                ->set('ttl', $qb->createNamedParameter($expire, IQueryBuilder::PARAM_INT))
+                ->where($qb->expr()->andX(
+                    $qb->expr()->eq('key', $qb->createNamedParameter($path)),
+                    $qb->expr()->eq('lock', $qb->createNamedParameter(1, IQueryBuilder::PARAM_INT))
+                ))->executeStatement();
+        }
+        if ($result !== 1) {
+            throw new LockedException($path);
+        }
+        $this->markChange($path, $targetType);
+    }
+
+    /** @inheritDoc */
+    public function cleanExpiredLocks(): void {
+        $expire = $this->timeFactory->getTime();
+        try {
+            $qb = $this->connection->getQueryBuilder();
+            $qb->delete('file_locks')
+                ->where($qb->expr()->lt('ttl', $qb->createNamedParameter($expire, IQueryBuilder::PARAM_INT)))
+                ->executeStatement();
+        } catch (\Exception $e) {
+            // If the table is missing, the clean up was successful
+            if ($this->connection->tableExists('file_locks')) {
+                throw $e;
+            }
+        }
+    }
+
+    /** @inheritDoc */
+    public function releaseAll(): void {
+        parent::releaseAll();
+
+        if (!$this->cacheSharedLocks) {
+            return;
+        }
+        // since we keep shared locks we need to manually clean those
+        $lockedPaths = array_keys($this->sharedLocks);
+        $lockedPaths = array_filter($lockedPaths, function ($path) {
+            return $this->sharedLocks[$path];
+        });
+
+        $chunkedPaths = array_chunk($lockedPaths, 100);
+
+        $qb = $this->connection->getQueryBuilder();
+        $qb->update('file_locks')
+            ->set('lock', $qb->func()->subtract('lock', $qb->expr()->literal(1)))
+            ->where($qb->expr()->in('key', $qb->createParameter('chunk')))
+            ->andWhere($qb->expr()->gt('lock', new Literal(0)));
+
+        foreach ($chunkedPaths as $chunk) {
+            $qb->setParameter('chunk', $chunk, IQueryBuilder::PARAM_STR_ARRAY);
+            $qb->executeStatement();
+        }
+    }
 }

lib/private/Diagnostics/QueryLogger.php

Spacing +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
 	public function stopQuery() {
 		if ($this->activated && $this->activeQuery) {
 			$this->activeQuery->end(microtime(true));
-			$this->queries[(string)$this->index] = $this->activeQuery;
+			$this->queries[(string) $this->index] = $this->activeQuery;
 			$this->index++;
 			$this->activeQuery = null;
 		}

Indentation +52 added lines, -52 removed lines

@@ -11,64 +11,64 @@
 use OCP\Diagnostics\IQueryLogger;
 
 class QueryLogger implements IQueryLogger {
-	protected int $index = 0;
-	protected ?Query $activeQuery = null;
-	/** @var CappedMemoryCache<Query> */
-	protected CappedMemoryCache $queries;
+    protected int $index = 0;
+    protected ?Query $activeQuery = null;
+    /** @var CappedMemoryCache<Query> */
+    protected CappedMemoryCache $queries;
 
-	/**
-	 * QueryLogger constructor.
-	 */
-	public function __construct() {
-		$this->queries = new CappedMemoryCache(1024);
-	}
+    /**
+     * QueryLogger constructor.
+     */
+    public function __construct() {
+        $this->queries = new CappedMemoryCache(1024);
+    }
 
 
-	/**
-	 * @var bool - Module needs to be activated by some app
-	 */
-	private $activated = false;
+    /**
+     * @var bool - Module needs to be activated by some app
+     */
+    private $activated = false;
 
-	/**
-	 * @inheritdoc
-	 */
-	public function startQuery($sql, ?array $params = null, ?array $types = null) {
-		if ($this->activated) {
-			$this->activeQuery = new Query($sql, $params, microtime(true), $this->getStack());
-		}
-	}
+    /**
+     * @inheritdoc
+     */
+    public function startQuery($sql, ?array $params = null, ?array $types = null) {
+        if ($this->activated) {
+            $this->activeQuery = new Query($sql, $params, microtime(true), $this->getStack());
+        }
+    }
 
-	private function getStack() {
-		$stack = debug_backtrace();
-		array_shift($stack);
-		array_shift($stack);
-		array_shift($stack);
-		return $stack;
-	}
+    private function getStack() {
+        $stack = debug_backtrace();
+        array_shift($stack);
+        array_shift($stack);
+        array_shift($stack);
+        return $stack;
+    }
 
-	/**
-	 * @inheritdoc
-	 */
-	public function stopQuery() {
-		if ($this->activated && $this->activeQuery) {
-			$this->activeQuery->end(microtime(true));
-			$this->queries[(string)$this->index] = $this->activeQuery;
-			$this->index++;
-			$this->activeQuery = null;
-		}
-	}
+    /**
+     * @inheritdoc
+     */
+    public function stopQuery() {
+        if ($this->activated && $this->activeQuery) {
+            $this->activeQuery->end(microtime(true));
+            $this->queries[(string)$this->index] = $this->activeQuery;
+            $this->index++;
+            $this->activeQuery = null;
+        }
+    }
 
-	/**
-	 * @inheritdoc
-	 */
-	public function getQueries() {
-		return $this->queries->getData();
-	}
+    /**
+     * @inheritdoc
+     */
+    public function getQueries() {
+        return $this->queries->getData();
+    }
 
-	/**
-	 * @inheritdoc
-	 */
-	public function activate() {
-		$this->activated = true;
-	}
+    /**
+     * @inheritdoc
+     */
+    public function activate() {
+        $this->activated = true;
+    }
 }

apps/federation/lib/DbHandler.php

Spacing +5 added lines, -5 removed lines

@@ -80,7 +80,7 @@ 
 			return $query->getLastInsertId();
 		}
 
-		$message = 'Internal failure, Could not add trusted server: ' . $url;
+		$message = 'Internal failure, Could not add trusted server: '.$url;
 		$message_t = $this->IL10N->t('Could not add server');
 		throw new HintException($message, $message_t);
 		return -1;
@@ -114,7 +114,7 @@ 
 		$qResult->closeCursor();
 
 		if (empty($result)) {
-			throw new \Exception('No Server found with ID: ' . $id);
+			throw new \Exception('No Server found with ID: '.$id);
 		}
 
 		return $result[0];
@@ -183,7 +183,7 @@ 
 		$statement->closeCursor();
 
 		if (!isset($result['token'])) {
-			throw new \Exception('No token found for: ' . $url);
+			throw new \Exception('No token found for: '.$url);
 		}
 
 		return $result['token'];
@@ -216,7 +216,7 @@ 
 		$statement = $query->executeQuery();
 		$result = $statement->fetch();
 		$statement->closeCursor();
-		return (string)$result['shared_secret'];
+		return (string) $result['shared_secret'];
 	}
 
 	/**
@@ -247,7 +247,7 @@ 
 		$statement = $query->executeQuery();
 		$result = $statement->fetch();
 		$statement->closeCursor();
-		return (int)$result['status'];
+		return (int) $result['status'];
 	}
 
 	/**

Indentation +240 added lines, -240 removed lines

@@ -25,244 +25,244 @@
  * @package OCA\Federation
  */
 class DbHandler {
-	private string $dbTable = 'trusted_servers';
-
-	public function __construct(
-		private IDBConnection $connection,
-		private IL10N $IL10N,
-	) {
-	}
-
-	/**
-	 * Add server to the list of trusted servers
-	 *
-	 * @throws HintException
-	 */
-	public function addServer(string $url): int {
-		$hash = $this->hash($url);
-		$url = rtrim($url, '/');
-		$query = $this->connection->getQueryBuilder();
-		$query->insert($this->dbTable)
-			->values([
-				'url' => $query->createParameter('url'),
-				'url_hash' => $query->createParameter('url_hash'),
-			])
-			->setParameter('url', $url)
-			->setParameter('url_hash', $hash);
-
-		$result = $query->executeStatement();
-
-		if ($result) {
-			return $query->getLastInsertId();
-		}
-
-		$message = 'Internal failure, Could not add trusted server: ' . $url;
-		$message_t = $this->IL10N->t('Could not add server');
-		throw new HintException($message, $message_t);
-		return -1;
-	}
-
-	/**
-	 * Remove server from the list of trusted servers
-	 */
-	public function removeServer(int $id): void {
-		$query = $this->connection->getQueryBuilder();
-		$query->delete($this->dbTable)
-			->where($query->expr()->eq('id', $query->createParameter('id')))
-			->setParameter('id', $id);
-		$query->executeStatement();
-	}
-
-	/**
-	 * Get trusted server with given ID
-	 *
-	 * @return array{id: int, url: string, url_hash: string, token: ?string, shared_secret: ?string, status: int, sync_token: ?string}
-	 * @throws \Exception
-	 */
-	public function getServerById(int $id): array {
-		$query = $this->connection->getQueryBuilder();
-		$query->select('*')->from($this->dbTable)
-			->where($query->expr()->eq('id', $query->createParameter('id')))
-			->setParameter('id', $id, IQueryBuilder::PARAM_INT);
-
-		$qResult = $query->executeQuery();
-		$result = $qResult->fetchAll();
-		$qResult->closeCursor();
-
-		if (empty($result)) {
-			throw new \Exception('No Server found with ID: ' . $id);
-		}
-
-		return $result[0];
-	}
-
-	/**
-	 * Get all trusted servers
-	 *
-	 * @return list<array{id: int, url: string, url_hash: string, shared_secret: ?string, status: int, sync_token: ?string}>
-	 * @throws DBException
-	 */
-	public function getAllServer(): array {
-		$query = $this->connection->getQueryBuilder();
-		$query->select(['url', 'url_hash', 'id', 'status', 'shared_secret', 'sync_token'])
-			->from($this->dbTable);
-		$statement = $query->executeQuery();
-		$result = $statement->fetchAll();
-		$statement->closeCursor();
-		return $result;
-	}
-
-	/**
-	 * Check if server already exists in the database table
-	 */
-	public function serverExists(string $url): bool {
-		$hash = $this->hash($url);
-		$query = $this->connection->getQueryBuilder();
-		$query->select('url')
-			->from($this->dbTable)
-			->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
-			->setParameter('url_hash', $hash);
-		$statement = $query->executeQuery();
-		$result = $statement->fetchAll();
-		$statement->closeCursor();
-
-		return !empty($result);
-	}
-
-	/**
-	 * Write token to database. Token is used to exchange the secret
-	 */
-	public function addToken(string $url, string $token): void {
-		$hash = $this->hash($url);
-		$query = $this->connection->getQueryBuilder();
-		$query->update($this->dbTable)
-			->set('token', $query->createParameter('token'))
-			->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
-			->setParameter('url_hash', $hash)
-			->setParameter('token', $token);
-		$query->executeStatement();
-	}
-
-	/**
-	 * Get token stored in database
-	 * @throws \Exception
-	 */
-	public function getToken(string $url): string {
-		$hash = $this->hash($url);
-		$query = $this->connection->getQueryBuilder();
-		$query->select('token')->from($this->dbTable)
-			->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
-			->setParameter('url_hash', $hash);
-
-		$statement = $query->executeQuery();
-		$result = $statement->fetch();
-		$statement->closeCursor();
-
-		if (!isset($result['token'])) {
-			throw new \Exception('No token found for: ' . $url);
-		}
-
-		return $result['token'];
-	}
-
-	/**
-	 * Add shared Secret to database
-	 */
-	public function addSharedSecret(string $url, string $sharedSecret): void {
-		$hash = $this->hash($url);
-		$query = $this->connection->getQueryBuilder();
-		$query->update($this->dbTable)
-			->set('shared_secret', $query->createParameter('sharedSecret'))
-			->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
-			->setParameter('url_hash', $hash)
-			->setParameter('sharedSecret', $sharedSecret);
-		$query->executeStatement();
-	}
-
-	/**
-	 * Get shared secret from database
-	 */
-	public function getSharedSecret(string $url): string {
-		$hash = $this->hash($url);
-		$query = $this->connection->getQueryBuilder();
-		$query->select('shared_secret')->from($this->dbTable)
-			->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
-			->setParameter('url_hash', $hash);
-
-		$statement = $query->executeQuery();
-		$result = $statement->fetch();
-		$statement->closeCursor();
-		return (string)$result['shared_secret'];
-	}
-
-	/**
-	 * Set server status
-	 */
-	public function setServerStatus(string $url, int $status, ?string $token = null): void {
-		$hash = $this->hash($url);
-		$query = $this->connection->getQueryBuilder();
-		$query->update($this->dbTable)
-			->set('status', $query->createNamedParameter($status))
-			->where($query->expr()->eq('url_hash', $query->createNamedParameter($hash)));
-		if (!is_null($token)) {
-			$query->set('sync_token', $query->createNamedParameter($token));
-		}
-		$query->executeStatement();
-	}
-
-	/**
-	 * Get server status
-	 */
-	public function getServerStatus(string $url): int {
-		$hash = $this->hash($url);
-		$query = $this->connection->getQueryBuilder();
-		$query->select('status')->from($this->dbTable)
-			->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
-			->setParameter('url_hash', $hash);
-
-		$statement = $query->executeQuery();
-		$result = $statement->fetch();
-		$statement->closeCursor();
-		return (int)$result['status'];
-	}
-
-	/**
-	 * Create hash from URL
-	 */
-	protected function hash(string $url): string {
-		$normalized = $this->normalizeUrl($url);
-		return sha1($normalized);
-	}
-
-	/**
-	 * Normalize URL, used to create the sha1 hash
-	 */
-	protected function normalizeUrl(string $url): string {
-		$normalized = $url;
-
-		if (strpos($url, 'https://') === 0) {
-			$normalized = substr($url, strlen('https://'));
-		} elseif (strpos($url, 'http://') === 0) {
-			$normalized = substr($url, strlen('http://'));
-		}
-
-		$normalized = Filesystem::normalizePath($normalized);
-		$normalized = trim($normalized, '/');
-
-		return $normalized;
-	}
-
-	public function auth(string $username, string $password): bool {
-		if ($username !== 'system') {
-			return false;
-		}
-		$query = $this->connection->getQueryBuilder();
-		$query->select('url')->from($this->dbTable)
-			->where($query->expr()->eq('shared_secret', $query->createNamedParameter($password)));
-
-		$statement = $query->executeQuery();
-		$result = $statement->fetch();
-		$statement->closeCursor();
-		return !empty($result);
-	}
+    private string $dbTable = 'trusted_servers';
+
+    public function __construct(
+        private IDBConnection $connection,
+        private IL10N $IL10N,
+    ) {
+    }
+
+    /**
+     * Add server to the list of trusted servers
+     *
+     * @throws HintException
+     */
+    public function addServer(string $url): int {
+        $hash = $this->hash($url);
+        $url = rtrim($url, '/');
+        $query = $this->connection->getQueryBuilder();
+        $query->insert($this->dbTable)
+            ->values([
+                'url' => $query->createParameter('url'),
+                'url_hash' => $query->createParameter('url_hash'),
+            ])
+            ->setParameter('url', $url)
+            ->setParameter('url_hash', $hash);
+
+        $result = $query->executeStatement();
+
+        if ($result) {
+            return $query->getLastInsertId();
+        }
+
+        $message = 'Internal failure, Could not add trusted server: ' . $url;
+        $message_t = $this->IL10N->t('Could not add server');
+        throw new HintException($message, $message_t);
+        return -1;
+    }
+
+    /**
+     * Remove server from the list of trusted servers
+     */
+    public function removeServer(int $id): void {
+        $query = $this->connection->getQueryBuilder();
+        $query->delete($this->dbTable)
+            ->where($query->expr()->eq('id', $query->createParameter('id')))
+            ->setParameter('id', $id);
+        $query->executeStatement();
+    }
+
+    /**
+     * Get trusted server with given ID
+     *
+     * @return array{id: int, url: string, url_hash: string, token: ?string, shared_secret: ?string, status: int, sync_token: ?string}
+     * @throws \Exception
+     */
+    public function getServerById(int $id): array {
+        $query = $this->connection->getQueryBuilder();
+        $query->select('*')->from($this->dbTable)
+            ->where($query->expr()->eq('id', $query->createParameter('id')))
+            ->setParameter('id', $id, IQueryBuilder::PARAM_INT);
+
+        $qResult = $query->executeQuery();
+        $result = $qResult->fetchAll();
+        $qResult->closeCursor();
+
+        if (empty($result)) {
+            throw new \Exception('No Server found with ID: ' . $id);
+        }
+
+        return $result[0];
+    }
+
+    /**
+     * Get all trusted servers
+     *
+     * @return list<array{id: int, url: string, url_hash: string, shared_secret: ?string, status: int, sync_token: ?string}>
+     * @throws DBException
+     */
+    public function getAllServer(): array {
+        $query = $this->connection->getQueryBuilder();
+        $query->select(['url', 'url_hash', 'id', 'status', 'shared_secret', 'sync_token'])
+            ->from($this->dbTable);
+        $statement = $query->executeQuery();
+        $result = $statement->fetchAll();
+        $statement->closeCursor();
+        return $result;
+    }
+
+    /**
+     * Check if server already exists in the database table
+     */
+    public function serverExists(string $url): bool {
+        $hash = $this->hash($url);
+        $query = $this->connection->getQueryBuilder();
+        $query->select('url')
+            ->from($this->dbTable)
+            ->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
+            ->setParameter('url_hash', $hash);
+        $statement = $query->executeQuery();
+        $result = $statement->fetchAll();
+        $statement->closeCursor();
+
+        return !empty($result);
+    }
+
+    /**
+     * Write token to database. Token is used to exchange the secret
+     */
+    public function addToken(string $url, string $token): void {
+        $hash = $this->hash($url);
+        $query = $this->connection->getQueryBuilder();
+        $query->update($this->dbTable)
+            ->set('token', $query->createParameter('token'))
+            ->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
+            ->setParameter('url_hash', $hash)
+            ->setParameter('token', $token);
+        $query->executeStatement();
+    }
+
+    /**
+     * Get token stored in database
+     * @throws \Exception
+     */
+    public function getToken(string $url): string {
+        $hash = $this->hash($url);
+        $query = $this->connection->getQueryBuilder();
+        $query->select('token')->from($this->dbTable)
+            ->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
+            ->setParameter('url_hash', $hash);
+
+        $statement = $query->executeQuery();
+        $result = $statement->fetch();
+        $statement->closeCursor();
+
+        if (!isset($result['token'])) {
+            throw new \Exception('No token found for: ' . $url);
+        }
+
+        return $result['token'];
+    }
+
+    /**
+     * Add shared Secret to database
+     */
+    public function addSharedSecret(string $url, string $sharedSecret): void {
+        $hash = $this->hash($url);
+        $query = $this->connection->getQueryBuilder();
+        $query->update($this->dbTable)
+            ->set('shared_secret', $query->createParameter('sharedSecret'))
+            ->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
+            ->setParameter('url_hash', $hash)
+            ->setParameter('sharedSecret', $sharedSecret);
+        $query->executeStatement();
+    }
+
+    /**
+     * Get shared secret from database
+     */
+    public function getSharedSecret(string $url): string {
+        $hash = $this->hash($url);
+        $query = $this->connection->getQueryBuilder();
+        $query->select('shared_secret')->from($this->dbTable)
+            ->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
+            ->setParameter('url_hash', $hash);
+
+        $statement = $query->executeQuery();
+        $result = $statement->fetch();
+        $statement->closeCursor();
+        return (string)$result['shared_secret'];
+    }
+
+    /**
+     * Set server status
+     */
+    public function setServerStatus(string $url, int $status, ?string $token = null): void {
+        $hash = $this->hash($url);
+        $query = $this->connection->getQueryBuilder();
+        $query->update($this->dbTable)
+            ->set('status', $query->createNamedParameter($status))
+            ->where($query->expr()->eq('url_hash', $query->createNamedParameter($hash)));
+        if (!is_null($token)) {
+            $query->set('sync_token', $query->createNamedParameter($token));
+        }
+        $query->executeStatement();
+    }
+
+    /**
+     * Get server status
+     */
+    public function getServerStatus(string $url): int {
+        $hash = $this->hash($url);
+        $query = $this->connection->getQueryBuilder();
+        $query->select('status')->from($this->dbTable)
+            ->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
+            ->setParameter('url_hash', $hash);
+
+        $statement = $query->executeQuery();
+        $result = $statement->fetch();
+        $statement->closeCursor();
+        return (int)$result['status'];
+    }
+
+    /**
+     * Create hash from URL
+     */
+    protected function hash(string $url): string {
+        $normalized = $this->normalizeUrl($url);
+        return sha1($normalized);
+    }
+
+    /**
+     * Normalize URL, used to create the sha1 hash
+     */
+    protected function normalizeUrl(string $url): string {
+        $normalized = $url;
+
+        if (strpos($url, 'https://') === 0) {
+            $normalized = substr($url, strlen('https://'));
+        } elseif (strpos($url, 'http://') === 0) {
+            $normalized = substr($url, strlen('http://'));
+        }
+
+        $normalized = Filesystem::normalizePath($normalized);
+        $normalized = trim($normalized, '/');
+
+        return $normalized;
+    }
+
+    public function auth(string $username, string $password): bool {
+        if ($username !== 'system') {
+            return false;
+        }
+        $query = $this->connection->getQueryBuilder();
+        $query->select('url')->from($this->dbTable)
+            ->where($query->expr()->eq('shared_secret', $query->createNamedParameter($password)));
+
+        $statement = $query->executeQuery();
+        $result = $statement->fetch();
+        $statement->closeCursor();
+        return !empty($result);
+    }
 }

apps/files_sharing/lib/ExpireSharesJob.php

Spacing +3 added lines, -3 removed lines

@@ -87,13 +87,13 @@
 
 		$shares = $qb->executeQuery();
 		while ($share = $shares->fetch()) {
-			if ((int)$share['share_type'] === IShare::TYPE_LINK) {
+			if ((int) $share['share_type'] === IShare::TYPE_LINK) {
 				$id = 'ocinternal';
-			} elseif ((int)$share['share_type'] === IShare::TYPE_EMAIL) {
+			} elseif ((int) $share['share_type'] === IShare::TYPE_EMAIL) {
 				$id = 'ocMailShare';
 			}
 
-			$id .= ':' . $share['id'];
+			$id .= ':'.$share['id'];
 
 			try {
 				$share = $this->shareManager->getShareById($id);

Indentation +47 added lines, -47 removed lines

@@ -19,60 +19,60 @@
  */
 class ExpireSharesJob extends TimedJob {
 
-	public function __construct(
-		ITimeFactory $time,
-		private IManager $shareManager,
-		private IDBConnection $db,
-	) {
-		parent::__construct($time);
+    public function __construct(
+        ITimeFactory $time,
+        private IManager $shareManager,
+        private IDBConnection $db,
+    ) {
+        parent::__construct($time);
 
-		// Run once a day
-		$this->setInterval(24 * 60 * 60);
-		$this->setTimeSensitivity(self::TIME_INSENSITIVE);
-	}
+        // Run once a day
+        $this->setInterval(24 * 60 * 60);
+        $this->setTimeSensitivity(self::TIME_INSENSITIVE);
+    }
 
 
-	/**
-	 * Makes the background job do its work
-	 *
-	 * @param array $argument unused argument
-	 */
-	public function run($argument) {
-		//Current time
-		$now = new \DateTime();
-		$now = $now->format('Y-m-d H:i:s');
+    /**
+     * Makes the background job do its work
+     *
+     * @param array $argument unused argument
+     */
+    public function run($argument) {
+        //Current time
+        $now = new \DateTime();
+        $now = $now->format('Y-m-d H:i:s');
 
-		/*
+        /*
 		 * Expire file link shares only (for now)
 		 */
-		$qb = $this->db->getQueryBuilder();
-		$qb->select('id', 'share_type')
-			->from('share')
-			->where(
-				$qb->expr()->andX(
-					$qb->expr()->in('share_type', $qb->createNamedParameter([IShare::TYPE_LINK, IShare::TYPE_EMAIL], IQueryBuilder::PARAM_INT_ARRAY)),
-					$qb->expr()->lte('expiration', $qb->expr()->literal($now)),
-					$qb->expr()->in('item_type', $qb->createNamedParameter(['file', 'folder'], IQueryBuilder::PARAM_STR_ARRAY))
-				)
-			);
+        $qb = $this->db->getQueryBuilder();
+        $qb->select('id', 'share_type')
+            ->from('share')
+            ->where(
+                $qb->expr()->andX(
+                    $qb->expr()->in('share_type', $qb->createNamedParameter([IShare::TYPE_LINK, IShare::TYPE_EMAIL], IQueryBuilder::PARAM_INT_ARRAY)),
+                    $qb->expr()->lte('expiration', $qb->expr()->literal($now)),
+                    $qb->expr()->in('item_type', $qb->createNamedParameter(['file', 'folder'], IQueryBuilder::PARAM_STR_ARRAY))
+                )
+            );
 
-		$shares = $qb->executeQuery();
-		while ($share = $shares->fetch()) {
-			if ((int)$share['share_type'] === IShare::TYPE_LINK) {
-				$id = 'ocinternal';
-			} elseif ((int)$share['share_type'] === IShare::TYPE_EMAIL) {
-				$id = 'ocMailShare';
-			}
+        $shares = $qb->executeQuery();
+        while ($share = $shares->fetch()) {
+            if ((int)$share['share_type'] === IShare::TYPE_LINK) {
+                $id = 'ocinternal';
+            } elseif ((int)$share['share_type'] === IShare::TYPE_EMAIL) {
+                $id = 'ocMailShare';
+            }
 
-			$id .= ':' . $share['id'];
+            $id .= ':' . $share['id'];
 
-			try {
-				$share = $this->shareManager->getShareById($id);
-				$this->shareManager->deleteShare($share);
-			} catch (ShareNotFound $e) {
-				// Normally the share gets automatically expired on fetching it
-			}
-		}
-		$shares->closeCursor();
-	}
+            try {
+                $share = $this->shareManager->getShareById($id);
+                $this->shareManager->deleteShare($share);
+            } catch (ShareNotFound $e) {
+                // Normally the share gets automatically expired on fetching it
+            }
+        }
+        $shares->closeCursor();
+    }
 }

apps/files/templates/list.php

Spacing +2 added lines, -2 removed lines

@@ -15,7 +15,7 @@ 
 	<?php if (isset($_['dirToken'])):?>
 	<input type="hidden" id="publicUploadRequestToken" name="requesttoken" value="<?php p($_['requesttoken']) ?>" />
 	<input type="hidden" id="dirToken" name="dirToken" value="<?php p($_['dirToken']) ?>" />
-	<?php endif;?>
+	<?php endif; ?>
 	<input type="hidden" class="max_human_file_size"
 		   value="(max <?php isset($_['uploadMaxHumanFilesize']) ? p($_['uploadMaxHumanFilesize']) : ''; ?>)">
 </div>
@@ -75,6 +75,6 @@ 
 </div>
 <div id="uploadsize-message" title="<?php p($l->t('Upload too large'))?>">
 	<p>
-	<?php p($l->t('The files you are trying to upload exceed the maximum size for file uploads on this server.'));?>
+	<?php p($l->t('The files you are trying to upload exceed the maximum size for file uploads on this server.')); ?>
 	</p>
 </div>

apps/dav/templates/schedule-response-success.php

Spacing +1 added lines, -1 removed lines

@@ -5,5 +5,5 @@
 ?>
 <div class="guest-box">
 	<div class="icon icon-checkmark"></div>
-	<p class="message"><?php p($l->t('Your attendance was updated successfully.'));?></p>
+	<p class="message"><?php p($l->t('Your attendance was updated successfully.')); ?></p>
 </div>

apps/dav/templates/schedule-response-error.php

Spacing +2 added lines, -2 removed lines

@@ -6,8 +6,8 @@
 ?>
 <div class="guest-box">
 	<div class="notecard error">
-		<p><?php p($l->t('There was an error updating your attendance status.'));?></p>
-		<p><?php p($l->t('Please contact the organizer directly.'));?></p>
+		<p><?php p($l->t('There was an error updating your attendance status.')); ?></p>
+		<p><?php p($l->t('Please contact the organizer directly.')); ?></p>
 		<?php if (isset($_['organizer'])): ?>
 			<p><a href="<?php p($_['organizer']) ?>"><?php p(substr($_['organizer'], 7)) ?></a></p>
 		<?php endif; ?>

apps/dav/lib/Migration/Version1024Date20211221144219.php

Indentation +38 added lines, -38 removed lines

@@ -17,42 +17,42 @@
  */
 class Version1024Date20211221144219 extends SimpleMigrationStep {
 
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 */
-	public function preSchemaChange(IOutput $output, Closure $schemaClosure, array $options): void {
-	}
-
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 * @throws SchemaException
-	 */
-	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
-		$propertiesTable = $schema->getTable('properties');
-
-		if ($propertiesTable->hasColumn('valuetype')) {
-			return null;
-		}
-		$propertiesTable->addColumn('valuetype', Types::SMALLINT, [
-			'notnull' => false,
-			'default' => CustomPropertiesBackend::PROPERTY_TYPE_STRING
-		]);
-
-		return $schema;
-	}
-
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 */
-	public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options): void {
-	}
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     */
+    public function preSchemaChange(IOutput $output, Closure $schemaClosure, array $options): void {
+    }
+
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     * @throws SchemaException
+     */
+    public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
+        $propertiesTable = $schema->getTable('properties');
+
+        if ($propertiesTable->hasColumn('valuetype')) {
+            return null;
+        }
+        $propertiesTable->addColumn('valuetype', Types::SMALLINT, [
+            'notnull' => false,
+            'default' => CustomPropertiesBackend::PROPERTY_TYPE_STRING
+        ]);
+
+        return $schema;
+    }
+
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     */
+    public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options): void {
+    }
 }

apps/dav/lib/CalDAV/PublicCalendar.php

Indentation +54 added lines, -54 removed lines

@@ -28,63 +28,63 @@
 
 class PublicCalendar extends Calendar {
 
-	/**
-	 * @param string $name
-	 * @throws NotFound
-	 * @return PublicCalendarObject
-	 */
-	public function getChild($name) {
-		$obj = $this->caldavBackend->getCalendarObject($this->calendarInfo['id'], $name);
+    /**
+     * @param string $name
+     * @throws NotFound
+     * @return PublicCalendarObject
+     */
+    public function getChild($name) {
+        $obj = $this->caldavBackend->getCalendarObject($this->calendarInfo['id'], $name);
 
-		if (!$obj) {
-			throw new NotFound('Calendar object not found');
-		}
-		if ($obj['classification'] === CalDavBackend::CLASSIFICATION_PRIVATE) {
-			throw new NotFound('Calendar object not found');
-		}
-		$obj['acl'] = $this->getChildACL();
+        if (!$obj) {
+            throw new NotFound('Calendar object not found');
+        }
+        if ($obj['classification'] === CalDavBackend::CLASSIFICATION_PRIVATE) {
+            throw new NotFound('Calendar object not found');
+        }
+        $obj['acl'] = $this->getChildACL();
 
-		return new PublicCalendarObject($this->caldavBackend, $this->l10n, $this->calendarInfo, $obj);
-	}
+        return new PublicCalendarObject($this->caldavBackend, $this->l10n, $this->calendarInfo, $obj);
+    }
 
-	/**
-	 * @return PublicCalendarObject[]
-	 */
-	public function getChildren() {
-		$objs = $this->caldavBackend->getCalendarObjects($this->calendarInfo['id']);
-		$children = [];
-		foreach ($objs as $obj) {
-			if ($obj['classification'] === CalDavBackend::CLASSIFICATION_PRIVATE) {
-				continue;
-			}
-			$obj['acl'] = $this->getChildACL();
-			$children[] = new PublicCalendarObject($this->caldavBackend, $this->l10n, $this->calendarInfo, $obj);
-		}
-		return $children;
-	}
+    /**
+     * @return PublicCalendarObject[]
+     */
+    public function getChildren() {
+        $objs = $this->caldavBackend->getCalendarObjects($this->calendarInfo['id']);
+        $children = [];
+        foreach ($objs as $obj) {
+            if ($obj['classification'] === CalDavBackend::CLASSIFICATION_PRIVATE) {
+                continue;
+            }
+            $obj['acl'] = $this->getChildACL();
+            $children[] = new PublicCalendarObject($this->caldavBackend, $this->l10n, $this->calendarInfo, $obj);
+        }
+        return $children;
+    }
 
-	/**
-	 * @param string[] $paths
-	 * @return PublicCalendarObject[]
-	 */
-	public function getMultipleChildren(array $paths) {
-		$objs = $this->caldavBackend->getMultipleCalendarObjects($this->calendarInfo['id'], $paths);
-		$children = [];
-		foreach ($objs as $obj) {
-			if ($obj['classification'] === CalDavBackend::CLASSIFICATION_PRIVATE) {
-				continue;
-			}
-			$obj['acl'] = $this->getChildACL();
-			$children[] = new PublicCalendarObject($this->caldavBackend, $this->l10n, $this->calendarInfo, $obj);
-		}
-		return $children;
-	}
+    /**
+     * @param string[] $paths
+     * @return PublicCalendarObject[]
+     */
+    public function getMultipleChildren(array $paths) {
+        $objs = $this->caldavBackend->getMultipleCalendarObjects($this->calendarInfo['id'], $paths);
+        $children = [];
+        foreach ($objs as $obj) {
+            if ($obj['classification'] === CalDavBackend::CLASSIFICATION_PRIVATE) {
+                continue;
+            }
+            $obj['acl'] = $this->getChildACL();
+            $children[] = new PublicCalendarObject($this->caldavBackend, $this->l10n, $this->calendarInfo, $obj);
+        }
+        return $children;
+    }
 
-	/**
-	 * public calendars are always shared
-	 * @return bool
-	 */
-	public function isShared() {
-		return true;
-	}
+    /**
+     * public calendars are always shared
+     * @return bool
+     */
+    public function isShared() {
+        return true;
+    }
 }