Inspection of "Merge pull request #56251 from nextcloud/carl/temp..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aeed32...1ef465 )

unknown

created 2025-12-04 16:27 UTC

Status

Indentation +78 added lines, -78 removed lines patch added patch discarded remove patch

@@ -30,82 +30,82 @@
 block discarded – undo
 
 class TemplateManagerTest extends TestCase {
 
-	private IRootFolder $rootFolder;
-	private Coordinator $bootstrapCoordinator;
-
-	private TemplateManager $templateManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$l10n = $this->createMock(IL10N::class);
-		$l10n->method('t')
-			->willReturnCallback(fn ($string, $params) => sprintf($string, ...$params));
-		$l10nFactory = $this->createMock(IFactory::class);
-		$l10nFactory->method('get')
-			->willReturn($l10n);
-		$database = $this->createMock(IDBConnection::class);
-		$database->method('supports4ByteText')->willReturn(true);
-		$config = $this->createMock(IConfig::class);
-		$logger = new NullLogger();
-
-		$filenameValidator = new FilenameValidator(
-			$l10nFactory,
-			$database,
-			$config,
-			$logger,
-		);
-
-		$serverContainer = $this->createMock(IServerContainer::class);
-		$eventDispatcher = $this->createMock(IEventDispatcher::class);
-		$this->bootstrapCoordinator = $this->createMock(Coordinator::class);
-		$this->bootstrapCoordinator->method('getRegistrationContext')
-			->willReturn(new RegistrationContext($logger));
-		$this->rootFolder = $this->createMock(IRootFolder::class);
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')->willReturn('user1');
-		$userSession = $this->createMock(\OCP\IUserSession::class);
-		$userSession->method('getUser')
-			->willReturn($user);
-		$userManager = $this->createMock(\OCP\IUserManager::class);
-		$previewManager = $this->createMock(IPreview::class);
-
-		$this->templateManager = new TemplateManager(
-			$serverContainer,
-			$eventDispatcher,
-			$this->bootstrapCoordinator,
-			$this->rootFolder,
-			$userSession,
-			$userManager,
-			$previewManager,
-			$config,
-			$l10nFactory,
-			$logger,
-			$filenameValidator
-		);
-	}
-
-	public function testCreateFromTemplateShoudValidateFilename(): void {
-		$this->expectException(GenericFileException::class);
-
-		$fileDirectory = '/';
-		$filePath = $fileDirectory . str_repeat('a', 251);
-
-		$userFolder = $this->createMock(Folder::class);
-		$userFolder->method('get')
-			->willReturnCallback(function ($path) use ($filePath, $fileDirectory) {
-				if ($path === $filePath) {
-					throw new NotFoundException();
-				}
-				return $this->createMock(Folder::class);
-			});
-		$userFolder->method('nodeExists')
-			->willReturnCallback(function ($path) use ($filePath, $fileDirectory) {
-				return $path === $fileDirectory;
-			});
-		$this->rootFolder->method('getUserFolder')
-			->willReturn($userFolder);
-
-		$this->templateManager->createFromTemplate($filePath);
-	}
+    private IRootFolder $rootFolder;
+    private Coordinator $bootstrapCoordinator;
+
+    private TemplateManager $templateManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $l10n = $this->createMock(IL10N::class);
+        $l10n->method('t')
+            ->willReturnCallback(fn ($string, $params) => sprintf($string, ...$params));
+        $l10nFactory = $this->createMock(IFactory::class);
+        $l10nFactory->method('get')
+            ->willReturn($l10n);
+        $database = $this->createMock(IDBConnection::class);
+        $database->method('supports4ByteText')->willReturn(true);
+        $config = $this->createMock(IConfig::class);
+        $logger = new NullLogger();
+
+        $filenameValidator = new FilenameValidator(
+            $l10nFactory,
+            $database,
+            $config,
+            $logger,
+        );
+
+        $serverContainer = $this->createMock(IServerContainer::class);
+        $eventDispatcher = $this->createMock(IEventDispatcher::class);
+        $this->bootstrapCoordinator = $this->createMock(Coordinator::class);
+        $this->bootstrapCoordinator->method('getRegistrationContext')
+            ->willReturn(new RegistrationContext($logger));
+        $this->rootFolder = $this->createMock(IRootFolder::class);
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')->willReturn('user1');
+        $userSession = $this->createMock(\OCP\IUserSession::class);
+        $userSession->method('getUser')
+            ->willReturn($user);
+        $userManager = $this->createMock(\OCP\IUserManager::class);
+        $previewManager = $this->createMock(IPreview::class);
+
+        $this->templateManager = new TemplateManager(
+            $serverContainer,
+            $eventDispatcher,
+            $this->bootstrapCoordinator,
+            $this->rootFolder,
+            $userSession,
+            $userManager,
+            $previewManager,
+            $config,
+            $l10nFactory,
+            $logger,
+            $filenameValidator
+        );
+    }
+
+    public function testCreateFromTemplateShoudValidateFilename(): void {
+        $this->expectException(GenericFileException::class);
+
+        $fileDirectory = '/';
+        $filePath = $fileDirectory . str_repeat('a', 251);
+
+        $userFolder = $this->createMock(Folder::class);
+        $userFolder->method('get')
+            ->willReturnCallback(function ($path) use ($filePath, $fileDirectory) {
+                if ($path === $filePath) {
+                    throw new NotFoundException();
+                }
+                return $this->createMock(Folder::class);
+            });
+        $userFolder->method('nodeExists')
+            ->willReturnCallback(function ($path) use ($filePath, $fileDirectory) {
+                return $path === $fileDirectory;
+            });
+        $this->rootFolder->method('getUserFolder')
+            ->willReturn($userFolder);
+
+        $this->templateManager->createFromTemplate($filePath);
+    }
 }

Please login to merge, or discard this patch.

		@@ -30,82 +30,82 @@
		block discarded – undo
30	30
31	31	class TemplateManagerTest extends TestCase {
32	32
33		- private IRootFolder $rootFolder;
34		- private Coordinator $bootstrapCoordinator;
35		-
36		- private TemplateManager $templateManager;
37		-
38		- protected function setUp(): void {
39		- parent::setUp();
40		-
41		- $l10n = $this->createMock(IL10N::class);
42		- $l10n->method('t')
43		- ->willReturnCallback(fn ($string, $params) => sprintf($string, ...$params));
44		- $l10nFactory = $this->createMock(IFactory::class);
45		- $l10nFactory->method('get')
46		- ->willReturn($l10n);
47		- $database = $this->createMock(IDBConnection::class);
48		- $database->method('supports4ByteText')->willReturn(true);
49		- $config = $this->createMock(IConfig::class);
50		- $logger = new NullLogger();
51		-
52		- $filenameValidator = new FilenameValidator(
53		- $l10nFactory,
54		- $database,
55		- $config,
56		- $logger,
57		- );
58		-
59		- $serverContainer = $this->createMock(IServerContainer::class);
60		- $eventDispatcher = $this->createMock(IEventDispatcher::class);
61		- $this->bootstrapCoordinator = $this->createMock(Coordinator::class);
62		- $this->bootstrapCoordinator->method('getRegistrationContext')
63		- ->willReturn(new RegistrationContext($logger));
64		- $this->rootFolder = $this->createMock(IRootFolder::class);
65		- $user = $this->createMock(IUser::class);
66		- $user->method('getUID')->willReturn('user1');
67		- $userSession = $this->createMock(\OCP\IUserSession::class);
68		- $userSession->method('getUser')
69		- ->willReturn($user);
70		- $userManager = $this->createMock(\OCP\IUserManager::class);
71		- $previewManager = $this->createMock(IPreview::class);
72		-
73		- $this->templateManager = new TemplateManager(
74		- $serverContainer,
75		- $eventDispatcher,
76		- $this->bootstrapCoordinator,
77		- $this->rootFolder,
78		- $userSession,
79		- $userManager,
80		- $previewManager,
81		- $config,
82		- $l10nFactory,
83		- $logger,
84		- $filenameValidator
85		- );
86		- }
87		-
88		- public function testCreateFromTemplateShoudValidateFilename(): void {
89		- $this->expectException(GenericFileException::class);
90		-
91		- $fileDirectory = '/';
92		- $filePath = $fileDirectory . str_repeat('a', 251);
93		-
94		- $userFolder = $this->createMock(Folder::class);
95		- $userFolder->method('get')
96		- ->willReturnCallback(function ($path) use ($filePath, $fileDirectory) {
97		- if ($path === $filePath) {
98		- throw new NotFoundException();
99		- }
100		- return $this->createMock(Folder::class);
101		- });
102		- $userFolder->method('nodeExists')
103		- ->willReturnCallback(function ($path) use ($filePath, $fileDirectory) {
104		- return $path === $fileDirectory;
105		- });
106		- $this->rootFolder->method('getUserFolder')
107		- ->willReturn($userFolder);
108		-
109		- $this->templateManager->createFromTemplate($filePath);
110		- }
	33	+ private IRootFolder $rootFolder;
	34	+ private Coordinator $bootstrapCoordinator;
	35	+
	36	+ private TemplateManager $templateManager;
	37	+
	38	+ protected function setUp(): void {
	39	+ parent::setUp();
	40	+
	41	+ $l10n = $this->createMock(IL10N::class);
	42	+ $l10n->method('t')
	43	+ ->willReturnCallback(fn ($string, $params) => sprintf($string, ...$params));
	44	+ $l10nFactory = $this->createMock(IFactory::class);
	45	+ $l10nFactory->method('get')
	46	+ ->willReturn($l10n);
	47	+ $database = $this->createMock(IDBConnection::class);
	48	+ $database->method('supports4ByteText')->willReturn(true);
	49	+ $config = $this->createMock(IConfig::class);
	50	+ $logger = new NullLogger();
	51	+
	52	+ $filenameValidator = new FilenameValidator(
	53	+ $l10nFactory,
	54	+ $database,
	55	+ $config,
	56	+ $logger,
	57	+ );
	58	+
	59	+ $serverContainer = $this->createMock(IServerContainer::class);
	60	+ $eventDispatcher = $this->createMock(IEventDispatcher::class);
	61	+ $this->bootstrapCoordinator = $this->createMock(Coordinator::class);
	62	+ $this->bootstrapCoordinator->method('getRegistrationContext')
	63	+ ->willReturn(new RegistrationContext($logger));
	64	+ $this->rootFolder = $this->createMock(IRootFolder::class);
	65	+ $user = $this->createMock(IUser::class);
	66	+ $user->method('getUID')->willReturn('user1');
	67	+ $userSession = $this->createMock(\OCP\IUserSession::class);
	68	+ $userSession->method('getUser')
	69	+ ->willReturn($user);
	70	+ $userManager = $this->createMock(\OCP\IUserManager::class);
	71	+ $previewManager = $this->createMock(IPreview::class);
	72	+
	73	+ $this->templateManager = new TemplateManager(
	74	+ $serverContainer,
	75	+ $eventDispatcher,
	76	+ $this->bootstrapCoordinator,
	77	+ $this->rootFolder,
	78	+ $userSession,
	79	+ $userManager,
	80	+ $previewManager,
	81	+ $config,
	82	+ $l10nFactory,
	83	+ $logger,
	84	+ $filenameValidator
	85	+ );
	86	+ }
	87	+
	88	+ public function testCreateFromTemplateShoudValidateFilename(): void {
	89	+ $this->expectException(GenericFileException::class);
	90	+
	91	+ $fileDirectory = '/';
	92	+ $filePath = $fileDirectory . str_repeat('a', 251);
	93	+
	94	+ $userFolder = $this->createMock(Folder::class);
	95	+ $userFolder->method('get')
	96	+ ->willReturnCallback(function ($path) use ($filePath, $fileDirectory) {
	97	+ if ($path === $filePath) {
	98	+ throw new NotFoundException();
	99	+ }
	100	+ return $this->createMock(Folder::class);
	101	+ });
	102	+ $userFolder->method('nodeExists')
	103	+ ->willReturnCallback(function ($path) use ($filePath, $fileDirectory) {
	104	+ return $path === $fileDirectory;
	105	+ });
	106	+ $this->rootFolder->method('getUserFolder')
	107	+ ->willReturn($userFolder);
	108	+
	109	+ $this->templateManager->createFromTemplate($filePath);
	110	+ }
111	111	}

nextcloud / server

Push — master ( aeed32...1ef465 )

Status

Category

Indentation +78 added lines, -78 removed lines patch added patch discarded remove patch