nextcloud / server

lib/private/Settings/Manager.php

Doc Comments +6 added lines

@@ -273,6 +273,9 @@ 
 		return $this->mapper->has($table, 'section', $sectionId);
 	}
 
+	/**
+	 * @param string $type
+	 */
 	private function setupSettingsEntry($settingsClassName, $type) {
 		if (!class_exists($settingsClassName)) {
 			$this->log->debug('Could not find ' . $type . ' section class ' . $settingsClassName);
@@ -302,6 +305,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $type
+	 */
 	private function getSectionTableForType($type) {
 		if($type === 'admin') {
 			return Mapper::TABLE_ADMIN_SECTIONS;

Spacing +12 added lines, -12 removed lines

@@ -188,7 +188,7 @@ 
 	 */
 	private function setupSectionEntry($sectionClassName, $type) {
 		if (!class_exists($sectionClassName)) {
-			$this->log->debug('Could not find ' . ucfirst($type) . ' section class ' . $sectionClassName);
+			$this->log->debug('Could not find '.ucfirst($type).' section class '.$sectionClassName);
 			return;
 		}
 		try {
@@ -200,13 +200,13 @@ 
 
 		if (!$section instanceof ISection) {
 			$this->log->error(
-				ucfirst($type) .' section instance must implement \OCP\ISection. Invalid class: {class}',
+				ucfirst($type).' section instance must implement \OCP\ISection. Invalid class: {class}',
 				['class' => $sectionClassName]
 			);
 			return;
 		}
 		$table = $this->getSectionTableForType($type);
-		if(!$this->hasSection($section->getID(), $table)) {
+		if (!$this->hasSection($section->getID(), $table)) {
 			$this->addSection($section, $table);
 		} else {
 			$this->updateSection($section, $table);
@@ -275,7 +275,7 @@ 
 
 	private function setupSettingsEntry($settingsClassName, $type) {
 		if (!class_exists($settingsClassName)) {
-			$this->log->debug('Could not find ' . $type . ' section class ' . $settingsClassName);
+			$this->log->debug('Could not find '.$type.' section class '.$settingsClassName);
 			return;
 		}
 
@@ -289,7 +289,7 @@ 
 
 		if (!$settings instanceof ISettings) {
 			$this->log->error(
-				ucfirst($type) . ' section instance must implement \OCP\Settings\ISettings. Invalid class: {class}',
+				ucfirst($type).' section instance must implement \OCP\Settings\ISettings. Invalid class: {class}',
 				['class' => $settingsClassName]
 			);
 			return;
@@ -303,18 +303,18 @@ 
 	}
 
 	private function getSectionTableForType($type) {
-		if($type === 'admin') {
+		if ($type === 'admin') {
 			return Mapper::TABLE_ADMIN_SECTIONS;
-		} else if($type === 'personal') {
+		} else if ($type === 'personal') {
 			return Mapper::TABLE_PERSONAL_SECTIONS;
 		}
 		throw new \InvalidArgumentException('"admin" or "personal" expected');
 	}
 
 	private function getSettingsTableForType($type) {
-		if($type === 'admin') {
+		if ($type === 'admin') {
 			return Mapper::TABLE_ADMIN_SETTINGS;
-		} else if($type === 'personal') {
+		} else if ($type === 'personal') {
 			return Mapper::TABLE_PERSONAL_SETTINGS;
 		}
 		throw new \InvalidArgumentException('"admin" or "personal" expected');
@@ -421,7 +421,7 @@ 
 				);
 				$forms[$form->getPriority()] = [$form];
 			}
-			if($section === 'security') {
+			if ($section === 'security') {
 				/** @var ISettings $form */
 				$form = new Personal\Security();
 				$forms[$form->getPriority()] = [$form];
@@ -470,7 +470,7 @@ 
 		];
 
 		$legacyForms = \OC_App::getForms('personal');
-		if(count($legacyForms) > 0 && $this->hasLegacyPersonalSettingsToRender($legacyForms)) {
+		if (count($legacyForms) > 0 && $this->hasLegacyPersonalSettingsToRender($legacyForms)) {
 			$sections[98] = [new Section('additional', $this->l->t('Additional settings'), 0, $this->url->imagePath('core', 'actions/settings-dark.svg'))];
 		}
 
@@ -498,7 +498,7 @@ 
 	 */
 	private function hasLegacyPersonalSettingsToRender($forms) {
 		foreach ($forms as $form) {
-			if(trim($form) !== '') {
+			if (trim($form) !== '') {
 				return true;
 			}
 		}