Passed
Push — master ( 3cf321...e1a11b )
by Christoph
11:45 queued 13s
created
apps/user_ldap/ajax/clearMappings.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -31,25 +31,25 @@
 block discarded – undo
31 31
 \OC_JSON::checkAppEnabled('user_ldap');
32 32
 \OC_JSON::callCheck();
33 33
 
34
-$subject = (string)$_POST['ldap_clear_mapping'];
34
+$subject = (string) $_POST['ldap_clear_mapping'];
35 35
 $mapping = null;
36 36
 try {
37
-	if($subject === 'user') {
37
+	if ($subject === 'user') {
38 38
 		$mapping = new UserMapping(\OC::$server->getDatabaseConnection());
39 39
 		$result = $mapping->clearCb(
40
-			function ($uid) {
40
+			function($uid) {
41 41
 				\OC::$server->getUserManager()->emit('\OC\User', 'preUnassignedUserId', [$uid]);
42 42
 			},
43
-			function ($uid) {
43
+			function($uid) {
44 44
 				\OC::$server->getUserManager()->emit('\OC\User', 'postUnassignedUserId', [$uid]);
45 45
 			}
46 46
 		);
47
-	} else if($subject === 'group') {
47
+	} else if ($subject === 'group') {
48 48
 		$mapping = new GroupMapping(\OC::$server->getDatabaseConnection());
49 49
 		$result = $mapping->clear();
50 50
 	}
51 51
 
52
-	if($mapping === null || !$result) {
52
+	if ($mapping === null || !$result) {
53 53
 		$l = \OC::$server->getL10N('user_ldap');
54 54
 		throw new \Exception($l->t('Failed to clear the mappings.'));
55 55
 	}
Please login to merge, or discard this patch.
lib/public/AppFramework/Http/Template/LinkMenuAction.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -51,16 +51,16 @@
 block discarded – undo
51 51
 	 * @since 14.0.0
52 52
 	 */
53 53
 	public function render(): string {
54
-		return '<li>' .
55
-			'<a id="directLink-container">' .
56
-			'<span class="icon ' . Util::sanitizeHTML($this->getIcon()) . '"></span>' .
57
-			'<label for="directLink">' . Util::sanitizeHTML($this->getLabel()) . '</label>' .
58
-			'</a>' .
59
-			'</li>' .
60
-			'<li>' .
61
-			'<span class="menuitem">' .
62
-			'<input id="directLink" type="text" readonly="" value="' . Util::sanitizeHTML($this->getLink()) . '">' .
63
-			'</span>' .
54
+		return '<li>'.
55
+			'<a id="directLink-container">'.
56
+			'<span class="icon '.Util::sanitizeHTML($this->getIcon()).'"></span>'.
57
+			'<label for="directLink">'.Util::sanitizeHTML($this->getLabel()).'</label>'.
58
+			'</a>'.
59
+			'</li>'.
60
+			'<li>'.
61
+			'<span class="menuitem">'.
62
+			'<input id="directLink" type="text" readonly="" value="'.Util::sanitizeHTML($this->getLink()).'">'.
63
+			'</span>'.
64 64
 			'</li>';
65 65
 	}
66 66
 }
Please login to merge, or discard this patch.
apps/files_sharing/lib/BackgroundJob/FederatedSharesDiscoverJob.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 			->from('share_external');
28 28
 
29 29
 		$result = $qb->execute();
30
-		while($row = $result->fetch()) {
30
+		while ($row = $result->fetch()) {
31 31
 			$this->discoveryService->discover($row['remote'], 'FEDERATED_SHARING', true);
32 32
 		}
33 33
 		$result->closeCursor();
Please login to merge, or discard this patch.
core/Command/Log/File.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@
 block discarded – undo
105 105
 		$defaultLogFile = rtrim($dataDir, '/').'/nextcloud.log';
106 106
 		$output->writeln('Log file: '.$this->config->getSystemValue('logfile', $defaultLogFile));
107 107
 
108
-		$rotateSize = $this->config->getSystemValue('log_rotate_size', 100*1024*1024);
108
+		$rotateSize = $this->config->getSystemValue('log_rotate_size', 100 * 1024 * 1024);
109 109
 		if ($rotateSize) {
110 110
 			$rotateString = \OCP\Util::humanFileSize($rotateSize);
111 111
 		} else {
Please login to merge, or discard this patch.
lib/private/Lock/DBLockingProvider.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
 		}
155 155
 		$query = $this->connection->prepare('SELECT `lock` from `*PREFIX*file_locks` WHERE `key` = ?');
156 156
 		$query->execute([$path]);
157
-		$lockValue = (int)$query->fetchColumn();
157
+		$lockValue = (int) $query->fetchColumn();
158 158
 		if ($type === self::LOCK_SHARED) {
159 159
 			if ($this->isLocallyLocked($path)) {
160 160
 				// if we have a shared lock we kept open locally but it's released we always have at least 1 shared lock in the db
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
 		}
292 292
 		// since we keep shared locks we need to manually clean those
293 293
 		$lockedPaths = array_keys($this->sharedLocks);
294
-		$lockedPaths = array_filter($lockedPaths, function ($path) {
294
+		$lockedPaths = array_filter($lockedPaths, function($path) {
295 295
 			return $this->sharedLocks[$path];
296 296
 		});
297 297
 
Please login to merge, or discard this patch.
core/Command/Db/Migrations/StatusCommand.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -59,10 +59,10 @@
 block discarded – undo
59 59
 			if (is_array($value)) {
60 60
 				$output->writeln("    <comment>>></comment> $key:");
61 61
 				foreach ($value as $subKey => $subValue) {
62
-					$output->writeln("        <comment>>></comment> $subKey: " . str_repeat(' ', 46 - strlen($subKey)) . $subValue);
62
+					$output->writeln("        <comment>>></comment> $subKey: ".str_repeat(' ', 46 - strlen($subKey)).$subValue);
63 63
 				}
64 64
 			} else {
65
-				$output->writeln("    <comment>>></comment> $key: " . str_repeat(' ', 50 - strlen($key)) . $value);
65
+				$output->writeln("    <comment>>></comment> $key: ".str_repeat(' ', 50 - strlen($key)).$value);
66 66
 			}
67 67
 		}
68 68
 	}
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/QuotaPlugin.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 			return;
93 93
 		}
94 94
 
95
-		return $this->checkQuota($parent->getPath() . '/' . basename($uri));
95
+		return $this->checkQuota($parent->getPath().'/'.basename($uri));
96 96
 	}
97 97
 
98 98
 	/**
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 
153 153
 		if ($length) {
154 154
 			list($parentPath, $newName) = \Sabre\Uri\split($path);
155
-			if(is_null($parentPath)) {
155
+			if (is_null($parentPath)) {
156 156
 				$parentPath = '';
157 157
 			}
158 158
 			$req = $this->server->httpRequest;
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 				// there is still enough space for the remaining chunks
164 164
 				$length -= $chunkHandler->getCurrentSize();
165 165
 				// use target file name for free space check in case of shared files
166
-				$path = rtrim($parentPath, '/') . '/' . $info['name'];
166
+				$path = rtrim($parentPath, '/').'/'.$info['name'];
167 167
 			}
168 168
 			$freeSpace = $this->getFreeSpace($path);
169 169
 			if ($freeSpace >= 0 && $length > $freeSpace) {
Please login to merge, or discard this patch.
apps/files_external/lib/Service/LegacyStoragesService.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 	) {
59 59
 		$backend = $this->backendService->getBackend($storageOptions['backend']);
60 60
 		if (!$backend) {
61
-			throw new \UnexpectedValueException('Invalid backend ' . $storageOptions['backend']);
61
+			throw new \UnexpectedValueException('Invalid backend '.$storageOptions['backend']);
62 62
 		}
63 63
 		$storageConfig->setBackend($backend);
64 64
 		if (isset($storageOptions['authMechanism']) && $storageOptions['authMechanism'] !== 'builtin::builtin') {
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 			$storageOptions['authMechanism'] = 'null'; // to make error handling easier
69 69
 		}
70 70
 		if (!$authMechanism) {
71
-			throw new \UnexpectedValueException('Invalid authentication mechanism ' . $storageOptions['authMechanism']);
71
+			throw new \UnexpectedValueException('Invalid authentication mechanism '.$storageOptions['authMechanism']);
72 72
 		}
73 73
 		$storageConfig->setAuthMechanism($authMechanism);
74 74
 		$storageConfig->setBackendOptions($storageOptions['options']);
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 					$parts = explode('/', ltrim($rootMountPath, '/'), 3);
141 141
 					if (count($parts) < 3) {
142 142
 						// something went wrong, skip
143
-						\OC::$server->getLogger()->error('Could not parse mount point "' . $rootMountPath . '"', ['app' => 'files_external']);
143
+						\OC::$server->getLogger()->error('Could not parse mount point "'.$rootMountPath.'"', ['app' => 'files_external']);
144 144
 						continue;
145 145
 					}
146 146
 					$relativeMountPath = rtrim($parts[2], '/');
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
 						$storageOptions['authMechanism'] = null; // ensure config hash works
155 155
 					}
156 156
 					if (isset($storageOptions['id'])) {
157
-						$configId = (int)$storageOptions['id'];
157
+						$configId = (int) $storageOptions['id'];
158 158
 						if (isset($storages[$configId])) {
159 159
 							$currentStorage = $storages[$configId];
160 160
 						}
Please login to merge, or discard this patch.
apps/federation/lib/Controller/OCSAuthAPIController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
  *
48 48
  * @package OCA\Federation\Controller
49 49
  */
50
-class OCSAuthAPIController extends OCSController{
50
+class OCSAuthAPIController extends OCSController {
51 51
 
52 52
 	/** @var ISecureRandom  */
53 53
 	private $secureRandom;
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 	 */
144 144
 	public function requestSharedSecret($url, $token) {
145 145
 		if ($this->trustedServers->isTrustedServer($url) === false) {
146
-			$this->logger->error('remote server not trusted (' . $url . ') while requesting shared secret', ['app' => 'federation']);
146
+			$this->logger->error('remote server not trusted ('.$url.') while requesting shared secret', ['app' => 'federation']);
147 147
 			throw new OCSForbiddenException();
148 148
 		}
149 149
 
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 		$localToken = $this->dbHandler->getToken($url);
153 153
 		if (strcmp($localToken, $token) > 0) {
154 154
 			$this->logger->info(
155
-				'remote server (' . $url . ') presented lower token. We will initiate the exchange of the shared secret.',
155
+				'remote server ('.$url.') presented lower token. We will initiate the exchange of the shared secret.',
156 156
 				['app' => 'federation']
157 157
 			);
158 158
 			throw new OCSForbiddenException();
@@ -184,14 +184,14 @@  discard block
 block discarded – undo
184 184
 	public function getSharedSecret($url, $token) {
185 185
 
186 186
 		if ($this->trustedServers->isTrustedServer($url) === false) {
187
-			$this->logger->error('remote server not trusted (' . $url . ') while getting shared secret', ['app' => 'federation']);
187
+			$this->logger->error('remote server not trusted ('.$url.') while getting shared secret', ['app' => 'federation']);
188 188
 			throw new OCSForbiddenException();
189 189
 		}
190 190
 
191 191
 		if ($this->isValidToken($url, $token) === false) {
192 192
 			$expectedToken = $this->dbHandler->getToken($url);
193 193
 			$this->logger->error(
194
-				'remote server (' . $url . ') didn\'t send a valid token (got "' . $token . '" but expected "'. $expectedToken . '") while getting shared secret',
194
+				'remote server ('.$url.') didn\'t send a valid token (got "'.$token.'" but expected "'.$expectedToken.'") while getting shared secret',
195 195
 				['app' => 'federation']
196 196
 			);
197 197
 			throw new OCSForbiddenException();
Please login to merge, or discard this patch.