ResetPassword::execute() - Code Metrics - Inspection of "Merge pull request #31889 from nextcloud/feature/n..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c233ac...ceefe0 )

by Joas

created 2022-04-13 06:03 UTC

ResetPassword::execute() B

↳ Parent: ResetPassword

Complexity

Conditions	11
Paths	17

Size

Total Lines	67
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	11
eloc	44
c	0
b	0
f	0
nc	17
nop	2
dl	0
loc	67
rs	7.3166

How to fix Long Method Complexity

<?php
/**
 * @copyright Copyright (c) 2016, ownCloud, Inc.
 *
 * @author Andreas Fischer <[email protected]>
 * @author Christopher Schäpers <[email protected]>
 * @author Clark Tomlinson <[email protected]>
 * @author Joas Schilling <[email protected]>
 * @author Laurens Post <[email protected]>
 * @author Roeland Jago Douma <[email protected]>
 * @author Sujith H <[email protected]>
 *
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program. If not, see <http://www.gnu.org/licenses/>
 *
 */
namespace OC\Core\Command\User;

use OC\Core\Command\Base;
use OCP\IUser;
use OCP\IUserManager;
use Stecman\Component\Symfony\Console\BashCompletion\CompletionContext;
use Symfony\Component\Console\Helper\QuestionHelper;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ConfirmationQuestion;
use Symfony\Component\Console\Question\Question;

class ResetPassword extends Base {

	/** @var IUserManager */
	protected $userManager;

	public function __construct(IUserManager $userManager) {
		$this->userManager = $userManager;
		parent::__construct();
	}

	protected function configure() {
		$this
			->setName('user:resetpassword')
			->setDescription('Resets the password of the named user')
			->addArgument(
				'user',
				InputArgument::REQUIRED,
				'Username to reset password'
			)
			->addOption(
				'password-from-env',
				null,
				InputOption::VALUE_NONE,
				'read password from environment variable OC_PASS'
			)
		;
	}

	protected function execute(InputInterface $input, OutputInterface $output): int {
		$username = $input->getArgument('user');

		$user = $this->userManager->get($username);
		if (is_null($user)) {
			$output->writeln('<error>User does not exist</error>');
			return 1;
		}

		if ($input->getOption('password-from-env')) {
			$password = getenv('OC_PASS');
			if (!$password) {
				$output->writeln('<error>--password-from-env given, but OC_PASS is empty!</error>');
				return 1;
			}
		} elseif ($input->isInteractive()) {
			/** @var QuestionHelper $helper */
			$helper = $this->getHelper('question');

			if (\OCP\App::isEnabled('encryption')) {
				$output->writeln(
					'<error>Warning: Resetting the password when using encryption will result in data loss!</error>'
				);

				$question = new ConfirmationQuestion('Do you want to continue?');
				if (!$helper->ask($input, $output, $question)) {
					return 1;
				}
			}

			$question = new Question('Enter a new password: ');
			$question->setHidden(true);
			$password = $helper->ask($input, $output, $question);

			if ($password === null) {
				$output->writeln("<error>Password cannot be empty!</error>");
				return 1;
			}

			$question = new Question('Confirm the new password: ');
			$question->setHidden(true);
			$confirm = $helper->ask($input, $output, $question);

			if ($password !== $confirm) {
				$output->writeln("<error>Passwords did not match!</error>");
				return 1;
			}
		} else {
			$output->writeln("<error>Interactive input or --password-from-env is needed for entering a new password!</error>");
			return 1;
		}


		try {
			$success = $user->setPassword($password);
		} catch (\Exception $e) {
			$output->writeln('<error>' . $e->getMessage() . '</error>');
			return 1;
		}

		if ($success) {
			$output->writeln("<info>Successfully reset password for " . $username . "</info>");
		} else {
			$output->writeln("<error>Error while resetting password!</error>");
			return 1;
		}
		return 0;
	}

	/**
	 * @param string $argumentName
	 * @param CompletionContext $context
	 * @return string[]
	 */
	public function completeArgumentValues($argumentName, CompletionContext $context) {
		if ($argumentName === 'user') {
			return array_map(static fn (IUser $user) => $user->getUID(), $this->userManager->search($context->getCurrentWord()));
		}
		return [];
	}
}


1			<?php
2			/**
3			* @copyright Copyright (c) 2016, ownCloud, Inc.
4			*
5			* @author Andreas Fischer <[email protected]>
6			* @author Christopher Schäpers <[email protected]>
7			* @author Clark Tomlinson <[email protected]>
8			* @author Joas Schilling <[email protected]>
9			* @author Laurens Post <[email protected]>
10			* @author Roeland Jago Douma <[email protected]>
11			* @author Sujith H <[email protected]>
12			*
13			* @license AGPL-3.0
14			*
15			* This code is free software: you can redistribute it and/or modify
16			* it under the terms of the GNU Affero General Public License, version 3,
17			* as published by the Free Software Foundation.
18			*
19			* This program is distributed in the hope that it will be useful,
20			* but WITHOUT ANY WARRANTY; without even the implied warranty of
21			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
22			* GNU Affero General Public License for more details.
23			*
24			* You should have received a copy of the GNU Affero General Public License, version 3,
25			* along with this program. If not, see <http://www.gnu.org/licenses/>
26			*
27			*/
28			namespace OC\Core\Command\User;
29
30			use OC\Core\Command\Base;
31			use OCP\IUser;
32			use OCP\IUserManager;
33			use Stecman\Component\Symfony\Console\BashCompletion\CompletionContext;
34			use Symfony\Component\Console\Helper\QuestionHelper;
35			use Symfony\Component\Console\Input\InputArgument;
36			use Symfony\Component\Console\Input\InputInterface;
37			use Symfony\Component\Console\Input\InputOption;
38			use Symfony\Component\Console\Output\OutputInterface;
39			use Symfony\Component\Console\Question\ConfirmationQuestion;
40			use Symfony\Component\Console\Question\Question;
41
42			class ResetPassword extends Base {
43
44			/** @var IUserManager */
45			protected $userManager;
46
47			public function __construct(IUserManager $userManager) {
48			$this->userManager = $userManager;
49			parent::__construct();
50			}
51
52			protected function configure() {
53			$this
54			->setName('user:resetpassword')
55			->setDescription('Resets the password of the named user')
56			->addArgument(
57			'user',
58			InputArgument::REQUIRED,
59			'Username to reset password'
60			)
61			->addOption(
62			'password-from-env',
63			null,
64			InputOption::VALUE_NONE,
65			'read password from environment variable OC_PASS'
66			)
67			;
68			}
69
70			protected function execute(InputInterface $input, OutputInterface $output): int {
71			$username = $input->getArgument('user');
72
73			$user = $this->userManager->get($username);
74			if (is_null($user)) {
75			$output->writeln('<error>User does not exist</error>');
76			return 1;
77			}
78
79			if ($input->getOption('password-from-env')) {
80			$password = getenv('OC_PASS');
81			if (!$password) {
82			$output->writeln('<error>--password-from-env given, but OC_PASS is empty!</error>');
83			return 1;
84			}
85			} elseif ($input->isInteractive()) {
86			/** @var QuestionHelper $helper */
87			$helper = $this->getHelper('question');
88
89			if (\OCP\App::isEnabled('encryption')) {
90			$output->writeln(
91			'<error>Warning: Resetting the password when using encryption will result in data loss!</error>'
92			);
93
94			$question = new ConfirmationQuestion('Do you want to continue?');
95			if (!$helper->ask($input, $output, $question)) {
96			return 1;
97			}
98			}
99
100			$question = new Question('Enter a new password: ');
101			$question->setHidden(true);
102			$password = $helper->ask($input, $output, $question);
103
104			if ($password === null) {
105			$output->writeln("<error>Password cannot be empty!</error>");
106			return 1;
107			}
108
109			$question = new Question('Confirm the new password: ');
110			$question->setHidden(true);
111			$confirm = $helper->ask($input, $output, $question);
112
113			if ($password !== $confirm) {
114			$output->writeln("<error>Passwords did not match!</error>");
115			return 1;
116			}
117			} else {
118			$output->writeln("<error>Interactive input or --password-from-env is needed for entering a new password!</error>");
119			return 1;
120			}
121
122
123			try {
124			$success = $user->setPassword($password);
125			} catch (\Exception $e) {
126			$output->writeln('<error>' . $e->getMessage() . '</error>');
127			return 1;
128			}
129
130			if ($success) {
131			$output->writeln("<info>Successfully reset password for " . $username . "</info>");
132			} else {
133			$output->writeln("<error>Error while resetting password!</error>");
134			return 1;
135			}
136			return 0;
137			}
138
139			/**
140			* @param string $argumentName
141			* @param CompletionContext $context
142			* @return string[]
143			*/
144			public function completeArgumentValues($argumentName, CompletionContext $context) {
145			if ($argumentName === 'user') {
146			return array_map(static fn (IUser $user) => $user->getUID(), $this->userManager->search($context->getCurrentWord()));
147			}
148			return [];
149			}
150			}
151

nextcloud / server

Push — master ( c233ac...ceefe0 )

ResetPassword::execute() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like