nextcloud / server

lib/public/AppFramework/Http/Template/SimpleMenuAction.php

Spacing +1 added lines, -1 removed lines

@@ -164,7 +164,7 @@
 	 * @since 14.0.0
 	 */
 	public function render(): string {
-		$detailContent = ($this->detail !== '') ? '&nbsp;<span class="download-size">(' . Util::sanitizeHTML($this->detail) . ')</span>' : '';
+		$detailContent = ($this->detail !== '') ? '&nbsp;<span class="download-size">('.Util::sanitizeHTML($this->detail).')</span>' : '';
 		return sprintf(
 			'<li id="%s"><a href="%s"><span class="icon %s"></span>%s %s</a></li>',
 			Util::sanitizeHTML($this->id), Util::sanitizeHTML($this->link), Util::sanitizeHTML($this->icon), Util::sanitizeHTML($this->label), $detailContent

Indentation +77 added lines, -77 removed lines

@@ -32,93 +32,93 @@
  */
 class SimpleMenuAction implements IMenuAction {
 
-	/** @var string */
-	private $id;
+    /** @var string */
+    private $id;
 
-	/** @var string */
-	private $label;
+    /** @var string */
+    private $label;
 
-	/** @var string */
-	private $icon;
+    /** @var string */
+    private $icon;
 
-	/** @var string */
-	private $link;
+    /** @var string */
+    private $link;
 
-	/** @var int */
-	private $priority;
+    /** @var int */
+    private $priority;
 
-	/** @var string */
-	private $detail;
+    /** @var string */
+    private $detail;
 
-	/**
-	 * SimpleMenuAction constructor.
-	 *
-	 * @param string $id
-	 * @param string $label
-	 * @param string $icon
-	 * @param string $link
-	 * @param int $priority
-	 * @param string $detail
-	 * @since 14.0.0
-	 */
-	public function __construct(string $id, string $label, string $icon, string $link = '', int $priority = 100, string $detail = '') {
-		$this->id = $id;
-		$this->label = $label;
-		$this->icon = $icon;
-		$this->link = $link;
-		$this->priority = $priority;
-		$this->detail = $detail;
-	}
+    /**
+     * SimpleMenuAction constructor.
+     *
+     * @param string $id
+     * @param string $label
+     * @param string $icon
+     * @param string $link
+     * @param int $priority
+     * @param string $detail
+     * @since 14.0.0
+     */
+    public function __construct(string $id, string $label, string $icon, string $link = '', int $priority = 100, string $detail = '') {
+        $this->id = $id;
+        $this->label = $label;
+        $this->icon = $icon;
+        $this->link = $link;
+        $this->priority = $priority;
+        $this->detail = $detail;
+    }
 
-	/**
-	 * @return string
-	 * @since 14.0.0
-	 */
-	public function getId(): string {
-		return $this->id;
-	}
+    /**
+     * @return string
+     * @since 14.0.0
+     */
+    public function getId(): string {
+        return $this->id;
+    }
 
-	/**
-	 * @return string
-	 * @since 14.0.0
-	 */
-	public function getLabel(): string {
-		return $this->label;
-	}
+    /**
+     * @return string
+     * @since 14.0.0
+     */
+    public function getLabel(): string {
+        return $this->label;
+    }
 
-	/**
-	 * @return string
-	 * @since 14.0.0
-	 */
-	public function getIcon(): string {
-		return $this->icon;
-	}
+    /**
+     * @return string
+     * @since 14.0.0
+     */
+    public function getIcon(): string {
+        return $this->icon;
+    }
 
-	/**
-	 * @return string
-	 * @since 14.0.0
-	 */
-	public function getLink(): string {
-		return $this->link;
-	}
+    /**
+     * @return string
+     * @since 14.0.0
+     */
+    public function getLink(): string {
+        return $this->link;
+    }
 
-	/**
-	 * @return int
-	 * @since 14.0.0
-	 */
-	public function getPriority(): int {
-		return $this->priority;
-	}
+    /**
+     * @return int
+     * @since 14.0.0
+     */
+    public function getPriority(): int {
+        return $this->priority;
+    }
 
-	/**
-	 * @return string
-	 * @since 14.0.0
-	 */
-	public function render(): string {
-		$detailContent = ($this->detail !== '') ? '&nbsp;<span class="download-size">(' . Util::sanitizeHTML($this->detail) . ')</span>' : '';
-		return sprintf(
-			'<li id="%s"><a href="%s"><span class="icon %s"></span>%s %s</a></li>',
-			Util::sanitizeHTML($this->id), Util::sanitizeHTML($this->link), Util::sanitizeHTML($this->icon), Util::sanitizeHTML($this->label), $detailContent
-		);
-	}
+    /**
+     * @return string
+     * @since 14.0.0
+     */
+    public function render(): string {
+        $detailContent = ($this->detail !== '') ? '&nbsp;<span class="download-size">(' . Util::sanitizeHTML($this->detail) . ')</span>' : '';
+        return sprintf(
+            '<li id="%s"><a href="%s"><span class="icon %s"></span>%s %s</a></li>',
+            Util::sanitizeHTML($this->id), Util::sanitizeHTML($this->link), Util::sanitizeHTML($this->icon), Util::sanitizeHTML($this->label), $detailContent
+        );
+    }
 }

apps/comments/lib/Activity/Listener.php

Spacing +3 added lines, -3 removed lines

@@ -84,7 +84,7 @@ 
 
 		// Get all mount point owners
 		$cache = $this->mountCollection->getMountCache();
-		$mounts = $cache->getMountsForFileId((int)$event->getComment()->getObjectId());
+		$mounts = $cache->getMountsForFileId((int) $event->getComment()->getObjectId());
 		if (empty($mounts)) {
 			return;
 		}
@@ -93,7 +93,7 @@ 
 		foreach ($mounts as $mount) {
 			$owner = $mount->getUser()->getUID();
 			$ownerFolder = $this->rootFolder->getUserFolder($owner);
-			$nodes = $ownerFolder->getById((int)$event->getComment()->getObjectId());
+			$nodes = $ownerFolder->getById((int) $event->getComment()->getObjectId());
 			if (!empty($nodes)) {
 				/** @var Node $node */
 				$node = array_shift($nodes);
@@ -121,7 +121,7 @@ 
 		foreach ($users as $user => $path) {
 			// numerical user ids end up as integers from array keys, but string
 			// is required
-			$activity->setAffectedUser((string)$user);
+			$activity->setAffectedUser((string) $user);
 
 			$activity->setSubject('add_comment_subject', [
 				'actor' => $actor,

Indentation +76 added lines, -76 removed lines

@@ -35,88 +35,88 @@
 use OCP\Share\IShareHelper;
 
 class Listener {
-	protected IManager $activityManager;
-	protected IUserSession $session;
-	protected IAppManager $appManager;
-	protected IMountProviderCollection $mountCollection;
-	protected IRootFolder $rootFolder;
-	protected IShareHelper $shareHelper;
+    protected IManager $activityManager;
+    protected IUserSession $session;
+    protected IAppManager $appManager;
+    protected IMountProviderCollection $mountCollection;
+    protected IRootFolder $rootFolder;
+    protected IShareHelper $shareHelper;
 
-	/**
-	 * Listener constructor.
-	 */
-	public function __construct(IManager $activityManager,
-								IUserSession $session,
-								IAppManager $appManager,
-								IMountProviderCollection $mountCollection,
-								IRootFolder $rootFolder,
-								IShareHelper $shareHelper) {
-		$this->activityManager = $activityManager;
-		$this->session = $session;
-		$this->appManager = $appManager;
-		$this->mountCollection = $mountCollection;
-		$this->rootFolder = $rootFolder;
-		$this->shareHelper = $shareHelper;
-	}
+    /**
+     * Listener constructor.
+     */
+    public function __construct(IManager $activityManager,
+                                IUserSession $session,
+                                IAppManager $appManager,
+                                IMountProviderCollection $mountCollection,
+                                IRootFolder $rootFolder,
+                                IShareHelper $shareHelper) {
+        $this->activityManager = $activityManager;
+        $this->session = $session;
+        $this->appManager = $appManager;
+        $this->mountCollection = $mountCollection;
+        $this->rootFolder = $rootFolder;
+        $this->shareHelper = $shareHelper;
+    }
 
-	/**
-	 * @param CommentsEvent $event
-	 */
-	public function commentEvent(CommentsEvent $event) {
-		if ($event->getComment()->getObjectType() !== 'files'
-			|| $event->getEvent() !== CommentsEvent::EVENT_ADD
-			|| !$this->appManager->isInstalled('activity')) {
-			// Comment not for file, not adding a comment or no activity-app enabled (save the energy)
-			return;
-		}
+    /**
+     * @param CommentsEvent $event
+     */
+    public function commentEvent(CommentsEvent $event) {
+        if ($event->getComment()->getObjectType() !== 'files'
+            || $event->getEvent() !== CommentsEvent::EVENT_ADD
+            || !$this->appManager->isInstalled('activity')) {
+            // Comment not for file, not adding a comment or no activity-app enabled (save the energy)
+            return;
+        }
 
-		// Get all mount point owners
-		$cache = $this->mountCollection->getMountCache();
-		$mounts = $cache->getMountsForFileId((int)$event->getComment()->getObjectId());
-		if (empty($mounts)) {
-			return;
-		}
+        // Get all mount point owners
+        $cache = $this->mountCollection->getMountCache();
+        $mounts = $cache->getMountsForFileId((int)$event->getComment()->getObjectId());
+        if (empty($mounts)) {
+            return;
+        }
 
-		$users = [];
-		foreach ($mounts as $mount) {
-			$owner = $mount->getUser()->getUID();
-			$ownerFolder = $this->rootFolder->getUserFolder($owner);
-			$nodes = $ownerFolder->getById((int)$event->getComment()->getObjectId());
-			if (!empty($nodes)) {
-				/** @var Node $node */
-				$node = array_shift($nodes);
-				$al = $this->shareHelper->getPathsForAccessList($node);
-				$users += $al['users'];
-			}
-		}
+        $users = [];
+        foreach ($mounts as $mount) {
+            $owner = $mount->getUser()->getUID();
+            $ownerFolder = $this->rootFolder->getUserFolder($owner);
+            $nodes = $ownerFolder->getById((int)$event->getComment()->getObjectId());
+            if (!empty($nodes)) {
+                /** @var Node $node */
+                $node = array_shift($nodes);
+                $al = $this->shareHelper->getPathsForAccessList($node);
+                $users += $al['users'];
+            }
+        }
 
-		$actor = $this->session->getUser();
-		if ($actor instanceof IUser) {
-			$actor = $actor->getUID();
-		} else {
-			$actor = '';
-		}
+        $actor = $this->session->getUser();
+        if ($actor instanceof IUser) {
+            $actor = $actor->getUID();
+        } else {
+            $actor = '';
+        }
 
-		$activity = $this->activityManager->generateEvent();
-		$activity->setApp('comments')
-			->setType('comments')
-			->setAuthor($actor)
-			->setObject($event->getComment()->getObjectType(), (int) $event->getComment()->getObjectId())
-			->setMessage('add_comment_message', [
-				'commentId' => $event->getComment()->getId(),
-			]);
+        $activity = $this->activityManager->generateEvent();
+        $activity->setApp('comments')
+            ->setType('comments')
+            ->setAuthor($actor)
+            ->setObject($event->getComment()->getObjectType(), (int) $event->getComment()->getObjectId())
+            ->setMessage('add_comment_message', [
+                'commentId' => $event->getComment()->getId(),
+            ]);
 
-		foreach ($users as $user => $path) {
-			// numerical user ids end up as integers from array keys, but string
-			// is required
-			$activity->setAffectedUser((string)$user);
+        foreach ($users as $user => $path) {
+            // numerical user ids end up as integers from array keys, but string
+            // is required
+            $activity->setAffectedUser((string)$user);
 
-			$activity->setSubject('add_comment_subject', [
-				'actor' => $actor,
-				'fileId' => (int) $event->getComment()->getObjectId(),
-				'filePath' => trim($path, '/'),
-			]);
-			$this->activityManager->publish($activity);
-		}
-	}
+            $activity->setSubject('add_comment_subject', [
+                'actor' => $actor,
+                'fileId' => (int) $event->getComment()->getObjectId(),
+                'filePath' => trim($path, '/'),
+            ]);
+            $this->activityManager->publish($activity);
+        }
+    }
 }

lib/private/IntegrityCheck/Helpers/EnvironmentHelper.php

Indentation +16 added lines, -16 removed lines

@@ -30,21 +30,21 @@
  * @package OC\IntegrityCheck\Helpers
  */
 class EnvironmentHelper {
-	/**
-	 * Provides \OC::$SERVERROOT
-	 *
-	 * @return string
-	 */
-	public function getServerRoot(): string {
-		return rtrim(\OC::$SERVERROOT, '/');
-	}
+    /**
+     * Provides \OC::$SERVERROOT
+     *
+     * @return string
+     */
+    public function getServerRoot(): string {
+        return rtrim(\OC::$SERVERROOT, '/');
+    }
 
-	/**
-	 * Provides \OC_Util::getChannel()
-	 *
-	 * @return string
-	 */
-	public function getChannel(): string {
-		return \OC_Util::getChannel();
-	}
+    /**
+     * Provides \OC_Util::getChannel()
+     *
+     * @return string
+     */
+    public function getChannel(): string {
+        return \OC_Util::getChannel();
+    }
 }

lib/public/SystemTag/ISystemTagObjectMapper.php

Indentation +93 added lines, -93 removed lines

@@ -31,102 +31,102 @@
  */
 interface ISystemTagObjectMapper {
 
-	/**
-	 * Get a list of tag ids for the given object ids.
-	 *
-	 * This returns an array that maps object id to tag ids
-	 * [
-	 *   1 => array('id1', 'id2'),
-	 *   2 => array('id3', 'id2'),
-	 *   3 => array('id5'),
-	 *   4 => array()
-	 * ]
-	 *
-	 * Untagged objects will have an empty array associated.
-	 *
-	 * @param string|array $objIds object ids
-	 * @param string $objectType object type
-	 *
-	 * @return array with object id as key and an array
-	 * of tag ids as value
-	 *
-	 * @since 9.0.0
-	 */
-	public function getTagIdsForObjects($objIds, string $objectType): array;
+    /**
+     * Get a list of tag ids for the given object ids.
+     *
+     * This returns an array that maps object id to tag ids
+     * [
+     *   1 => array('id1', 'id2'),
+     *   2 => array('id3', 'id2'),
+     *   3 => array('id5'),
+     *   4 => array()
+     * ]
+     *
+     * Untagged objects will have an empty array associated.
+     *
+     * @param string|array $objIds object ids
+     * @param string $objectType object type
+     *
+     * @return array with object id as key and an array
+     * of tag ids as value
+     *
+     * @since 9.0.0
+     */
+    public function getTagIdsForObjects($objIds, string $objectType): array;
 
-	/**
-	 * Get a list of objects tagged with $tagIds.
-	 *
-	 * @param string|array $tagIds Tag id or array of tag ids.
-	 * @param string $objectType object type
-	 * @param int $limit Count of object ids you want to get
-	 * @param string $offset The last object id you already received
-	 *
-	 * @return string[] array of object ids or empty array if none found
-	 *
-	 * @throws TagNotFoundException if at least one of the
-	 * given tags does not exist
-	 * @throws \InvalidArgumentException When a limit is specified together with
-	 * multiple tag ids
-	 *
-	 * @since 9.0.0
-	 */
-	public function getObjectIdsForTags($tagIds, string $objectType, int $limit = 0, string $offset = ''): array;
+    /**
+     * Get a list of objects tagged with $tagIds.
+     *
+     * @param string|array $tagIds Tag id or array of tag ids.
+     * @param string $objectType object type
+     * @param int $limit Count of object ids you want to get
+     * @param string $offset The last object id you already received
+     *
+     * @return string[] array of object ids or empty array if none found
+     *
+     * @throws TagNotFoundException if at least one of the
+     * given tags does not exist
+     * @throws \InvalidArgumentException When a limit is specified together with
+     * multiple tag ids
+     *
+     * @since 9.0.0
+     */
+    public function getObjectIdsForTags($tagIds, string $objectType, int $limit = 0, string $offset = ''): array;
 
-	/**
-	 * Assign the given tags to the given object.
-	 *
-	 * If at least one of the given tag ids doesn't exist, none of the tags
-	 * will be assigned.
-	 *
-	 * If the relationship already existed, fail silently.
-	 *
-	 * @param string $objId object id
-	 * @param string $objectType object type
-	 * @param string|array $tagIds tag id or array of tag ids to assign
-	 *
-	 * @throws TagNotFoundException if at least one of the
-	 * given tags does not exist
-	 *
-	 * @since 9.0.0
-	 */
-	public function assignTags(string $objId, string $objectType, $tagIds);
+    /**
+     * Assign the given tags to the given object.
+     *
+     * If at least one of the given tag ids doesn't exist, none of the tags
+     * will be assigned.
+     *
+     * If the relationship already existed, fail silently.
+     *
+     * @param string $objId object id
+     * @param string $objectType object type
+     * @param string|array $tagIds tag id or array of tag ids to assign
+     *
+     * @throws TagNotFoundException if at least one of the
+     * given tags does not exist
+     *
+     * @since 9.0.0
+     */
+    public function assignTags(string $objId, string $objectType, $tagIds);
 
-	/**
-	 * Unassign the given tags from the given object.
-	 *
-	 * If at least one of the given tag ids doesn't exist, none of the tags
-	 * will be unassigned.
-	 *
-	 * If the relationship did not exist in the first place, fail silently.
-	 *
-	 * @param string $objId object id
-	 * @param string $objectType object type
-	 * @param string|array $tagIds tag id or array of tag ids to unassign
-	 *
-	 * @throws TagNotFoundException if at least one of the
-	 * given tags does not exist
-	 *
-	 * @since 9.0.0
-	 */
-	public function unassignTags(string $objId, string $objectType, $tagIds);
+    /**
+     * Unassign the given tags from the given object.
+     *
+     * If at least one of the given tag ids doesn't exist, none of the tags
+     * will be unassigned.
+     *
+     * If the relationship did not exist in the first place, fail silently.
+     *
+     * @param string $objId object id
+     * @param string $objectType object type
+     * @param string|array $tagIds tag id or array of tag ids to unassign
+     *
+     * @throws TagNotFoundException if at least one of the
+     * given tags does not exist
+     *
+     * @since 9.0.0
+     */
+    public function unassignTags(string $objId, string $objectType, $tagIds);
 
-	/**
-	 * Checks whether the given objects have the given tag.
-	 *
-	 * @param string|array $objIds object ids
-	 * @param string $objectType object type
-	 * @param string $tagId tag id to check
-	 * @param bool $all true to check that ALL objects have the tag assigned,
-	 * false to check that at least ONE object has the tag.
-	 *
-	 * @return bool true if the condition set by $all is matched, false
-	 * otherwise
-	 *
-	 * @throws TagNotFoundException if the tag does not exist
-	 *
-	 * @since 9.0.0
-	 */
-	public function haveTag($objIds, string $objectType, string $tagId, bool $all = true): bool;
+    /**
+     * Checks whether the given objects have the given tag.
+     *
+     * @param string|array $objIds object ids
+     * @param string $objectType object type
+     * @param string $tagId tag id to check
+     * @param bool $all true to check that ALL objects have the tag assigned,
+     * false to check that at least ONE object has the tag.
+     *
+     * @return bool true if the condition set by $all is matched, false
+     * otherwise
+     *
+     * @throws TagNotFoundException if the tag does not exist
+     *
+     * @since 9.0.0
+     */
+    public function haveTag($objIds, string $objectType, string $tagId, bool $all = true): bool;
 
 }

lib/public/SystemTag/ISystemTagManagerFactory.php

Indentation +22 added lines, -22 removed lines

@@ -34,28 +34,28 @@
  */
 interface ISystemTagManagerFactory {
 
-	/**
-	 * Constructor for the system tag manager factory
-	 *
-	 * @param IServerContainer $serverContainer server container
-	 * @since 9.0.0
-	 */
-	public function __construct(IServerContainer $serverContainer);
+    /**
+     * Constructor for the system tag manager factory
+     *
+     * @param IServerContainer $serverContainer server container
+     * @since 9.0.0
+     */
+    public function __construct(IServerContainer $serverContainer);
 
-	/**
-	 * creates and returns an instance of the system tag manager
-	 *
-	 * @return ISystemTagManager
-	 * @since 9.0.0
-	 */
-	public function getManager(): ISystemTagManager;
+    /**
+     * creates and returns an instance of the system tag manager
+     *
+     * @return ISystemTagManager
+     * @since 9.0.0
+     */
+    public function getManager(): ISystemTagManager;
 
-	/**
-	 * creates and returns an instance of the system tag object
-	 * mapper
-	 *
-	 * @return ISystemTagObjectMapper
-	 * @since 9.0.0
-	 */
-	public function getObjectMapper(): ISystemTagObjectMapper;
+    /**
+     * creates and returns an instance of the system tag object
+     * mapper
+     *
+     * @return ISystemTagObjectMapper
+     * @since 9.0.0
+     */
+    public function getObjectMapper(): ISystemTagObjectMapper;
 }

lib/public/SystemTag/ISystemTagManager.php

Indentation +120 added lines, -120 removed lines

@@ -33,133 +33,133 @@
  */
 interface ISystemTagManager {
 
-	/**
-	 * Returns the tag objects matching the given tag ids.
-	 *
-	 * @param array|string $tagIds id or array of unique ids of the tag to retrieve
-	 *
-	 * @return ISystemTag[] array of system tags with tag id as key
-	 *
-	 * @throws \InvalidArgumentException if at least one given tag ids is invalid (string instead of integer, etc.)
-	 * @throws TagNotFoundException if at least one given tag ids did no exist
-	 * 			The message contains a json_encoded array of the ids that could not be found
-	 *
-	 * @since 9.0.0
-	 */
-	public function getTagsByIds($tagIds): array;
+    /**
+     * Returns the tag objects matching the given tag ids.
+     *
+     * @param array|string $tagIds id or array of unique ids of the tag to retrieve
+     *
+     * @return ISystemTag[] array of system tags with tag id as key
+     *
+     * @throws \InvalidArgumentException if at least one given tag ids is invalid (string instead of integer, etc.)
+     * @throws TagNotFoundException if at least one given tag ids did no exist
+     * 			The message contains a json_encoded array of the ids that could not be found
+     *
+     * @since 9.0.0
+     */
+    public function getTagsByIds($tagIds): array;
 
-	/**
-	 * Returns the tag object matching the given attributes.
-	 *
-	 * @param string $tagName tag name
-	 * @param bool $userVisible whether the tag is visible by users
-	 * @param bool $userAssignable whether the tag is assignable by users
-	 *
-	 * @return ISystemTag system tag
-	 *
-	 * @throws TagNotFoundException if tag does not exist
-	 *
-	 * @since 9.0.0
-	 */
-	public function getTag(string $tagName, bool $userVisible, bool $userAssignable): ISystemTag;
+    /**
+     * Returns the tag object matching the given attributes.
+     *
+     * @param string $tagName tag name
+     * @param bool $userVisible whether the tag is visible by users
+     * @param bool $userAssignable whether the tag is assignable by users
+     *
+     * @return ISystemTag system tag
+     *
+     * @throws TagNotFoundException if tag does not exist
+     *
+     * @since 9.0.0
+     */
+    public function getTag(string $tagName, bool $userVisible, bool $userAssignable): ISystemTag;
 
-	/**
-	 * Creates the tag object using the given attributes.
-	 *
-	 * @param string $tagName tag name
-	 * @param bool $userVisible whether the tag is visible by users
-	 * @param bool $userAssignable whether the tag is assignable by users
-	 *
-	 * @return ISystemTag system tag
-	 *
-	 * @throws TagAlreadyExistsException if tag already exists
-	 *
-	 * @since 9.0.0
-	 */
-	public function createTag(string $tagName, bool $userVisible, bool $userAssignable): ISystemTag;
+    /**
+     * Creates the tag object using the given attributes.
+     *
+     * @param string $tagName tag name
+     * @param bool $userVisible whether the tag is visible by users
+     * @param bool $userAssignable whether the tag is assignable by users
+     *
+     * @return ISystemTag system tag
+     *
+     * @throws TagAlreadyExistsException if tag already exists
+     *
+     * @since 9.0.0
+     */
+    public function createTag(string $tagName, bool $userVisible, bool $userAssignable): ISystemTag;
 
-	/**
-	 * Returns all known tags, optionally filtered by visibility.
-	 *
-	 * @param bool|null $visibilityFilter filter by visibility if non-null
-	 * @param string $nameSearchPattern optional search pattern for the tag name
-	 *
-	 * @return ISystemTag[] array of system tags or empty array if none found
-	 *
-	 * @since 9.0.0
-	 */
-	public function getAllTags($visibilityFilter = null, $nameSearchPattern = null): array;
+    /**
+     * Returns all known tags, optionally filtered by visibility.
+     *
+     * @param bool|null $visibilityFilter filter by visibility if non-null
+     * @param string $nameSearchPattern optional search pattern for the tag name
+     *
+     * @return ISystemTag[] array of system tags or empty array if none found
+     *
+     * @since 9.0.0
+     */
+    public function getAllTags($visibilityFilter = null, $nameSearchPattern = null): array;
 
-	/**
-	 * Updates the given tag
-	 *
-	 * @param string $tagId tag id
-	 * @param string $newName the new tag name
-	 * @param bool $userVisible whether the tag is visible by users
-	 * @param bool $userAssignable whether the tag is assignable by users
-	 *
-	 * @throws TagNotFoundException if tag with the given id does not exist
-	 * @throws TagAlreadyExistsException if there is already another tag
-	 * with the same attributes
-	 *
-	 * @since 9.0.0
-	 */
-	public function updateTag(string $tagId, string $newName, bool $userVisible, bool $userAssignable);
+    /**
+     * Updates the given tag
+     *
+     * @param string $tagId tag id
+     * @param string $newName the new tag name
+     * @param bool $userVisible whether the tag is visible by users
+     * @param bool $userAssignable whether the tag is assignable by users
+     *
+     * @throws TagNotFoundException if tag with the given id does not exist
+     * @throws TagAlreadyExistsException if there is already another tag
+     * with the same attributes
+     *
+     * @since 9.0.0
+     */
+    public function updateTag(string $tagId, string $newName, bool $userVisible, bool $userAssignable);
 
-	/**
-	 * Delete the given tags from the database and all their relationships.
-	 *
-	 * @param string|array $tagIds array of tag ids
-	 *
-	 * @throws TagNotFoundException if at least one tag did not exist
-	 *
-	 * @since 9.0.0
-	 */
-	public function deleteTags($tagIds);
+    /**
+     * Delete the given tags from the database and all their relationships.
+     *
+     * @param string|array $tagIds array of tag ids
+     *
+     * @throws TagNotFoundException if at least one tag did not exist
+     *
+     * @since 9.0.0
+     */
+    public function deleteTags($tagIds);
 
-	/**
-	 * Checks whether the given user is allowed to assign/unassign the tag with the
-	 * given id.
-	 *
-	 * @param ISystemTag $tag tag to check permission for
-	 * @param IUser $user user to check permission for
-	 *
-	 * @return true if the user is allowed to assign/unassign the tag, false otherwise
-	 *
-	 * @since 9.1.0
-	 */
-	public function canUserAssignTag(ISystemTag $tag, IUser $user): bool;
+    /**
+     * Checks whether the given user is allowed to assign/unassign the tag with the
+     * given id.
+     *
+     * @param ISystemTag $tag tag to check permission for
+     * @param IUser $user user to check permission for
+     *
+     * @return true if the user is allowed to assign/unassign the tag, false otherwise
+     *
+     * @since 9.1.0
+     */
+    public function canUserAssignTag(ISystemTag $tag, IUser $user): bool;
 
-	/**
-	 * Checks whether the given user is allowed to see the tag with the given id.
-	 *
-	 * @param ISystemTag $tag tag to check permission for
-	 * @param IUser $user user to check permission for
-	 *
-	 * @return true if the user can see the tag, false otherwise
-	 *
-	 * @since 9.1.0
-	 */
-	public function canUserSeeTag(ISystemTag $tag, IUser $user): bool;
+    /**
+     * Checks whether the given user is allowed to see the tag with the given id.
+     *
+     * @param ISystemTag $tag tag to check permission for
+     * @param IUser $user user to check permission for
+     *
+     * @return true if the user can see the tag, false otherwise
+     *
+     * @since 9.1.0
+     */
+    public function canUserSeeTag(ISystemTag $tag, IUser $user): bool;
 
-	/**
-	 * Set groups that can assign a given tag.
-	 *
-	 * @param ISystemTag $tag tag for group assignment
-	 * @param string[] $groupIds group ids of groups that can assign/unassign the tag
-	 *
-	 * @since 9.1.0
-	 */
-	public function setTagGroups(ISystemTag $tag, array $groupIds);
+    /**
+     * Set groups that can assign a given tag.
+     *
+     * @param ISystemTag $tag tag for group assignment
+     * @param string[] $groupIds group ids of groups that can assign/unassign the tag
+     *
+     * @since 9.1.0
+     */
+    public function setTagGroups(ISystemTag $tag, array $groupIds);
 
-	/**
-	 * Get groups that can assign a given tag.
-	 *
-	 * @param ISystemTag $tag tag for group assignment
-	 *
-	 * @return string[] group ids of groups that can assign/unassign the tag
-	 *
-	 * @since 9.1.0
-	 */
-	public function getTagGroups(ISystemTag $tag): array;
+    /**
+     * Get groups that can assign a given tag.
+     *
+     * @param ISystemTag $tag tag for group assignment
+     *
+     * @return string[] group ids of groups that can assign/unassign the tag
+     *
+     * @since 9.1.0
+     */
+    public function getTagGroups(ISystemTag $tag): array;
 }

lib/public/SystemTag/TagNotFoundException.php

Indentation +22 added lines, -22 removed lines

@@ -32,28 +32,28 @@
  */
 class TagNotFoundException extends \RuntimeException {
 
-	/** @var string[] */
-	protected $tags;
+    /** @var string[] */
+    protected $tags;
 
-	/**
-	 * TagNotFoundException constructor.
-	 *
-	 * @param string $message
-	 * @param int $code
-	 * @param \Exception|null $previous
-	 * @param string[] $tags
-	 * @since 9.0.0
-	 */
-	public function __construct(string $message = '', int $code = 0, \Exception $previous = null, array $tags = []) {
-		parent::__construct($message, $code, $previous);
-		$this->tags = $tags;
-	}
+    /**
+     * TagNotFoundException constructor.
+     *
+     * @param string $message
+     * @param int $code
+     * @param \Exception|null $previous
+     * @param string[] $tags
+     * @since 9.0.0
+     */
+    public function __construct(string $message = '', int $code = 0, \Exception $previous = null, array $tags = []) {
+        parent::__construct($message, $code, $previous);
+        $this->tags = $tags;
+    }
 
-	/**
-	 * @return string[]
-	 * @since 9.0.0
-	 */
-	public function getMissingTags(): array {
-		return $this->tags;
-	}
+    /**
+     * @return string[]
+     * @since 9.0.0
+     */
+    public function getMissingTags(): array {
+        return $this->tags;
+    }
 }

lib/private/SystemTag/ManagerFactory.php

Indentation +41 added lines, -41 removed lines

@@ -36,48 +36,48 @@
  */
 class ManagerFactory implements ISystemTagManagerFactory {
 
-	/**
-	 * Server container
-	 *
-	 * @var IServerContainer
-	 */
-	private $serverContainer;
+    /**
+     * Server container
+     *
+     * @var IServerContainer
+     */
+    private $serverContainer;
 
-	/**
-	 * Constructor for the system tag manager factory
-	 *
-	 * @param IServerContainer $serverContainer server container
-	 */
-	public function __construct(IServerContainer $serverContainer) {
-		$this->serverContainer = $serverContainer;
-	}
+    /**
+     * Constructor for the system tag manager factory
+     *
+     * @param IServerContainer $serverContainer server container
+     */
+    public function __construct(IServerContainer $serverContainer) {
+        $this->serverContainer = $serverContainer;
+    }
 
-	/**
-	 * Creates and returns an instance of the system tag manager
-	 *
-	 * @return ISystemTagManager
-	 * @since 9.0.0
-	 */
-	public function getManager(): ISystemTagManager {
-		return new SystemTagManager(
-			$this->serverContainer->getDatabaseConnection(),
-			$this->serverContainer->getGroupManager(),
-			$this->serverContainer->getEventDispatcher()
-		);
-	}
+    /**
+     * Creates and returns an instance of the system tag manager
+     *
+     * @return ISystemTagManager
+     * @since 9.0.0
+     */
+    public function getManager(): ISystemTagManager {
+        return new SystemTagManager(
+            $this->serverContainer->getDatabaseConnection(),
+            $this->serverContainer->getGroupManager(),
+            $this->serverContainer->getEventDispatcher()
+        );
+    }
 
-	/**
-	 * Creates and returns an instance of the system tag object
-	 * mapper
-	 *
-	 * @return ISystemTagObjectMapper
-	 * @since 9.0.0
-	 */
-	public function getObjectMapper(): ISystemTagObjectMapper {
-		return new SystemTagObjectMapper(
-			$this->serverContainer->getDatabaseConnection(),
-			$this->getManager(),
-			$this->serverContainer->getEventDispatcher()
-		);
-	}
+    /**
+     * Creates and returns an instance of the system tag object
+     * mapper
+     *
+     * @return ISystemTagObjectMapper
+     * @since 9.0.0
+     */
+    public function getObjectMapper(): ISystemTagObjectMapper {
+        return new SystemTagObjectMapper(
+            $this->serverContainer->getDatabaseConnection(),
+            $this->getManager(),
+            $this->serverContainer->getEventDispatcher()
+        );
+    }
 }

apps/user_ldap/templates/part.wizard-userfilter.php

Spacing +12 added lines, -12 removed lines

@@ -1,11 +1,11 @@ 
 <fieldset id="ldapWizard2">
 	<div>
 		<p>
-			<?php p($l->t('Listing and searching for users is constrained by these criteria:'));?>
+			<?php p($l->t('Listing and searching for users is constrained by these criteria:')); ?>
 		</p>
 		<p>
 			<label for="ldap_userfilter_objectclass">
-				<?php p($l->t('Only these object classes:'));?>
+				<?php p($l->t('Only these object classes:')); ?>
 			</label>
 
 			<select id="ldap_userfilter_objectclass" multiple="multiple"
@@ -14,14 +14,14 @@ 
 		</p>
 		<p>
 			<label></label>
-			<span class="ldapInputColElement"><?php p($l->t('The most common object classes for users are organizationalPerson, person, user, and inetOrgPerson. If you are not sure which object class to select, please consult your directory admin.'));?></span>
+			<span class="ldapInputColElement"><?php p($l->t('The most common object classes for users are organizationalPerson, person, user, and inetOrgPerson. If you are not sure which object class to select, please consult your directory admin.')); ?></span>
 		</p>
 		<p>
 			<label for="ldap_userfilter_groups">
-				<?php p($l->t('Only from these groups:'));?>
+				<?php p($l->t('Only from these groups:')); ?>
 			</label>
 
-			<input type="text" class="ldapManyGroupsSupport ldapManyGroupsSearch hidden" placeholder="<?php p($l->t('Search groups'));?>" />
+			<input type="text" class="ldapManyGroupsSupport ldapManyGroupsSearch hidden" placeholder="<?php p($l->t('Search groups')); ?>" />
 
 			<select id="ldap_userfilter_groups" multiple="multiple"
 			 name="ldap_userfilter_groups" class="multiSelectPlugin">
@@ -30,26 +30,26 @@ 
 		<p class="ldapManyGroupsSupport hidden">
 			<label></label>
 			<select class="ldapGroupList ldapGroupListAvailable" multiple="multiple"
-					title="<?php p($l->t('Available groups'));?>"></select>
+					title="<?php p($l->t('Available groups')); ?>"></select>
 			<span class="buttonSpan">
 				<button class="ldapGroupListSelect" type="button">&gt;</button><br/>
 				<button class="ldapGroupListDeselect" type="button">&lt;</button>
 			</span>
 			<select class="ldapGroupList ldapGroupListSelected" multiple="multiple"
-					title="<?php p($l->t('Selected groups'));?>"></select>
+					title="<?php p($l->t('Selected groups')); ?>"></select>
 		</p>
 		<p>
-			<label><a id='toggleRawUserFilter' class='ldapToggle'>↓ <?php p($l->t('Edit LDAP Query'));?></a></label>
+			<label><a id='toggleRawUserFilter' class='ldapToggle'>↓ <?php p($l->t('Edit LDAP Query')); ?></a></label>
 		</p>
 		<p id="ldapReadOnlyUserFilterContainer" class="hidden ldapReadOnlyFilterContainer">
-			<label><?php p($l->t('LDAP Filter:'));?></label>
+			<label><?php p($l->t('LDAP Filter:')); ?></label>
 			<span class="ldapFilterReadOnlyElement ldapInputColElement"></span>
 		</p>
 		<p id="rawUserFilterContainer">
 			<textarea type="text" id="ldap_userlist_filter" name="ldap_userlist_filter"
 				class="ldapFilterInputElement"
-				placeholder="<?php p($l->t('Edit LDAP Query'));?>"
-				title="<?php p($l->t('The filter specifies which LDAP users shall have access to the %s instance.', [$theme->getName()]));?>">
+				placeholder="<?php p($l->t('Edit LDAP Query')); ?>"
+				title="<?php p($l->t('The filter specifies which LDAP users shall have access to the %s instance.', [$theme->getName()])); ?>">
 			</textarea>
 		</p>
 		<p>
@@ -57,7 +57,7 @@ 
 		</p>
 		<p class="ldap_count">
 			<button class="ldapGetEntryCount ldapGetUserCount" name="ldapGetEntryCount" type="button">
-				<?php p($l->t('Verify settings and count users'));?>
+				<?php p($l->t('Verify settings and count users')); ?>
 			</button>
 			<span id="ldap_user_count"></span>
 		</p>