Completed
Pull Request — master (#5116)
by Nicolai
14:21
created
lib/private/Template/SCSSCacher.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -114,8 +114,8 @@
 block discarded – undo
114 114
 	}
115 115
 
116 116
 	/**
117
-	 * @param $appName
118
-	 * @param $fileName
117
+	 * @param string $appName
118
+	 * @param string $fileName
119 119
 	 * @return ISimpleFile
120 120
 	 */
121 121
 	public function getCachedCSS($appName, $fileName) {
Please login to merge, or discard this patch.
apps/dav/lib/Avatars/AvatarHome.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -98,6 +98,9 @@
 block discarded – undo
98 98
 		throw new Forbidden('Permission denied to delete this folder');
99 99
 	}
100 100
 
101
+	/**
102
+	 * @return string
103
+	 */
101 104
 	public function getName() {
102 105
 		list(,$name) = Uri\split($this->principalInfo['uri']);
103 106
 		return $name;
Please login to merge, or discard this patch.
apps/dav/lib/Migration/CalDAVRemoveEmptyValue.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -97,6 +97,9 @@
 block discarded – undo
97 97
 		}
98 98
 	}
99 99
 
100
+	/**
101
+	 * @param string $pattern
102
+	 */
100 103
 	protected function getInvalidObjects($pattern) {
101 104
 		$query = $this->db->getQueryBuilder();
102 105
 		$query->select(['calendarid', 'uri'])
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/Search/Xml/Request/CalendarSearchReport.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
 	 * the next element.
80 80
 	 *
81 81
 	 * @param Reader $reader
82
-	 * @return mixed
82
+	 * @return CalendarSearchReport
83 83
 	 */
84 84
 	static function xmlDeserialize(Reader $reader) {
85 85
 		$elems = $reader->parseInnerTree([
Please login to merge, or discard this patch.
lib/private/Share20/Manager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -1100,6 +1100,9 @@
 block discarded – undo
1100 1100
 		return $share;
1101 1101
 	}
1102 1102
 
1103
+	/**
1104
+	 * @param \OCP\Share\IShare $share
1105
+	 */
1103 1106
 	protected function checkExpireDate($share) {
1104 1107
 		if ($share->getExpirationDate() !== null &&
1105 1108
 			$share->getExpirationDate() <= new \DateTime()) {
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/SyncService.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -163,7 +163,6 @@  discard block
 block discarded – undo
163 163
 	/**
164 164
 	 * @param string $url
165 165
 	 * @param string $userName
166
-	 * @param string $addressBookUrl
167 166
 	 * @param string $sharedSecret
168 167
 	 * @return Client
169 168
 	 */
@@ -301,7 +300,7 @@  discard block
 block discarded – undo
301 300
 	}
302 301
 
303 302
 	/**
304
-	 * @return array|null
303
+	 * @return string
305 304
 	 */
306 305
 	public function getLocalSystemAddressBook() {
307 306
 		if (is_null($this->localSystemAddressBook)) {
Please login to merge, or discard this patch.
apps/user_ldap/lib/Access.php 1 patch
Doc Comments   +8 added lines, -6 removed lines patch added patch discarded remove patch
@@ -490,7 +490,7 @@  discard block
 block discarded – undo
490 490
 
491 491
 	/**
492 492
 	 * returns the internal Nextcloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
493
-	 * @param string $dn the dn of the user object
493
+	 * @param string $fdn the dn of the user object
494 494
 	 * @param string $ldapName optional, the display name of the object
495 495
 	 * @return string|false with with the name to use in Nextcloud
496 496
 	 */
@@ -507,7 +507,7 @@  discard block
 block discarded – undo
507 507
 
508 508
 	/**
509 509
 	 * returns an internal Nextcloud name for the given LDAP DN, false on DN outside of search DN
510
-	 * @param string $dn the dn of the user object
510
+	 * @param string $fdn the dn of the user object
511 511
 	 * @param string $ldapName optional, the display name of the object
512 512
 	 * @param bool $isUser optional, whether it is a user object (otherwise group assumed)
513 513
 	 * @return string|false with with the name to use in Nextcloud
@@ -770,7 +770,7 @@  discard block
 block discarded – undo
770 770
 	 * the login filter.
771 771
 	 *
772 772
 	 * @param string $loginName
773
-	 * @param array $attributes optional, list of attributes to read
773
+	 * @param string[] $attributes optional, list of attributes to read
774 774
 	 * @return array
775 775
 	 */
776 776
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -843,7 +843,7 @@  discard block
 block discarded – undo
843 843
 
844 844
 	/**
845 845
 	 * @param string $filter
846
-	 * @param string|string[] $attr
846
+	 * @param string[] $attr
847 847
 	 * @param int $limit
848 848
 	 * @param int $offset
849 849
 	 * @return array
@@ -891,7 +891,7 @@  discard block
 block discarded – undo
891 891
 
892 892
 	/**
893 893
 	 * @param string $filter
894
-	 * @param string|string[] $attr
894
+	 * @param string[] $attr
895 895
 	 * @param int $limit
896 896
 	 * @param int $offset
897 897
 	 * @return false|int
@@ -941,6 +941,7 @@  discard block
 block discarded – undo
941 941
 	 * retrieved. Results will according to the order in the array.
942 942
 	 * @param int $limit optional, maximum results to be counted
943 943
 	 * @param int $offset optional, a starting point
944
+	 * @param string $filter
944 945
 	 * @return array|false array with the search result as first value and pagedSearchOK as
945 946
 	 * second | false if not successful
946 947
 	 */
@@ -1191,7 +1192,7 @@  discard block
 block discarded – undo
1191 1192
 
1192 1193
 	/**
1193 1194
 	 * @param string $name
1194
-	 * @return bool|mixed|string
1195
+	 * @return string
1195 1196
 	 */
1196 1197
 	public function sanitizeUsername($name) {
1197 1198
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -1215,6 +1216,7 @@  discard block
 block discarded – undo
1215 1216
 	* escapes (user provided) parts for LDAP filter
1216 1217
 	* @param string $input, the provided value
1217 1218
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
1219
+	* @param string $input
1218 1220
 	* @return string the escaped string
1219 1221
 	*/
1220 1222
 	public function escapeFilterPart($input, $allowAsterisk = false) {
Please login to merge, or discard this patch.
lib/private/Mail/EMailTemplate.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -335,7 +335,7 @@
 block discarded – undo
335 335
 	 * Adds a heading to the email
336 336
 	 *
337 337
 	 * @param string $title
338
-	 * @param string $plainTitle|bool Title that is used in the plain text email
338
+	 * @param string $plainTitle Title that is used in the plain text email
339 339
 	 *   if empty the $title is used, if false none will be used
340 340
 	 */
341 341
 	public function addHeading($title, $plainTitle = '') {
Please login to merge, or discard this patch.
lib/private/AppFramework/Utility/ControllerMethodReflector.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
 	private $parameters = [];
38 38
 
39 39
 	/**
40
-	 * @param object $object an object or classname
40
+	 * @param \OCP\AppFramework\Controller $object an object or classname
41 41
 	 * @param string $method the method which we want to inspect
42 42
 	 */
43 43
 	public function reflect($object, $method){
Please login to merge, or discard this patch.