Inspection of "Merge pull request #12275 from nextcloud/bugfix/11..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( e36924...3c5e43 )

by Morris

created 2018-11-13 15:34 UTC

Status

Indentation +37 added lines, -37 removed lines patch added patch discarded remove patch

@@ -34,46 +34,46 @@
 block discarded – undo
 
 class Version1008Date20181105110300 extends SimpleMigrationStep {
 
-	/** @var IDBConnection */
-	private $connection;
+    /** @var IDBConnection */
+    private $connection;
 
-	/**
-	 * Version1008Date20181105110300 constructor.
-	 *
-	 * @param IDBConnection $connection
-	 */
-	public function __construct(IDBConnection $connection) {
-		$this->connection = $connection;
-	}
+    /**
+     * Version1008Date20181105110300 constructor.
+     *
+     * @param IDBConnection $connection
+     */
+    public function __construct(IDBConnection $connection) {
+        $this->connection = $connection;
+    }
 
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 */
-	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
-		$table = $schema->getTable('calendarsubscriptions');
-		$table->addColumn('source', Type::TEXT, [
-			'notnull' => false,
-			'length' => null,
-		]);
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     */
+    public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
+        $table = $schema->getTable('calendarsubscriptions');
+        $table->addColumn('source', Type::TEXT, [
+            'notnull' => false,
+            'length' => null,
+        ]);
 
-		return $schema;
-	}
+        return $schema;
+    }
 
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 */
-	public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {
-		$qb = $this->connection->getQueryBuilder();
-		$qb->update('calendarsubscriptions')
-			->set('source', 'source_copy')
-			->execute();
-	}
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     */
+    public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {
+        $qb = $this->connection->getQueryBuilder();
+        $qb->update('calendarsubscriptions')
+            ->set('source', 'source_copy')
+            ->execute();
+    }
 
 }

Please login to merge, or discard this patch.

apps/dav/lib/Migration/Version1008Date20181105112049.php 1 patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -32,18 +32,18 @@
 block discarded – undo
 
 class Version1008Date20181105112049 extends SimpleMigrationStep {
 
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 */
-	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
-		$table = $schema->getTable('calendarsubscriptions');
-		$table->dropColumn('source_copy');
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     */
+    public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
+        $table = $schema->getTable('calendarsubscriptions');
+        $table->dropColumn('source_copy');
 
-		return $schema;
-	}
+        return $schema;
+    }
 }

Please login to merge, or discard this patch.

apps/dav/lib/Migration/Version1008Date20181105104826.php 1 patch

Indentation +37 added lines, -37 removed lines patch added patch discarded remove patch

@@ -35,46 +35,46 @@
 block discarded – undo
 
 class Version1008Date20181105104826 extends SimpleMigrationStep {
 
-	/** @var IDBConnection */
-	private $connection;
+    /** @var IDBConnection */
+    private $connection;
 
-	/**
-	 * Version1008Date20181105104826 constructor.
-	 *
-	 * @param IDBConnection $connection
-	 */
-	public function __construct(IDBConnection $connection) {
-		$this->connection = $connection;
-	}
+    /**
+     * Version1008Date20181105104826 constructor.
+     *
+     * @param IDBConnection $connection
+     */
+    public function __construct(IDBConnection $connection) {
+        $this->connection = $connection;
+    }
 
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 */
-	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
-		$table = $schema->getTable('calendarsubscriptions');
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     */
+    public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
+        $table = $schema->getTable('calendarsubscriptions');
 
-		$table->addColumn('source_copy', Type::TEXT, [
-			'notnull' => false,
-			'length' => null,
-		]);
+        $table->addColumn('source_copy', Type::TEXT, [
+            'notnull' => false,
+            'length' => null,
+        ]);
 
-		return $schema;
-	}
+        return $schema;
+    }
 
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 */
-	public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {
-		$qb = $this->connection->getQueryBuilder();
-		$qb->update('calendarsubscriptions')
-			->set('source_copy', 'source')
-			->execute();
-	}
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     */
+    public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {
+        $qb = $this->connection->getQueryBuilder();
+        $qb->update('calendarsubscriptions')
+            ->set('source_copy', 'source')
+            ->execute();
+    }
 }

Please login to merge, or discard this patch.

apps/dav/lib/Migration/Version1008Date20181105104833.php 1 patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -32,18 +32,18 @@
 block discarded – undo
 
 class Version1008Date20181105104833 extends SimpleMigrationStep {
 
-	/**
-	 * @param IOutput $output
-	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 */
-	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
-		$table = $schema->getTable('calendarsubscriptions');
-		$table->dropColumn('source');
+    /**
+     * @param IOutput $output
+     * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     */
+    public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
+        $table = $schema->getTable('calendarsubscriptions');
+        $table->dropColumn('source');
 
-		return $schema;
-	}
+        return $schema;
+    }
 }

Please login to merge, or discard this patch.

		@@ -34,46 +34,46 @@
		block discarded – undo
34	34
35	35	class Version1008Date20181105110300 extends SimpleMigrationStep {
36	36
37		- /** @var IDBConnection */
38		- private $connection;
	37	+ /** @var IDBConnection */
	38	+ private $connection;
39	39
40		- /**
41		- * Version1008Date20181105110300 constructor.
42		- *
43		- * @param IDBConnection $connection
44		- */
45		- public function __construct(IDBConnection $connection) {
46		- $this->connection = $connection;
47		- }
	40	+ /**
	41	+ * Version1008Date20181105110300 constructor.
	42	+ *
	43	+ * @param IDBConnection $connection
	44	+ */
	45	+ public function __construct(IDBConnection $connection) {
	46	+ $this->connection = $connection;
	47	+ }
48	48
49		- /**
50		- * @param IOutput $output
51		- * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
52		- * @param array $options
53		- * @return null\|ISchemaWrapper
54		- */
55		- public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
56		- /** @var ISchemaWrapper $schema */
57		- $schema = $schemaClosure();
58		- $table = $schema->getTable('calendarsubscriptions');
59		- $table->addColumn('source', Type::TEXT, [
60		- 'notnull' => false,
61		- 'length' => null,
62		- ]);
	49	+ /**
	50	+ * @param IOutput $output
	51	+ * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	52	+ * @param array $options
	53	+ * @return null\|ISchemaWrapper
	54	+ */
	55	+ public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
	56	+ /** @var ISchemaWrapper $schema */
	57	+ $schema = $schemaClosure();
	58	+ $table = $schema->getTable('calendarsubscriptions');
	59	+ $table->addColumn('source', Type::TEXT, [
	60	+ 'notnull' => false,
	61	+ 'length' => null,
	62	+ ]);
63	63
64		- return $schema;
65		- }
	64	+ return $schema;
	65	+ }
66	66
67		- /**
68		- * @param IOutput $output
69		- * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
70		- * @param array $options
71		- */
72		- public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {
73		- $qb = $this->connection->getQueryBuilder();
74		- $qb->update('calendarsubscriptions')
75		- ->set('source', 'source_copy')
76		- ->execute();
77		- }
	67	+ /**
	68	+ * @param IOutput $output
	69	+ * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	70	+ * @param array $options
	71	+ */
	72	+ public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {
	73	+ $qb = $this->connection->getQueryBuilder();
	74	+ $qb->update('calendarsubscriptions')
	75	+ ->set('source', 'source_copy')
	76	+ ->execute();
	77	+ }
78	78
79	79	}

		@@ -32,18 +32,18 @@
		block discarded – undo
32	32
33	33	class Version1008Date20181105112049 extends SimpleMigrationStep {
34	34
35		- /**
36		- * @param IOutput $output
37		- * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
38		- * @param array $options
39		- * @return null\|ISchemaWrapper
40		- */
41		- public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
42		- /** @var ISchemaWrapper $schema */
43		- $schema = $schemaClosure();
44		- $table = $schema->getTable('calendarsubscriptions');
45		- $table->dropColumn('source_copy');
	35	+ /**
	36	+ * @param IOutput $output
	37	+ * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	38	+ * @param array $options
	39	+ * @return null\|ISchemaWrapper
	40	+ */
	41	+ public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
	42	+ /** @var ISchemaWrapper $schema */
	43	+ $schema = $schemaClosure();
	44	+ $table = $schema->getTable('calendarsubscriptions');
	45	+ $table->dropColumn('source_copy');
46	46
47		- return $schema;
48		- }
	47	+ return $schema;
	48	+ }
49	49	}

		@@ -35,46 +35,46 @@
		block discarded – undo
35	35
36	36	class Version1008Date20181105104826 extends SimpleMigrationStep {
37	37
38		- /** @var IDBConnection */
39		- private $connection;
	38	+ /** @var IDBConnection */
	39	+ private $connection;
40	40
41		- /**
42		- * Version1008Date20181105104826 constructor.
43		- *
44		- * @param IDBConnection $connection
45		- */
46		- public function __construct(IDBConnection $connection) {
47		- $this->connection = $connection;
48		- }
	41	+ /**
	42	+ * Version1008Date20181105104826 constructor.
	43	+ *
	44	+ * @param IDBConnection $connection
	45	+ */
	46	+ public function __construct(IDBConnection $connection) {
	47	+ $this->connection = $connection;
	48	+ }
49	49
50		- /**
51		- * @param IOutput $output
52		- * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
53		- * @param array $options
54		- * @return null\|ISchemaWrapper
55		- */
56		- public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
57		- /** @var ISchemaWrapper $schema */
58		- $schema = $schemaClosure();
59		- $table = $schema->getTable('calendarsubscriptions');
	50	+ /**
	51	+ * @param IOutput $output
	52	+ * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	53	+ * @param array $options
	54	+ * @return null\|ISchemaWrapper
	55	+ */
	56	+ public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
	57	+ /** @var ISchemaWrapper $schema */
	58	+ $schema = $schemaClosure();
	59	+ $table = $schema->getTable('calendarsubscriptions');
60	60
61		- $table->addColumn('source_copy', Type::TEXT, [
62		- 'notnull' => false,
63		- 'length' => null,
64		- ]);
	61	+ $table->addColumn('source_copy', Type::TEXT, [
	62	+ 'notnull' => false,
	63	+ 'length' => null,
	64	+ ]);
65	65
66		- return $schema;
67		- }
	66	+ return $schema;
	67	+ }
68	68
69		- /**
70		- * @param IOutput $output
71		- * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
72		- * @param array $options
73		- */
74		- public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {
75		- $qb = $this->connection->getQueryBuilder();
76		- $qb->update('calendarsubscriptions')
77		- ->set('source_copy', 'source')
78		- ->execute();
79		- }
	69	+ /**
	70	+ * @param IOutput $output
	71	+ * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	72	+ * @param array $options
	73	+ */
	74	+ public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {
	75	+ $qb = $this->connection->getQueryBuilder();
	76	+ $qb->update('calendarsubscriptions')
	77	+ ->set('source_copy', 'source')
	78	+ ->execute();
	79	+ }
80	80	}

		@@ -32,18 +32,18 @@
		block discarded – undo
32	32
33	33	class Version1008Date20181105104833 extends SimpleMigrationStep {
34	34
35		- /**
36		- * @param IOutput $output
37		- * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
38		- * @param array $options
39		- * @return null\|ISchemaWrapper
40		- */
41		- public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
42		- /** @var ISchemaWrapper $schema */
43		- $schema = $schemaClosure();
44		- $table = $schema->getTable('calendarsubscriptions');
45		- $table->dropColumn('source');
	35	+ /**
	36	+ * @param IOutput $output
	37	+ * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	38	+ * @param array $options
	39	+ * @return null\|ISchemaWrapper
	40	+ */
	41	+ public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
	42	+ /** @var ISchemaWrapper $schema */
	43	+ $schema = $schemaClosure();
	44	+ $table = $schema->getTable('calendarsubscriptions');
	45	+ $table->dropColumn('source');
46	46
47		- return $schema;
48		- }
	47	+ return $schema;
	48	+ }
49	49	}

nextcloud / server

Push — master ( e36924...3c5e43 )

Status

Category

Indentation +37 added lines, -37 removed lines patch added patch discarded remove patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

Indentation +37 added lines, -37 removed lines patch added patch discarded remove patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch