Completed
Pull Request — master (#7418)
by Blizzz
28:19 queued 13:51
created
apps/user_ldap/lib/Access.php 1 patch
Doc Comments   +7 added lines, -6 removed lines patch added patch discarded remove patch
@@ -503,7 +503,7 @@  discard block
 block discarded – undo
503 503
 
504 504
 	/**
505 505
 	 * returns the internal Nextcloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
506
-	 * @param string $dn the dn of the user object
506
+	 * @param string $fdn the dn of the user object
507 507
 	 * @param string $ldapName optional, the display name of the object
508 508
 	 * @return string|false with with the name to use in Nextcloud
509 509
 	 */
@@ -789,7 +789,7 @@  discard block
 block discarded – undo
789 789
 	 * the login filter.
790 790
 	 *
791 791
 	 * @param string $loginName
792
-	 * @param array $attributes optional, list of attributes to read
792
+	 * @param string[] $attributes optional, list of attributes to read
793 793
 	 * @return array
794 794
 	 */
795 795
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -873,7 +873,7 @@  discard block
 block discarded – undo
873 873
 
874 874
 	/**
875 875
 	 * @param string $filter
876
-	 * @param string|string[] $attr
876
+	 * @param string[] $attr
877 877
 	 * @param int $limit
878 878
 	 * @param int $offset
879 879
 	 * @return array
@@ -921,7 +921,7 @@  discard block
 block discarded – undo
921 921
 
922 922
 	/**
923 923
 	 * @param string $filter
924
-	 * @param string|string[] $attr
924
+	 * @param string[] $attr
925 925
 	 * @param int $limit
926 926
 	 * @param int $offset
927 927
 	 * @return false|int
@@ -1020,7 +1020,7 @@  discard block
 block discarded – undo
1020 1020
 	/**
1021 1021
 	 * retrieved. Results will according to the order in the array.
1022 1022
 	 *
1023
-	 * @param $filter
1023
+	 * @param string $filter
1024 1024
 	 * @param $base
1025 1025
 	 * @param null $attr
1026 1026
 	 * @param int $limit optional, maximum results to be counted
@@ -1282,7 +1282,7 @@  discard block
 block discarded – undo
1282 1282
 
1283 1283
 	/**
1284 1284
 	 * @param string $name
1285
-	 * @return bool|mixed|string
1285
+	 * @return string
1286 1286
 	 */
1287 1287
 	public function sanitizeUsername($name) {
1288 1288
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -1306,6 +1306,7 @@  discard block
 block discarded – undo
1306 1306
 	* escapes (user provided) parts for LDAP filter
1307 1307
 	* @param string $input, the provided value
1308 1308
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
1309
+	* @param string $input
1309 1310
 	* @return string the escaped string
1310 1311
 	*/
1311 1312
 	public function escapeFilterPart($input, $allowAsterisk = false) {
Please login to merge, or discard this patch.