Version13000Date20170705121758::changeSchema() - Code Metrics - Inspection of "Merge pull request #5231 from nextcloud/migrations" - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ca5656...60398b )

by Morris

created 2017-07-05 15:33 UTC

Version13000Date20170705121758::changeSchema() A

↳ Parent: Version13000Date20170705121758

Complexity

Conditions	3
Paths	4

Size

Total Lines	54
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	36
c	0
b	0
f	0
nc	4
nop	3
dl	0
loc	54
rs	9.6716

How to fix Long Method

<?php
/**
 * @copyright Copyright (c) 2017 Joas Schilling <[email protected]>
 *
 * @author Joas Schilling <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OC\Core\Migrations;

use Doctrine\DBAL\Schema\Schema;
use Doctrine\DBAL\Types\Type;
use OCP\Migration\SimpleMigrationStep;
use OCP\Migration\IOutput;

class Version13000Date20170705121758 extends SimpleMigrationStep {
	/**
	 * @param IOutput $output
	 * @param \Closure $schemaClosure The `\Closure` returns a `Schema`
	 * @param array $options
	 * @return null|Schema
	 * @since 13.0.0
	 */
	public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
		/** @var Schema $schema */
		$schema = $schemaClosure();

		if (!$schema->hasTable('personal_sections')) {
			$table = $schema->createTable('personal_sections');

			$table->addColumn('id', Type::STRING, [
				'notnull' => false,
				'length' => 64,
			]);
			$table->addColumn('class', Type::STRING, [
				'notnull' => true,
				'length' => 255,
			]);
			$table->addColumn('priority', Type::INTEGER, [
				'notnull' => true,
				'length' => 6,
				'default' => 0,
			]);

			$table->setPrimaryKey(['id'], 'personal_sections_id_index');
			$table->addUniqueIndex(['class'], 'personal_sections_class');
		}

		if (!$schema->hasTable('personal_settings')) {
			$table = $schema->createTable('personal_settings');

			$table->addColumn('id', Type::INTEGER, [
				'autoincrement' => true,
				'notnull' => true,
				'length' => 20,
			]);
			$table->addColumn('class', Type::STRING, [
				'notnull' => true,
				'length' => 255,
			]);
			$table->addColumn('section', Type::STRING, [
				'notnull' => false,
				'length' => 64,
			]);
			$table->addColumn('priority', Type::INTEGER, [
				'notnull' => true,
				'length' => 6,
				'default' => 0,
			]);

			$table->setPrimaryKey(['id'], 'personal_settings_id_index');
			$table->addUniqueIndex(['class'], 'personal_settings_class');
			$table->addIndex(['section'], 'personal_settings_section');
		}

		return $schema;
	}
}


1			<?php
2			/**
3			* @copyright Copyright (c) 2017 Joas Schilling <[email protected]>
4			*
5			* @author Joas Schilling <[email protected]>
6			*
7			* @license GNU AGPL version 3 or any later version
8			*
9			* This program is free software: you can redistribute it and/or modify
10			* it under the terms of the GNU Affero General Public License as
11			* published by the Free Software Foundation, either version 3 of the
12			* License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU Affero General Public License for more details.
18			*
19			* You should have received a copy of the GNU Affero General Public License
20			* along with this program. If not, see <http://www.gnu.org/licenses/>.
21			*
22			*/
23
24			namespace OC\Core\Migrations;
25
26			use Doctrine\DBAL\Schema\Schema;
27			use Doctrine\DBAL\Types\Type;
28			use OCP\Migration\SimpleMigrationStep;
29			use OCP\Migration\IOutput;
30
31			class Version13000Date20170705121758 extends SimpleMigrationStep {
32			/**
33			* @param IOutput $output
34			* @param \Closure $schemaClosure The `\Closure` returns a `Schema`
35			* @param array $options
36			* @return null\|Schema
37			* @since 13.0.0
38			*/
39			public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
40			/** @var Schema $schema */
41			$schema = $schemaClosure();
42
43			if (!$schema->hasTable('personal_sections')) {
44			$table = $schema->createTable('personal_sections');
45
46			$table->addColumn('id', Type::STRING, [
47			'notnull' => false,
48			'length' => 64,
49			]);
50			$table->addColumn('class', Type::STRING, [
51			'notnull' => true,
52			'length' => 255,
53			]);
54			$table->addColumn('priority', Type::INTEGER, [
55			'notnull' => true,
56			'length' => 6,
57			'default' => 0,
58			]);
59
60			$table->setPrimaryKey(['id'], 'personal_sections_id_index');
61			$table->addUniqueIndex(['class'], 'personal_sections_class');
62			}
63
64			if (!$schema->hasTable('personal_settings')) {
65			$table = $schema->createTable('personal_settings');
66
67			$table->addColumn('id', Type::INTEGER, [
68			'autoincrement' => true,
69			'notnull' => true,
70			'length' => 20,
71			]);
72			$table->addColumn('class', Type::STRING, [
73			'notnull' => true,
74			'length' => 255,
75			]);
76			$table->addColumn('section', Type::STRING, [
77			'notnull' => false,
78			'length' => 64,
79			]);
80			$table->addColumn('priority', Type::INTEGER, [
81			'notnull' => true,
82			'length' => 6,
83			'default' => 0,
84			]);
85
86			$table->setPrimaryKey(['id'], 'personal_settings_id_index');
87			$table->addUniqueIndex(['class'], 'personal_settings_class');
88			$table->addIndex(['section'], 'personal_settings_section');
89			}
90
91			return $schema;
92			}
93			}
94

nextcloud / server

Push — master ( ca5656...60398b )

Version13000Date20170705121758::changeSchema() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like