@@ -28,7 +28,7 @@ |
||
28 | 28 | use OCP\Util; |
29 | 29 | |
30 | 30 | class Application extends App { |
31 | - public function __construct () { |
|
31 | + public function __construct() { |
|
32 | 32 | parent::__construct('twofactor_backupcodes'); |
33 | 33 | } |
34 | 34 |
@@ -14,8 +14,8 @@ |
||
14 | 14 | |
15 | 15 | <?php if ($_['tooBig']) { ?> |
16 | 16 | <div class="warning updateAnyways"> |
17 | - <?php p($l->t('I know that if I continue doing the update via web UI has the risk, that the request runs into a timeout and could cause data loss, but I have a backup and know how to restore my instance in case of a failure.' )); ?> |
|
18 | - <a href="?IKnowThatThisIsABigInstanceAndTheUpdateRequestCouldRunIntoATimeoutAndHowToRestoreABackup=IAmSuperSureToDoThis" class="button updateAnywaysButton"><?php p($l->t('Upgrade via web on my own risk' )); ?></a> |
|
17 | + <?php p($l->t('I know that if I continue doing the update via web UI has the risk, that the request runs into a timeout and could cause data loss, but I have a backup and know how to restore my instance in case of a failure.')); ?> |
|
18 | + <a href="?IKnowThatThisIsABigInstanceAndTheUpdateRequestCouldRunIntoATimeoutAndHowToRestoreABackup=IAmSuperSureToDoThis" class="button updateAnywaysButton"><?php p($l->t('Upgrade via web on my own risk')); ?></a> |
|
19 | 19 | </div> |
20 | 20 | <?php } ?> |
21 | 21 |
@@ -84,7 +84,7 @@ |
||
84 | 84 | |
85 | 85 | if (isset($this->namespaces[$namespace])) { |
86 | 86 | if (!isset($this->hasNoAppContainer[$namespace])) { |
87 | - $applicationClassName = 'OCA\\' . $sensitiveNamespace . '\\AppInfo\\Application'; |
|
87 | + $applicationClassName = 'OCA\\'.$sensitiveNamespace.'\\AppInfo\\Application'; |
|
88 | 88 | if (class_exists($applicationClassName)) { |
89 | 89 | new $applicationClassName(); |
90 | 90 | if (isset($this->appContainers[$namespace])) { |
@@ -49,7 +49,7 @@ discard block |
||
49 | 49 | $result = $qb->execute(); |
50 | 50 | $row = $result->fetch(); |
51 | 51 | $result->closeCursor(); |
52 | - if($row === false) { |
|
52 | + if ($row === false) { |
|
53 | 53 | throw new ClientNotFoundException(); |
54 | 54 | } |
55 | 55 | return Client::fromRow($row); |
@@ -69,7 +69,7 @@ discard block |
||
69 | 69 | $result = $qb->execute(); |
70 | 70 | $row = $result->fetch(); |
71 | 71 | $result->closeCursor(); |
72 | - if($row === false) { |
|
72 | + if ($row === false) { |
|
73 | 73 | throw new ClientNotFoundException(); |
74 | 74 | } |
75 | 75 | return Client::fromRow($row); |
@@ -49,7 +49,7 @@ |
||
49 | 49 | $result = $qb->execute(); |
50 | 50 | $row = $result->fetch(); |
51 | 51 | $result->closeCursor(); |
52 | - if($row === false) { |
|
52 | + if ($row === false) { |
|
53 | 53 | throw new AccessTokenNotFoundException(); |
54 | 54 | } |
55 | 55 | return AccessToken::fromRow($row); |
@@ -170,12 +170,12 @@ discard block |
||
170 | 170 | */ |
171 | 171 | private function requiresCSRFCheck() { |
172 | 172 | // GET requires no check at all |
173 | - if($this->request->getMethod() === 'GET') { |
|
173 | + if ($this->request->getMethod() === 'GET') { |
|
174 | 174 | return false; |
175 | 175 | } |
176 | 176 | |
177 | 177 | // Official Nextcloud clients require no checks |
178 | - if($this->request->isUserAgent([ |
|
178 | + if ($this->request->isUserAgent([ |
|
179 | 179 | IRequest::USER_AGENT_CLIENT_DESKTOP, |
180 | 180 | IRequest::USER_AGENT_CLIENT_ANDROID, |
181 | 181 | IRequest::USER_AGENT_CLIENT_IOS, |
@@ -184,17 +184,17 @@ discard block |
||
184 | 184 | } |
185 | 185 | |
186 | 186 | // If not logged-in no check is required |
187 | - if(!$this->userSession->isLoggedIn()) { |
|
187 | + if (!$this->userSession->isLoggedIn()) { |
|
188 | 188 | return false; |
189 | 189 | } |
190 | 190 | |
191 | 191 | // POST always requires a check |
192 | - if($this->request->getMethod() === 'POST') { |
|
192 | + if ($this->request->getMethod() === 'POST') { |
|
193 | 193 | return true; |
194 | 194 | } |
195 | 195 | |
196 | 196 | // If logged-in AND DAV authenticated no check is required |
197 | - if($this->userSession->isLoggedIn() && |
|
197 | + if ($this->userSession->isLoggedIn() && |
|
198 | 198 | $this->isDavAuthenticated($this->userSession->getUser()->getUID())) { |
199 | 199 | return false; |
200 | 200 | } |
@@ -211,10 +211,10 @@ discard block |
||
211 | 211 | private function auth(RequestInterface $request, ResponseInterface $response) { |
212 | 212 | $forcedLogout = false; |
213 | 213 | |
214 | - if(!$this->request->passesCSRFCheck() && |
|
214 | + if (!$this->request->passesCSRFCheck() && |
|
215 | 215 | $this->requiresCSRFCheck()) { |
216 | 216 | // In case of a fail with POST we need to recheck the credentials |
217 | - if($this->request->getMethod() === 'POST') { |
|
217 | + if ($this->request->getMethod() === 'POST') { |
|
218 | 218 | $forcedLogout = true; |
219 | 219 | } else { |
220 | 220 | $response->setStatus(401); |
@@ -222,10 +222,10 @@ discard block |
||
222 | 222 | } |
223 | 223 | } |
224 | 224 | |
225 | - if($forcedLogout) { |
|
225 | + if ($forcedLogout) { |
|
226 | 226 | $this->userSession->logout(); |
227 | 227 | } else { |
228 | - if($this->twoFactorManager->needsSecondFactor($this->userSession->getUser())) { |
|
228 | + if ($this->twoFactorManager->needsSecondFactor($this->userSession->getUser())) { |
|
229 | 229 | throw new \Sabre\DAV\Exception\NotAuthenticated('2FA challenge not passed.'); |
230 | 230 | } |
231 | 231 | if (\OC_User::handleApacheAuth() || |
@@ -238,19 +238,19 @@ discard block |
||
238 | 238 | \OC_Util::setupFS($user); |
239 | 239 | $this->currentUser = $user; |
240 | 240 | $this->session->close(); |
241 | - return [true, $this->principalPrefix . $user]; |
|
241 | + return [true, $this->principalPrefix.$user]; |
|
242 | 242 | } |
243 | 243 | } |
244 | 244 | |
245 | 245 | if (!$this->userSession->isLoggedIn() && in_array('XMLHttpRequest', explode(',', $request->getHeader('X-Requested-With')))) { |
246 | 246 | // do not re-authenticate over ajax, use dummy auth name to prevent browser popup |
247 | - $response->addHeader('WWW-Authenticate','DummyBasic realm="' . $this->realm . '"'); |
|
247 | + $response->addHeader('WWW-Authenticate', 'DummyBasic realm="'.$this->realm.'"'); |
|
248 | 248 | $response->setStatus(401); |
249 | 249 | throw new \Sabre\DAV\Exception\NotAuthenticated('Cannot authenticate over ajax calls'); |
250 | 250 | } |
251 | 251 | |
252 | 252 | $data = parent::check($request, $response); |
253 | - if($data[0] === true) { |
|
253 | + if ($data[0] === true) { |
|
254 | 254 | $startPos = strrpos($data[1], '/') + 1; |
255 | 255 | $user = $this->userSession->getUser()->getUID(); |
256 | 256 | $data[1] = substr_replace($data[1], $user, $startPos); |
@@ -55,7 +55,7 @@ discard block |
||
55 | 55 | private function setupUserFs($userId) { |
56 | 56 | \OC_Util::setupFS($userId); |
57 | 57 | $this->session->close(); |
58 | - return $this->principalPrefix . $userId; |
|
58 | + return $this->principalPrefix.$userId; |
|
59 | 59 | } |
60 | 60 | |
61 | 61 | /** |
@@ -64,10 +64,10 @@ discard block |
||
64 | 64 | public function validateBearerToken($bearerToken) { |
65 | 65 | \OC_Util::setupFS(); |
66 | 66 | |
67 | - if(!$this->userSession->isLoggedIn()) { |
|
67 | + if (!$this->userSession->isLoggedIn()) { |
|
68 | 68 | $this->userSession->tryTokenLogin($this->request); |
69 | 69 | } |
70 | - if($this->userSession->isLoggedIn()) { |
|
70 | + if ($this->userSession->isLoggedIn()) { |
|
71 | 71 | return $this->setupUserFs($this->userSession->getUser()->getUID()); |
72 | 72 | } |
73 | 73 |
@@ -71,26 +71,26 @@ |
||
71 | 71 | } |
72 | 72 | |
73 | 73 | $app = substr($script, 0, strpos($script, '/')); |
74 | - $script = substr($script, strpos($script, '/')+1); |
|
74 | + $script = substr($script, strpos($script, '/') + 1); |
|
75 | 75 | $app_path = \OC_App::getAppPath($app); |
76 | 76 | $app_url = \OC_App::getAppWebPath($app); |
77 | 77 | |
78 | 78 | // missing translations files fill be ignored |
79 | 79 | if (strpos($script, 'l10n/') === 0) { |
80 | - $this->appendIfExist($app_path, $script . '.js', $app_url); |
|
80 | + $this->appendIfExist($app_path, $script.'.js', $app_url); |
|
81 | 81 | return; |
82 | 82 | } |
83 | 83 | |
84 | 84 | if ($app_path === false && $app_url === false) { |
85 | 85 | $this->logger->error('Could not find resource {resource} to load', [ |
86 | - 'resource' => $app . '/' . $script . '.js', |
|
86 | + 'resource' => $app.'/'.$script.'.js', |
|
87 | 87 | 'app' => 'jsresourceloader', |
88 | 88 | ]); |
89 | 89 | return; |
90 | 90 | } |
91 | 91 | |
92 | 92 | if (!$this->cacheAndAppendCombineJsonIfExist($app_path, $script.'.json', $app)) { |
93 | - $this->append($app_path, $script . '.js', $app_url); |
|
93 | + $this->append($app_path, $script.'.js', $app_url); |
|
94 | 94 | } |
95 | 95 | } |
96 | 96 |
@@ -26,7 +26,7 @@ |
||
26 | 26 | $app = new \OCP\AppFramework\App('theming'); |
27 | 27 | /** @var \OCA\Theming\Util $util */ |
28 | 28 | $util = $app->getContainer()->query(\OCA\Theming\Util::class); |
29 | -if(!$util->isAlreadyThemed()) { |
|
29 | +if (!$util->isAlreadyThemed()) { |
|
30 | 30 | |
31 | 31 | $app->getContainer()->registerCapability(\OCA\Theming\Capabilities::class); |
32 | 32 |