Passed
Push — master ( a1ed1d...263a69 )
by John
16:05 queued 13s
created
apps/theming/lib/Themes/CommonThemeTrait.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 		$variables = [];
91 91
 
92 92
 		// Default last fallback values
93
-		$variables['--image-background-default'] = "url('" . $this->themingDefaults->getBackground() . "')";
93
+		$variables['--image-background-default'] = "url('".$this->themingDefaults->getBackground()."')";
94 94
 		$variables['--color-background-plain'] = $this->defaultPrimaryColor;
95 95
 
96 96
 		// Register image variables only if custom-defined
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 			if ($this->imageManager->hasImage($image)) {
99 99
 				$imageUrl = $this->imageManager->getImageUrl($image);
100 100
 				// --image-background is overridden by user theming
101
-				$variables["--image-$image"] = "url('" . $imageUrl . "')";
101
+				$variables["--image-$image"] = "url('".$imageUrl."')";
102 102
 			}
103 103
 		}
104 104
 
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 			&& !$this->themingDefaults->isUserThemingDisabled()
129 129
 			&& $this->appManager->isEnabledForUser(Application::APP_ID)) {
130 130
 			$backgroundImage = $this->config->getUserValue($user->getUID(), Application::APP_ID, 'background_image', BackgroundService::BACKGROUND_DEFAULT);
131
-			$currentVersion = (int)$this->config->getUserValue($user->getUID(), Application::APP_ID, 'userCacheBuster', '0');
131
+			$currentVersion = (int) $this->config->getUserValue($user->getUID(), Application::APP_ID, 'userCacheBuster', '0');
132 132
 			$isPrimaryBright = $this->util->invertTextColor($this->primaryColor);
133 133
 
134 134
 			// The user removed the background
@@ -143,9 +143,9 @@  discard block
 block discarded – undo
143 143
 
144 144
 			// The user uploaded a custom background
145 145
 			if ($backgroundImage === BackgroundService::BACKGROUND_CUSTOM) {
146
-				$cacheBuster = substr(sha1($user->getUID() . '_' . $currentVersion), 0, 8);
146
+				$cacheBuster = substr(sha1($user->getUID().'_'.$currentVersion), 0, 8);
147 147
 				return [
148
-					'--image-background' => "url('" . $this->urlGenerator->linkToRouteAbsolute('theming.userTheme.getBackground') . "?v=$cacheBuster')",
148
+					'--image-background' => "url('".$this->urlGenerator->linkToRouteAbsolute('theming.userTheme.getBackground')."?v=$cacheBuster')",
149 149
 					'--color-background-plain' => $this->themingDefaults->getColorPrimary(),
150 150
 				];
151 151
 			}
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 			// The user picked a shipped background
154 154
 			if (isset(BackgroundService::SHIPPED_BACKGROUNDS[$backgroundImage])) {
155 155
 				return [
156
-					'--image-background' => "url('" . $this->urlGenerator->linkTo(Application::APP_ID, "img/background/$backgroundImage") . "')",
156
+					'--image-background' => "url('".$this->urlGenerator->linkTo(Application::APP_ID, "img/background/$backgroundImage")."')",
157 157
 					'--color-background-plain' => $this->themingDefaults->getColorPrimary(),
158 158
 					'--background-image-invert-if-bright' => BackgroundService::SHIPPED_BACKGROUNDS[$backgroundImage]['theming'] ?? null === BackgroundService::THEMING_MODE_DARK ? 'invert(100%)' : 'no',
159 159
 				];
Please login to merge, or discard this patch.