Completed
Push — master ( be71ce...e964f8 )
by Björn
15:54
created
settings/Controller/CheckSetupController.php 1 patch
Indentation   +372 added lines, -372 removed lines patch added patch discarded remove patch
@@ -46,282 +46,282 @@  discard block
 block discarded – undo
46 46
  * @package OC\Settings\Controller
47 47
  */
48 48
 class CheckSetupController extends Controller {
49
-	/** @var IConfig */
50
-	private $config;
51
-	/** @var IClientService */
52
-	private $clientService;
53
-	/** @var \OC_Util */
54
-	private $util;
55
-	/** @var IURLGenerator */
56
-	private $urlGenerator;
57
-	/** @var IL10N */
58
-	private $l10n;
59
-	/** @var Checker */
60
-	private $checker;
61
-	/** @var ILogger */
62
-	private $logger;
63
-
64
-	/**
65
-	 * @param string $AppName
66
-	 * @param IRequest $request
67
-	 * @param IConfig $config
68
-	 * @param IClientService $clientService
69
-	 * @param IURLGenerator $urlGenerator
70
-	 * @param \OC_Util $util
71
-	 * @param IL10N $l10n
72
-	 * @param Checker $checker
73
-	 * @param ILogger $logger
74
-	 */
75
-	public function __construct($AppName,
76
-								IRequest $request,
77
-								IConfig $config,
78
-								IClientService $clientService,
79
-								IURLGenerator $urlGenerator,
80
-								\OC_Util $util,
81
-								IL10N $l10n,
82
-								Checker $checker,
83
-								ILogger $logger) {
84
-		parent::__construct($AppName, $request);
85
-		$this->config = $config;
86
-		$this->clientService = $clientService;
87
-		$this->util = $util;
88
-		$this->urlGenerator = $urlGenerator;
89
-		$this->l10n = $l10n;
90
-		$this->checker = $checker;
91
-		$this->logger = $logger;
92
-	}
93
-
94
-	/**
95
-	 * Checks if the ownCloud server can connect to the internet using HTTPS and HTTP
96
-	 * @return bool
97
-	 */
98
-	private function isInternetConnectionWorking() {
99
-		if ($this->config->getSystemValue('has_internet_connection', true) === false) {
100
-			return false;
101
-		}
102
-
103
-		$siteArray = ['www.nextcloud.com',
104
-						'www.google.com',
105
-						'www.github.com'];
106
-
107
-		foreach($siteArray as $site) {
108
-			if ($this->isSiteReachable($site)) {
109
-				return true;
110
-			}
111
-		}
112
-		return false;
113
-	}
114
-
115
-	/**
116
-	* Chceks if the ownCloud server can connect to a specific URL using both HTTPS and HTTP
117
-	* @return bool
118
-	*/
119
-	private function isSiteReachable($sitename) {
120
-		$httpSiteName = 'http://' . $sitename . '/';
121
-		$httpsSiteName = 'https://' . $sitename . '/';
122
-
123
-		try {
124
-			$client = $this->clientService->newClient();
125
-			$client->get($httpSiteName);
126
-			$client->get($httpsSiteName);
127
-		} catch (\Exception $e) {
128
-			$this->logger->logException($e, ['app' => 'internet_connection_check']);
129
-			return false;
130
-		}
131
-		return true;
132
-	}
133
-
134
-	/**
135
-	 * Checks whether a local memcache is installed or not
136
-	 * @return bool
137
-	 */
138
-	private function isMemcacheConfigured() {
139
-		return $this->config->getSystemValue('memcache.local', null) !== null;
140
-	}
141
-
142
-	/**
143
-	 * Whether /dev/urandom is available to the PHP controller
144
-	 *
145
-	 * @return bool
146
-	 */
147
-	private function isUrandomAvailable() {
148
-		if(@file_exists('/dev/urandom')) {
149
-			$file = fopen('/dev/urandom', 'rb');
150
-			if($file) {
151
-				fclose($file);
152
-				return true;
153
-			}
154
-		}
155
-
156
-		return false;
157
-	}
158
-
159
-	/**
160
-	 * Public for the sake of unit-testing
161
-	 *
162
-	 * @return array
163
-	 */
164
-	protected function getCurlVersion() {
165
-		return curl_version();
166
-	}
167
-
168
-	/**
169
-	 * Check if the used  SSL lib is outdated. Older OpenSSL and NSS versions do
170
-	 * have multiple bugs which likely lead to problems in combination with
171
-	 * functionality required by ownCloud such as SNI.
172
-	 *
173
-	 * @link https://github.com/owncloud/core/issues/17446#issuecomment-122877546
174
-	 * @link https://bugzilla.redhat.com/show_bug.cgi?id=1241172
175
-	 * @return string
176
-	 */
177
-	private function isUsedTlsLibOutdated() {
178
-		// Don't run check when:
179
-		// 1. Server has `has_internet_connection` set to false
180
-		// 2. AppStore AND S2S is disabled
181
-		if(!$this->config->getSystemValue('has_internet_connection', true)) {
182
-			return '';
183
-		}
184
-		if(!$this->config->getSystemValue('appstoreenabled', true)
185
-			&& $this->config->getAppValue('files_sharing', 'outgoing_server2server_share_enabled', 'yes') === 'no'
186
-			&& $this->config->getAppValue('files_sharing', 'incoming_server2server_share_enabled', 'yes') === 'no') {
187
-			return '';
188
-		}
189
-
190
-		$versionString = $this->getCurlVersion();
191
-		if(isset($versionString['ssl_version'])) {
192
-			$versionString = $versionString['ssl_version'];
193
-		} else {
194
-			return '';
195
-		}
196
-
197
-		$features = (string)$this->l10n->t('installing and updating apps via the app store or Federated Cloud Sharing');
198
-		if(!$this->config->getSystemValue('appstoreenabled', true)) {
199
-			$features = (string)$this->l10n->t('Federated Cloud Sharing');
200
-		}
201
-
202
-		// Check if at least OpenSSL after 1.01d or 1.0.2b
203
-		if(strpos($versionString, 'OpenSSL/') === 0) {
204
-			$majorVersion = substr($versionString, 8, 5);
205
-			$patchRelease = substr($versionString, 13, 6);
206
-
207
-			if(($majorVersion === '1.0.1' && ord($patchRelease) < ord('d')) ||
208
-				($majorVersion === '1.0.2' && ord($patchRelease) < ord('b'))) {
209
-				return (string) $this->l10n->t('cURL is using an outdated %s version (%s). Please update your operating system or features such as %s will not work reliably.', ['OpenSSL', $versionString, $features]);
210
-			}
211
-		}
212
-
213
-		// Check if NSS and perform heuristic check
214
-		if(strpos($versionString, 'NSS/') === 0) {
215
-			try {
216
-				$firstClient = $this->clientService->newClient();
217
-				$firstClient->get('https://nextcloud.com/');
218
-
219
-				$secondClient = $this->clientService->newClient();
220
-				$secondClient->get('https://nextcloud.com/');
221
-			} catch (ClientException $e) {
222
-				if($e->getResponse()->getStatusCode() === 400) {
223
-					return (string) $this->l10n->t('cURL is using an outdated %s version (%s). Please update your operating system or features such as %s will not work reliably.', ['NSS', $versionString, $features]);
224
-				}
225
-			}
226
-		}
227
-
228
-		return '';
229
-	}
230
-
231
-	/**
232
-	 * Whether the version is outdated
233
-	 *
234
-	 * @return bool
235
-	 */
236
-	protected function isPhpOutdated() {
237
-		if (version_compare(PHP_VERSION, '5.5.0') === -1) {
238
-			return true;
239
-		}
240
-
241
-		return false;
242
-	}
243
-
244
-	/**
245
-	 * Whether the php version is still supported (at time of release)
246
-	 * according to: https://secure.php.net/supported-versions.php
247
-	 *
248
-	 * @return array
249
-	 */
250
-	private function isPhpSupported() {
251
-		return ['eol' => $this->isPhpOutdated(), 'version' => PHP_VERSION];
252
-	}
253
-
254
-	/**
255
-	 * Check if the reverse proxy configuration is working as expected
256
-	 *
257
-	 * @return bool
258
-	 */
259
-	private function forwardedForHeadersWorking() {
260
-		$trustedProxies = $this->config->getSystemValue('trusted_proxies', []);
261
-		$remoteAddress = $this->request->getRemoteAddress();
262
-
263
-		if (is_array($trustedProxies) && in_array($remoteAddress, $trustedProxies)) {
264
-			return false;
265
-		}
266
-
267
-		// either not enabled or working correctly
268
-		return true;
269
-	}
270
-
271
-	/**
272
-	 * Checks if the correct memcache module for PHP is installed. Only
273
-	 * fails if memcached is configured and the working module is not installed.
274
-	 *
275
-	 * @return bool
276
-	 */
277
-	private function isCorrectMemcachedPHPModuleInstalled() {
278
-		if ($this->config->getSystemValue('memcache.distributed', null) !== '\OC\Memcache\Memcached') {
279
-			return true;
280
-		}
281
-
282
-		// there are two different memcached modules for PHP
283
-		// we only support memcached and not memcache
284
-		// https://code.google.com/p/memcached/wiki/PHPClientComparison
285
-		return !(!extension_loaded('memcached') && extension_loaded('memcache'));
286
-	}
287
-
288
-	/**
289
-	 * Checks if set_time_limit is not disabled.
290
-	 *
291
-	 * @return bool
292
-	 */
293
-	private function isSettimelimitAvailable() {
294
-		if (function_exists('set_time_limit')
295
-			&& strpos(@ini_get('disable_functions'), 'set_time_limit') === false) {
296
-			return true;
297
-		}
298
-
299
-		return false;
300
-	}
301
-
302
-	/**
303
-	 * @return RedirectResponse
304
-	 */
305
-	public function rescanFailedIntegrityCheck() {
306
-		$this->checker->runInstanceVerification();
307
-		return new RedirectResponse(
308
-			$this->urlGenerator->linkToRoute('settings.AdminSettings.index')
309
-		);
310
-	}
311
-
312
-	/**
313
-	 * @NoCSRFRequired
314
-	 * @return DataResponse
315
-	 */
316
-	public function getFailedIntegrityCheckFiles() {
317
-		if(!$this->checker->isCodeCheckEnforced()) {
318
-			return new DataDisplayResponse('Integrity checker has been disabled. Integrity cannot be verified.');
319
-		}
320
-
321
-		$completeResults = $this->checker->getResults();
322
-
323
-		if(!empty($completeResults)) {
324
-			$formattedTextResponse = 'Technical information
49
+    /** @var IConfig */
50
+    private $config;
51
+    /** @var IClientService */
52
+    private $clientService;
53
+    /** @var \OC_Util */
54
+    private $util;
55
+    /** @var IURLGenerator */
56
+    private $urlGenerator;
57
+    /** @var IL10N */
58
+    private $l10n;
59
+    /** @var Checker */
60
+    private $checker;
61
+    /** @var ILogger */
62
+    private $logger;
63
+
64
+    /**
65
+     * @param string $AppName
66
+     * @param IRequest $request
67
+     * @param IConfig $config
68
+     * @param IClientService $clientService
69
+     * @param IURLGenerator $urlGenerator
70
+     * @param \OC_Util $util
71
+     * @param IL10N $l10n
72
+     * @param Checker $checker
73
+     * @param ILogger $logger
74
+     */
75
+    public function __construct($AppName,
76
+                                IRequest $request,
77
+                                IConfig $config,
78
+                                IClientService $clientService,
79
+                                IURLGenerator $urlGenerator,
80
+                                \OC_Util $util,
81
+                                IL10N $l10n,
82
+                                Checker $checker,
83
+                                ILogger $logger) {
84
+        parent::__construct($AppName, $request);
85
+        $this->config = $config;
86
+        $this->clientService = $clientService;
87
+        $this->util = $util;
88
+        $this->urlGenerator = $urlGenerator;
89
+        $this->l10n = $l10n;
90
+        $this->checker = $checker;
91
+        $this->logger = $logger;
92
+    }
93
+
94
+    /**
95
+     * Checks if the ownCloud server can connect to the internet using HTTPS and HTTP
96
+     * @return bool
97
+     */
98
+    private function isInternetConnectionWorking() {
99
+        if ($this->config->getSystemValue('has_internet_connection', true) === false) {
100
+            return false;
101
+        }
102
+
103
+        $siteArray = ['www.nextcloud.com',
104
+                        'www.google.com',
105
+                        'www.github.com'];
106
+
107
+        foreach($siteArray as $site) {
108
+            if ($this->isSiteReachable($site)) {
109
+                return true;
110
+            }
111
+        }
112
+        return false;
113
+    }
114
+
115
+    /**
116
+     * Chceks if the ownCloud server can connect to a specific URL using both HTTPS and HTTP
117
+     * @return bool
118
+     */
119
+    private function isSiteReachable($sitename) {
120
+        $httpSiteName = 'http://' . $sitename . '/';
121
+        $httpsSiteName = 'https://' . $sitename . '/';
122
+
123
+        try {
124
+            $client = $this->clientService->newClient();
125
+            $client->get($httpSiteName);
126
+            $client->get($httpsSiteName);
127
+        } catch (\Exception $e) {
128
+            $this->logger->logException($e, ['app' => 'internet_connection_check']);
129
+            return false;
130
+        }
131
+        return true;
132
+    }
133
+
134
+    /**
135
+     * Checks whether a local memcache is installed or not
136
+     * @return bool
137
+     */
138
+    private function isMemcacheConfigured() {
139
+        return $this->config->getSystemValue('memcache.local', null) !== null;
140
+    }
141
+
142
+    /**
143
+     * Whether /dev/urandom is available to the PHP controller
144
+     *
145
+     * @return bool
146
+     */
147
+    private function isUrandomAvailable() {
148
+        if(@file_exists('/dev/urandom')) {
149
+            $file = fopen('/dev/urandom', 'rb');
150
+            if($file) {
151
+                fclose($file);
152
+                return true;
153
+            }
154
+        }
155
+
156
+        return false;
157
+    }
158
+
159
+    /**
160
+     * Public for the sake of unit-testing
161
+     *
162
+     * @return array
163
+     */
164
+    protected function getCurlVersion() {
165
+        return curl_version();
166
+    }
167
+
168
+    /**
169
+     * Check if the used  SSL lib is outdated. Older OpenSSL and NSS versions do
170
+     * have multiple bugs which likely lead to problems in combination with
171
+     * functionality required by ownCloud such as SNI.
172
+     *
173
+     * @link https://github.com/owncloud/core/issues/17446#issuecomment-122877546
174
+     * @link https://bugzilla.redhat.com/show_bug.cgi?id=1241172
175
+     * @return string
176
+     */
177
+    private function isUsedTlsLibOutdated() {
178
+        // Don't run check when:
179
+        // 1. Server has `has_internet_connection` set to false
180
+        // 2. AppStore AND S2S is disabled
181
+        if(!$this->config->getSystemValue('has_internet_connection', true)) {
182
+            return '';
183
+        }
184
+        if(!$this->config->getSystemValue('appstoreenabled', true)
185
+            && $this->config->getAppValue('files_sharing', 'outgoing_server2server_share_enabled', 'yes') === 'no'
186
+            && $this->config->getAppValue('files_sharing', 'incoming_server2server_share_enabled', 'yes') === 'no') {
187
+            return '';
188
+        }
189
+
190
+        $versionString = $this->getCurlVersion();
191
+        if(isset($versionString['ssl_version'])) {
192
+            $versionString = $versionString['ssl_version'];
193
+        } else {
194
+            return '';
195
+        }
196
+
197
+        $features = (string)$this->l10n->t('installing and updating apps via the app store or Federated Cloud Sharing');
198
+        if(!$this->config->getSystemValue('appstoreenabled', true)) {
199
+            $features = (string)$this->l10n->t('Federated Cloud Sharing');
200
+        }
201
+
202
+        // Check if at least OpenSSL after 1.01d or 1.0.2b
203
+        if(strpos($versionString, 'OpenSSL/') === 0) {
204
+            $majorVersion = substr($versionString, 8, 5);
205
+            $patchRelease = substr($versionString, 13, 6);
206
+
207
+            if(($majorVersion === '1.0.1' && ord($patchRelease) < ord('d')) ||
208
+                ($majorVersion === '1.0.2' && ord($patchRelease) < ord('b'))) {
209
+                return (string) $this->l10n->t('cURL is using an outdated %s version (%s). Please update your operating system or features such as %s will not work reliably.', ['OpenSSL', $versionString, $features]);
210
+            }
211
+        }
212
+
213
+        // Check if NSS and perform heuristic check
214
+        if(strpos($versionString, 'NSS/') === 0) {
215
+            try {
216
+                $firstClient = $this->clientService->newClient();
217
+                $firstClient->get('https://nextcloud.com/');
218
+
219
+                $secondClient = $this->clientService->newClient();
220
+                $secondClient->get('https://nextcloud.com/');
221
+            } catch (ClientException $e) {
222
+                if($e->getResponse()->getStatusCode() === 400) {
223
+                    return (string) $this->l10n->t('cURL is using an outdated %s version (%s). Please update your operating system or features such as %s will not work reliably.', ['NSS', $versionString, $features]);
224
+                }
225
+            }
226
+        }
227
+
228
+        return '';
229
+    }
230
+
231
+    /**
232
+     * Whether the version is outdated
233
+     *
234
+     * @return bool
235
+     */
236
+    protected function isPhpOutdated() {
237
+        if (version_compare(PHP_VERSION, '5.5.0') === -1) {
238
+            return true;
239
+        }
240
+
241
+        return false;
242
+    }
243
+
244
+    /**
245
+     * Whether the php version is still supported (at time of release)
246
+     * according to: https://secure.php.net/supported-versions.php
247
+     *
248
+     * @return array
249
+     */
250
+    private function isPhpSupported() {
251
+        return ['eol' => $this->isPhpOutdated(), 'version' => PHP_VERSION];
252
+    }
253
+
254
+    /**
255
+     * Check if the reverse proxy configuration is working as expected
256
+     *
257
+     * @return bool
258
+     */
259
+    private function forwardedForHeadersWorking() {
260
+        $trustedProxies = $this->config->getSystemValue('trusted_proxies', []);
261
+        $remoteAddress = $this->request->getRemoteAddress();
262
+
263
+        if (is_array($trustedProxies) && in_array($remoteAddress, $trustedProxies)) {
264
+            return false;
265
+        }
266
+
267
+        // either not enabled or working correctly
268
+        return true;
269
+    }
270
+
271
+    /**
272
+     * Checks if the correct memcache module for PHP is installed. Only
273
+     * fails if memcached is configured and the working module is not installed.
274
+     *
275
+     * @return bool
276
+     */
277
+    private function isCorrectMemcachedPHPModuleInstalled() {
278
+        if ($this->config->getSystemValue('memcache.distributed', null) !== '\OC\Memcache\Memcached') {
279
+            return true;
280
+        }
281
+
282
+        // there are two different memcached modules for PHP
283
+        // we only support memcached and not memcache
284
+        // https://code.google.com/p/memcached/wiki/PHPClientComparison
285
+        return !(!extension_loaded('memcached') && extension_loaded('memcache'));
286
+    }
287
+
288
+    /**
289
+     * Checks if set_time_limit is not disabled.
290
+     *
291
+     * @return bool
292
+     */
293
+    private function isSettimelimitAvailable() {
294
+        if (function_exists('set_time_limit')
295
+            && strpos(@ini_get('disable_functions'), 'set_time_limit') === false) {
296
+            return true;
297
+        }
298
+
299
+        return false;
300
+    }
301
+
302
+    /**
303
+     * @return RedirectResponse
304
+     */
305
+    public function rescanFailedIntegrityCheck() {
306
+        $this->checker->runInstanceVerification();
307
+        return new RedirectResponse(
308
+            $this->urlGenerator->linkToRoute('settings.AdminSettings.index')
309
+        );
310
+    }
311
+
312
+    /**
313
+     * @NoCSRFRequired
314
+     * @return DataResponse
315
+     */
316
+    public function getFailedIntegrityCheckFiles() {
317
+        if(!$this->checker->isCodeCheckEnforced()) {
318
+            return new DataDisplayResponse('Integrity checker has been disabled. Integrity cannot be verified.');
319
+        }
320
+
321
+        $completeResults = $this->checker->getResults();
322
+
323
+        if(!empty($completeResults)) {
324
+            $formattedTextResponse = 'Technical information
325 325
 =====================
326 326
 The following list covers which files have failed the integrity check. Please read
327 327
 the previous linked documentation to learn more about the errors and how to fix
@@ -330,103 +330,103 @@  discard block
 block discarded – undo
330 330
 Results
331 331
 =======
332 332
 ';
333
-			foreach($completeResults as $context => $contextResult) {
334
-				$formattedTextResponse .= "- $context\n";
335
-
336
-				foreach($contextResult as $category => $result) {
337
-					$formattedTextResponse .= "\t- $category\n";
338
-					if($category !== 'EXCEPTION') {
339
-						foreach ($result as $key => $results) {
340
-							$formattedTextResponse .= "\t\t- $key\n";
341
-						}
342
-					} else {
343
-						foreach ($result as $key => $results) {
344
-							$formattedTextResponse .= "\t\t- $results\n";
345
-						}
346
-					}
347
-
348
-				}
349
-			}
350
-
351
-			$formattedTextResponse .= '
333
+            foreach($completeResults as $context => $contextResult) {
334
+                $formattedTextResponse .= "- $context\n";
335
+
336
+                foreach($contextResult as $category => $result) {
337
+                    $formattedTextResponse .= "\t- $category\n";
338
+                    if($category !== 'EXCEPTION') {
339
+                        foreach ($result as $key => $results) {
340
+                            $formattedTextResponse .= "\t\t- $key\n";
341
+                        }
342
+                    } else {
343
+                        foreach ($result as $key => $results) {
344
+                            $formattedTextResponse .= "\t\t- $results\n";
345
+                        }
346
+                    }
347
+
348
+                }
349
+            }
350
+
351
+            $formattedTextResponse .= '
352 352
 Raw output
353 353
 ==========
354 354
 ';
355
-			$formattedTextResponse .= print_r($completeResults, true);
356
-		} else {
357
-			$formattedTextResponse = 'No errors have been found.';
358
-		}
359
-
360
-
361
-		$response = new DataDisplayResponse(
362
-			$formattedTextResponse,
363
-			Http::STATUS_OK,
364
-			[
365
-				'Content-Type' => 'text/plain',
366
-			]
367
-		);
368
-
369
-		return $response;
370
-	}
371
-
372
-	/**
373
-	 * Checks whether a PHP opcache is properly set up
374
-	 * @return bool
375
-	 */
376
-	protected function isOpcacheProperlySetup() {
377
-		$iniWrapper = new IniGetWrapper();
378
-
379
-		$isOpcacheProperlySetUp = true;
380
-
381
-		if(!$iniWrapper->getBool('opcache.enable')) {
382
-			$isOpcacheProperlySetUp = false;
383
-		}
384
-
385
-		if(!$iniWrapper->getBool('opcache.save_comments')) {
386
-			$isOpcacheProperlySetUp = false;
387
-		}
388
-
389
-		if(!$iniWrapper->getBool('opcache.enable_cli')) {
390
-			$isOpcacheProperlySetUp = false;
391
-		}
392
-
393
-		if($iniWrapper->getNumeric('opcache.max_accelerated_files') < 10000) {
394
-			$isOpcacheProperlySetUp = false;
395
-		}
396
-
397
-		if($iniWrapper->getNumeric('opcache.memory_consumption') < 128) {
398
-			$isOpcacheProperlySetUp = false;
399
-		}
400
-
401
-		if($iniWrapper->getNumeric('opcache.interned_strings_buffer') < 8) {
402
-			$isOpcacheProperlySetUp = false;
403
-		}
404
-
405
-		return $isOpcacheProperlySetUp;
406
-	}
407
-
408
-	/**
409
-	 * @return DataResponse
410
-	 */
411
-	public function check() {
412
-		return new DataResponse(
413
-			[
414
-				'serverHasInternetConnection' => $this->isInternetConnectionWorking(),
415
-				'isMemcacheConfigured' => $this->isMemcacheConfigured(),
416
-				'memcacheDocs' => $this->urlGenerator->linkToDocs('admin-performance'),
417
-				'isUrandomAvailable' => $this->isUrandomAvailable(),
418
-				'securityDocs' => $this->urlGenerator->linkToDocs('admin-security'),
419
-				'isUsedTlsLibOutdated' => $this->isUsedTlsLibOutdated(),
420
-				'phpSupported' => $this->isPhpSupported(),
421
-				'forwardedForHeadersWorking' => $this->forwardedForHeadersWorking(),
422
-				'reverseProxyDocs' => $this->urlGenerator->linkToDocs('admin-reverse-proxy'),
423
-				'isCorrectMemcachedPHPModuleInstalled' => $this->isCorrectMemcachedPHPModuleInstalled(),
424
-				'hasPassedCodeIntegrityCheck' => $this->checker->hasPassedCheck(),
425
-				'codeIntegrityCheckerDocumentation' => $this->urlGenerator->linkToDocs('admin-code-integrity'),
426
-				'isOpcacheProperlySetup' => $this->isOpcacheProperlySetup(),
427
-				'phpOpcacheDocumentation' => $this->urlGenerator->linkToDocs('admin-php-opcache'),
428
-				'isSettimelimitAvailable' => $this->isSettimelimitAvailable(),
429
-			]
430
-		);
431
-	}
355
+            $formattedTextResponse .= print_r($completeResults, true);
356
+        } else {
357
+            $formattedTextResponse = 'No errors have been found.';
358
+        }
359
+
360
+
361
+        $response = new DataDisplayResponse(
362
+            $formattedTextResponse,
363
+            Http::STATUS_OK,
364
+            [
365
+                'Content-Type' => 'text/plain',
366
+            ]
367
+        );
368
+
369
+        return $response;
370
+    }
371
+
372
+    /**
373
+     * Checks whether a PHP opcache is properly set up
374
+     * @return bool
375
+     */
376
+    protected function isOpcacheProperlySetup() {
377
+        $iniWrapper = new IniGetWrapper();
378
+
379
+        $isOpcacheProperlySetUp = true;
380
+
381
+        if(!$iniWrapper->getBool('opcache.enable')) {
382
+            $isOpcacheProperlySetUp = false;
383
+        }
384
+
385
+        if(!$iniWrapper->getBool('opcache.save_comments')) {
386
+            $isOpcacheProperlySetUp = false;
387
+        }
388
+
389
+        if(!$iniWrapper->getBool('opcache.enable_cli')) {
390
+            $isOpcacheProperlySetUp = false;
391
+        }
392
+
393
+        if($iniWrapper->getNumeric('opcache.max_accelerated_files') < 10000) {
394
+            $isOpcacheProperlySetUp = false;
395
+        }
396
+
397
+        if($iniWrapper->getNumeric('opcache.memory_consumption') < 128) {
398
+            $isOpcacheProperlySetUp = false;
399
+        }
400
+
401
+        if($iniWrapper->getNumeric('opcache.interned_strings_buffer') < 8) {
402
+            $isOpcacheProperlySetUp = false;
403
+        }
404
+
405
+        return $isOpcacheProperlySetUp;
406
+    }
407
+
408
+    /**
409
+     * @return DataResponse
410
+     */
411
+    public function check() {
412
+        return new DataResponse(
413
+            [
414
+                'serverHasInternetConnection' => $this->isInternetConnectionWorking(),
415
+                'isMemcacheConfigured' => $this->isMemcacheConfigured(),
416
+                'memcacheDocs' => $this->urlGenerator->linkToDocs('admin-performance'),
417
+                'isUrandomAvailable' => $this->isUrandomAvailable(),
418
+                'securityDocs' => $this->urlGenerator->linkToDocs('admin-security'),
419
+                'isUsedTlsLibOutdated' => $this->isUsedTlsLibOutdated(),
420
+                'phpSupported' => $this->isPhpSupported(),
421
+                'forwardedForHeadersWorking' => $this->forwardedForHeadersWorking(),
422
+                'reverseProxyDocs' => $this->urlGenerator->linkToDocs('admin-reverse-proxy'),
423
+                'isCorrectMemcachedPHPModuleInstalled' => $this->isCorrectMemcachedPHPModuleInstalled(),
424
+                'hasPassedCodeIntegrityCheck' => $this->checker->hasPassedCheck(),
425
+                'codeIntegrityCheckerDocumentation' => $this->urlGenerator->linkToDocs('admin-code-integrity'),
426
+                'isOpcacheProperlySetup' => $this->isOpcacheProperlySetup(),
427
+                'phpOpcacheDocumentation' => $this->urlGenerator->linkToDocs('admin-php-opcache'),
428
+                'isSettimelimitAvailable' => $this->isSettimelimitAvailable(),
429
+            ]
430
+        );
431
+    }
432 432
 }
Please login to merge, or discard this patch.