Plugin::getCalendarHomeForPrincipal() - Code Metrics - Inspection of "Bump sabre" - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1792)

by Lukas

created 2016-11-09 10:54 UTC

Plugin::getCalendarHomeForPrincipal() A

↳ Parent: Plugin

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	4
Ratio	44.44 %

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	1
dl	4
loc	9
rs	9.6666
c	0
b	0
f	0

<?php
/**
 * @author Thomas Müller <[email protected]>
 *
 * @copyright Copyright (c) 2016, ownCloud GmbH.
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace OCA\DAV\CalDAV;

use Sabre\HTTP\URLUtil;

class Plugin extends \Sabre\CalDAV\Plugin {

	/**
	 * @inheritdoc
	 */
	function getCalendarHomeForPrincipal($principalUrl) {


		if (strrpos($principalUrl, 'principals/users', -strlen($principalUrl)) !== false) {

			list(, $principalId) = URLUtil::splitPath($principalUrl);
			return self::CALENDAR_ROOT .'/' . $principalId;
		}

		return;
	}

}


1		<?php
2		/**
3		* @author Thomas Müller <[email protected]>
4		*
5		* @copyright Copyright (c) 2016, ownCloud GmbH.
6		* @license AGPL-3.0
7		*
8		* This code is free software: you can redistribute it and/or modify
9		* it under the terms of the GNU Affero General Public License, version 3,
10		* as published by the Free Software Foundation.
11		*
12		* This program is distributed in the hope that it will be useful,
13		* but WITHOUT ANY WARRANTY; without even the implied warranty of
14		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15		* GNU Affero General Public License for more details.
16		*
17		* You should have received a copy of the GNU Affero General Public License, version 3,
18		* along with this program. If not, see <http://www.gnu.org/licenses/>
19		*
20		*/
21
22		namespace OCA\DAV\CalDAV;
23
24		use Sabre\HTTP\URLUtil;
25
26		class Plugin extends \Sabre\CalDAV\Plugin {
27
28		/**
29		* @inheritdoc
30		*/
31		function getCalendarHomeForPrincipal($principalUrl) {
		0 ignored issues – show Best Practice introduced 2016-10-18 21:15 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
32
33	View Code Duplication	if (strrpos($principalUrl, 'principals/users', -strlen($principalUrl)) !== false) {
		0 ignored issues – show Duplication introduced 2016-10-18 21:15 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		list(, $principalId) = URLUtil::splitPath($principalUrl);
35		return self::CALENDAR_ROOT .'/' . $principalId;
36		}
37
38		return;
39		}
40
41		}
42

nextcloud / server

Pull Request — master (#1792)

Plugin::getCalendarHomeForPrincipal() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like