Database - Code Metrics - Inspection of "Merge pull request #9488 from nextcloud/disabled-u..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d4a0af...760b28 )

by Blizzz

created 2018-05-25 13:54 UTC

Database A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	355
Duplicated Lines	15.49 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

Metric	Value
dl	55
loc	355
rs	10
c	0
b	0
f	0
wmc	28
lcom	1
cbo	6

13 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	fixDI()	0	5	2
A	createGroup()	0	13	1
B	deleteGroup()	0	26	1
A	inGroup()	16	16	2
A	addToGroup()	0	15	2
A	removeFromGroup()	0	11	1
B	getUserGroups()	0	24	4
B	getGroups()	5	26	3
A	groupExists()	0	22	3
B	usersInGroup()	5	27	3
B	countUsersInGroup()	5	26	3
B	countDisabledInGroup()	24	24	2

How to fix Duplicated Code

<?php
/**
 * @copyright Copyright (c) 2016, ownCloud, Inc.
 *
 * @author Aaron Wood <[email protected]>
 * @author Loki3000 <[email protected]>
 * @author Roeland Jago Douma <[email protected]>
 * @author John Molakvoæ <[email protected]>
 *
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */
/*
 *
 * The following SQL statement is just a help for developers and will not be
 * executed!
 *
 * CREATE TABLE `groups` (
 *   `gid` varchar(64) COLLATE utf8_unicode_ci NOT NULL,
 *   PRIMARY KEY (`gid`)
 * ) ENGINE=MyISAM DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;
 *
 * CREATE TABLE `group_user` (
 *   `gid` varchar(64) COLLATE utf8_unicode_ci NOT NULL,
 *   `uid` varchar(64) COLLATE utf8_unicode_ci NOT NULL
 * ) ENGINE=MyISAM DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;
 *
 */

namespace OC\Group;

use OCP\DB\QueryBuilder\IQueryBuilder;
use OCP\Group\Backend\ABackend;
use OCP\Group\Backend\IAddToGroupBackend;
use OCP\Group\Backend\ICountDisabledInGroup;
use OCP\Group\Backend\ICountUsersBackend;
use OCP\Group\Backend\ICreateGroupBackend;
use OCP\Group\Backend\IDeleteGroupBackend;
use OCP\Group\Backend\IRemoveFromGroupBackend;
use OCP\IDBConnection;

/**
 * Class for group management in a SQL Database (e.g. MySQL, SQLite)
 */
class Database extends ABackend

	implements IAddToGroupBackend,

	           ICountDisabledInGroup,

	           ICountUsersBackend,

	           ICreateGroupBackend,

	           IDeleteGroupBackend,

	           IRemoveFromGroupBackend {


	/** @var string[] */
	private $groupCache = [];

	/** @var IDBConnection */
	private $dbConn;

	/**
	 * \OC\Group\Database constructor.
	 *
	 * @param IDBConnection|null $dbConn
	 */
	public function __construct(IDBConnection $dbConn = null) {
		$this->dbConn = $dbConn;
	}

	/**
	 * FIXME: This function should not be required!
	 */
	private function fixDI() {
		if ($this->dbConn === null) {
			$this->dbConn = \OC::$server->getDatabaseConnection();
		}
	}

	/**
	 * Try to create a new group
	 * @param string $gid The name of the group to create
	 * @return bool
	 *
	 * Tries to create a new group. If the group name already exists, false will
	 * be returned.
	 */
	public function createGroup(string $gid): bool {
		$this->fixDI();

		// Add group
		$result = $this->dbConn->insertIfNotExist('*PREFIX*groups', [
			'gid' => $gid,
		]);

		// Add to cache
		$this->groupCache[$gid] = $gid;

		return $result === 1;
	}

	/**
	 * delete a group
	 * @param string $gid gid of the group to delete
	 * @return bool
	 *
	 * Deletes a group and removes it from the group_user-table
	 */
	public function deleteGroup(string $gid): bool {
		$this->fixDI();

		// Delete the group
		$qb = $this->dbConn->getQueryBuilder();
		$qb->delete('groups')
			->where($qb->expr()->eq('gid', $qb->createNamedParameter($gid)))
			->execute();

		// Delete the group-user relation
		$qb = $this->dbConn->getQueryBuilder();
		$qb->delete('group_user')
			->where($qb->expr()->eq('gid', $qb->createNamedParameter($gid)))
			->execute();

		// Delete the group-groupadmin relation
		$qb = $this->dbConn->getQueryBuilder();
		$qb->delete('group_admin')
			->where($qb->expr()->eq('gid', $qb->createNamedParameter($gid)))
			->execute();

		// Delete from cache
		unset($this->groupCache[$gid]);

		return true;
	}

	/**
	 * is user in group?
	 * @param string $uid uid of the user
	 * @param string $gid gid of the group
	 * @return bool
	 *
	 * Checks whether the user is member of a group or not.
	 */
	public function inGroup( $uid, $gid ) {
		$this->fixDI();

		// check
		$qb = $this->dbConn->getQueryBuilder();
		$cursor = $qb->select('uid')
			->from('group_user')
			->where($qb->expr()->eq('gid', $qb->createNamedParameter($gid)))
			->andWhere($qb->expr()->eq('uid', $qb->createNamedParameter($uid)))
			->execute();

		$result = $cursor->fetch();
		$cursor->closeCursor();

		return $result ? true : false;
	}

	/**
	 * Add a user to a group
	 * @param string $uid Name of the user to add to group
	 * @param string $gid Name of the group in which add the user
	 * @return bool
	 *
	 * Adds a user to a group.
	 */
	public function addToGroup(string $uid, string $gid): bool {
		$this->fixDI();

		// No duplicate entries!
		if( !$this->inGroup( $uid, $gid )) {
			$qb = $this->dbConn->getQueryBuilder();
			$qb->insert('group_user')
				->setValue('uid', $qb->createNamedParameter($uid))
				->setValue('gid', $qb->createNamedParameter($gid))
				->execute();
			return true;
		}else{
			return false;
		}
	}

	/**
	 * Removes a user from a group
	 * @param string $uid Name of the user to remove from group
	 * @param string $gid Name of the group from which remove the user
	 * @return bool
	 *
	 * removes the user from a group.
	 */
	public function removeFromGroup(string $uid, string $gid): bool {
		$this->fixDI();

		$qb = $this->dbConn->getQueryBuilder();
		$qb->delete('group_user')
			->where($qb->expr()->eq('uid', $qb->createNamedParameter($uid)))
			->andWhere($qb->expr()->eq('gid', $qb->createNamedParameter($gid)))
			->execute();

		return true;
	}

	/**
	 * Get all groups a user belongs to
	 * @param string $uid Name of the user
	 * @return array an array of group names
	 *
	 * This function fetches all groups a user belongs to. It does not check
	 * if the user exists at all.
	 */
	public function getUserGroups( $uid ) {
		//guests has empty or null $uid

		if ($uid === null || $uid === '') {
			return [];
		}

		$this->fixDI();

		// No magic!
		$qb = $this->dbConn->getQueryBuilder();
		$cursor = $qb->select('gid')
			->from('group_user')
			->where($qb->expr()->eq('uid', $qb->createNamedParameter($uid)))
			->execute();

		$groups = [];
		while( $row = $cursor->fetch()) {
			$groups[] = $row['gid'];
			$this->groupCache[$row['gid']] = $row['gid'];
		}
		$cursor->closeCursor();

		return $groups;
	}

	/**
	 * get a list of all groups
	 * @param string $search
	 * @param int $limit
	 * @param int $offset
	 * @return array an array of group names
	 *
	 * Returns a list with all groups
	 */
	public function getGroups($search = '', $limit = null, $offset = null) {
		$this->fixDI();

		$query = $this->dbConn->getQueryBuilder();
		$query->select('gid')
			->from('groups')
			->orderBy('gid', 'ASC');

		if ($search !== '') {
			$query->where($query->expr()->iLike('gid', $query->createNamedParameter(
				'%' . $this->dbConn->escapeLikeParameter($search) . '%'
			)));
		}

		$query->setMaxResults($limit)
			->setFirstResult($offset);
		$result = $query->execute();

		$groups = [];
		while ($row = $result->fetch()) {
			$groups[] = $row['gid'];
		}
		$result->closeCursor();

		return $groups;
	}

	/**
	 * check if a group exists
	 * @param string $gid
	 * @return bool
	 */
	public function groupExists($gid) {
		$this->fixDI();

		// Check cache first
		if (isset($this->groupCache[$gid])) {
			return true;
		}

		$qb = $this->dbConn->getQueryBuilder();
		$cursor = $qb->select('gid')
			->from('groups')
			->where($qb->expr()->eq('gid', $qb->createNamedParameter($gid)))
			->execute();
		$result = $cursor->fetch();
		$cursor->closeCursor();

		if ($result !== false) {
			$this->groupCache[$gid] = $gid;
			return true;
		}
		return false;
	}

	/**
	 * get a list of all users in a group
	 * @param string $gid
	 * @param string $search
	 * @param int $limit
	 * @param int $offset
	 * @return array an array of user ids
	 */
	public function usersInGroup($gid, $search = '', $limit = null, $offset = null) {
		$this->fixDI();

		$query = $this->dbConn->getQueryBuilder();
		$query->select('uid')
			->from('group_user')
			->where($query->expr()->eq('gid', $query->createNamedParameter($gid)))
			->orderBy('uid', 'ASC');

		if ($search !== '') {
			$query->andWhere($query->expr()->like('uid', $query->createNamedParameter(
				'%' . $this->dbConn->escapeLikeParameter($search) . '%'
			)));
		}

		$query->setMaxResults($limit)
			->setFirstResult($offset);
		$result = $query->execute();

		$users = [];
		while ($row = $result->fetch()) {
			$users[] = $row['uid'];
		}
		$result->closeCursor();

		return $users;
	}

	/**
	 * get the number of all users matching the search string in a group
	 * @param string $gid
	 * @param string $search
	 * @return int
	 */
	public function countUsersInGroup(string $gid, string $search = ''): int {
		$this->fixDI();

		$query = $this->dbConn->getQueryBuilder();
		$query->selectAlias($query->createFunction('COUNT(*)'), 'num_users')
			->from('group_user')
			->where($query->expr()->eq('gid', $query->createNamedParameter($gid)));

		if ($search !== '') {
			$query->andWhere($query->expr()->like('uid', $query->createNamedParameter(
				'%' . $this->dbConn->escapeLikeParameter($search) . '%'
			)));
		}

		$result = $query->execute();
		$count = $result->fetchColumn();
		$result->closeCursor();

		if ($count !== false) {
			$count = (int)$count;
		} else {
			$count = 0;
		}

		return $count;
	}

	/**
	 * get the number of disabled users in a group
	 *
	 * @param string $search
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	 * @return int|bool
	 */
	public function countDisabledInGroup(string $gid): int {
		$this->fixDI();
		
		$query = $this->dbConn->getQueryBuilder();
		$query->select($query->createFunction('COUNT(Distinct uid)'))
			->from('preferences', 'p')
			->innerJoin('p', 'group_user', 'g', 'p.userid = g.uid')
			->where($query->expr()->eq('appid', $query->createNamedParameter('core')))
			->andWhere($query->expr()->eq('configkey', $query->createNamedParameter('enabled')))
			->andWhere($query->expr()->eq('configvalue', $query->createNamedParameter('false'), IQueryBuilder::PARAM_STR))
			->andWhere($query->expr()->eq('gid', $query->createNamedParameter($gid), IQueryBuilder::PARAM_STR));
		
		$result = $query->execute();
		$count = $result->fetchColumn();
		$result->closeCursor();
		
		if ($count !== false) {
			$count = (int)$count;
		} else {
			$count = 0;
		}

		return $count;
	}

}


1		<?php
2		/**
3		* @copyright Copyright (c) 2016, ownCloud, Inc.
4		*
5		* @author Aaron Wood <[email protected]>
6		* @author Loki3000 <[email protected]>
7		* @author Roeland Jago Douma <[email protected]>
8		* @author John Molakvoæ <[email protected]>
9		*
10		* @license AGPL-3.0
11		*
12		* This code is free software: you can redistribute it and/or modify
13		* it under the terms of the GNU Affero General Public License, version 3,
14		* as published by the Free Software Foundation.
15		*
16		* This program is distributed in the hope that it will be useful,
17		* but WITHOUT ANY WARRANTY; without even the implied warranty of
18		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
19		* GNU Affero General Public License for more details.
20		*
21		* You should have received a copy of the GNU Affero General Public License, version 3,
22		* along with this program. If not, see <http://www.gnu.org/licenses/>
23		*
24		*/
25		/*
26		*
27		* The following SQL statement is just a help for developers and will not be
28		* executed!
29		*
30		* CREATE TABLE `groups` (
31		* `gid` varchar(64) COLLATE utf8_unicode_ci NOT NULL,
32		* PRIMARY KEY (`gid`)
33		* ) ENGINE=MyISAM DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;
34		*
35		* CREATE TABLE `group_user` (
36		* `gid` varchar(64) COLLATE utf8_unicode_ci NOT NULL,
37		* `uid` varchar(64) COLLATE utf8_unicode_ci NOT NULL
38		* ) ENGINE=MyISAM DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;
39		*
40		*/
41
42		namespace OC\Group;
43
44		use OCP\DB\QueryBuilder\IQueryBuilder;
45		use OCP\Group\Backend\ABackend;
46		use OCP\Group\Backend\IAddToGroupBackend;
47		use OCP\Group\Backend\ICountDisabledInGroup;
48		use OCP\Group\Backend\ICountUsersBackend;
49		use OCP\Group\Backend\ICreateGroupBackend;
50		use OCP\Group\Backend\IDeleteGroupBackend;
51		use OCP\Group\Backend\IRemoveFromGroupBackend;
52		use OCP\IDBConnection;
53
54		/**
55		* Class for group management in a SQL Database (e.g. MySQL, SQLite)
56		*/
57		class Database extends ABackend
		0 ignored issues – show Coding Style introduced 2018-04-23 13:21 UTC by Report Bug Copy Issue Report Expected 0 spaces between "ABackend" and comma; 1 found Loading history...
58		implements IAddToGroupBackend,
		0 ignored issues – show Coding Style introduced 2018-04-23 13:21 UTC by Report Bug Copy Issue Report The implements keyword must be on the same line as the class name Loading history... Coding Style introduced 2018-04-23 13:21 UTC by Report Bug Copy Issue Report The first item in a multi-line implements list must be on the line following the implements keyword Loading history...
59		ICountDisabledInGroup,
		0 ignored issues – show Coding Style introduced 2018-05-16 10:57 UTC by Report Bug Copy Issue Report Expected 4 spaces before interface name; 12 found Loading history...
60		ICountUsersBackend,
		0 ignored issues – show Coding Style introduced 2018-05-16 10:57 UTC by Report Bug Copy Issue Report Expected 4 spaces before interface name; 12 found Loading history...
61		ICreateGroupBackend,
		0 ignored issues – show Coding Style introduced 2018-04-23 13:21 UTC by Report Bug Copy Issue Report Expected 4 spaces before interface name; 12 found Loading history...
62		IDeleteGroupBackend,
		0 ignored issues – show Coding Style introduced 2018-04-23 13:21 UTC by Report Bug Copy Issue Report Expected 4 spaces before interface name; 12 found Loading history...
63		IRemoveFromGroupBackend {
		0 ignored issues – show Coding Style introduced 2018-04-23 13:21 UTC by Report Bug Copy Issue Report Expected 4 spaces before interface name; 12 found Loading history...
64
65		/** @var string[] */
66		private $groupCache = [];
67
68		/** @var IDBConnection */
69		private $dbConn;
70
71		/**
72		* \OC\Group\Database constructor.
73		*
74		* @param IDBConnection\|null $dbConn
75		*/
76		public function __construct(IDBConnection $dbConn = null) {
77		$this->dbConn = $dbConn;
78		}
79
80		/**
81		* FIXME: This function should not be required!
82		*/
83		private function fixDI() {
84		if ($this->dbConn === null) {
85		$this->dbConn = \OC::$server->getDatabaseConnection();
86		}
87		}
88
89		/**
90		* Try to create a new group
91		* @param string $gid The name of the group to create
92		* @return bool
93		*
94		* Tries to create a new group. If the group name already exists, false will
95		* be returned.
96		*/
97		public function createGroup(string $gid): bool {
98		$this->fixDI();
99
100		// Add group
101		$result = $this->dbConn->insertIfNotExist('PREFIXgroups', [
102		'gid' => $gid,
103		]);
104
105		// Add to cache
106		$this->groupCache[$gid] = $gid;
107
108		return $result === 1;
109		}
110
111		/**
112		* delete a group
113		* @param string $gid gid of the group to delete
114		* @return bool
115		*
116		* Deletes a group and removes it from the group_user-table
117		*/
118		public function deleteGroup(string $gid): bool {
119		$this->fixDI();
120
121		// Delete the group
122		$qb = $this->dbConn->getQueryBuilder();
123		$qb->delete('groups')
124		->where($qb->expr()->eq('gid', $qb->createNamedParameter($gid)))
125		->execute();
126
127		// Delete the group-user relation
128		$qb = $this->dbConn->getQueryBuilder();
129		$qb->delete('group_user')
130		->where($qb->expr()->eq('gid', $qb->createNamedParameter($gid)))
131		->execute();
132
133		// Delete the group-groupadmin relation
134		$qb = $this->dbConn->getQueryBuilder();
135		$qb->delete('group_admin')
136		->where($qb->expr()->eq('gid', $qb->createNamedParameter($gid)))
137		->execute();
138
139		// Delete from cache
140		unset($this->groupCache[$gid]);
141
142		return true;
143		}
144
145		/**
146		* is user in group?
147		* @param string $uid uid of the user
148		* @param string $gid gid of the group
149		* @return bool
150		*
151		* Checks whether the user is member of a group or not.
152		*/
153	View Code Duplication	public function inGroup( $uid, $gid ) {
154		$this->fixDI();
155
156		// check
157		$qb = $this->dbConn->getQueryBuilder();
158		$cursor = $qb->select('uid')
159		->from('group_user')
160		->where($qb->expr()->eq('gid', $qb->createNamedParameter($gid)))
161		->andWhere($qb->expr()->eq('uid', $qb->createNamedParameter($uid)))
162		->execute();
163
164		$result = $cursor->fetch();
165		$cursor->closeCursor();
166
167		return $result ? true : false;
168		}
169
170		/**
171		* Add a user to a group
172		* @param string $uid Name of the user to add to group
173		* @param string $gid Name of the group in which add the user
174		* @return bool
175		*
176		* Adds a user to a group.
177		*/
178		public function addToGroup(string $uid, string $gid): bool {
179		$this->fixDI();
180
181		// No duplicate entries!
182		if( !$this->inGroup( $uid, $gid )) {
183		$qb = $this->dbConn->getQueryBuilder();
184		$qb->insert('group_user')
185		->setValue('uid', $qb->createNamedParameter($uid))
186		->setValue('gid', $qb->createNamedParameter($gid))
187		->execute();
188		return true;
189		}else{
190		return false;
191		}
192		}
193
194		/**
195		* Removes a user from a group
196		* @param string $uid Name of the user to remove from group
197		* @param string $gid Name of the group from which remove the user
198		* @return bool
199		*
200		* removes the user from a group.
201		*/
202		public function removeFromGroup(string $uid, string $gid): bool {
203		$this->fixDI();
204
205		$qb = $this->dbConn->getQueryBuilder();
206		$qb->delete('group_user')
207		->where($qb->expr()->eq('uid', $qb->createNamedParameter($uid)))
208		->andWhere($qb->expr()->eq('gid', $qb->createNamedParameter($gid)))
209		->execute();
210
211		return true;
212		}
213
214		/**
215		* Get all groups a user belongs to
216		* @param string $uid Name of the user
217		* @return array an array of group names
218		*
219		* This function fetches all groups a user belongs to. It does not check
220		* if the user exists at all.
221		*/
222		public function getUserGroups( $uid ) {
223		//guests has empty or null $uid
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-21 00:52 UTC by Report Bug Copy Issue Report `37%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
224		if ($uid === null \|\| $uid === '') {
225		return [];
226		}
227
228		$this->fixDI();
229
230		// No magic!
231		$qb = $this->dbConn->getQueryBuilder();
232		$cursor = $qb->select('gid')
233		->from('group_user')
234		->where($qb->expr()->eq('uid', $qb->createNamedParameter($uid)))
235		->execute();
236
237		$groups = [];
238		while( $row = $cursor->fetch()) {
239		$groups[] = $row['gid'];
240		$this->groupCache[$row['gid']] = $row['gid'];
241		}
242		$cursor->closeCursor();
243
244		return $groups;
245		}
246
247		/**
248		* get a list of all groups
249		* @param string $search
250		* @param int $limit
251		* @param int $offset
252		* @return array an array of group names
253		*
254		* Returns a list with all groups
255		*/
256		public function getGroups($search = '', $limit = null, $offset = null) {
257		$this->fixDI();
258
259		$query = $this->dbConn->getQueryBuilder();
260		$query->select('gid')
261		->from('groups')
262		->orderBy('gid', 'ASC');
263
264	View Code Duplication	if ($search !== '') {
265		$query->where($query->expr()->iLike('gid', $query->createNamedParameter(
266		'%' . $this->dbConn->escapeLikeParameter($search) . '%'
267		)));
268		}
269
270		$query->setMaxResults($limit)
271		->setFirstResult($offset);
272		$result = $query->execute();
273
274		$groups = [];
275		while ($row = $result->fetch()) {
276		$groups[] = $row['gid'];
277		}
278		$result->closeCursor();
279
280		return $groups;
281		}
282
283		/**
284		* check if a group exists
285		* @param string $gid
286		* @return bool
287		*/
288		public function groupExists($gid) {
289		$this->fixDI();
290
291		// Check cache first
292		if (isset($this->groupCache[$gid])) {
293		return true;
294		}
295
296		$qb = $this->dbConn->getQueryBuilder();
297		$cursor = $qb->select('gid')
298		->from('groups')
299		->where($qb->expr()->eq('gid', $qb->createNamedParameter($gid)))
300		->execute();
301		$result = $cursor->fetch();
302		$cursor->closeCursor();
303
304		if ($result !== false) {
305		$this->groupCache[$gid] = $gid;
306		return true;
307		}
308		return false;
309		}
310
311		/**
312		* get a list of all users in a group
313		* @param string $gid
314		* @param string $search
315		* @param int $limit
316		* @param int $offset
317		* @return array an array of user ids
318		*/
319		public function usersInGroup($gid, $search = '', $limit = null, $offset = null) {
320		$this->fixDI();
321
322		$query = $this->dbConn->getQueryBuilder();
323		$query->select('uid')
324		->from('group_user')
325		->where($query->expr()->eq('gid', $query->createNamedParameter($gid)))
326		->orderBy('uid', 'ASC');
327
328	View Code Duplication	if ($search !== '') {
329		$query->andWhere($query->expr()->like('uid', $query->createNamedParameter(
330		'%' . $this->dbConn->escapeLikeParameter($search) . '%'
331		)));
332		}
333
334		$query->setMaxResults($limit)
335		->setFirstResult($offset);
336		$result = $query->execute();
337
338		$users = [];
339		while ($row = $result->fetch()) {
340		$users[] = $row['uid'];
341		}
342		$result->closeCursor();
343
344		return $users;
345		}
346
347		/**
348		* get the number of all users matching the search string in a group
349		* @param string $gid
350		* @param string $search
351		* @return int
352		*/
353		public function countUsersInGroup(string $gid, string $search = ''): int {
354		$this->fixDI();
355
356		$query = $this->dbConn->getQueryBuilder();
357		$query->selectAlias($query->createFunction('COUNT(*)'), 'num_users')
358		->from('group_user')
359		->where($query->expr()->eq('gid', $query->createNamedParameter($gid)));
360
361	View Code Duplication	if ($search !== '') {
362		$query->andWhere($query->expr()->like('uid', $query->createNamedParameter(
363		'%' . $this->dbConn->escapeLikeParameter($search) . '%'
364		)));
365		}
366
367		$result = $query->execute();
368		$count = $result->fetchColumn();
369		$result->closeCursor();
370
371		if ($count !== false) {
372		$count = (int)$count;
373		} else {
374		$count = 0;
375		}
376
377		return $count;
378		}
379
380		/**
381		* get the number of disabled users in a group
382		*
383		* @param string $search
		0 ignored issues – show Bug introduced 2018-04-23 09:57 UTC by Report Bug Copy Issue Report There is no parameter named `$search`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
384		* @return int\|bool
385		*/
386	View Code Duplication	public function countDisabledInGroup(string $gid): int {
387		$this->fixDI();
388
389		$query = $this->dbConn->getQueryBuilder();
390		$query->select($query->createFunction('COUNT(Distinct uid)'))
391		->from('preferences', 'p')
392		->innerJoin('p', 'group_user', 'g', 'p.userid = g.uid')
393		->where($query->expr()->eq('appid', $query->createNamedParameter('core')))
394		->andWhere($query->expr()->eq('configkey', $query->createNamedParameter('enabled')))
395		->andWhere($query->expr()->eq('configvalue', $query->createNamedParameter('false'), IQueryBuilder::PARAM_STR))
396		->andWhere($query->expr()->eq('gid', $query->createNamedParameter($gid), IQueryBuilder::PARAM_STR));
397
398		$result = $query->execute();
399		$count = $result->fetchColumn();
400		$result->closeCursor();
401
402		if ($count !== false) {
403		$count = (int)$count;
404		} else {
405		$count = 0;
406		}
407
408		return $count;
409		}
410
411		}
412

nextcloud / server

Push — master ( d4a0af...760b28 )

Database A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

13 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like