Passed
Push — master ( 757a84...ccabc6 )
by Morris
24:05 queued 11:37
created
lib/public/AppFramework/Db/Entity.php 1 patch
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -47,8 +47,8 @@  discard block
 block discarded – undo
47 47
 	public static function fromParams(array $params) {
48 48
 		$instance = new static();
49 49
 
50
-		foreach($params as $key => $value) {
51
-			$method = 'set' . ucfirst($key);
50
+		foreach ($params as $key => $value) {
51
+			$method = 'set'.ucfirst($key);
52 52
 			$instance->$method($value);
53 53
 		}
54 54
 
@@ -61,12 +61,12 @@  discard block
 block discarded – undo
61 61
 	 * @param array $row the row to map onto the entity
62 62
 	 * @since 7.0.0
63 63
 	 */
64
-	public static function fromRow(array $row){
64
+	public static function fromRow(array $row) {
65 65
 		$instance = new static();
66 66
 
67
-		foreach($row as $key => $value){
67
+		foreach ($row as $key => $value) {
68 68
 			$prop = ucfirst($instance->columnToProperty($key));
69
-			$setter = 'set' . $prop;
69
+			$setter = 'set'.$prop;
70 70
 			$instance->$setter($value);
71 71
 		}
72 72
 
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 	 * Marks the entity as clean needed for setting the id after the insertion
90 90
 	 * @since 7.0.0
91 91
 	 */
92
-	public function resetUpdatedFields(){
92
+	public function resetUpdatedFields() {
93 93
 		$this->_updatedFields = array();
94 94
 	}
95 95
 
@@ -99,20 +99,20 @@  discard block
 block discarded – undo
99 99
 	 */
100 100
 	protected function setter($name, $args) {
101 101
 		// setters should only work for existing attributes
102
-		if(property_exists($this, $name)){
103
-			if($this->$name === $args[0]) {
102
+		if (property_exists($this, $name)) {
103
+			if ($this->$name === $args[0]) {
104 104
 				return;
105 105
 			}
106 106
 			$this->markFieldUpdated($name);
107 107
 
108 108
 			// if type definition exists, cast to correct type
109
-			if($args[0] !== null && array_key_exists($name, $this->_fieldTypes)) {
109
+			if ($args[0] !== null && array_key_exists($name, $this->_fieldTypes)) {
110 110
 				settype($args[0], $this->_fieldTypes[$name]);
111 111
 			}
112 112
 			$this->$name = $args[0];
113 113
 
114 114
 		} else {
115
-			throw new \BadFunctionCallException($name . 
115
+			throw new \BadFunctionCallException($name. 
116 116
 				' is not a valid attribute');
117 117
 		}
118 118
 	}
@@ -123,10 +123,10 @@  discard block
 block discarded – undo
123 123
 	 */
124 124
 	protected function getter($name) {
125 125
 		// getters should only work for existing attributes
126
-		if(property_exists($this, $name)){
126
+		if (property_exists($this, $name)) {
127 127
 			return $this->$name;
128 128
 		} else {
129
-			throw new \BadFunctionCallException($name . 
129
+			throw new \BadFunctionCallException($name. 
130 130
 				' is not a valid attribute');
131 131
 		}
132 132
 	}
@@ -139,15 +139,15 @@  discard block
 block discarded – undo
139 139
 	 * getter method
140 140
 	 * @since 7.0.0
141 141
 	 */
142
-	public function __call($methodName, $args){
143
-		$attr = lcfirst( substr($methodName, 3) );
142
+	public function __call($methodName, $args) {
143
+		$attr = lcfirst(substr($methodName, 3));
144 144
 
145
-		if(strpos($methodName, 'set') === 0){
145
+		if (strpos($methodName, 'set') === 0) {
146 146
 			$this->setter($attr, $args);
147
-		} elseif(strpos($methodName, 'get') === 0) {
147
+		} elseif (strpos($methodName, 'get') === 0) {
148 148
 			return $this->getter($attr);
149 149
 		} else {
150
-			throw new \BadFunctionCallException($methodName . 
150
+			throw new \BadFunctionCallException($methodName. 
151 151
 					' does not exist');
152 152
 		}
153 153
 
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
 	 * @param string $attribute the name of the attribute
160 160
 	 * @since 7.0.0
161 161
 	 */
162
-	protected function markFieldUpdated($attribute){
162
+	protected function markFieldUpdated($attribute) {
163 163
 		$this->_updatedFields[$attribute] = true;
164 164
 	}
165 165
 
@@ -170,12 +170,12 @@  discard block
 block discarded – undo
170 170
 	 * @return string the property name
171 171
 	 * @since 7.0.0
172 172
 	 */
173
-	public function columnToProperty($columnName){
173
+	public function columnToProperty($columnName) {
174 174
 		$parts = explode('_', $columnName);
175 175
 		$property = null;
176 176
 
177
-		foreach($parts as $part){
178
-			if($property === null){
177
+		foreach ($parts as $part) {
178
+			if ($property === null) {
179 179
 				$property = $part;
180 180
 			} else {
181 181
 				$property .= ucfirst($part);
@@ -192,15 +192,15 @@  discard block
 block discarded – undo
192 192
 	 * @return string the column name
193 193
 	 * @since 7.0.0
194 194
 	 */
195
-	public function propertyToColumn($property){
195
+	public function propertyToColumn($property) {
196 196
 		$parts = preg_split('/(?=[A-Z])/', $property);
197 197
 		$column = null;
198 198
 
199
-		foreach($parts as $part){
200
-			if($column === null){
199
+		foreach ($parts as $part) {
200
+			if ($column === null) {
201 201
 				$column = $part;
202 202
 			} else {
203
-				$column .= '_' . lcfirst($part);
203
+				$column .= '_'.lcfirst($part);
204 204
 			}
205 205
 		}
206 206
 
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
 	 * @return array array of updated fields for update query
213 213
 	 * @since 7.0.0
214 214
 	 */
215
-	public function getUpdatedFields(){
215
+	public function getUpdatedFields() {
216 216
 		return $this->_updatedFields;
217 217
 	}
218 218
 
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 	 * @param string $type the type which will be used to call settype()
225 225
 	 * @since 7.0.0
226 226
 	 */
227
-	protected function addType($fieldName, $type){
227
+	protected function addType($fieldName, $type) {
228 228
 		$this->_fieldTypes[$fieldName] = $type;
229 229
 	}
230 230
 
@@ -236,9 +236,9 @@  discard block
 block discarded – undo
236 236
 	 * @return string slugified value
237 237
 	 * @since 7.0.0
238 238
 	 */
239
-	public function slugify($attributeName){
239
+	public function slugify($attributeName) {
240 240
 		// toSlug should only work for existing attributes
241
-		if(property_exists($this, $attributeName)){
241
+		if (property_exists($this, $attributeName)) {
242 242
 			$value = $this->$attributeName;
243 243
 			// replace everything except alphanumeric with a single '-'
244 244
 			$value = preg_replace('/[^A-Za-z0-9]+/', '-', $value);
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
 			// trim '-'
247 247
 			return trim($value, '-');
248 248
 		} else {
249
-			throw new \BadFunctionCallException($attributeName .
249
+			throw new \BadFunctionCallException($attributeName.
250 250
 				' is not a valid attribute');
251 251
 		}
252 252
 	}
Please login to merge, or discard this patch.
lib/public/DB/QueryBuilder/IExpressionBuilder.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 	/**
36 36
 	 * @since 9.0.0
37 37
 	 */
38
-	const EQ  = ExpressionBuilder::EQ;
38
+	const EQ = ExpressionBuilder::EQ;
39 39
 	/**
40 40
 	 * @since 9.0.0
41 41
 	 */
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 	/**
44 44
 	 * @since 9.0.0
45 45
 	 */
46
-	const LT  = ExpressionBuilder::LT;
46
+	const LT = ExpressionBuilder::LT;
47 47
 	/**
48 48
 	 * @since 9.0.0
49 49
 	 */
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 	/**
52 52
 	 * @since 9.0.0
53 53
 	 */
54
-	const GT  = ExpressionBuilder::GT;
54
+	const GT = ExpressionBuilder::GT;
55 55
 	/**
56 56
 	 * @since 9.0.0
57 57
 	 */
Please login to merge, or discard this patch.
lib/public/App/ManagerEvent.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@
 block discarded – undo
84 84
 	 * @since 9.0.0
85 85
 	 */
86 86
 	public function getGroups() {
87
-		return array_map(function ($group) {
87
+		return array_map(function($group) {
88 88
 			/** @var \OCP\IGroup $group */
89 89
 			return $group->getGID();
90 90
 		}, $this->groups);
Please login to merge, or discard this patch.
lib/public/IPreview.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 	/**
47 47
 	 * @since 9.2.0
48 48
 	 */
49
-	const EVENT = self::class . ':' . 'PreviewRequested';
49
+	const EVENT = self::class.':'.'PreviewRequested';
50 50
 
51 51
 	const MODE_FILL = 'fill';
52 52
 	const MODE_COVER = 'cover';
Please login to merge, or discard this patch.
lib/private/Authentication/Token/DefaultTokenMapper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@
 block discarded – undo
129 129
 		$data = $result->fetchAll();
130 130
 		$result->closeCursor();
131 131
 
132
-		$entities = array_map(function ($row) {
132
+		$entities = array_map(function($row) {
133 133
 			return DefaultToken::fromRow($row);
134 134
 		}, $data);
135 135
 
Please login to merge, or discard this patch.
lib/private/Console/TimestampFormatter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -103,6 +103,6 @@
 block discarded – undo
103 103
 		$time = new \DateTime('now', $timeZone);
104 104
 		$timestampInfo = $time->format($this->config->getSystemValue('logdateformat', \DateTime::ATOM));
105 105
 
106
-		return $timestampInfo . ' ' . $this->formatter->format($message);
106
+		return $timestampInfo.' '.$this->formatter->format($message);
107 107
 	}
108 108
 }
Please login to merge, or discard this patch.
lib/private/Security/Certificate.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -54,19 +54,19 @@
 block discarded – undo
54 54
 
55 55
 		// If string starts with "file://" ignore the certificate
56 56
 		$query = 'file://';
57
-		if(strtolower(substr($data, 0, strlen($query))) === $query) {
57
+		if (strtolower(substr($data, 0, strlen($query))) === $query) {
58 58
 			throw new \Exception('Certificate could not get parsed.');
59 59
 		}
60 60
 
61 61
 		$info = openssl_x509_parse($data);
62
-		if(!is_array($info)) {
62
+		if (!is_array($info)) {
63 63
 			throw new \Exception('Certificate could not get parsed.');
64 64
 		}
65 65
 
66 66
 		$this->commonName = isset($info['subject']['CN']) ? $info['subject']['CN'] : null;
67 67
 		$this->organization = isset($info['subject']['O']) ? $info['subject']['O'] : null;
68
-		$this->issueDate = new \DateTime('@' . $info['validFrom_time_t'], $gmt);
69
-		$this->expireDate = new \DateTime('@' . $info['validTo_time_t'], $gmt);
68
+		$this->issueDate = new \DateTime('@'.$info['validFrom_time_t'], $gmt);
69
+		$this->expireDate = new \DateTime('@'.$info['validTo_time_t'], $gmt);
70 70
 		$this->issuerName = isset($info['issuer']['CN']) ? $info['issuer']['CN'] : null;
71 71
 		$this->issuerOrganization = isset($info['issuer']['O']) ? $info['issuer']['O'] : null;
72 72
 	}
Please login to merge, or discard this patch.
lib/private/TempManager.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -65,13 +65,13 @@  discard block
 block discarded – undo
65 65
 	 * @return string
66 66
 	 */
67 67
 	private function buildFileNameWithSuffix($absolutePath, $postFix = '') {
68
-		if($postFix !== '') {
69
-			$postFix = '.' . ltrim($postFix, '.');
68
+		if ($postFix !== '') {
69
+			$postFix = '.'.ltrim($postFix, '.');
70 70
 			$postFix = str_replace(['\\', '/'], '', $postFix);
71 71
 			$absolutePath .= '-';
72 72
 		}
73 73
 
74
-		return $absolutePath . $postFix;
74
+		return $absolutePath.$postFix;
75 75
 	}
76 76
 
77 77
 	/**
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 
92 92
 			// If a postfix got specified sanitize it and create a postfixed
93 93
 			// temporary file
94
-			if($postFix !== '') {
94
+			if ($postFix !== '') {
95 95
 				$fileNameWithPostfix = $this->buildFileNameWithSuffix($file, $postFix);
96 96
 				touch($fileNameWithPostfix);
97 97
 				chmod($fileNameWithPostfix, 0600);
@@ -127,11 +127,11 @@  discard block
 block discarded – undo
127 127
 			$this->current[] = $uniqueFileName;
128 128
 
129 129
 			// Build a name without postfix
130
-			$path = $this->buildFileNameWithSuffix($uniqueFileName . '-folder', $postFix);
130
+			$path = $this->buildFileNameWithSuffix($uniqueFileName.'-folder', $postFix);
131 131
 			mkdir($path, 0700);
132 132
 			$this->current[] = $path;
133 133
 
134
-			return $path . '/';
134
+			return $path.'/';
135 135
 		} else {
136 136
 			$this->log->warning(
137 137
 				'Can not create a temporary folder in directory {dir}. Check it exists and has correct permissions',
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
 		if ($dh) {
191 191
 			while (($file = readdir($dh)) !== false) {
192 192
 				if (substr($file, 0, 7) === self::TMP_PREFIX) {
193
-					$path = $this->tmpBaseDir . '/' . $file;
193
+					$path = $this->tmpBaseDir.'/'.$file;
194 194
 					$mtime = filemtime($path);
195 195
 					if ($mtime < $cutOfTime) {
196 196
 						$files[] = $path;
Please login to merge, or discard this patch.
lib/private/Log/ErrorHandler.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 		return preg_replace('/\/\/(.*):(.*)@/', '//xxx:xxx@', $msg);
41 41
 	}
42 42
 
43
-	public static function register($debug=false) {
43
+	public static function register($debug = false) {
44 44
 		$handler = new ErrorHandler();
45 45
 
46 46
 		if ($debug) {
@@ -62,9 +62,9 @@  discard block
 block discarded – undo
62 62
 	//Fatal errors handler
63 63
 	public static function onShutdown() {
64 64
 		$error = error_get_last();
65
-		if($error && self::$logger) {
65
+		if ($error && self::$logger) {
66 66
 			//ob_end_clean();
67
-			$msg = $error['message'] . ' at ' . $error['file'] . '#' . $error['line'];
67
+			$msg = $error['message'].' at '.$error['file'].'#'.$error['line'];
68 68
 			self::$logger->critical(self::removePassword($msg), array('app' => 'PHP'));
69 69
 		}
70 70
 	}
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 	public static function onException($exception) {
78 78
 		$class = get_class($exception);
79 79
 		$msg = $exception->getMessage();
80
-		$msg = "$class: $msg at " . $exception->getFile() . '#' . $exception->getLine();
80
+		$msg = "$class: $msg at ".$exception->getFile().'#'.$exception->getLine();
81 81
 		self::$logger->critical(self::removePassword($msg), ['app' => 'PHP']);
82 82
 	}
83 83
 
@@ -86,14 +86,14 @@  discard block
 block discarded – undo
86 86
 		if (error_reporting() === 0) {
87 87
 			return;
88 88
 		}
89
-		$msg = $message . ' at ' . $file . '#' . $line;
89
+		$msg = $message.' at '.$file.'#'.$line;
90 90
 		self::$logger->error(self::removePassword($msg), array('app' => 'PHP'));
91 91
 
92 92
 	}
93 93
 
94 94
 	//Recoverable handler which catch all errors, warnings and notices
95 95
 	public static function onAll($number, $message, $file, $line) {
96
-		$msg = $message . ' at ' . $file . '#' . $line;
96
+		$msg = $message.' at '.$file.'#'.$line;
97 97
 		self::$logger->debug(self::removePassword($msg), array('app' => 'PHP'));
98 98
 
99 99
 	}
Please login to merge, or discard this patch.