nextcloud / server

lib/private/Share20/Manager.php

Doc Comments +3 added lines

@@ -1101,6 +1101,9 @@
 		return $share;
 	}
 
+	/**
+	 * @param IShare $share
+	 */
 	protected function checkExpireDate($share) {
 		if ($share->getExpirationDate() !== null &&
 			$share->getExpirationDate() <= new \DateTime()) {

apps/user_ldap/lib/Access.php

Doc Comments +8 added lines, -6 removed lines

@@ -490,7 +490,7 @@ 
 
 	/**
 	 * returns the internal Nextcloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
-	 * @param string $dn the dn of the user object
+	 * @param string $fdn the dn of the user object
 	 * @param string $ldapName optional, the display name of the object
 	 * @return string|false with with the name to use in Nextcloud
 	 */
@@ -507,7 +507,7 @@ 
 
 	/**
 	 * returns an internal Nextcloud name for the given LDAP DN, false on DN outside of search DN
-	 * @param string $dn the dn of the user object
+	 * @param string $fdn the dn of the user object
 	 * @param string $ldapName optional, the display name of the object
 	 * @param bool $isUser optional, whether it is a user object (otherwise group assumed)
 	 * @return string|false with with the name to use in Nextcloud
@@ -770,7 +770,7 @@ 
 	 * the login filter.
 	 *
 	 * @param string $loginName
-	 * @param array $attributes optional, list of attributes to read
+	 * @param string[] $attributes optional, list of attributes to read
 	 * @return array
 	 */
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -843,7 +843,7 @@ 
 
 	/**
 	 * @param string $filter
-	 * @param string|string[] $attr
+	 * @param string[] $attr
 	 * @param int $limit
 	 * @param int $offset
 	 * @return array
@@ -891,7 +891,7 @@ 
 
 	/**
 	 * @param string $filter
-	 * @param string|string[] $attr
+	 * @param string[] $attr
 	 * @param int $limit
 	 * @param int $offset
 	 * @return false|int
@@ -941,6 +941,7 @@ 
 	 * retrieved. Results will according to the order in the array.
 	 * @param int $limit optional, maximum results to be counted
 	 * @param int $offset optional, a starting point
+	 * @param string $filter
 	 * @return array|false array with the search result as first value and pagedSearchOK as
 	 * second | false if not successful
 	 */
@@ -1191,7 +1192,7 @@ 
 
 	/**
 	 * @param string $name
-	 * @return bool|mixed|string
+	 * @return string
 	 */
 	public function sanitizeUsername($name) {
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -1215,6 +1216,7 @@ 
 	* escapes (user provided) parts for LDAP filter
 	* @param string $input, the provided value
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
+	* @param string $input
 	* @return string the escaped string
 	*/
 	public function escapeFilterPart($input, $allowAsterisk = false) {

lib/private/Mail/EMailTemplate.php

Doc Comments +1 added lines, -1 removed lines

@@ -335,7 +335,7 @@
 	 * Adds a heading to the email
 	 *
 	 * @param string $title
-	 * @param string $plainTitle|bool Title that is used in the plain text email
+	 * @param string $plainTitle Title that is used in the plain text email
 	 *   if empty the $title is used, if false none will be used
 	 */
 	public function addHeading($title, $plainTitle = '') {

lib/private/AppFramework/Utility/ControllerMethodReflector.php

Doc Comments +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
 	private $parameters = [];
 
 	/**
-	 * @param object $object an object or classname
+	 * @param \OCP\AppFramework\Controller $object an object or classname
 	 * @param string $method the method which we want to inspect
 	 */
 	public function reflect($object, $method){

lib/private/User/User.php

Doc Comments +5 added lines

@@ -436,6 +436,11 @@
 		return $url;
 	}
 
+	/**
+	 * @param string $feature
+	 * @param string $value
+	 * @param string $oldValue
+	 */
 	public function triggerChange($feature, $value = null, $oldValue = null) {
 		if ($this->emitter) {
 			$this->emitter->emit('\OC\User', 'changeUser', array($this, $feature, $value, $oldValue));

lib/private/User/Session.php

Doc Comments +5 added lines, -2 removed lines

@@ -329,7 +329,7 @@ 
 	 * @param IUser $user
 	 * @param array $loginDetails
 	 * @param bool $regenerateSessionId
-	 * @return true returns true if login successful or an exception otherwise
+	 * @return boolean returns true if login successful or an exception otherwise
 	 * @throws LoginException
 	 */
 	public function completeLogin(IUser $user, array $loginDetails, $regenerateSessionId = true) {
@@ -377,7 +377,7 @@ 
 	 * @param OC\Security\Bruteforce\Throttler $throttler
 	 * @throws LoginException
 	 * @throws PasswordLoginForbiddenException
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	public function logClientIn($user,
 								$password,
@@ -431,6 +431,9 @@ 
 		return $this->config->getSystemValue('token_auth_enforced', false);
 	}
 
+	/**
+	 * @param string $username
+	 */
 	protected function isTwoFactorEnforced($username) {
 		Util::emitHook(
 			'\OCA\Files_Sharing\API\Server2Server',

lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php

Doc Comments +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
 	 * @param bool $isLoggedIn
 	 * @param bool $isAdminUser
 	 * @param ContentSecurityPolicyManager $contentSecurityPolicyManager
-	 * @param CSRFTokenManager $csrfTokenManager
+	 * @param CsrfTokenManager $csrfTokenManager
 	 * @param ContentSecurityPolicyNonceManager $cspNonceManager
 	 */
 	public function __construct(IRequest $request,

lib/public/Mail/IEMailTemplate.php

Doc Comments +7 added lines, -1 removed lines

@@ -55,6 +55,7 @@ 
 	 * Adds a header to the email
 	 *
 	 * @since 12.0.0
+	 * @return void
 	 */
 	public function addHeader();
 
@@ -62,10 +63,11 @@ 
 	 * Adds a heading to the email
 	 *
 	 * @param string $title
-	 * @param string $plainTitle|bool Title that is used in the plain text email
+	 * @param string $plainTitle Title that is used in the plain text email
 	 *   if empty the $title is used, if false none will be used
 	 *
 	 * @since 12.0.0
+	 * @return void
 	 */
 	public function addHeading($title, $plainTitle = '');
 
@@ -77,6 +79,7 @@ 
 	 *   if empty the $text is used, if false none will be used
 	 *
 	 * @since 12.0.0
+	 * @return void
 	 */
 	public function addBodyText($text, $plainText = '');
 
@@ -91,6 +94,7 @@ 
 	 * @param string $plainTextRight Text of right button that is used in the plain text version - if empty the $textRight is used
 	 *
 	 * @since 12.0.0
+	 * @return void
 	 */
 	public function addBodyButtonGroup($textLeft, $urlLeft, $textRight, $urlRight, $plainTextLeft = '', $plainTextRight = '');
 
@@ -103,6 +107,7 @@ 
 	 * 		if empty the $text is used, if false none will be used
 	 *
 	 * @since 12.0.0
+	 * @return void
 	 */
 	public function addBodyButton($text, $url, $plainText = '');
 
@@ -112,6 +117,7 @@ 
 	 * @param string $text If the text is empty the default "Name - Slogan<br>This is an automatically sent email" will be used
 	 *
 	 * @since 12.0.0
+	 * @return void
 	 */
 	public function addFooter($text = '');
 

apps/sharebymail/lib/ShareByMailProvider.php

Doc Comments +5 added lines, -4 removed lines

@@ -276,10 +276,10 @@ 
 	 * publish activity if a file/folder was shared by mail
 	 *
 	 * @param $subject
-	 * @param $parameters
-	 * @param $affectedUser
+	 * @param string[] $parameters
+	 * @param string $affectedUser
 	 * @param $fileId
-	 * @param $filePath
+	 * @param string $filePath
 	 */
 	protected function publishActivity($subject, $parameters, $affectedUser, $fileId, $filePath) {
 		$event = $this->activityManager->generateEvent();
@@ -557,6 +557,7 @@ 
 	 * @param string $uidOwner
 	 * @param int $permissions
 	 * @param string $token
+	 * @param string $password
 	 * @return int
 	 */
 	protected function addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $uidOwner, $permissions, $token, $password) {
@@ -950,7 +951,7 @@ 
 	/**
 	 * get database row of a give share
 	 *
-	 * @param $id
+	 * @param integer $id
 	 * @return array
 	 * @throws ShareNotFound
 	 */