LocalAddressChecker::ThrowIfLocalAddress() - Code Metrics - Inspection of "Merge pull request #26266 from nextcloud/future-pr..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b07a8f...789bb0 )

by Roeland

created 2021-04-12 10:42 UTC

LocalAddressChecker::ThrowIfLocalAddress() B

↳ Parent: LocalAddressChecker

Complexity

Conditions	10
Paths	7

Size

Total Lines	26
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	10
eloc	14
c	1
b	0
f	0
nc	7
nop	1
dl	0
loc	26
rs	7.6666

How to fix Complexity

<?php

declare(strict_types=1);

/**
 * @copyright Copyright (c) 2021, Lukas Reschke <[email protected]>
 *
 * @author Lukas Reschke <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OC\Http\Client;

use OCP\ILogger;
use OCP\Http\Client\LocalServerException;

class LocalAddressChecker {
	/** @var ILogger */
	private $logger;

	public function __construct(ILogger $logger) {
		$this->logger = $logger;
	}

	public function ThrowIfLocalIp(string $ip) : void {
		if ((bool)filter_var($ip, FILTER_VALIDATE_IP) && !filter_var($ip, FILTER_VALIDATE_IP, FILTER_FLAG_NO_PRIV_RANGE | FILTER_FLAG_NO_RES_RANGE)) {
			$this->logger->warning("Host $ip was not connected to because it violates local access rules");
			throw new LocalServerException('Host violates local access rules');
		}

		// Also check for IPv6 IPv4 nesting, because that's not covered by filter_var
		if ((bool)filter_var($ip, FILTER_VALIDATE_IP, FILTER_FLAG_IPV6) && substr_count($ip, '.') > 0) {
			$delimiter = strrpos($ip, ':'); // Get last colon
			$ipv4Address = substr($ip, $delimiter + 1);

			if (!filter_var($ipv4Address, FILTER_VALIDATE_IP, FILTER_FLAG_NO_PRIV_RANGE | FILTER_FLAG_NO_RES_RANGE)) {
				$this->logger->warning("Host $ip was not connected to because it violates local access rules");
				throw new LocalServerException('Host violates local access rules');
			}
		}
	}

	public function ThrowIfLocalAddress(string $uri) : void {
		$host = parse_url($uri, PHP_URL_HOST);
		if ($host === false || $host === null) {
			$this->logger->warning("Could not detect any host in $uri");
			throw new LocalServerException('Could not detect any host');
		}

		$host = strtolower($host);
		// Remove brackets from IPv6 addresses
		if (strpos($host, '[') === 0 && substr($host, -1) === ']') {
			$host = substr($host, 1, -1);
		}

		// Disallow localhost and local network
		if ($host === 'localhost' || substr($host, -6) === '.local' || substr($host, -10) === '.localhost') {
			$this->logger->warning("Host $host was not connected to because it violates local access rules");
			throw new LocalServerException('Host violates local access rules');
		}

		// Disallow hostname only
		if (substr_count($host, '.') === 0 && !(bool)filter_var($host, FILTER_VALIDATE_IP, FILTER_FLAG_IPV6)) {
			$this->logger->warning("Host $host was not connected to because it violates local access rules");
			throw new LocalServerException('Host violates local access rules');
		}

		$this->ThrowIfLocalIp($host);
	}
}


1			<?php
2
3			declare(strict_types=1);
4
5			/**
6			* @copyright Copyright (c) 2021, Lukas Reschke <[email protected]>
7			*
8			* @author Lukas Reschke <[email protected]>
9			*
10			* @license GNU AGPL version 3 or any later version
11			*
12			* This program is free software: you can redistribute it and/or modify
13			* it under the terms of the GNU Affero General Public License as
14			* published by the Free Software Foundation, either version 3 of the
15			* License, or (at your option) any later version.
16			*
17			* This program is distributed in the hope that it will be useful,
18			* but WITHOUT ANY WARRANTY; without even the implied warranty of
19			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
20			* GNU Affero General Public License for more details.
21			*
22			* You should have received a copy of the GNU Affero General Public License
23			* along with this program. If not, see <http://www.gnu.org/licenses/>.
24			*
25			*/
26
27			namespace OC\Http\Client;
28
29			use OCP\ILogger;
30			use OCP\Http\Client\LocalServerException;
31
32			class LocalAddressChecker {
33			/** @var ILogger */
34			private $logger;
35
36			public function __construct(ILogger $logger) {
37			$this->logger = $logger;
38			}
39
40			public function ThrowIfLocalIp(string $ip) : void {
41			if ((bool)filter_var($ip, FILTER_VALIDATE_IP) && !filter_var($ip, FILTER_VALIDATE_IP, FILTER_FLAG_NO_PRIV_RANGE \| FILTER_FLAG_NO_RES_RANGE)) {
42			$this->logger->warning("Host $ip was not connected to because it violates local access rules");
43			throw new LocalServerException('Host violates local access rules');
44			}
45
46			// Also check for IPv6 IPv4 nesting, because that's not covered by filter_var
47			if ((bool)filter_var($ip, FILTER_VALIDATE_IP, FILTER_FLAG_IPV6) && substr_count($ip, '.') > 0) {
48			$delimiter = strrpos($ip, ':'); // Get last colon
49			$ipv4Address = substr($ip, $delimiter + 1);
50
51			if (!filter_var($ipv4Address, FILTER_VALIDATE_IP, FILTER_FLAG_NO_PRIV_RANGE \| FILTER_FLAG_NO_RES_RANGE)) {
52			$this->logger->warning("Host $ip was not connected to because it violates local access rules");
53			throw new LocalServerException('Host violates local access rules');
54			}
55			}
56			}
57
58			public function ThrowIfLocalAddress(string $uri) : void {
59			$host = parse_url($uri, PHP_URL_HOST);
60			if ($host === false \|\| $host === null) {
61			$this->logger->warning("Could not detect any host in $uri");
62			throw new LocalServerException('Could not detect any host');
63			}
64
65			$host = strtolower($host);
66			// Remove brackets from IPv6 addresses
67			if (strpos($host, '[') === 0 && substr($host, -1) === ']') {
68			$host = substr($host, 1, -1);
69			}
70
71			// Disallow localhost and local network
72			if ($host === 'localhost' \|\| substr($host, -6) === '.local' \|\| substr($host, -10) === '.localhost') {
73			$this->logger->warning("Host $host was not connected to because it violates local access rules");
74			throw new LocalServerException('Host violates local access rules');
75			}
76
77			// Disallow hostname only
78			if (substr_count($host, '.') === 0 && !(bool)filter_var($host, FILTER_VALIDATE_IP, FILTER_FLAG_IPV6)) {
79			$this->logger->warning("Host $host was not connected to because it violates local access rules");
80			throw new LocalServerException('Host violates local access rules');
81			}
82
83			$this->ThrowIfLocalIp($host);
84			}
85			}
86

nextcloud / server

Push — master ( b07a8f...789bb0 )

LocalAddressChecker::ThrowIfLocalAddress() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like