| Conditions | 1 |
| Paths | 1 |
| Total Lines | 138 |
| Code Lines | 103 |
| Lines | 55 |
| Ratio | 39.86 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 135 | public function registerServices() { |
||
| 136 | $container = $this->getContainer(); |
||
| 137 | |||
| 138 | $container->registerService('Crypt', |
||
| 139 | function (IAppContainer $c) { |
||
| 140 | $server = $c->getServer(); |
||
| 141 | return new Crypt($server->getLogger(), |
||
| 142 | $server->getUserSession(), |
||
| 143 | $server->getConfig(), |
||
| 144 | $server->getL10N($c->getAppName())); |
||
| 145 | }); |
||
| 146 | |||
| 147 | $container->registerService('Session', |
||
| 148 | function (IAppContainer $c) { |
||
| 149 | $server = $c->getServer(); |
||
| 150 | return new Session($server->getSession()); |
||
| 151 | } |
||
| 152 | ); |
||
| 153 | |||
| 154 | $container->registerService('KeyManager', |
||
| 155 | View Code Duplication | function (IAppContainer $c) { |
|
| 156 | $server = $c->getServer(); |
||
| 157 | |||
| 158 | return new KeyManager($server->getEncryptionKeyStorage(), |
||
| 159 | $c->query('Crypt'), |
||
| 160 | $server->getConfig(), |
||
| 161 | $server->getUserSession(), |
||
| 162 | new Session($server->getSession()), |
||
| 163 | $server->getLogger(), |
||
| 164 | $c->query('Util') |
||
| 165 | ); |
||
| 166 | }); |
||
| 167 | |||
| 168 | $container->registerService('Recovery', |
||
| 169 | View Code Duplication | function (IAppContainer $c) { |
|
| 170 | $server = $c->getServer(); |
||
| 171 | |||
| 172 | return new Recovery( |
||
| 173 | $server->getUserSession(), |
||
| 174 | $c->query('Crypt'), |
||
| 175 | $server->getSecureRandom(), |
||
| 176 | $c->query('KeyManager'), |
||
| 177 | $server->getConfig(), |
||
| 178 | $server->getEncryptionKeyStorage(), |
||
| 179 | $server->getEncryptionFilesHelper(), |
||
| 180 | new View()); |
||
| 181 | }); |
||
| 182 | |||
| 183 | View Code Duplication | $container->registerService('RecoveryController', function (IAppContainer $c) { |
|
| 184 | $server = $c->getServer(); |
||
| 185 | return new RecoveryController( |
||
| 186 | $c->getAppName(), |
||
| 187 | $server->getRequest(), |
||
| 188 | $server->getConfig(), |
||
| 189 | $server->getL10N($c->getAppName()), |
||
| 190 | $c->query('Recovery')); |
||
| 191 | }); |
||
| 192 | |||
| 193 | View Code Duplication | $container->registerService('StatusController', function (IAppContainer $c) { |
|
| 194 | $server = $c->getServer(); |
||
| 195 | return new StatusController( |
||
| 196 | $c->getAppName(), |
||
| 197 | $server->getRequest(), |
||
| 198 | $server->getL10N($c->getAppName()), |
||
| 199 | $c->query('Session'), |
||
| 200 | $server->getEncryptionManager() |
||
| 201 | ); |
||
| 202 | }); |
||
| 203 | |||
| 204 | $container->registerService('SettingsController', function (IAppContainer $c) { |
||
| 205 | $server = $c->getServer(); |
||
| 206 | return new SettingsController( |
||
| 207 | $c->getAppName(), |
||
| 208 | $server->getRequest(), |
||
| 209 | $server->getL10N($c->getAppName()), |
||
| 210 | $server->getUserManager(), |
||
| 211 | $server->getUserSession(), |
||
| 212 | $c->query('KeyManager'), |
||
| 213 | $c->query('Crypt'), |
||
| 214 | $c->query('Session'), |
||
| 215 | $server->getSession(), |
||
| 216 | $c->query('Util') |
||
| 217 | ); |
||
| 218 | }); |
||
| 219 | |||
| 220 | $container->registerService('UserSetup', |
||
| 221 | function (IAppContainer $c) { |
||
| 222 | $server = $c->getServer(); |
||
| 223 | return new Setup($server->getLogger(), |
||
| 224 | $server->getUserSession(), |
||
| 225 | $c->query('Crypt'), |
||
| 226 | $c->query('KeyManager')); |
||
| 227 | }); |
||
| 228 | |||
| 229 | $container->registerService('Util', |
||
| 230 | View Code Duplication | function (IAppContainer $c) { |
|
| 231 | $server = $c->getServer(); |
||
| 232 | |||
| 233 | return new Util( |
||
| 234 | new View(), |
||
| 235 | $c->query('Crypt'), |
||
| 236 | $server->getLogger(), |
||
| 237 | $server->getUserSession(), |
||
| 238 | $server->getConfig(), |
||
| 239 | $server->getUserManager()); |
||
| 240 | }); |
||
| 241 | |||
| 242 | $container->registerService('EncryptAll', |
||
| 243 | function (IAppContainer $c) { |
||
| 244 | $server = $c->getServer(); |
||
| 245 | return new EncryptAll( |
||
| 246 | $c->query('UserSetup'), |
||
| 247 | $c->getServer()->getUserManager(), |
||
| 248 | new View(), |
||
| 249 | $c->query('KeyManager'), |
||
| 250 | $c->query('Util'), |
||
| 251 | $server->getConfig(), |
||
| 252 | $server->getMailer(), |
||
| 253 | $server->getL10N('encryption'), |
||
| 254 | new QuestionHelper(), |
||
| 255 | $server->getSecureRandom() |
||
| 256 | ); |
||
| 257 | } |
||
| 258 | ); |
||
| 259 | |||
| 260 | $container->registerService('DecryptAll', |
||
| 261 | function (IAppContainer $c) { |
||
| 262 | return new DecryptAll( |
||
| 263 | $c->query('Util'), |
||
| 264 | $c->query('KeyManager'), |
||
| 265 | $c->query('Crypt'), |
||
| 266 | $c->query('Session'), |
||
| 267 | new QuestionHelper() |
||
| 268 | ); |
||
| 269 | } |
||
| 270 | ); |
||
| 271 | |||
| 272 | } |
||
| 273 | } |
||
| 274 |