Completed
Pull Request — master (#5888)
by Maxence
16:07
created
lib/public/Mail/IEMailTemplate.php 1 patch
Doc Comments   +8 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,6 +55,7 @@  discard block
 block discarded – undo
55 55
 	 * Adds a header to the email
56 56
 	 *
57 57
 	 * @since 12.0.0
58
+	 * @return void
58 59
 	 */
59 60
 	public function addHeader();
60 61
 
@@ -62,10 +63,11 @@  discard block
 block discarded – undo
62 63
 	 * Adds a heading to the email
63 64
 	 *
64 65
 	 * @param string $title
65
-	 * @param string $plainTitle|bool Title that is used in the plain text email
66
+	 * @param string $plainTitle Title that is used in the plain text email
66 67
 	 *   if empty the $title is used, if false none will be used
67 68
 	 *
68 69
 	 * @since 12.0.0
70
+	 * @return void
69 71
 	 */
70 72
 	public function addHeading($title, $plainTitle = '');
71 73
 
@@ -77,6 +79,7 @@  discard block
 block discarded – undo
77 79
 	 *   if empty the $text is used, if false none will be used
78 80
 	 *
79 81
 	 * @since 12.0.0
82
+	 * @return void
80 83
 	 */
81 84
 	public function addBodyText($text, $plainText = '');
82 85
 
@@ -91,6 +94,7 @@  discard block
 block discarded – undo
91 94
 	 * @param string $plainMetaInfo Meta info that is used in the plain text email
92 95
 	 *   if empty the $metaInfo is used, if false none will be used
93 96
 	 * @since 12.0.0
97
+	 * @return void
94 98
 	 */
95 99
 	public function addBodyListItem($text, $metaInfo = '', $icon = '', $plainText = '', $plainMetaInfo = '');
96 100
 
@@ -105,6 +109,7 @@  discard block
 block discarded – undo
105 109
 	 * @param string $plainTextRight Text of right button that is used in the plain text version - if empty the $textRight is used
106 110
 	 *
107 111
 	 * @since 12.0.0
112
+	 * @return void
108 113
 	 */
109 114
 	public function addBodyButtonGroup($textLeft, $urlLeft, $textRight, $urlRight, $plainTextLeft = '', $plainTextRight = '');
110 115
 
@@ -117,6 +122,7 @@  discard block
 block discarded – undo
117 122
 	 * 		if empty the $text is used, if false none will be used
118 123
 	 *
119 124
 	 * @since 12.0.0
125
+	 * @return void
120 126
 	 */
121 127
 	public function addBodyButton($text, $url, $plainText = '');
122 128
 
@@ -126,6 +132,7 @@  discard block
 block discarded – undo
126 132
 	 * @param string $text If the text is empty the default "Name - Slogan<br>This is an automatically sent email" will be used
127 133
 	 *
128 134
 	 * @since 12.0.0
135
+	 * @return void
129 136
 	 */
130 137
 	public function addFooter($text = '');
131 138
 
Please login to merge, or discard this patch.
lib/private/BackgroundJob/JobList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -320,7 +320,7 @@
 block discarded – undo
320 320
 
321 321
 	/**
322 322
 	 * @param IJob $job
323
-	 * @param $timeTaken
323
+	 * @param integer $timeTaken
324 324
 	 */
325 325
 	public function setExecutionTime(IJob $job, $timeTaken) {
326 326
 		$query = $this->connection->getQueryBuilder();
Please login to merge, or discard this patch.
lib/private/Updater.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -431,7 +431,7 @@
 block discarded – undo
431 431
 	}
432 432
 
433 433
 	/**
434
-	 * @param array $disabledApps
434
+	 * @param string[] $disabledApps
435 435
 	 * @throws \Exception
436 436
 	 */
437 437
 	private function upgradeAppStoreApps(array $disabledApps) {
Please login to merge, or discard this patch.
lib/private/Diagnostics/Query.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,6 +48,9 @@  discard block
 block discarded – undo
48 48
 		$this->stack = $stack;
49 49
 	}
50 50
 
51
+	/**
52
+	 * @param double $time
53
+	 */
51 54
 	public function end($time) {
52 55
 		$this->end = $time;
53 56
 	}
@@ -67,7 +70,7 @@  discard block
 block discarded – undo
67 70
 	}
68 71
 
69 72
 	/**
70
-	 * @return float
73
+	 * @return integer
71 74
 	 */
72 75
 	public function getStart() {
73 76
 		return $this->start;
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/FilesPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -448,7 +448,7 @@
 block discarded – undo
448 448
 	 *
449 449
 	 * @param string $path source path
450 450
 	 * @param string $destination destination path
451
-	 * @return bool|void false to stop handling, void to skip this handler
451
+	 * @return null|false false to stop handling, void to skip this handler
452 452
 	 */
453 453
 	public function beforeMoveFutureFile($path, $destination) {
454 454
 		$sourceNode = $this->tree->getNodeForPath($path);
Please login to merge, or discard this patch.
apps/theming/lib/ThemingDefaults.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -58,7 +58,6 @@
 block discarded – undo
58 58
 	 * @param IConfig $config
59 59
 	 * @param IL10N $l
60 60
 	 * @param IURLGenerator $urlGenerator
61
-	 * @param \OC_Defaults $defaults
62 61
 	 * @param IAppData $appData
63 62
 	 * @param ICacheFactory $cacheFactory
64 63
 	 * @param Util $util
Please login to merge, or discard this patch.
apps/theming/lib/Util.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 	/**
72 72
 	 * get color for on-page elements:
73 73
 	 * theme color by default, grey if theme color is to bright
74
-	 * @param $color
74
+	 * @param string $color
75 75
 	 * @return string
76 76
 	 */
77 77
 	public function elementColor($color) {
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 
115 115
 	/**
116 116
 	 * @param $app string app name
117
-	 * @return string|ISimpleFile path to app icon / file of logo
117
+	 * @return string path to app icon / file of logo
118 118
 	 */
119 119
 	public function getAppIcon($app) {
120 120
 		$app = str_replace(array('\0', '/', '\\', '..'), '', $app);
@@ -190,8 +190,8 @@  discard block
 block discarded – undo
190 190
 	/**
191 191
 	 * replace default color with a custom one
192 192
 	 *
193
-	 * @param $svg string content of a svg file
194
-	 * @param $color string color to match
193
+	 * @param string $svg string content of a svg file
194
+	 * @param string $color string color to match
195 195
 	 * @return string
196 196
 	 */
197 197
 	public function colorizeSvg($svg, $color) {
Please login to merge, or discard this patch.
lib/private/Settings/Manager.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -265,6 +265,9 @@  discard block
 block discarded – undo
265 265
 		return $this->mapper->has($table, $className);
266 266
 	}
267 267
 
268
+	/**
269
+	 * @param string $type
270
+	 */
268 271
 	private function setupSettingsEntry($settingsClassName, $type) {
269 272
 		if (!class_exists($settingsClassName)) {
270 273
 			$this->log->debug('Could not find ' . $type . ' section class ' . $settingsClassName);
@@ -294,6 +297,9 @@  discard block
 block discarded – undo
294 297
 		}
295 298
 	}
296 299
 
300
+	/**
301
+	 * @param string $type
302
+	 */
297 303
 	private function getSectionTableForType($type) {
298 304
 		if($type === 'admin') {
299 305
 			return Mapper::TABLE_ADMIN_SECTIONS;
Please login to merge, or discard this patch.
apps/user_ldap/lib/Access.php 1 patch
Doc Comments   +8 added lines, -6 removed lines patch added patch discarded remove patch
@@ -491,7 +491,7 @@  discard block
 block discarded – undo
491 491
 
492 492
 	/**
493 493
 	 * returns the internal Nextcloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
494
-	 * @param string $dn the dn of the user object
494
+	 * @param string $fdn the dn of the user object
495 495
 	 * @param string $ldapName optional, the display name of the object
496 496
 	 * @return string|false with with the name to use in Nextcloud
497 497
 	 */
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
508 508
 
509 509
 	/**
510 510
 	 * returns an internal Nextcloud name for the given LDAP DN, false on DN outside of search DN
511
-	 * @param string $dn the dn of the user object
511
+	 * @param string $fdn the dn of the user object
512 512
 	 * @param string $ldapName optional, the display name of the object
513 513
 	 * @param bool $isUser optional, whether it is a user object (otherwise group assumed)
514 514
 	 * @return string|false with with the name to use in Nextcloud
@@ -771,7 +771,7 @@  discard block
 block discarded – undo
771 771
 	 * the login filter.
772 772
 	 *
773 773
 	 * @param string $loginName
774
-	 * @param array $attributes optional, list of attributes to read
774
+	 * @param string[] $attributes optional, list of attributes to read
775 775
 	 * @return array
776 776
 	 */
777 777
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -844,7 +844,7 @@  discard block
 block discarded – undo
844 844
 
845 845
 	/**
846 846
 	 * @param string $filter
847
-	 * @param string|string[] $attr
847
+	 * @param string[] $attr
848 848
 	 * @param int $limit
849 849
 	 * @param int $offset
850 850
 	 * @return array
@@ -892,7 +892,7 @@  discard block
 block discarded – undo
892 892
 
893 893
 	/**
894 894
 	 * @param string $filter
895
-	 * @param string|string[] $attr
895
+	 * @param string[] $attr
896 896
 	 * @param int $limit
897 897
 	 * @param int $offset
898 898
 	 * @return false|int
@@ -989,6 +989,7 @@  discard block
 block discarded – undo
989 989
 	 * retrieved. Results will according to the order in the array.
990 990
 	 * @param int $limit optional, maximum results to be counted
991 991
 	 * @param int $offset optional, a starting point
992
+	 * @param string $filter
992 993
 	 * @return array|false array with the search result as first value and pagedSearchOK as
993 994
 	 * second | false if not successful
994 995
 	 * @throws \OC\ServerNotAvailableException
@@ -1240,7 +1241,7 @@  discard block
 block discarded – undo
1240 1241
 
1241 1242
 	/**
1242 1243
 	 * @param string $name
1243
-	 * @return bool|mixed|string
1244
+	 * @return string
1244 1245
 	 */
1245 1246
 	public function sanitizeUsername($name) {
1246 1247
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -1264,6 +1265,7 @@  discard block
 block discarded – undo
1264 1265
 	* escapes (user provided) parts for LDAP filter
1265 1266
 	* @param string $input, the provided value
1266 1267
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
1268
+	* @param string $input
1267 1269
 	* @return string the escaped string
1268 1270
 	*/
1269 1271
 	public function escapeFilterPart($input, $allowAsterisk = false) {
Please login to merge, or discard this patch.