SubAdmin::isSubAdminOfGroup() - Code Metrics - Inspection of "Merge pull request #3141 from nextcloud/subadmin-c..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 16afaa...5d4864 )

by Joas

created 2017-01-23 11:10 UTC

SubAdmin::isSubAdminOfGroup() A

↳ Parent: SubAdmin

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	11
nc	2
nop	2
dl	0
loc	18
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * @copyright Copyright (c) 2016, ownCloud, Inc.
 *
 * @author Arthur Schiwon <[email protected]>
 * @author Bart Visscher <[email protected]>
 * @author Georg Ehrke <[email protected]>
 * @author Lukas Reschke <[email protected]>
 * @author Morris Jobke <[email protected]>
 * @author Roeland Jago Douma <[email protected]>
 *
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace OC;

use OC\Hooks\PublicEmitter;
use OCP\IUser;
use OCP\IUserManager;
use OCP\IGroup;
use OCP\IGroupManager;
use OCP\IDBConnection;

class SubAdmin extends PublicEmitter {

	/** @var IUserManager */
	private $userManager;

	/** @var IGroupManager */
	private $groupManager;

	/** @var IDBConnection */
	private $dbConn;

	/**
	 * @param IUserManager $userManager
	 * @param IGroupManager $groupManager
	 * @param IDBConnection $dbConn
	 */
	public function __construct(IUserManager $userManager,
	                            IGroupManager $groupManager,
								IDBConnection $dbConn) {
		$this->userManager = $userManager;
		$this->groupManager = $groupManager;
		$this->dbConn = $dbConn;

		$this->userManager->listen('\OC\User', 'postDelete', function($user) {
			$this->post_deleteUser($user);
		});
		$this->groupManager->listen('\OC\Group', 'postDelete', function($group) {
			$this->post_deleteGroup($group);	
		});
	}

	/**
	 * add a SubAdmin
	 * @param IUser $user user to be SubAdmin
	 * @param IGroup $group group $user becomes subadmin of
	 * @return bool
	 */
	public function createSubAdmin(IUser $user, IGroup $group) {
		$qb = $this->dbConn->getQueryBuilder();

		$qb->insert('group_admin')
			->values([
				'gid' => $qb->createNamedParameter($group->getGID()),
				'uid' => $qb->createNamedParameter($user->getUID())
			])
			->execute();

		$this->emit('\OC\SubAdmin', 'postCreateSubAdmin', [$user, $group]);
		\OC_Hook::emit("OC_SubAdmin", "post_createSubAdmin", ["gid" => $group->getGID()]);
		return true;
	}

	/**
	 * delete a SubAdmin
	 * @param IUser $user the user that is the SubAdmin
	 * @param IGroup $group the group
	 * @return bool
	 */
	public function deleteSubAdmin(IUser $user, IGroup $group) {
		$qb = $this->dbConn->getQueryBuilder();

		$qb->delete('group_admin')
			->where($qb->expr()->eq('gid', $qb->createNamedParameter($group->getGID())))
			->andWhere($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
			->execute();

		$this->emit('\OC\SubAdmin', 'postDeleteSubAdmin', [$user, $group]);
		\OC_Hook::emit("OC_SubAdmin", "post_deleteSubAdmin", ["gid" => $group->getGID()]);
		return true;
	}

	/**
	 * get groups of a SubAdmin
	 * @param IUser $user the SubAdmin
	 * @return IGroup[]
	 */
	public function getSubAdminsGroups(IUser $user) {

		$qb = $this->dbConn->getQueryBuilder();

		$result = $qb->select('gid')
			->from('group_admin')
			->where($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
			->execute();

		$groups = [];
		while($row = $result->fetch()) {
			$group = $this->groupManager->get($row['gid']);
			if(!is_null($group)) {
				$groups[] = $group;
			}
		}
		$result->closeCursor();

		return $groups;
	}

	/**
	 * get SubAdmins of a group
	 * @param IGroup $group the group
	 * @return IUser[]
	 */
	public function getGroupsSubAdmins(IGroup $group) {

		$qb = $this->dbConn->getQueryBuilder();

		$result = $qb->select('uid')
			->from('group_admin')
			->where($qb->expr()->eq('gid', $qb->createNamedParameter($group->getGID())))
			->execute();

		$users = [];
		while($row = $result->fetch()) {
			$user = $this->userManager->get($row['uid']);
			if(!is_null($user)) {
				$users[] = $user;
			}
		}
		$result->closeCursor();

		return $users;
	}

	/**
	 * get all SubAdmins
	 * @return array
	 */
	public function getAllSubAdmins() {
		$qb = $this->dbConn->getQueryBuilder();

		$result = $qb->select('*')
			->from('group_admin')
			->execute();

		$subadmins = [];
		while($row = $result->fetch()) {
			$user = $this->userManager->get($row['uid']);
			$group = $this->groupManager->get($row['gid']);
			if(!is_null($user) && !is_null($group)) {
				$subadmins[] = [
					'user'  => $user,
					'group' => $group
				];
			}
		}
		$result->closeCursor();

		return $subadmins;
	}

	/**
	 * checks if a user is a SubAdmin of a group
	 * @param IUser $user 
	 * @param IGroup $group
	 * @return bool
	 */
	public function isSubAdminOfGroup(IUser $user, IGroup $group) {
		$qb = $this->dbConn->getQueryBuilder();

		/*
		 * Primary key is ('gid', 'uid') so max 1 result possible here
		 */
		$result = $qb->select('*')
			->from('group_admin')
			->where($qb->expr()->eq('gid', $qb->createNamedParameter($group->getGID())))
			->andWhere($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
			->execute();

		$fetch =  $result->fetch();
		$result->closeCursor();
		$result = !empty($fetch) ? true : false;

		return $result;
	}

	/**
	 * checks if a user is a SubAdmin
	 * @param IUser $user 
	 * @return bool
	 */
	public function isSubAdmin(IUser $user) {
		// Check if the user is already an admin
		if ($this->groupManager->isAdmin($user->getUID())) {
			return true;
		}

		$qb = $this->dbConn->getQueryBuilder();

		$result = $qb->select('gid')
			->from('group_admin')
			->andWhere($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
			->setMaxResults(1)
			->execute();

		$isSubAdmin = $result->fetch();
		$result->closeCursor();

		$result = $isSubAdmin === false ? false : true;

		return $result;
	}

	/**
	 * checks if a user is a accessible by a subadmin
	 * @param IUser $subadmin
	 * @param IUser $user
	 * @return bool
	 */
	public function isUserAccessible($subadmin, $user) {
		if(!$this->isSubAdmin($subadmin)) {
			return false;
		}
		if($this->groupManager->isAdmin($user->getUID())) {
			return false;
		}
		$accessibleGroups = $this->getSubAdminsGroups($subadmin);
		foreach($accessibleGroups as $accessibleGroup) {
			if($accessibleGroup->inGroup($user)) {
				return true;
			}
		}
		return false;
	}

	/**
	 * delete all SubAdmins by $user
	 * @param IUser $user
	 * @return boolean
	 */
	private function post_deleteUser($user) {

		$qb = $this->dbConn->getQueryBuilder();

		$qb->delete('group_admin')
			->where($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
			->execute();

		return true;
	}

	/**
	 * delete all SubAdmins by $group
	 * @param IGroup $group
	 * @return boolean
	 */
	private function post_deleteGroup($group) {

		$qb = $this->dbConn->getQueryBuilder();

		$qb->delete('group_admin')
			->where($qb->expr()->eq('gid', $qb->createNamedParameter($group->getGID())))
			->execute();

		return true;
	}
}


1		<?php
2		/**
3		* @copyright Copyright (c) 2016, ownCloud, Inc.
4		*
5		* @author Arthur Schiwon <[email protected]>
6		* @author Bart Visscher <[email protected]>
7		* @author Georg Ehrke <[email protected]>
8		* @author Lukas Reschke <[email protected]>
9		* @author Morris Jobke <[email protected]>
10		* @author Roeland Jago Douma <[email protected]>
11		*
12		* @license AGPL-3.0
13		*
14		* This code is free software: you can redistribute it and/or modify
15		* it under the terms of the GNU Affero General Public License, version 3,
16		* as published by the Free Software Foundation.
17		*
18		* This program is distributed in the hope that it will be useful,
19		* but WITHOUT ANY WARRANTY; without even the implied warranty of
20		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21		* GNU Affero General Public License for more details.
22		*
23		* You should have received a copy of the GNU Affero General Public License, version 3,
24		* along with this program. If not, see <http://www.gnu.org/licenses/>
25		*
26		*/
27
28		namespace OC;
29
30		use OC\Hooks\PublicEmitter;
31		use OCP\IUser;
32		use OCP\IUserManager;
33		use OCP\IGroup;
34		use OCP\IGroupManager;
35		use OCP\IDBConnection;
36
37		class SubAdmin extends PublicEmitter {
38
39		/** @var IUserManager */
40		private $userManager;
41
42		/** @var IGroupManager */
43		private $groupManager;
44
45		/** @var IDBConnection */
46		private $dbConn;
47
48		/**
49		* @param IUserManager $userManager
50		* @param IGroupManager $groupManager
51		* @param IDBConnection $dbConn
52		*/
53		public function __construct(IUserManager $userManager,
54		IGroupManager $groupManager,
55		IDBConnection $dbConn) {
56		$this->userManager = $userManager;
57		$this->groupManager = $groupManager;
58		$this->dbConn = $dbConn;
59
60		$this->userManager->listen('\OC\User', 'postDelete', function($user) {
61		$this->post_deleteUser($user);
62		});
63		$this->groupManager->listen('\OC\Group', 'postDelete', function($group) {
64		$this->post_deleteGroup($group);
65		});
66		}
67
68		/**
69		* add a SubAdmin
70		* @param IUser $user user to be SubAdmin
71		* @param IGroup $group group $user becomes subadmin of
72		* @return bool
73		*/
74		public function createSubAdmin(IUser $user, IGroup $group) {
75		$qb = $this->dbConn->getQueryBuilder();
76
77		$qb->insert('group_admin')
78		->values([
79		'gid' => $qb->createNamedParameter($group->getGID()),
80		'uid' => $qb->createNamedParameter($user->getUID())
81		])
82		->execute();
83
84		$this->emit('\OC\SubAdmin', 'postCreateSubAdmin', [$user, $group]);
85		\OC_Hook::emit("OC_SubAdmin", "post_createSubAdmin", ["gid" => $group->getGID()]);
86		return true;
87		}
88
89		/**
90		* delete a SubAdmin
91		* @param IUser $user the user that is the SubAdmin
92		* @param IGroup $group the group
93		* @return bool
94		*/
95		public function deleteSubAdmin(IUser $user, IGroup $group) {
96		$qb = $this->dbConn->getQueryBuilder();
97
98		$qb->delete('group_admin')
99		->where($qb->expr()->eq('gid', $qb->createNamedParameter($group->getGID())))
100		->andWhere($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
101		->execute();
102
103		$this->emit('\OC\SubAdmin', 'postDeleteSubAdmin', [$user, $group]);
104		\OC_Hook::emit("OC_SubAdmin", "post_deleteSubAdmin", ["gid" => $group->getGID()]);
105		return true;
106		}
107
108		/**
109		* get groups of a SubAdmin
110		* @param IUser $user the SubAdmin
111		* @return IGroup[]
112		*/
113	View Code Duplication	public function getSubAdminsGroups(IUser $user) {
		0 ignored issues – show Duplication introduced 2016-06-09 12:21 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
114		$qb = $this->dbConn->getQueryBuilder();
115
116		$result = $qb->select('gid')
117		->from('group_admin')
118		->where($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
119		->execute();
120
121		$groups = [];
122		while($row = $result->fetch()) {
123		$group = $this->groupManager->get($row['gid']);
124		if(!is_null($group)) {
125		$groups[] = $group;
126		}
127		}
128		$result->closeCursor();
129
130		return $groups;
131		}
132
133		/**
134		* get SubAdmins of a group
135		* @param IGroup $group the group
136		* @return IUser[]
137		*/
138	View Code Duplication	public function getGroupsSubAdmins(IGroup $group) {
		0 ignored issues – show Duplication introduced 2016-06-09 12:21 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
139		$qb = $this->dbConn->getQueryBuilder();
140
141		$result = $qb->select('uid')
142		->from('group_admin')
143		->where($qb->expr()->eq('gid', $qb->createNamedParameter($group->getGID())))
144		->execute();
145
146		$users = [];
147		while($row = $result->fetch()) {
148		$user = $this->userManager->get($row['uid']);
149		if(!is_null($user)) {
150		$users[] = $user;
151		}
152		}
153		$result->closeCursor();
154
155		return $users;
156		}
157
158		/**
159		* get all SubAdmins
160		* @return array
161		*/
162		public function getAllSubAdmins() {
163		$qb = $this->dbConn->getQueryBuilder();
164
165		$result = $qb->select('*')
166		->from('group_admin')
167		->execute();
168
169		$subadmins = [];
170		while($row = $result->fetch()) {
171		$user = $this->userManager->get($row['uid']);
172		$group = $this->groupManager->get($row['gid']);
173		if(!is_null($user) && !is_null($group)) {
174		$subadmins[] = [
175		'user' => $user,
176		'group' => $group
177		];
178		}
179		}
180		$result->closeCursor();
181
182		return $subadmins;
183		}
184
185		/**
186		* checks if a user is a SubAdmin of a group
187		* @param IUser $user
188		* @param IGroup $group
189		* @return bool
190		*/
191		public function isSubAdminOfGroup(IUser $user, IGroup $group) {
192		$qb = $this->dbConn->getQueryBuilder();
193
194		/*
195		* Primary key is ('gid', 'uid') so max 1 result possible here
196		*/
197		$result = $qb->select('*')
198		->from('group_admin')
199		->where($qb->expr()->eq('gid', $qb->createNamedParameter($group->getGID())))
200		->andWhere($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
201		->execute();
202
203		$fetch = $result->fetch();
204		$result->closeCursor();
205		$result = !empty($fetch) ? true : false;
206
207		return $result;
208		}
209
210		/**
211		* checks if a user is a SubAdmin
212		* @param IUser $user
213		* @return bool
214		*/
215		public function isSubAdmin(IUser $user) {
216		// Check if the user is already an admin
217		if ($this->groupManager->isAdmin($user->getUID())) {
218		return true;
219		}
220
221		$qb = $this->dbConn->getQueryBuilder();
222
223		$result = $qb->select('gid')
224		->from('group_admin')
225		->andWhere($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
226		->setMaxResults(1)
227		->execute();
228
229		$isSubAdmin = $result->fetch();
230		$result->closeCursor();
231
232		$result = $isSubAdmin === false ? false : true;
233
234		return $result;
235		}
236
237		/**
238		* checks if a user is a accessible by a subadmin
239		* @param IUser $subadmin
240		* @param IUser $user
241		* @return bool
242		*/
243		public function isUserAccessible($subadmin, $user) {
244		if(!$this->isSubAdmin($subadmin)) {
245		return false;
246		}
247		if($this->groupManager->isAdmin($user->getUID())) {
248		return false;
249		}
250		$accessibleGroups = $this->getSubAdminsGroups($subadmin);
251		foreach($accessibleGroups as $accessibleGroup) {
252		if($accessibleGroup->inGroup($user)) {
253		return true;
254		}
255		}
256		return false;
257		}
258
259		/**
260		* delete all SubAdmins by $user
261		* @param IUser $user
262		* @return boolean
263		*/
264	View Code Duplication	private function post_deleteUser($user) {
		0 ignored issues – show Duplication introduced 2016-06-09 12:21 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
265		$qb = $this->dbConn->getQueryBuilder();
266
267		$qb->delete('group_admin')
268		->where($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
269		->execute();
270
271		return true;
272		}
273
274		/**
275		* delete all SubAdmins by $group
276		* @param IGroup $group
277		* @return boolean
278		*/
279	View Code Duplication	private function post_deleteGroup($group) {
		0 ignored issues – show Duplication introduced 2016-06-09 12:21 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
280		$qb = $this->dbConn->getQueryBuilder();
281
282		$qb->delete('group_admin')
283		->where($qb->expr()->eq('gid', $qb->createNamedParameter($group->getGID())))
284		->execute();
285
286		return true;
287		}
288		}
289

nextcloud / server

Push — master ( 16afaa...5d4864 )

SubAdmin::isSubAdminOfGroup() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like