Completed
Pull Request — master (#9345)
by Björn
16:57
created
apps/cloud_federation_api/lib/Controller/RequestHandlerController.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,6 @@
 block discarded – undo
106 106
 	 * @param string $ownerDisplayName display name of the user who shared the item
107 107
 	 * @param string $sharedBy provider specific UID of the user who shared the resource
108 108
 	 * @param string $sharedByDisplayName display name of the user who shared the resource
109
-	 * @param string $sharedSecret use to authenticate accross servers
110 109
 	 * @param array $protocol (e,.g. ['name' => 'webdav', 'options' => ['username' => 'john', 'permissions' => 31]])
111 110
 	 * @param string $shareType ('group' or 'user' share)
112 111
 	 * @param $resourceType ('file', 'calendar',...)
Please login to merge, or discard this patch.
apps/files_sharing/lib/External/Manager.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -324,9 +324,9 @@  discard block
 block discarded – undo
324 324
 	 *
325 325
 	 * @param string $remoteDomain
326 326
 	 * @param string $token
327
-	 * @param $remoteId id of the share
327
+	 * @param integer $remoteId id of the share
328 328
 	 * @param string $feedback
329
-	 * @return mixed
329
+	 * @return boolean|null
330 330
 	 */
331 331
 	protected function tryOCMEndPoint($remoteDomain, $token, $remoteId, $feedback) {
332 332
 		switch ($feedback) {
@@ -406,6 +406,9 @@  discard block
 block discarded – undo
406 406
 		return $result;
407 407
 	}
408 408
 
409
+	/**
410
+	 * @param string $mountPoint
411
+	 */
409 412
 	public function removeShare($mountPoint) {
410 413
 
411 414
 		$mountPointObj = $this->mountManager->find($mountPoint);
Please login to merge, or discard this patch.
apps/federatedfilesharing/lib/ocm/CloudFederationProviderFiles.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 	 * share received from another server
123 123
 	 *
124 124
 	 * @param ICloudFederationShare $share
125
-	 * @return string provider specific unique ID of the share
125
+	 * @return integer provider specific unique ID of the share
126 126
 	 *
127 127
 	 * @throws ProviderCouldNotAddShareException
128 128
 	 * @throws \OCP\AppFramework\QueryException
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
 	}
266 266
 
267 267
 	/**
268
-	 * @param $id
268
+	 * @param string $id
269 269
 	 * @param $notification
270 270
 	 * @return bool
271 271
 	 * @throws ActionNotSupportedException
Please login to merge, or discard this patch.
lib/public/Federation/Exceptions/AuthenticationFailedException.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,6 @@
 block discarded – undo
28 28
 	/**
29 29
 	 * BadRequestException constructor.
30 30
 	 *
31
-	 * @param array $missingParameters
32 31
 	 */
33 32
 	public function __construct() {
34 33
 		$l = \OC::$server->getL10N('federation');
Please login to merge, or discard this patch.