Completed
Pull Request — master (#3838)
by Vars
12:18
created
apps/dav/lib/SystemTag/SystemTagsObjectMappingCollection.php 1 patch
Indentation   +165 added lines, -165 removed lines patch added patch discarded remove patch
@@ -39,169 +39,169 @@
 block discarded – undo
39 39
  */
40 40
 class SystemTagsObjectMappingCollection implements ICollection {
41 41
 
42
-	/**
43
-	 * @var string
44
-	 */
45
-	private $objectId;
46
-
47
-	/**
48
-	 * @var string
49
-	 */
50
-	private $objectType;
51
-
52
-	/**
53
-	 * @var ISystemTagManager
54
-	 */
55
-	private $tagManager;
56
-
57
-	/**
58
-	 * @var ISystemTagObjectMapper
59
-	 */
60
-	private $tagMapper;
61
-
62
-	/**
63
-	 * User
64
-	 *
65
-	 * @var IUser
66
-	 */
67
-	private $user;
68
-
69
-
70
-	/**
71
-	 * Constructor
72
-	 *
73
-	 * @param string $objectId object id
74
-	 * @param string $objectType object type
75
-	 * @param IUser $user user
76
-	 * @param ISystemTagManager $tagManager tag manager
77
-	 * @param ISystemTagObjectMapper $tagMapper tag mapper
78
-	 */
79
-	public function __construct(
80
-		$objectId,
81
-		$objectType,
82
-		IUser $user,
83
-		ISystemTagManager $tagManager,
84
-		ISystemTagObjectMapper $tagMapper
85
-	) {
86
-		$this->tagManager = $tagManager;
87
-		$this->tagMapper = $tagMapper;
88
-		$this->objectId = $objectId;
89
-		$this->objectType = $objectType;
90
-		$this->user = $user;
91
-	}
92
-
93
-	function createFile($tagId, $data = null) {
94
-		try {
95
-			$tags = $this->tagManager->getTagsByIds([$tagId]);
96
-			$tag = current($tags);
97
-			if (!$this->tagManager->canUserSeeTag($tag, $this->user)) {
98
-				throw new PreconditionFailed('Tag with id ' . $tagId . ' does not exist, cannot assign');
99
-			}
100
-			if (!$this->tagManager->canUserAssignTag($tag, $this->user)) {
101
-				throw new Forbidden('No permission to assign tag ' . $tagId);
102
-			}
103
-
104
-			$this->tagMapper->assignTags($this->objectId, $this->objectType, $tagId);
105
-		} catch (TagNotFoundException $e) {
106
-			throw new PreconditionFailed('Tag with id ' . $tagId . ' does not exist, cannot assign');
107
-		}
108
-	}
109
-
110
-	function createDirectory($name) {
111
-		throw new Forbidden('Permission denied to create collections');
112
-	}
113
-
114
-	function getChild($tagId) {
115
-		try {
116
-			if ($this->tagMapper->haveTag([$this->objectId], $this->objectType, $tagId, true)) {
117
-				$tag = $this->tagManager->getTagsByIds([$tagId]);
118
-				$tag = current($tag);
119
-				if ($this->tagManager->canUserSeeTag($tag, $this->user)) {
120
-					return $this->makeNode($tag);
121
-				}
122
-			}
123
-			throw new NotFound('Tag with id ' . $tagId . ' not present for object ' . $this->objectId);
124
-		} catch (\InvalidArgumentException $e) {
125
-			throw new BadRequest('Invalid tag id', 0, $e);
126
-		} catch (TagNotFoundException $e) {
127
-			throw new NotFound('Tag with id ' . $tagId . ' not found', 0, $e);
128
-		}
129
-	}
130
-
131
-	function getChildren() {
132
-		$tagIds = current($this->tagMapper->getTagIdsForObjects([$this->objectId], $this->objectType));
133
-		if (empty($tagIds)) {
134
-			return [];
135
-		}
136
-		$tags = $this->tagManager->getTagsByIds($tagIds);
137
-
138
-		// filter out non-visible tags
139
-		$tags = array_filter($tags, function($tag) {
140
-			return $this->tagManager->canUserSeeTag($tag, $this->user);
141
-		});
142
-
143
-		return array_values(array_map(function($tag) {
144
-			return $this->makeNode($tag);
145
-		}, $tags));
146
-	}
147
-
148
-	function childExists($tagId) {
149
-		try {
150
-			$result = ($this->tagMapper->haveTag([$this->objectId], $this->objectType, $tagId, true));
151
-
152
-			if ($result) {
153
-				$tags = $this->tagManager->getTagsByIds([$tagId]);
154
-				$tag = current($tags);
155
-				if (!$this->tagManager->canUserSeeTag($tag, $this->user)) {
156
-					return false;
157
-				}
158
-			}
159
-
160
-			return $result;
161
-		} catch (\InvalidArgumentException $e) {
162
-			throw new BadRequest('Invalid tag id', 0, $e);
163
-		} catch (TagNotFoundException $e) {
164
-			return false;
165
-		}
166
-	}
167
-
168
-	function delete() {
169
-		throw new Forbidden('Permission denied to delete this collection');
170
-	}
171
-
172
-	function getName() {
173
-		return $this->objectId;
174
-	}
175
-
176
-	function setName($name) {
177
-		throw new Forbidden('Permission denied to rename this collection');
178
-	}
179
-
180
-	/**
181
-	 * Returns the last modification time, as a unix timestamp
182
-	 *
183
-	 * @return int
184
-	 */
185
-	function getLastModified() {
186
-		return null;
187
-	}
188
-
189
-	/**
190
-	 * Create a sabre node for the mapping of the 
191
-	 * given system tag to the collection's object
192
-	 *
193
-	 * @param ISystemTag $tag
194
-	 *
195
-	 * @return SystemTagMappingNode
196
-	 */
197
-	private function makeNode(ISystemTag $tag) {
198
-		return new SystemTagMappingNode(
199
-			$tag,
200
-			$this->objectId,
201
-			$this->objectType,
202
-			$this->user,
203
-			$this->tagManager,
204
-			$this->tagMapper
205
-		);
206
-	}
42
+    /**
43
+     * @var string
44
+     */
45
+    private $objectId;
46
+
47
+    /**
48
+     * @var string
49
+     */
50
+    private $objectType;
51
+
52
+    /**
53
+     * @var ISystemTagManager
54
+     */
55
+    private $tagManager;
56
+
57
+    /**
58
+     * @var ISystemTagObjectMapper
59
+     */
60
+    private $tagMapper;
61
+
62
+    /**
63
+     * User
64
+     *
65
+     * @var IUser
66
+     */
67
+    private $user;
68
+
69
+
70
+    /**
71
+     * Constructor
72
+     *
73
+     * @param string $objectId object id
74
+     * @param string $objectType object type
75
+     * @param IUser $user user
76
+     * @param ISystemTagManager $tagManager tag manager
77
+     * @param ISystemTagObjectMapper $tagMapper tag mapper
78
+     */
79
+    public function __construct(
80
+        $objectId,
81
+        $objectType,
82
+        IUser $user,
83
+        ISystemTagManager $tagManager,
84
+        ISystemTagObjectMapper $tagMapper
85
+    ) {
86
+        $this->tagManager = $tagManager;
87
+        $this->tagMapper = $tagMapper;
88
+        $this->objectId = $objectId;
89
+        $this->objectType = $objectType;
90
+        $this->user = $user;
91
+    }
92
+
93
+    function createFile($tagId, $data = null) {
94
+        try {
95
+            $tags = $this->tagManager->getTagsByIds([$tagId]);
96
+            $tag = current($tags);
97
+            if (!$this->tagManager->canUserSeeTag($tag, $this->user)) {
98
+                throw new PreconditionFailed('Tag with id ' . $tagId . ' does not exist, cannot assign');
99
+            }
100
+            if (!$this->tagManager->canUserAssignTag($tag, $this->user)) {
101
+                throw new Forbidden('No permission to assign tag ' . $tagId);
102
+            }
103
+
104
+            $this->tagMapper->assignTags($this->objectId, $this->objectType, $tagId);
105
+        } catch (TagNotFoundException $e) {
106
+            throw new PreconditionFailed('Tag with id ' . $tagId . ' does not exist, cannot assign');
107
+        }
108
+    }
109
+
110
+    function createDirectory($name) {
111
+        throw new Forbidden('Permission denied to create collections');
112
+    }
113
+
114
+    function getChild($tagId) {
115
+        try {
116
+            if ($this->tagMapper->haveTag([$this->objectId], $this->objectType, $tagId, true)) {
117
+                $tag = $this->tagManager->getTagsByIds([$tagId]);
118
+                $tag = current($tag);
119
+                if ($this->tagManager->canUserSeeTag($tag, $this->user)) {
120
+                    return $this->makeNode($tag);
121
+                }
122
+            }
123
+            throw new NotFound('Tag with id ' . $tagId . ' not present for object ' . $this->objectId);
124
+        } catch (\InvalidArgumentException $e) {
125
+            throw new BadRequest('Invalid tag id', 0, $e);
126
+        } catch (TagNotFoundException $e) {
127
+            throw new NotFound('Tag with id ' . $tagId . ' not found', 0, $e);
128
+        }
129
+    }
130
+
131
+    function getChildren() {
132
+        $tagIds = current($this->tagMapper->getTagIdsForObjects([$this->objectId], $this->objectType));
133
+        if (empty($tagIds)) {
134
+            return [];
135
+        }
136
+        $tags = $this->tagManager->getTagsByIds($tagIds);
137
+
138
+        // filter out non-visible tags
139
+        $tags = array_filter($tags, function($tag) {
140
+            return $this->tagManager->canUserSeeTag($tag, $this->user);
141
+        });
142
+
143
+        return array_values(array_map(function($tag) {
144
+            return $this->makeNode($tag);
145
+        }, $tags));
146
+    }
147
+
148
+    function childExists($tagId) {
149
+        try {
150
+            $result = ($this->tagMapper->haveTag([$this->objectId], $this->objectType, $tagId, true));
151
+
152
+            if ($result) {
153
+                $tags = $this->tagManager->getTagsByIds([$tagId]);
154
+                $tag = current($tags);
155
+                if (!$this->tagManager->canUserSeeTag($tag, $this->user)) {
156
+                    return false;
157
+                }
158
+            }
159
+
160
+            return $result;
161
+        } catch (\InvalidArgumentException $e) {
162
+            throw new BadRequest('Invalid tag id', 0, $e);
163
+        } catch (TagNotFoundException $e) {
164
+            return false;
165
+        }
166
+    }
167
+
168
+    function delete() {
169
+        throw new Forbidden('Permission denied to delete this collection');
170
+    }
171
+
172
+    function getName() {
173
+        return $this->objectId;
174
+    }
175
+
176
+    function setName($name) {
177
+        throw new Forbidden('Permission denied to rename this collection');
178
+    }
179
+
180
+    /**
181
+     * Returns the last modification time, as a unix timestamp
182
+     *
183
+     * @return int
184
+     */
185
+    function getLastModified() {
186
+        return null;
187
+    }
188
+
189
+    /**
190
+     * Create a sabre node for the mapping of the 
191
+     * given system tag to the collection's object
192
+     *
193
+     * @param ISystemTag $tag
194
+     *
195
+     * @return SystemTagMappingNode
196
+     */
197
+    private function makeNode(ISystemTag $tag) {
198
+        return new SystemTagMappingNode(
199
+            $tag,
200
+            $this->objectId,
201
+            $this->objectType,
202
+            $this->user,
203
+            $this->tagManager,
204
+            $this->tagMapper
205
+        );
206
+    }
207 207
 }
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagsRelationsCollection.php 1 patch
Indentation   +49 added lines, -49 removed lines patch added patch discarded remove patch
@@ -36,59 +36,59 @@
 block discarded – undo
36 36
 
37 37
 class SystemTagsRelationsCollection extends SimpleCollection {
38 38
 
39
-	/**
40
-	 * SystemTagsRelationsCollection constructor.
41
-	 *
42
-	 * @param ISystemTagManager $tagManager
43
-	 * @param ISystemTagObjectMapper $tagMapper
44
-	 * @param IUserSession $userSession
45
-	 * @param IGroupManager $groupManager
46
-	 * @param EventDispatcherInterface $dispatcher
47
-	 */
48
-	public function __construct(
49
-		ISystemTagManager $tagManager,
50
-		ISystemTagObjectMapper $tagMapper,
51
-		IUserSession $userSession,
52
-		IGroupManager $groupManager,
53
-		EventDispatcherInterface $dispatcher
54
-	) {
55
-		$children = [
56
-			new SystemTagsObjectTypeCollection(
57
-				'files',
58
-				$tagManager,
59
-				$tagMapper,
60
-				$userSession,
61
-				$groupManager,
62
-				function($name) {
63
-					$nodes = \OC::$server->getUserFolder()->getById(intval($name));
64
-					return !empty($nodes);
65
-				}
66
-			),
67
-		];
39
+    /**
40
+     * SystemTagsRelationsCollection constructor.
41
+     *
42
+     * @param ISystemTagManager $tagManager
43
+     * @param ISystemTagObjectMapper $tagMapper
44
+     * @param IUserSession $userSession
45
+     * @param IGroupManager $groupManager
46
+     * @param EventDispatcherInterface $dispatcher
47
+     */
48
+    public function __construct(
49
+        ISystemTagManager $tagManager,
50
+        ISystemTagObjectMapper $tagMapper,
51
+        IUserSession $userSession,
52
+        IGroupManager $groupManager,
53
+        EventDispatcherInterface $dispatcher
54
+    ) {
55
+        $children = [
56
+            new SystemTagsObjectTypeCollection(
57
+                'files',
58
+                $tagManager,
59
+                $tagMapper,
60
+                $userSession,
61
+                $groupManager,
62
+                function($name) {
63
+                    $nodes = \OC::$server->getUserFolder()->getById(intval($name));
64
+                    return !empty($nodes);
65
+                }
66
+            ),
67
+        ];
68 68
 
69
-		$event = new SystemTagsEntityEvent(SystemTagsEntityEvent::EVENT_ENTITY);
70
-		$dispatcher->dispatch(SystemTagsEntityEvent::EVENT_ENTITY, $event);
69
+        $event = new SystemTagsEntityEvent(SystemTagsEntityEvent::EVENT_ENTITY);
70
+        $dispatcher->dispatch(SystemTagsEntityEvent::EVENT_ENTITY, $event);
71 71
 
72
-		foreach ($event->getEntityCollections() as $entity => $entityExistsFunction) {
73
-			$children[] = new SystemTagsObjectTypeCollection(
74
-				$entity,
75
-				$tagManager,
76
-				$tagMapper,
77
-				$userSession,
78
-				$groupManager,
79
-				$entityExistsFunction
80
-			);
81
-		}
72
+        foreach ($event->getEntityCollections() as $entity => $entityExistsFunction) {
73
+            $children[] = new SystemTagsObjectTypeCollection(
74
+                $entity,
75
+                $tagManager,
76
+                $tagMapper,
77
+                $userSession,
78
+                $groupManager,
79
+                $entityExistsFunction
80
+            );
81
+        }
82 82
 
83
-		parent::__construct('root', $children);
84
-	}
83
+        parent::__construct('root', $children);
84
+    }
85 85
 
86
-	function getName() {
87
-		return 'systemtags-relations';
88
-	}
86
+    function getName() {
87
+        return 'systemtags-relations';
88
+    }
89 89
 
90
-	function setName($name) {
91
-		throw new Forbidden('Permission denied to rename this collection');
92
-	}
90
+    function setName($name) {
91
+        throw new Forbidden('Permission denied to rename this collection');
92
+    }
93 93
 
94 94
 }
Please login to merge, or discard this patch.
apps/dav/appinfo/v1/webdav.php 1 patch
Indentation   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -31,30 +31,30 @@
 block discarded – undo
31 31
 \OC_Util::obEnd();
32 32
 
33 33
 $serverFactory = new \OCA\DAV\Connector\Sabre\ServerFactory(
34
-	\OC::$server->getConfig(),
35
-	\OC::$server->getLogger(),
36
-	\OC::$server->getDatabaseConnection(),
37
-	\OC::$server->getUserSession(),
38
-	\OC::$server->getMountManager(),
39
-	\OC::$server->getTagManager(),
40
-	\OC::$server->getRequest(),
41
-	\OC::$server->getPreviewManager()
34
+    \OC::$server->getConfig(),
35
+    \OC::$server->getLogger(),
36
+    \OC::$server->getDatabaseConnection(),
37
+    \OC::$server->getUserSession(),
38
+    \OC::$server->getMountManager(),
39
+    \OC::$server->getTagManager(),
40
+    \OC::$server->getRequest(),
41
+    \OC::$server->getPreviewManager()
42 42
 );
43 43
 
44 44
 // Backends
45 45
 $authBackend = new \OCA\DAV\Connector\Sabre\Auth(
46
-	\OC::$server->getSession(),
47
-	\OC::$server->getUserSession(),
48
-	\OC::$server->getRequest(),
49
-	\OC::$server->getTwoFactorAuthManager(),
50
-	\OC::$server->getBruteForceThrottler(),
51
-	'principals/'
46
+    \OC::$server->getSession(),
47
+    \OC::$server->getUserSession(),
48
+    \OC::$server->getRequest(),
49
+    \OC::$server->getTwoFactorAuthManager(),
50
+    \OC::$server->getBruteForceThrottler(),
51
+    'principals/'
52 52
 );
53 53
 $requestUri = \OC::$server->getRequest()->getRequestUri();
54 54
 
55 55
 $server = $serverFactory->createServer($baseuri, $requestUri, $authBackend, function() {
56
-	// use the view for the logged in user
57
-	return \OC\Files\Filesystem::getView();
56
+    // use the view for the logged in user
57
+    return \OC\Files\Filesystem::getView();
58 58
 });
59 59
 
60 60
 // And off we go!
Please login to merge, or discard this patch.
apps/dav/appinfo/v1/carddav.php 1 patch
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -35,17 +35,17 @@  discard block
 block discarded – undo
35 35
 use Sabre\CardDAV\Plugin;
36 36
 
37 37
 $authBackend = new Auth(
38
-	\OC::$server->getSession(),
39
-	\OC::$server->getUserSession(),
40
-	\OC::$server->getRequest(),
41
-	\OC::$server->getTwoFactorAuthManager(),
42
-	\OC::$server->getBruteForceThrottler(),
43
-	'principals/'
38
+    \OC::$server->getSession(),
39
+    \OC::$server->getUserSession(),
40
+    \OC::$server->getRequest(),
41
+    \OC::$server->getTwoFactorAuthManager(),
42
+    \OC::$server->getBruteForceThrottler(),
43
+    'principals/'
44 44
 );
45 45
 $principalBackend = new Principal(
46
-	\OC::$server->getUserManager(),
47
-	\OC::$server->getGroupManager(),
48
-	'principals/'
46
+    \OC::$server->getUserManager(),
47
+    \OC::$server->getGroupManager(),
48
+    'principals/'
49 49
 );
50 50
 $db = \OC::$server->getDatabaseConnection();
51 51
 $cardDavBackend = new CardDavBackend($db, $principalBackend, \OC::$server->getUserManager());
@@ -60,8 +60,8 @@  discard block
 block discarded – undo
60 60
 $addressBookRoot->disableListing = !$debugging; // Disable listing
61 61
 
62 62
 $nodes = array(
63
-	$principalCollection,
64
-	$addressBookRoot,
63
+    $principalCollection,
64
+    $addressBookRoot,
65 65
 );
66 66
 
67 67
 // Fire up server
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 
77 77
 $server->addPlugin(new LegacyDAVACL());
78 78
 if ($debugging) {
79
-	$server->addPlugin(new Sabre\DAV\Browser\Plugin());
79
+    $server->addPlugin(new Sabre\DAV\Browser\Plugin());
80 80
 }
81 81
 
82 82
 $server->addPlugin(new \Sabre\DAV\Sync\Plugin());
Please login to merge, or discard this patch.
apps/dav/appinfo/v1/caldav.php 1 patch
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -33,17 +33,17 @@  discard block
 block discarded – undo
33 33
 use OCA\DAV\Connector\Sabre\Principal;
34 34
 
35 35
 $authBackend = new Auth(
36
-	\OC::$server->getSession(),
37
-	\OC::$server->getUserSession(),
38
-	\OC::$server->getRequest(),
39
-	\OC::$server->getTwoFactorAuthManager(),
40
-	\OC::$server->getBruteForceThrottler(),
41
-	'principals/'
36
+    \OC::$server->getSession(),
37
+    \OC::$server->getUserSession(),
38
+    \OC::$server->getRequest(),
39
+    \OC::$server->getTwoFactorAuthManager(),
40
+    \OC::$server->getBruteForceThrottler(),
41
+    'principals/'
42 42
 );
43 43
 $principalBackend = new Principal(
44
-	\OC::$server->getUserManager(),
45
-	\OC::$server->getGroupManager(),
46
-	'principals/'
44
+    \OC::$server->getUserManager(),
45
+    \OC::$server->getGroupManager(),
46
+    'principals/'
47 47
 );
48 48
 $db = \OC::$server->getDatabaseConnection();
49 49
 $userManager = \OC::$server->getUserManager();
@@ -61,8 +61,8 @@  discard block
 block discarded – undo
61 61
 $addressBookRoot->disableListing = !$debugging; // Disable listing
62 62
 
63 63
 $nodes = array(
64
-	$principalCollection,
65
-	$addressBookRoot,
64
+    $principalCollection,
65
+    $addressBookRoot,
66 66
 );
67 67
 
68 68
 // Fire up server
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 
79 79
 $server->addPlugin(new LegacyDAVACL());
80 80
 if ($debugging) {
81
-	$server->addPlugin(new Sabre\DAV\Browser\Plugin());
81
+    $server->addPlugin(new Sabre\DAV\Browser\Plugin());
82 82
 }
83 83
 
84 84
 $server->addPlugin(new \Sabre\DAV\Sync\Plugin());
Please login to merge, or discard this patch.
apps/dav/appinfo/v1/publicwebdav.php 1 patch
Indentation   +46 added lines, -46 removed lines patch added patch discarded remove patch
@@ -38,20 +38,20 @@  discard block
 block discarded – undo
38 38
 
39 39
 // Backends
40 40
 $authBackend = new OCA\DAV\Connector\PublicAuth(
41
-	\OC::$server->getRequest(),
42
-	\OC::$server->getShareManager(),
43
-	\OC::$server->getSession()
41
+    \OC::$server->getRequest(),
42
+    \OC::$server->getShareManager(),
43
+    \OC::$server->getSession()
44 44
 );
45 45
 
46 46
 $serverFactory = new OCA\DAV\Connector\Sabre\ServerFactory(
47
-	\OC::$server->getConfig(),
48
-	\OC::$server->getLogger(),
49
-	\OC::$server->getDatabaseConnection(),
50
-	\OC::$server->getUserSession(),
51
-	\OC::$server->getMountManager(),
52
-	\OC::$server->getTagManager(),
53
-	\OC::$server->getRequest(),
54
-	\OC::$server->getPreviewManager()
47
+    \OC::$server->getConfig(),
48
+    \OC::$server->getLogger(),
49
+    \OC::$server->getDatabaseConnection(),
50
+    \OC::$server->getUserSession(),
51
+    \OC::$server->getMountManager(),
52
+    \OC::$server->getTagManager(),
53
+    \OC::$server->getRequest(),
54
+    \OC::$server->getPreviewManager()
55 55
 );
56 56
 
57 57
 $requestUri = \OC::$server->getRequest()->getRequestUri();
@@ -60,41 +60,41 @@  discard block
 block discarded – undo
60 60
 $filesDropPlugin = new \OCA\DAV\Files\Sharing\FilesDropPlugin();
61 61
 
62 62
 $server = $serverFactory->createServer($baseuri, $requestUri, $authBackend, function (\Sabre\DAV\Server $server) use ($authBackend, $linkCheckPlugin, $filesDropPlugin) {
63
-	$isAjax = (isset($_SERVER['HTTP_X_REQUESTED_WITH']) && $_SERVER['HTTP_X_REQUESTED_WITH'] === 'XMLHttpRequest');
64
-	$federatedSharingApp = new \OCA\FederatedFileSharing\AppInfo\Application();
65
-	$federatedShareProvider = $federatedSharingApp->getFederatedShareProvider();
66
-	if ($federatedShareProvider->isOutgoingServer2serverShareEnabled() === false && !$isAjax) {
67
-		// this is what is thrown when trying to access a non-existing share
68
-		throw new \Sabre\DAV\Exception\NotAuthenticated();
69
-	}
70
-
71
-	$share = $authBackend->getShare();
72
-	$owner = $share->getShareOwner();
73
-	$isReadable = $share->getPermissions() & \OCP\Constants::PERMISSION_READ;
74
-	$fileId = $share->getNodeId();
75
-
76
-	// FIXME: should not add storage wrappers outside of preSetup, need to find a better way
77
-	$previousLog = \OC\Files\Filesystem::logWarningWhenAddingStorageWrapper(false);
78
-	\OC\Files\Filesystem::addStorageWrapper('sharePermissions', function ($mountPoint, $storage) use ($share) {
79
-		return new \OC\Files\Storage\Wrapper\PermissionsMask(array('storage' => $storage, 'mask' => $share->getPermissions() | \OCP\Constants::PERMISSION_SHARE));
80
-	});
81
-	\OC\Files\Filesystem::logWarningWhenAddingStorageWrapper($previousLog);
82
-
83
-	OC_Util::setupFS($owner);
84
-	$ownerView = \OC\Files\Filesystem::getView();
85
-	$path = $ownerView->getPath($fileId);
86
-	$fileInfo = $ownerView->getFileInfo($path);
87
-	$linkCheckPlugin->setFileInfo($fileInfo);
88
-
89
-	// If not readble (files_drop) enable the filesdrop plugin
90
-	if (!$isReadable) {
91
-		$filesDropPlugin->enable();
92
-	}
93
-
94
-	$view = new \OC\Files\View($ownerView->getAbsolutePath($path));
95
-	$filesDropPlugin->setView($view);
96
-
97
-	return $view;
63
+    $isAjax = (isset($_SERVER['HTTP_X_REQUESTED_WITH']) && $_SERVER['HTTP_X_REQUESTED_WITH'] === 'XMLHttpRequest');
64
+    $federatedSharingApp = new \OCA\FederatedFileSharing\AppInfo\Application();
65
+    $federatedShareProvider = $federatedSharingApp->getFederatedShareProvider();
66
+    if ($federatedShareProvider->isOutgoingServer2serverShareEnabled() === false && !$isAjax) {
67
+        // this is what is thrown when trying to access a non-existing share
68
+        throw new \Sabre\DAV\Exception\NotAuthenticated();
69
+    }
70
+
71
+    $share = $authBackend->getShare();
72
+    $owner = $share->getShareOwner();
73
+    $isReadable = $share->getPermissions() & \OCP\Constants::PERMISSION_READ;
74
+    $fileId = $share->getNodeId();
75
+
76
+    // FIXME: should not add storage wrappers outside of preSetup, need to find a better way
77
+    $previousLog = \OC\Files\Filesystem::logWarningWhenAddingStorageWrapper(false);
78
+    \OC\Files\Filesystem::addStorageWrapper('sharePermissions', function ($mountPoint, $storage) use ($share) {
79
+        return new \OC\Files\Storage\Wrapper\PermissionsMask(array('storage' => $storage, 'mask' => $share->getPermissions() | \OCP\Constants::PERMISSION_SHARE));
80
+    });
81
+    \OC\Files\Filesystem::logWarningWhenAddingStorageWrapper($previousLog);
82
+
83
+    OC_Util::setupFS($owner);
84
+    $ownerView = \OC\Files\Filesystem::getView();
85
+    $path = $ownerView->getPath($fileId);
86
+    $fileInfo = $ownerView->getFileInfo($path);
87
+    $linkCheckPlugin->setFileInfo($fileInfo);
88
+
89
+    // If not readble (files_drop) enable the filesdrop plugin
90
+    if (!$isReadable) {
91
+        $filesDropPlugin->enable();
92
+    }
93
+
94
+    $view = new \OC\Files\View($ownerView->getAbsolutePath($path));
95
+    $filesDropPlugin->setView($view);
96
+
97
+    return $view;
98 98
 });
99 99
 
100 100
 $server->addPlugin($linkCheckPlugin);
Please login to merge, or discard this patch.
apps/dav/appinfo/app.php 1 patch
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -30,27 +30,27 @@
 block discarded – undo
30 30
 $app->registerHooks();
31 31
 
32 32
 \OC::$server->registerService('CardDAVSyncService', function() use ($app) {
33
-	return $app->getSyncService();
33
+    return $app->getSyncService();
34 34
 });
35 35
 
36 36
 $eventDispatcher = \OC::$server->getEventDispatcher();
37 37
 
38 38
 $eventDispatcher->addListener('OCP\Federation\TrustedServerEvent::remove',
39
-	function(GenericEvent $event) use ($app) {
40
-		/** @var CardDavBackend $cardDavBackend */
41
-		$cardDavBackend = $app->getContainer()->query(CardDavBackend::class);
42
-		$addressBookUri = $event->getSubject();
43
-		$addressBook = $cardDavBackend->getAddressBooksByUri('principals/system/system', $addressBookUri);
44
-		if (!is_null($addressBook)) {
45
-			$cardDavBackend->deleteAddressBook($addressBook['id']);
46
-		}
47
-	}
39
+    function(GenericEvent $event) use ($app) {
40
+        /** @var CardDavBackend $cardDavBackend */
41
+        $cardDavBackend = $app->getContainer()->query(CardDavBackend::class);
42
+        $addressBookUri = $event->getSubject();
43
+        $addressBook = $cardDavBackend->getAddressBooksByUri('principals/system/system', $addressBookUri);
44
+        if (!is_null($addressBook)) {
45
+            $cardDavBackend->deleteAddressBook($addressBook['id']);
46
+        }
47
+    }
48 48
 );
49 49
 
50 50
 $cm = \OC::$server->getContactsManager();
51 51
 $cm->register(function() use ($cm, $app) {
52
-	$user = \OC::$server->getUserSession()->getUser();
53
-	if (!is_null($user)) {
54
-		$app->setupContactsProvider($cm, $user->getUID());
55
-	}
52
+    $user = \OC::$server->getUserSession()->getUser();
53
+    if (!is_null($user)) {
54
+        $app->setupContactsProvider($cm, $user->getUID());
55
+    }
56 56
 });
Please login to merge, or discard this patch.
apps/dav/bin/chunkperf.php 1 patch
Indentation   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -23,8 +23,8 @@  discard block
 block discarded – undo
23 23
 require '../../../../3rdparty/autoload.php';
24 24
 
25 25
 if ($argc !== 6) {
26
-	echo "Invalid number of arguments" . PHP_EOL;
27
-	exit;
26
+    echo "Invalid number of arguments" . PHP_EOL;
27
+    exit;
28 28
 }
29 29
 
30 30
 /**
@@ -33,15 +33,15 @@  discard block
 block discarded – undo
33 33
  * @return mixed
34 34
  */
35 35
 function request($client, $method, $uploadUrl, $data = null, $headers = []) {
36
-	echo "$method $uploadUrl ... ";
37
-	$t0 = microtime(true);
38
-	$result = $client->request($method, $uploadUrl, $data, $headers);
39
-	$t1 = microtime(true);
40
-	echo $result['statusCode'] . " - " . ($t1 - $t0) . ' seconds' . PHP_EOL;
41
-	if (!in_array($result['statusCode'],  [200, 201])) {
42
-		echo $result['body'] . PHP_EOL;
43
-	}
44
-	return $result;
36
+    echo "$method $uploadUrl ... ";
37
+    $t0 = microtime(true);
38
+    $result = $client->request($method, $uploadUrl, $data, $headers);
39
+    $t1 = microtime(true);
40
+    echo $result['statusCode'] . " - " . ($t1 - $t0) . ' seconds' . PHP_EOL;
41
+    if (!in_array($result['statusCode'],  [200, 201])) {
42
+        echo $result['body'] . PHP_EOL;
43
+    }
44
+    return $result;
45 45
 }
46 46
 
47 47
 $baseUri = $argv[1];
@@ -51,9 +51,9 @@  discard block
 block discarded – undo
51 51
 $chunkSize = $argv[5] * 1024 * 1024;
52 52
 
53 53
 $client = new \Sabre\DAV\Client([
54
-	'baseUri' => $baseUri,
55
-	'userName' => $userName,
56
-	'password' => $password
54
+    'baseUri' => $baseUri,
55
+    'userName' => $userName,
56
+    'password' => $password
57 57
 ]);
58 58
 
59 59
 $transfer = uniqid('transfer', true);
@@ -66,12 +66,12 @@  discard block
 block discarded – undo
66 66
 
67 67
 $index = 0;
68 68
 while(!feof($stream)) {
69
-	request($client, 'PUT', "$uploadUrl/$index", fread($stream, $chunkSize));
70
-	$index++;
69
+    request($client, 'PUT', "$uploadUrl/$index", fread($stream, $chunkSize));
70
+    $index++;
71 71
 }
72 72
 
73 73
 $destination = pathinfo($file, PATHINFO_BASENAME);
74 74
 //echo "Moving $uploadUrl/.file to it's final destination $baseUri/files/$userName/$destination" . PHP_EOL;
75 75
 request($client, 'MOVE', "$uploadUrl/.file", null, [
76
-	'Destination' => "$baseUri/files/$userName/$destination"
76
+    'Destination' => "$baseUri/files/$userName/$destination"
77 77
 ]);
Please login to merge, or discard this patch.
apps/admin_audit/lib/auditlogger.php 1 patch
Indentation   +141 added lines, -141 removed lines patch added patch discarded remove patch
@@ -40,149 +40,149 @@
 block discarded – undo
40 40
 
41 41
 class AuditLogger {
42 42
 
43
-	/** @var ILogger */
44
-	private $logger;
43
+    /** @var ILogger */
44
+    private $logger;
45 45
 
46
-	/** @var IUserSession */
47
-	private $userSession;
46
+    /** @var IUserSession */
47
+    private $userSession;
48 48
 	
49
-	/** @var IGroupManager */
50
-	private $groupManager;
51
-
52
-	/**
53
-	 * AuditLogger constructor.
54
-	 *
55
-	 * @param ILogger $logger
56
-	 * @param IUserSession $userSession
57
-	 * @param IGroupManager $groupManager
58
-	 */
59
-	public function __construct(ILogger $logger,
60
-								IUserSession $userSession, 
61
-								IGroupManager $groupManager) {
62
-		$this->logger = $logger;
63
-		$this->userSession = $userSession;
64
-		$this->groupManager = $groupManager;
65
-	}
66
-
67
-	/**
68
-	 * register hooks in order to log them
69
-	 */
70
-	public function registerHooks() {
71
-		$this->userManagementHooks();
72
-		$this->groupHooks();
73
-		$this->sharingHooks();
74
-		$this->authHooks();
75
-		$this->fileHooks();
76
-		$this->trashbinHooks();
77
-		$this->versionsHooks();
78
-	}
79
-
80
-	/**
81
-	 * connect to user management hooks
82
-	 */
83
-	private function userManagementHooks() {
84
-		$userActions = new UserManagement($this->logger);
85
-
86
-		Util::connectHook('OC_User', 'post_createUser',	$userActions, 'create');
87
-		Util::connectHook('OC_User', 'post_deleteUser',	$userActions, 'delete');
88
-		$this->userSession->listen('\OC\User', 'postSetPassword', [$userActions, 'setPassword']);
89
-	}
49
+    /** @var IGroupManager */
50
+    private $groupManager;
51
+
52
+    /**
53
+     * AuditLogger constructor.
54
+     *
55
+     * @param ILogger $logger
56
+     * @param IUserSession $userSession
57
+     * @param IGroupManager $groupManager
58
+     */
59
+    public function __construct(ILogger $logger,
60
+                                IUserSession $userSession, 
61
+                                IGroupManager $groupManager) {
62
+        $this->logger = $logger;
63
+        $this->userSession = $userSession;
64
+        $this->groupManager = $groupManager;
65
+    }
66
+
67
+    /**
68
+     * register hooks in order to log them
69
+     */
70
+    public function registerHooks() {
71
+        $this->userManagementHooks();
72
+        $this->groupHooks();
73
+        $this->sharingHooks();
74
+        $this->authHooks();
75
+        $this->fileHooks();
76
+        $this->trashbinHooks();
77
+        $this->versionsHooks();
78
+    }
79
+
80
+    /**
81
+     * connect to user management hooks
82
+     */
83
+    private function userManagementHooks() {
84
+        $userActions = new UserManagement($this->logger);
85
+
86
+        Util::connectHook('OC_User', 'post_createUser',	$userActions, 'create');
87
+        Util::connectHook('OC_User', 'post_deleteUser',	$userActions, 'delete');
88
+        $this->userSession->listen('\OC\User', 'postSetPassword', [$userActions, 'setPassword']);
89
+    }
90 90
 	
91
-	private function groupHooks()  {
92
-		$groupActions = new GroupManagement($this->logger);
93
-		$this->groupManager->listen('\OC\Group', 'postRemoveUser',  [$groupActions, 'removeUser']);
94
-		$this->groupManager->listen('\OC\Group', 'postAddUser',  [$groupActions, 'addUser']);
95
-	}
96
-
97
-	/**
98
-	 * connect to sharing events
99
-	 */
100
-	private function sharingHooks() {
101
-		$shareActions = new Sharing($this->logger);
102
-
103
-		Util::connectHook('OCP\Share', 'post_shared', $shareActions, 'shared');
104
-		Util::connectHook('OCP\Share', 'post_unshare', $shareActions, 'unshare');
105
-		Util::connectHook('OCP\Share', 'post_update_permissions', $shareActions, 'updatePermissions');
106
-		Util::connectHook('OCP\Share', 'post_update_password', $shareActions, 'updatePassword');
107
-		Util::connectHook('OCP\Share', 'post_set_expiration_date', $shareActions, 'updateExpirationDate');
108
-		Util::connectHook('OCP\Share', 'share_link_access', $shareActions, 'shareAccessed');
109
-	}
110
-
111
-	/**
112
-	 * connect to authentication event and related actions
113
-	 */
114
-	private function authHooks() {
115
-		$authActions = new Auth($this->logger);
116
-
117
-		Util::connectHook('OC_User', 'pre_login', $authActions, 'loginAttempt');
118
-		Util::connectHook('OC_User', 'post_login', $authActions, 'loginSuccessful');
119
-		Util::connectHook('OC_User', 'logout', $authActions, 'logout');
120
-	}
121
-
122
-
123
-	/**
124
-	 * connect to file hooks
125
-	 */
126
-	private function fileHooks() {
127
-		$fileActions = new Files($this->logger);
128
-
129
-		Util::connectHook(
130
-			Filesystem::CLASSNAME,
131
-			Filesystem::signal_post_rename,
132
-			$fileActions,
133
-			'rename'
134
-		);
135
-		Util::connectHook(
136
-			Filesystem::CLASSNAME,
137
-			Filesystem::signal_post_create,
138
-			$fileActions,
139
-			'create'
140
-		);
141
-		Util::connectHook(
142
-			Filesystem::CLASSNAME,
143
-			Filesystem::signal_post_copy,
144
-			$fileActions,
145
-			'copy'
146
-		);
147
-		Util::connectHook(
148
-			Filesystem::CLASSNAME,
149
-			Filesystem::signal_post_write,
150
-			$fileActions,
151
-			'write'
152
-		);
153
-		Util::connectHook(
154
-			Filesystem::CLASSNAME,
155
-			Filesystem::signal_post_update,
156
-			$fileActions,
157
-			'update'
158
-		);
159
-		Util::connectHook(
160
-			Filesystem::CLASSNAME,
161
-			Filesystem::signal_read,
162
-			$fileActions,
163
-			'read'
164
-		);
165
-		Util::connectHook(
166
-			Filesystem::CLASSNAME,
167
-			Filesystem::signal_delete,
168
-			$fileActions,
169
-			'delete'
170
-		);
171
-	}
172
-
173
-	public function versionsHooks() {
174
-		$versionsActions = new Versions($this->logger);
175
-		Util::connectHook('\OCP\Versions', 'rollback', $versionsActions, 'rollback');
176
-		Util::connectHook('\OCP\Versions', 'delete',$versionsActions, 'delete');
177
-	}
178
-
179
-	/**
180
-	 * connect to trash bin hooks
181
-	 */
182
-	private function trashbinHooks() {
183
-		$trashActions = new Trashbin($this->logger);
184
-		Util::connectHook('\OCP\Trashbin', 'preDelete', $trashActions, 'delete');
185
-		Util::connectHook('\OCA\Files_Trashbin\Trashbin', 'post_restore', $trashActions, 'restore');
186
-	}
91
+    private function groupHooks()  {
92
+        $groupActions = new GroupManagement($this->logger);
93
+        $this->groupManager->listen('\OC\Group', 'postRemoveUser',  [$groupActions, 'removeUser']);
94
+        $this->groupManager->listen('\OC\Group', 'postAddUser',  [$groupActions, 'addUser']);
95
+    }
96
+
97
+    /**
98
+     * connect to sharing events
99
+     */
100
+    private function sharingHooks() {
101
+        $shareActions = new Sharing($this->logger);
102
+
103
+        Util::connectHook('OCP\Share', 'post_shared', $shareActions, 'shared');
104
+        Util::connectHook('OCP\Share', 'post_unshare', $shareActions, 'unshare');
105
+        Util::connectHook('OCP\Share', 'post_update_permissions', $shareActions, 'updatePermissions');
106
+        Util::connectHook('OCP\Share', 'post_update_password', $shareActions, 'updatePassword');
107
+        Util::connectHook('OCP\Share', 'post_set_expiration_date', $shareActions, 'updateExpirationDate');
108
+        Util::connectHook('OCP\Share', 'share_link_access', $shareActions, 'shareAccessed');
109
+    }
110
+
111
+    /**
112
+     * connect to authentication event and related actions
113
+     */
114
+    private function authHooks() {
115
+        $authActions = new Auth($this->logger);
116
+
117
+        Util::connectHook('OC_User', 'pre_login', $authActions, 'loginAttempt');
118
+        Util::connectHook('OC_User', 'post_login', $authActions, 'loginSuccessful');
119
+        Util::connectHook('OC_User', 'logout', $authActions, 'logout');
120
+    }
121
+
122
+
123
+    /**
124
+     * connect to file hooks
125
+     */
126
+    private function fileHooks() {
127
+        $fileActions = new Files($this->logger);
128
+
129
+        Util::connectHook(
130
+            Filesystem::CLASSNAME,
131
+            Filesystem::signal_post_rename,
132
+            $fileActions,
133
+            'rename'
134
+        );
135
+        Util::connectHook(
136
+            Filesystem::CLASSNAME,
137
+            Filesystem::signal_post_create,
138
+            $fileActions,
139
+            'create'
140
+        );
141
+        Util::connectHook(
142
+            Filesystem::CLASSNAME,
143
+            Filesystem::signal_post_copy,
144
+            $fileActions,
145
+            'copy'
146
+        );
147
+        Util::connectHook(
148
+            Filesystem::CLASSNAME,
149
+            Filesystem::signal_post_write,
150
+            $fileActions,
151
+            'write'
152
+        );
153
+        Util::connectHook(
154
+            Filesystem::CLASSNAME,
155
+            Filesystem::signal_post_update,
156
+            $fileActions,
157
+            'update'
158
+        );
159
+        Util::connectHook(
160
+            Filesystem::CLASSNAME,
161
+            Filesystem::signal_read,
162
+            $fileActions,
163
+            'read'
164
+        );
165
+        Util::connectHook(
166
+            Filesystem::CLASSNAME,
167
+            Filesystem::signal_delete,
168
+            $fileActions,
169
+            'delete'
170
+        );
171
+    }
172
+
173
+    public function versionsHooks() {
174
+        $versionsActions = new Versions($this->logger);
175
+        Util::connectHook('\OCP\Versions', 'rollback', $versionsActions, 'rollback');
176
+        Util::connectHook('\OCP\Versions', 'delete',$versionsActions, 'delete');
177
+    }
178
+
179
+    /**
180
+     * connect to trash bin hooks
181
+     */
182
+    private function trashbinHooks() {
183
+        $trashActions = new Trashbin($this->logger);
184
+        Util::connectHook('\OCP\Trashbin', 'preDelete', $trashActions, 'delete');
185
+        Util::connectHook('\OCA\Files_Trashbin\Trashbin', 'post_restore', $trashActions, 'restore');
186
+    }
187 187
 
188 188
 }
Please login to merge, or discard this patch.