OCA\DAV\CardDAV\UserAddressBooks

Complexity

Total Complexity

10

Size/Duplication

Total Lines	78
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	createExtendedCollection()	0	6	2
A	getChildren()	0	20	5
A	getACL()	0	12	2
A	__construct()	0	5	1

<?php

declare(strict_types=1);

/**
 * @copyright Copyright (c) 2016, ownCloud, Inc.
 *
 * @author Joas Schilling <coding@schilljs.com>
 * @author Roeland Jago Douma <roeland@famdouma.nl>
 * @author Thomas Müller <thomas.mueller@tmit.eu>
 *
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program. If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace OCA\DAV\CardDAV;

use OCA\DAV\AppInfo\PluginManager;
use OCA\DAV\CardDAV\Integration\ExternalAddressBook;
use OCP\IConfig;
use OCP\IL10N;
use Sabre\CardDAV\Backend;
use Sabre\DAV\Exception\MethodNotAllowed;
use Sabre\DAV\MkCol;

class UserAddressBooks extends \Sabre\CardDAV\AddressBookHome {

	/** @var IL10N */
	protected $l10n;

	/** @var IConfig */
	protected $config;

	/** @var PluginManager */
	private $pluginManager;

	public function __construct(Backend\BackendInterface $carddavBackend,
								string $principalUri,
								PluginManager $pluginManager) {
		parent::__construct($carddavBackend, $principalUri);
		$this->pluginManager = $pluginManager;
	}

	/**
	 * Returns a list of address books
	 *
	 * @return array
	 */
	function getChildren() {

It is generally recommended to explicitly declare the visibility for methods.

		if ($this->l10n === null) {
			$this->l10n = \OC::$server->getL10N('dav');
		}
		if ($this->config === null) {
			$this->config = \OC::$server->getConfig();
		}

		$addressBooks = $this->carddavBackend->getAddressBooksForUser($this->principalUri);

$this->principalUri of type array is incompatible with the type string expected by parameter $principalUri of Sabre\CardDAV\Backend\BackendInterface::getAddressBooksForUser().

		$objects = array_map(function(array $addressBook) {
			if ($addressBook['principaluri'] === 'principals/system/system') {
				return new SystemAddressbook($this->carddavBackend, $addressBook, $this->l10n, $this->config);
			}

			return new AddressBook($this->carddavBackend, $addressBook, $this->l10n);
		}, $addressBooks);
		foreach ($this->pluginManager->getAddressBookPlugins() as $plugin) {
			$plugin->fetchAllForAddressBookHome($this->principalUri);
		}
		return $objects;

	}

	public function createExtendedCollection($name, MkCol $mkCol) {
		if (ExternalAddressBook::doesViolateReservedName($name)) {
			throw new MethodNotAllowed('The resource you tried to create has a reserved name');
		}

		parent::createExtendedCollection($name, $mkCol);
	}

	/**
	 * Returns a list of ACE's for this node.
	 *
	 * Each ACE has the following properties:
	 *   * 'privilege', a string such as {DAV:}read or {DAV:}write. These are
	 *     currently the only supported privileges
	 *   * 'principal', a url to the principal who owns the node
	 *   * 'protected' (optional), indicating that this ACE is not allowed to
	 *      be updated.
	 *
	 * @return array
	 */
	function getACL() {

It is generally recommended to explicitly declare the visibility for methods.

		$acl = parent::getACL();
		if ($this->principalUri === 'principals/system/system') {

The condition $this->principalUri === 'principals/system/system' is always false.

			$acl[] = [
				'privilege' => '{DAV:}read',
				'principal' => '{DAV:}authenticated',
				'protected' => true,
			];
		}

		return $acl;
	}

}