Inspection of "cache webcal calendars on server" - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10059)

by Georg

created 2018-06-30 10:59 UTC

Status

Indentation +41 added lines, -41 removed lines patch added patch discarded remove patch

@@ -32,52 +32,52 @@
 block discarded – undo
 
 class RefreshWebcalJobRegistrar implements IRepairStep {
 
-	/** @var IDBConnection */
-	private $connection;
+    /** @var IDBConnection */
+    private $connection;
 
-	/** @var IJobList */
-	private $jobList;
+    /** @var IJobList */
+    private $jobList;
 
-	/**
-	 * FixBirthdayCalendarComponent constructor.
-	 *
-	 * @param IDBConnection $connection
-	 * @param IJobList $jobList
-	 */
-	public function __construct(IDBConnection $connection, IJobList $jobList) {
-		$this->connection = $connection;
-		$this->jobList = $jobList;
-	}
+    /**
+     * FixBirthdayCalendarComponent constructor.
+     *
+     * @param IDBConnection $connection
+     * @param IJobList $jobList
+     */
+    public function __construct(IDBConnection $connection, IJobList $jobList) {
+        $this->connection = $connection;
+        $this->jobList = $jobList;
+    }
 
-	/**
-	 * @inheritdoc
-	 */
-	public function getName() {
-		return 'Registering background jobs to update cache for webcal calendars';
-	}
+    /**
+     * @inheritdoc
+     */
+    public function getName() {
+        return 'Registering background jobs to update cache for webcal calendars';
+    }
 
-	/**
-	 * @inheritdoc
-	 */
-	public function run(IOutput $output) {
-		$query = $this->connection->getQueryBuilder();
-		$query->select(['principaluri', 'uri'])
-			->from('calendarsubscriptions');
-		$stmt = $query->execute();
+    /**
+     * @inheritdoc
+     */
+    public function run(IOutput $output) {
+        $query = $this->connection->getQueryBuilder();
+        $query->select(['principaluri', 'uri'])
+            ->from('calendarsubscriptions');
+        $stmt = $query->execute();
 
-		$count = 0;
-		while($row = $stmt->fetch(\PDO::FETCH_ASSOC)) {
-			$args = [
-				'principaluri' => $row['principaluri'],
-				'uri' => $row['uri'],
-			];
+        $count = 0;
+        while($row = $stmt->fetch(\PDO::FETCH_ASSOC)) {
+            $args = [
+                'principaluri' => $row['principaluri'],
+                'uri' => $row['uri'],
+            ];
 
-			if (!$this->jobList->has(RefreshWebcalJob::class, $args)) {
-				$this->jobList->add(RefreshWebcalJob::class, $args);
-				$count++;
-			}
-		}
+            if (!$this->jobList->has(RefreshWebcalJob::class, $args)) {
+                $this->jobList->add(RefreshWebcalJob::class, $args);
+                $count++;
+            }
+        }
 
-		$output->info("Added $count background jobs to update webcal calendars");
-	}
+        $output->info("Added $count background jobs to update webcal calendars");
+    }
 }

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -66,7 +66,7 @@
 block discarded – undo
 		$stmt = $query->execute();
 
 		$count = 0;
-		while($row = $stmt->fetch(\PDO::FETCH_ASSOC)) {
+		while ($row = $stmt->fetch(\PDO::FETCH_ASSOC)) {
 			$args = [
 				'principaluri' => $row['principaluri'],
 				'uri' => $row['uri'],

Please login to merge, or discard this patch.

apps/dav/lib/Migration/Version1006Date20180628111625.php 1 patch

Indentation +70 added lines, -70 removed lines patch added patch discarded remove patch

@@ -31,78 +31,78 @@
 block discarded – undo
 
 class Version1006Date20180628111625 extends SimpleMigrationStep {
 
-	/**
-	 * @param IOutput $output
-	 * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 */
-	public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
+    /**
+     * @param IOutput $output
+     * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     */
+    public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
 
-		if (!$schema->hasTable('calendarsubscrobjects')) {
-			$table = $schema->createTable('calendarsubscrobjects');
-			$table->addColumn('id', Type::BIGINT, [
-				'autoincrement' => true,
-				'notnull' => true,
-				'length' => 11,
-				'unsigned' => true,
-			]);
-			$table->addColumn('calendardata', Type::BLOB, [
-				'notnull' => false,
-			]);
-			$table->addColumn('uri', Type::STRING, [
-				'notnull' => false,
-				'length' => 255,
-			]);
-			$table->addColumn('subscriptionid', Type::BIGINT, [
-				'notnull' => true,
-				'length' => 11,
-				'unsigned' => true,
-			]);
-			$table->addColumn('lastmodified', Type::INTEGER, [
-				'notnull' => false,
-				'length' => 10,
-				'unsigned' => true,
-			]);
-			$table->addColumn('etag', Type::STRING, [
-				'notnull' => false,
-				'length' => 32,
-			]);
-			$table->addColumn('size', Type::BIGINT, [
-				'notnull' => true,
-				'length' => 11,
-				'unsigned' => true,
-			]);
-			$table->addColumn('componenttype', Type::STRING, [
-				'notnull' => false,
-				'length' => 8,
-			]);
-			$table->addColumn('firstoccurence', Type::BIGINT, [
-				'notnull' => false,
-				'length' => 11,
-				'unsigned' => true,
-			]);
-			$table->addColumn('lastoccurence', Type::BIGINT, [
-				'notnull' => false,
-				'length' => 11,
-				'unsigned' => true,
-			]);
-			$table->addColumn('uid', Type::STRING, [
-				'notnull' => false,
-				'length' => 255,
-			]);
-			$table->addColumn('classification', Type::INTEGER, [
-				'notnull' => false,
-				'default' => 0,
-			]);
-			$table->setPrimaryKey(['id']);
-			$table->addUniqueIndex(['subscriptionid', 'uri'], 'subobjects_index');
-		}
+        if (!$schema->hasTable('calendarsubscrobjects')) {
+            $table = $schema->createTable('calendarsubscrobjects');
+            $table->addColumn('id', Type::BIGINT, [
+                'autoincrement' => true,
+                'notnull' => true,
+                'length' => 11,
+                'unsigned' => true,
+            ]);
+            $table->addColumn('calendardata', Type::BLOB, [
+                'notnull' => false,
+            ]);
+            $table->addColumn('uri', Type::STRING, [
+                'notnull' => false,
+                'length' => 255,
+            ]);
+            $table->addColumn('subscriptionid', Type::BIGINT, [
+                'notnull' => true,
+                'length' => 11,
+                'unsigned' => true,
+            ]);
+            $table->addColumn('lastmodified', Type::INTEGER, [
+                'notnull' => false,
+                'length' => 10,
+                'unsigned' => true,
+            ]);
+            $table->addColumn('etag', Type::STRING, [
+                'notnull' => false,
+                'length' => 32,
+            ]);
+            $table->addColumn('size', Type::BIGINT, [
+                'notnull' => true,
+                'length' => 11,
+                'unsigned' => true,
+            ]);
+            $table->addColumn('componenttype', Type::STRING, [
+                'notnull' => false,
+                'length' => 8,
+            ]);
+            $table->addColumn('firstoccurence', Type::BIGINT, [
+                'notnull' => false,
+                'length' => 11,
+                'unsigned' => true,
+            ]);
+            $table->addColumn('lastoccurence', Type::BIGINT, [
+                'notnull' => false,
+                'length' => 11,
+                'unsigned' => true,
+            ]);
+            $table->addColumn('uid', Type::STRING, [
+                'notnull' => false,
+                'length' => 255,
+            ]);
+            $table->addColumn('classification', Type::INTEGER, [
+                'notnull' => false,
+                'default' => 0,
+            ]);
+            $table->setPrimaryKey(['id']);
+            $table->addUniqueIndex(['subscriptionid', 'uri'], 'subobjects_index');
+        }
 
-		return $schema;
-	}
+        return $schema;
+    }
 }
 
 

Please login to merge, or discard this patch.

		@@ -32,52 +32,52 @@
		block discarded – undo
32	32
33	33	class RefreshWebcalJobRegistrar implements IRepairStep {
34	34
35		- /** @var IDBConnection */
36		- private $connection;
	35	+ /** @var IDBConnection */
	36	+ private $connection;
37	37
38		- /** @var IJobList */
39		- private $jobList;
	38	+ /** @var IJobList */
	39	+ private $jobList;
40	40
41		- /**
42		- * FixBirthdayCalendarComponent constructor.
43		- *
44		- * @param IDBConnection $connection
45		- * @param IJobList $jobList
46		- */
47		- public function __construct(IDBConnection $connection, IJobList $jobList) {
48		- $this->connection = $connection;
49		- $this->jobList = $jobList;
50		- }
	41	+ /**
	42	+ * FixBirthdayCalendarComponent constructor.
	43	+ *
	44	+ * @param IDBConnection $connection
	45	+ * @param IJobList $jobList
	46	+ */
	47	+ public function __construct(IDBConnection $connection, IJobList $jobList) {
	48	+ $this->connection = $connection;
	49	+ $this->jobList = $jobList;
	50	+ }
51	51
52		- /**
53		- * @inheritdoc
54		- */
55		- public function getName() {
56		- return 'Registering background jobs to update cache for webcal calendars';
57		- }
	52	+ /**
	53	+ * @inheritdoc
	54	+ */
	55	+ public function getName() {
	56	+ return 'Registering background jobs to update cache for webcal calendars';
	57	+ }
58	58
59		- /**
60		- * @inheritdoc
61		- */
62		- public function run(IOutput $output) {
63		- $query = $this->connection->getQueryBuilder();
64		- $query->select(['principaluri', 'uri'])
65		- ->from('calendarsubscriptions');
66		- $stmt = $query->execute();
	59	+ /**
	60	+ * @inheritdoc
	61	+ */
	62	+ public function run(IOutput $output) {
	63	+ $query = $this->connection->getQueryBuilder();
	64	+ $query->select(['principaluri', 'uri'])
	65	+ ->from('calendarsubscriptions');
	66	+ $stmt = $query->execute();
67	67
68		- $count = 0;
69		- while($row = $stmt->fetch(\PDO::FETCH_ASSOC)) {
70		- $args = [
71		- 'principaluri' => $row['principaluri'],
72		- 'uri' => $row['uri'],
73		- ];
	68	+ $count = 0;
	69	+ while($row = $stmt->fetch(\PDO::FETCH_ASSOC)) {
	70	+ $args = [
	71	+ 'principaluri' => $row['principaluri'],
	72	+ 'uri' => $row['uri'],
	73	+ ];
74	74
75		- if (!$this->jobList->has(RefreshWebcalJob::class, $args)) {
76		- $this->jobList->add(RefreshWebcalJob::class, $args);
77		- $count++;
78		- }
79		- }
	75	+ if (!$this->jobList->has(RefreshWebcalJob::class, $args)) {
	76	+ $this->jobList->add(RefreshWebcalJob::class, $args);
	77	+ $count++;
	78	+ }
	79	+ }
80	80
81		- $output->info("Added $count background jobs to update webcal calendars");
82		- }
	81	+ $output->info("Added $count background jobs to update webcal calendars");
	82	+ }
83	83	}

		@@ -66,7 +66,7 @@
		block discarded – undo
66	66	$stmt = $query->execute();
67	67
68	68	$count = 0;
69		- while($row = $stmt->fetch(\PDO::FETCH_ASSOC)) {
	69	+ while ($row = $stmt->fetch(\PDO::FETCH_ASSOC)) {
70	70	$args = [
71	71	'principaluri' => $row['principaluri'],
72	72	'uri' => $row['uri'],

		@@ -31,78 +31,78 @@
		block discarded – undo
31	31
32	32	class Version1006Date20180628111625 extends SimpleMigrationStep {
33	33
34		- /**
35		- * @param IOutput $output
36		- * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
37		- * @param array $options
38		- * @return null\|ISchemaWrapper
39		- */
40		- public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
41		- /** @var ISchemaWrapper $schema */
42		- $schema = $schemaClosure();
	34	+ /**
	35	+ * @param IOutput $output
	36	+ * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	37	+ * @param array $options
	38	+ * @return null\|ISchemaWrapper
	39	+ */
	40	+ public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
	41	+ /** @var ISchemaWrapper $schema */
	42	+ $schema = $schemaClosure();
43	43
44		- if (!$schema->hasTable('calendarsubscrobjects')) {
45		- $table = $schema->createTable('calendarsubscrobjects');
46		- $table->addColumn('id', Type::BIGINT, [
47		- 'autoincrement' => true,
48		- 'notnull' => true,
49		- 'length' => 11,
50		- 'unsigned' => true,
51		- ]);
52		- $table->addColumn('calendardata', Type::BLOB, [
53		- 'notnull' => false,
54		- ]);
55		- $table->addColumn('uri', Type::STRING, [
56		- 'notnull' => false,
57		- 'length' => 255,
58		- ]);
59		- $table->addColumn('subscriptionid', Type::BIGINT, [
60		- 'notnull' => true,
61		- 'length' => 11,
62		- 'unsigned' => true,
63		- ]);
64		- $table->addColumn('lastmodified', Type::INTEGER, [
65		- 'notnull' => false,
66		- 'length' => 10,
67		- 'unsigned' => true,
68		- ]);
69		- $table->addColumn('etag', Type::STRING, [
70		- 'notnull' => false,
71		- 'length' => 32,
72		- ]);
73		- $table->addColumn('size', Type::BIGINT, [
74		- 'notnull' => true,
75		- 'length' => 11,
76		- 'unsigned' => true,
77		- ]);
78		- $table->addColumn('componenttype', Type::STRING, [
79		- 'notnull' => false,
80		- 'length' => 8,
81		- ]);
82		- $table->addColumn('firstoccurence', Type::BIGINT, [
83		- 'notnull' => false,
84		- 'length' => 11,
85		- 'unsigned' => true,
86		- ]);
87		- $table->addColumn('lastoccurence', Type::BIGINT, [
88		- 'notnull' => false,
89		- 'length' => 11,
90		- 'unsigned' => true,
91		- ]);
92		- $table->addColumn('uid', Type::STRING, [
93		- 'notnull' => false,
94		- 'length' => 255,
95		- ]);
96		- $table->addColumn('classification', Type::INTEGER, [
97		- 'notnull' => false,
98		- 'default' => 0,
99		- ]);
100		- $table->setPrimaryKey(['id']);
101		- $table->addUniqueIndex(['subscriptionid', 'uri'], 'subobjects_index');
102		- }
	44	+ if (!$schema->hasTable('calendarsubscrobjects')) {
	45	+ $table = $schema->createTable('calendarsubscrobjects');
	46	+ $table->addColumn('id', Type::BIGINT, [
	47	+ 'autoincrement' => true,
	48	+ 'notnull' => true,
	49	+ 'length' => 11,
	50	+ 'unsigned' => true,
	51	+ ]);
	52	+ $table->addColumn('calendardata', Type::BLOB, [
	53	+ 'notnull' => false,
	54	+ ]);
	55	+ $table->addColumn('uri', Type::STRING, [
	56	+ 'notnull' => false,
	57	+ 'length' => 255,
	58	+ ]);
	59	+ $table->addColumn('subscriptionid', Type::BIGINT, [
	60	+ 'notnull' => true,
	61	+ 'length' => 11,
	62	+ 'unsigned' => true,
	63	+ ]);
	64	+ $table->addColumn('lastmodified', Type::INTEGER, [
	65	+ 'notnull' => false,
	66	+ 'length' => 10,
	67	+ 'unsigned' => true,
	68	+ ]);
	69	+ $table->addColumn('etag', Type::STRING, [
	70	+ 'notnull' => false,
	71	+ 'length' => 32,
	72	+ ]);
	73	+ $table->addColumn('size', Type::BIGINT, [
	74	+ 'notnull' => true,
	75	+ 'length' => 11,
	76	+ 'unsigned' => true,
	77	+ ]);
	78	+ $table->addColumn('componenttype', Type::STRING, [
	79	+ 'notnull' => false,
	80	+ 'length' => 8,
	81	+ ]);
	82	+ $table->addColumn('firstoccurence', Type::BIGINT, [
	83	+ 'notnull' => false,
	84	+ 'length' => 11,
	85	+ 'unsigned' => true,
	86	+ ]);
	87	+ $table->addColumn('lastoccurence', Type::BIGINT, [
	88	+ 'notnull' => false,
	89	+ 'length' => 11,
	90	+ 'unsigned' => true,
	91	+ ]);
	92	+ $table->addColumn('uid', Type::STRING, [
	93	+ 'notnull' => false,
	94	+ 'length' => 255,
	95	+ ]);
	96	+ $table->addColumn('classification', Type::INTEGER, [
	97	+ 'notnull' => false,
	98	+ 'default' => 0,
	99	+ ]);
	100	+ $table->setPrimaryKey(['id']);
	101	+ $table->addUniqueIndex(['subscriptionid', 'uri'], 'subobjects_index');
	102	+ }
103	103
104		- return $schema;
105		- }
	104	+ return $schema;
	105	+ }
106	106	}
107	107
108	108

nextcloud / server

Pull Request — master (#10059)

Status

Category

Indentation +41 added lines, -41 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +70 added lines, -70 removed lines patch added patch discarded remove patch