Completed
Pull Request — master (#3585)
by Jan-Christoph
16:45
created
apps/provisioning_api/lib/Controller/UsersController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -225,7 +225,7 @@
 block discarded – undo
225 225
 	/**
226 226
 	 * creates a array with all user data
227 227
 	 *
228
-	 * @param $userId
228
+	 * @param string $userId
229 229
 	 * @return array
230 230
 	 * @throws OCSException
231 231
 	 */
Please login to merge, or discard this patch.
apps/sharebymail/lib/ShareByMailProvider.php 1 patch
Doc Comments   +11 added lines, -4 removed lines patch added patch discarded remove patch
@@ -185,10 +185,10 @@  discard block
 block discarded – undo
185 185
 	 * publish activity if a file/folder was shared by mail
186 186
 	 *
187 187
 	 * @param $subject
188
-	 * @param $parameters
189
-	 * @param $affectedUser
188
+	 * @param string[] $parameters
189
+	 * @param string $affectedUser
190 190
 	 * @param $fileId
191
-	 * @param $filePath
191
+	 * @param string $filePath
192 192
 	 */
193 193
 	protected function publishActivity($subject, $parameters, $affectedUser, $fileId, $filePath) {
194 194
 		$event = $this->activityManager->generateEvent();
@@ -240,6 +240,12 @@  discard block
 block discarded – undo
240 240
 
241 241
 	}
242 242
 
243
+	/**
244
+	 * @param string $link
245
+	 * @param string $owner
246
+	 * @param string $initiator
247
+	 * @param string $shareWith
248
+	 */
243 249
 	protected function sendMailNotification($filename, $link, $owner, $initiator, $shareWith) {
244 250
 		$ownerUser = $this->userManager->get($owner);
245 251
 		$initiatorUser = $this->userManager->get($initiator);
@@ -269,6 +275,7 @@  discard block
 block discarded – undo
269 275
 	 * @param $link
270 276
 	 * @param $owner
271 277
 	 * @param $initiator
278
+	 * @param string $template
272 279
 	 * @return string plain text mail
273 280
 	 * @throws HintException
274 281
 	 */
@@ -708,7 +715,7 @@  discard block
 block discarded – undo
708 715
 	/**
709 716
 	 * get database row of a give share
710 717
 	 *
711
-	 * @param $id
718
+	 * @param integer $id
712 719
 	 * @return array
713 720
 	 * @throws ShareNotFound
714 721
 	 */
Please login to merge, or discard this patch.
apps/user_ldap/lib/Helper.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -124,6 +124,9 @@
 block discarded – undo
124 124
 		return $nextPrefix;
125 125
 	}
126 126
 
127
+	/**
128
+	 * @param string $value
129
+	 */
127 130
 	private function getServersConfig($value) {
128 131
 		$regex = '/' . $value . '$/S';
129 132
 
Please login to merge, or discard this patch.
core/Middleware/TwoFactorMiddleware.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -104,6 +104,10 @@
 block discarded – undo
104 104
 		// TODO: dont check/enforce 2FA if a auth token is used
105 105
 	}
106 106
 
107
+	/**
108
+	 * @param Controller $controller
109
+	 * @param string $methodName
110
+	 */
107 111
 	private function checkTwoFactor($controller, $methodName, IUser $user) {
108 112
 		// If two-factor auth is in progress disallow access to any controllers
109 113
 		// defined within "LoginController".
Please login to merge, or discard this patch.
lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@
 block discarded – undo
102 102
 	 * @param bool $isLoggedIn
103 103
 	 * @param bool $isAdminUser
104 104
 	 * @param ContentSecurityPolicyManager $contentSecurityPolicyManager
105
-	 * @param CSRFTokenManager $csrfTokenManager
105
+	 * @param CsrfTokenManager $csrfTokenManager
106 106
 	 * @param ContentSecurityPolicyNonceManager $cspNonceManager
107 107
 	 * @param Throttler $throttler
108 108
 	 */
Please login to merge, or discard this patch.
lib/private/Archive/ZIP.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -370,6 +370,7 @@
 block discarded – undo
370 370
 
371 371
 	/**
372 372
 	 * write back temporary files
373
+	 * @param string $path
373 374
 	 */
374 375
 	function writeBack($tmpFile, $path) {
375 376
 		$this->addFile($path, $tmpFile);
Please login to merge, or discard this patch.
lib/private/Files/Cache/Wrapper/CacheJail.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -194,6 +194,9 @@
 block discarded – undo
194 194
 		return $this->getCache()->getStatus($this->getSourcePath($file));
195 195
 	}
196 196
 
197
+	/**
198
+	 * @param ICacheEntry[] $results
199
+	 */
197 200
 	private function formatSearchResults($results) {
198 201
 		$results = array_filter($results, array($this, 'filterCacheEntry'));
199 202
 		$results = array_values($results);
Please login to merge, or discard this patch.
lib/private/Group/Manager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -156,7 +156,7 @@
 block discarded – undo
156 156
 	/**
157 157
 	 * @param string $gid
158 158
 	 * @param string $displayName
159
-	 * @return \OCP\IGroup
159
+	 * @return null|Group
160 160
 	 */
161 161
 	protected function getGroupObject($gid, $displayName = null) {
162 162
 		$backends = array();
Please login to merge, or discard this patch.
lib/private/legacy/template/functions.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
  * make preview_icon available as a simple function
184 184
  * Returns the path to the preview of the image.
185 185
  * @param string $path path of file
186
- * @return link to the preview
186
+ * @return string to the preview
187 187
  */
188 188
 function preview_icon( $path ) {
189 189
 	return \OC::$server->getURLGenerator()->linkToRoute('core.Preview.getPreview', ['x' => 32, 'y' => 32, 'file' => $path]);
@@ -191,6 +191,7 @@  discard block
 block discarded – undo
191 191
 
192 192
 /**
193 193
  * @param string $path
194
+ * @param string $token
194 195
  */
195 196
 function publicPreview_icon ( $path, $token ) {
196 197
 	return \OC::$server->getURLGenerator()->linkToRoute('files_sharing.PublicPreview.getPreview', ['x' => 32, 'y' => 32, 'file' => $path, 't' => $token]);
Please login to merge, or discard this patch.