| Conditions | 11 |
| Paths | 1 |
| Total Lines | 219 |
| Code Lines | 124 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 131 | private function registerHooks(HookManager $hm, |
||
| 132 | EventDispatcherInterface $dispatcher, |
||
| 133 | IAppContainer $container, |
||
| 134 | IServerContainer $serverContainer) { |
||
| 135 | $hm->setup(); |
||
| 136 | |||
| 137 | // first time login event setup |
||
| 138 | $dispatcher->addListener(IUser::class . '::firstLogin', function ($event) use ($hm) { |
||
| 139 | if ($event instanceof GenericEvent) { |
||
| 140 | $hm->firstLogin($event->getSubject()); |
||
| 141 | } |
||
| 142 | }); |
||
| 143 | |||
| 144 | $birthdayListener = function ($event) use ($container) { |
||
| 145 | if ($event instanceof GenericEvent) { |
||
| 146 | /** @var BirthdayService $b */ |
||
| 147 | $b = $container->query(BirthdayService::class); |
||
| 148 | $b->onCardChanged( |
||
| 149 | (int) $event->getArgument('addressBookId'), |
||
| 150 | (string) $event->getArgument('cardUri'), |
||
| 151 | (string) $event->getArgument('cardData') |
||
| 152 | ); |
||
| 153 | } |
||
| 154 | }; |
||
| 155 | |||
| 156 | $dispatcher->addListener('\OCA\DAV\CardDAV\CardDavBackend::createCard', $birthdayListener); |
||
| 157 | $dispatcher->addListener('\OCA\DAV\CardDAV\CardDavBackend::updateCard', $birthdayListener); |
||
| 158 | $dispatcher->addListener('\OCA\DAV\CardDAV\CardDavBackend::deleteCard', function ($event) use ($container) { |
||
| 159 | if ($event instanceof GenericEvent) { |
||
| 160 | /** @var BirthdayService $b */ |
||
| 161 | $b = $container->query(BirthdayService::class); |
||
| 162 | $b->onCardDeleted( |
||
| 163 | (int) $event->getArgument('addressBookId'), |
||
| 164 | (string) $event->getArgument('cardUri') |
||
| 165 | ); |
||
| 166 | } |
||
| 167 | }); |
||
| 168 | |||
| 169 | $clearPhotoCache = function ($event) use ($container) { |
||
| 170 | if ($event instanceof GenericEvent) { |
||
| 171 | /** @var PhotoCache $p */ |
||
| 172 | $p = $container->query(PhotoCache::class); |
||
| 173 | $p->delete( |
||
| 174 | $event->getArgument('addressBookId'), |
||
| 175 | $event->getArgument('cardUri') |
||
| 176 | ); |
||
| 177 | } |
||
| 178 | }; |
||
| 179 | $dispatcher->addListener('\OCA\DAV\CardDAV\CardDavBackend::updateCard', $clearPhotoCache); |
||
| 180 | $dispatcher->addListener('\OCA\DAV\CardDAV\CardDavBackend::deleteCard', $clearPhotoCache); |
||
| 181 | |||
| 182 | $dispatcher->addListener('OC\AccountManager::userUpdated', function (GenericEvent $event) use ($container) { |
||
| 183 | $user = $event->getSubject(); |
||
| 184 | /** @var SyncService $syncService */ |
||
| 185 | $syncService = $container->query(SyncService::class); |
||
| 186 | $syncService->updateUser($user); |
||
| 187 | }); |
||
| 188 | |||
| 189 | $dispatcher->addListener('\OCA\DAV\CalDAV\CalDavBackend::createCalendar', function (GenericEvent $event) use ($container) { |
||
| 190 | /** @var Backend $backend */ |
||
| 191 | $backend = $container->query(Backend::class); |
||
| 192 | $backend->onCalendarAdd( |
||
| 193 | $event->getArgument('calendarData') |
||
| 194 | ); |
||
| 195 | }); |
||
| 196 | $dispatcher->addListener('\OCA\DAV\CalDAV\CalDavBackend::updateCalendar', function (GenericEvent $event) use ($container) { |
||
| 197 | /** @var Backend $backend */ |
||
| 198 | $backend = $container->query(Backend::class); |
||
| 199 | $backend->onCalendarUpdate( |
||
| 200 | $event->getArgument('calendarData'), |
||
| 201 | $event->getArgument('shares'), |
||
| 202 | $event->getArgument('propertyMutations') |
||
| 203 | ); |
||
| 204 | }); |
||
| 205 | $dispatcher->addListener('\OCA\DAV\CalDAV\CalDavBackend::deleteCalendar', function (GenericEvent $event) use ($container) { |
||
| 206 | /** @var Backend $backend */ |
||
| 207 | $backend = $container->query(Backend::class); |
||
| 208 | $backend->onCalendarDelete( |
||
| 209 | $event->getArgument('calendarData'), |
||
| 210 | $event->getArgument('shares') |
||
| 211 | ); |
||
| 212 | |||
| 213 | /** @var ReminderBackend $reminderBackend */ |
||
| 214 | $reminderBackend = $container->query(ReminderBackend::class); |
||
| 215 | $reminderBackend->cleanRemindersForCalendar( |
||
| 216 | (int) $event->getArgument('calendarId') |
||
| 217 | ); |
||
| 218 | }); |
||
| 219 | $dispatcher->addListener('\OCA\DAV\CalDAV\CalDavBackend::updateShares', function (GenericEvent $event) use ($container) { |
||
| 220 | /** @var Backend $backend */ |
||
| 221 | $backend = $container->query(Backend::class); |
||
| 222 | $backend->onCalendarUpdateShares( |
||
| 223 | $event->getArgument('calendarData'), |
||
| 224 | $event->getArgument('shares'), |
||
| 225 | $event->getArgument('add'), |
||
| 226 | $event->getArgument('remove') |
||
| 227 | ); |
||
| 228 | |||
| 229 | // Here we should recalculate if reminders should be sent to new or old sharees |
||
| 230 | }); |
||
| 231 | |||
| 232 | $dispatcher->addListener('\OCA\DAV\CalDAV\CalDavBackend::publishCalendar', function (GenericEvent $event) use ($container) { |
||
| 233 | /** @var Backend $backend */ |
||
| 234 | $backend = $container->query(Backend::class); |
||
| 235 | $backend->onCalendarPublication( |
||
| 236 | $event->getArgument('calendarData'), |
||
| 237 | $event->getArgument('public') |
||
| 238 | ); |
||
| 239 | }); |
||
| 240 | |||
| 241 | $listener = function (GenericEvent $event, $eventName) use ($container) { |
||
| 242 | /** @var Backend $backend */ |
||
| 243 | $backend = $container->query(Backend::class); |
||
| 244 | |||
| 245 | $subject = Event::SUBJECT_OBJECT_ADD; |
||
| 246 | if ($eventName === '\OCA\DAV\CalDAV\CalDavBackend::updateCalendarObject') { |
||
| 247 | $subject = Event::SUBJECT_OBJECT_UPDATE; |
||
| 248 | } elseif ($eventName === '\OCA\DAV\CalDAV\CalDavBackend::deleteCalendarObject') { |
||
| 249 | $subject = Event::SUBJECT_OBJECT_DELETE; |
||
| 250 | } |
||
| 251 | $backend->onTouchCalendarObject( |
||
| 252 | $subject, |
||
| 253 | $event->getArgument('calendarData'), |
||
| 254 | $event->getArgument('shares'), |
||
| 255 | $event->getArgument('objectData') |
||
| 256 | ); |
||
| 257 | |||
| 258 | /** @var ReminderService $reminderBackend */ |
||
| 259 | $reminderService = $container->query(ReminderService::class); |
||
| 260 | |||
| 261 | $reminderService->onTouchCalendarObject( |
||
| 262 | $eventName, |
||
| 263 | $event->getArgument('objectData') |
||
| 264 | ); |
||
| 265 | }; |
||
| 266 | $dispatcher->addListener('\OCA\DAV\CalDAV\CalDavBackend::createCalendarObject', $listener); |
||
| 267 | $dispatcher->addListener('\OCA\DAV\CalDAV\CalDavBackend::updateCalendarObject', $listener); |
||
| 268 | $dispatcher->addListener('\OCA\DAV\CalDAV\CalDavBackend::deleteCalendarObject', $listener); |
||
| 269 | |||
| 270 | /** |
||
| 271 | * In case the user has set their default calendar to this one |
||
| 272 | */ |
||
| 273 | $dispatcher->addListener('\OCA\DAV\CalDAV\CalDavBackend::deleteCalendar', function (GenericEvent $event) use ($serverContainer) { |
||
| 274 | /** @var IConfig $config */ |
||
| 275 | $config = $serverContainer->getConfig(); |
||
| 276 | $principalUri = $event->getArgument('calendarData')['principaluri']; |
||
| 277 | if (strpos($principalUri, 'principals/users') === 0) { |
||
| 278 | list(, $UID) = \Sabre\Uri\split($principalUri); |
||
| 279 | $uri = $event->getArgument('calendarData')['uri']; |
||
| 280 | if ($config->getUserValue($UID, 'dav', 'defaultCalendar') === $uri) { |
||
| 281 | $config->deleteUserValue($UID, 'dav', 'defaultCalendar'); |
||
| 282 | } |
||
| 283 | } |
||
| 284 | }); |
||
| 285 | |||
| 286 | $dispatcher->addListener('OCP\Federation\TrustedServerEvent::remove', |
||
| 287 | function (GenericEvent $event) { |
||
| 288 | /** @var CardDavBackend $cardDavBackend */ |
||
| 289 | $cardDavBackend = \OC::$server->query(CardDavBackend::class); |
||
| 290 | $addressBookUri = $event->getSubject(); |
||
| 291 | $addressBook = $cardDavBackend->getAddressBooksByUri('principals/system/system', $addressBookUri); |
||
| 292 | if (!is_null($addressBook)) { |
||
| 293 | $cardDavBackend->deleteAddressBook($addressBook['id']); |
||
| 294 | } |
||
| 295 | } |
||
| 296 | ); |
||
| 297 | |||
| 298 | $dispatcher->addListener('\OCA\DAV\CalDAV\CalDavBackend::createSubscription', |
||
| 299 | function (GenericEvent $event) use ($container, $serverContainer) { |
||
| 300 | $jobList = $serverContainer->getJobList(); |
||
| 301 | $subscriptionData = $event->getArgument('subscriptionData'); |
||
| 302 | |||
| 303 | /** |
||
| 304 | * Initial subscription refetch |
||
| 305 | * |
||
| 306 | * @var RefreshWebcalService $refreshWebcalService |
||
| 307 | */ |
||
| 308 | $refreshWebcalService = $container->query(RefreshWebcalService::class); |
||
| 309 | $refreshWebcalService->refreshSubscription( |
||
| 310 | (string) $subscriptionData['principaluri'], |
||
| 311 | (string) $subscriptionData['uri'] |
||
| 312 | ); |
||
| 313 | |||
| 314 | $jobList->add(\OCA\DAV\BackgroundJob\RefreshWebcalJob::class, [ |
||
| 315 | 'principaluri' => $subscriptionData['principaluri'], |
||
| 316 | 'uri' => $subscriptionData['uri'] |
||
| 317 | ]); |
||
| 318 | } |
||
| 319 | ); |
||
| 320 | |||
| 321 | $dispatcher->addListener('\OCA\DAV\CalDAV\CalDavBackend::deleteSubscription', |
||
| 322 | function (GenericEvent $event) use ($container, $serverContainer) { |
||
| 323 | $jobList = $serverContainer->getJobList(); |
||
| 324 | $subscriptionData = $event->getArgument('subscriptionData'); |
||
| 325 | |||
| 326 | $jobList->remove(\OCA\DAV\BackgroundJob\RefreshWebcalJob::class, [ |
||
| 327 | 'principaluri' => $subscriptionData['principaluri'], |
||
| 328 | 'uri' => $subscriptionData['uri'] |
||
| 329 | ]); |
||
| 330 | |||
| 331 | /** @var CalDavBackend $calDavBackend */ |
||
| 332 | $calDavBackend = $container->query(CalDavBackend::class); |
||
| 333 | $calDavBackend->purgeAllCachedEventsForSubscription($subscriptionData['id']); |
||
| 334 | } |
||
| 335 | ); |
||
| 336 | |||
| 337 | $eventHandler = function () use ($container, $serverContainer) { |
||
| 338 | try { |
||
| 339 | /** @var UpdateCalendarResourcesRoomsBackgroundJob $job */ |
||
| 340 | $job = $container->query(UpdateCalendarResourcesRoomsBackgroundJob::class); |
||
| 341 | $job->run([]); |
||
| 342 | $serverContainer->getJobList()->setLastRun($job); |
||
| 343 | } catch (Exception $ex) { |
||
| 344 | $serverContainer->getLogger()->logException($ex); |
||
| 345 | } |
||
| 346 | }; |
||
| 347 | |||
| 348 | $dispatcher->addListener('\OCP\Calendar\Resource\ForceRefreshEvent', $eventHandler); |
||
| 349 | $dispatcher->addListener('\OCP\Calendar\Room\ForceRefreshEvent', $eventHandler); |
||
| 350 | } |
||
| 412 |