nextcloud / server

lib/private/Files/Storage/DAV.php

Unused Use Statements -1 removed lines

@@ -38,7 +38,6 @@
 use GuzzleHttp\Message\ResponseInterface;
 use Icewind\Streams\CallbackWrapper;
 use OC\Files\Filesystem;
-use OC\Files\Stream\Close;
 use Icewind\Streams\IteratorDirectory;
 use OC\MemCache\ArrayCache;
 use OCP\AppFramework\Http;

apps/files_external/lib/Lib/Notify/SMBNotifyHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
 
 	/**
 	 * @param \Icewind\SMB\Change $change
-	 * @return IChange|null
+	 * @return null|Change
 	 */
 	private function mapChange(\Icewind\SMB\Change $change) {
 		$path = $this->relativePath($change->getPath());

apps/files_external/lib/Lib/Storage/SMB.php

Unused Use Statements -3 removed lines

@@ -31,14 +31,11 @@
 
 namespace OCA\Files_External\Lib\Storage;
 
-use Icewind\SMB\Change;
 use Icewind\SMB\Exception\ConnectException;
 use Icewind\SMB\Exception\Exception;
 use Icewind\SMB\Exception\ForbiddenException;
 use Icewind\SMB\Exception\NotFoundException;
-use Icewind\SMB\INotifyHandler;
 use Icewind\SMB\IFileInfo;
-use Icewind\SMB\IShare;
 use Icewind\SMB\NativeServer;
 use Icewind\SMB\Server;
 use Icewind\Streams\CallbackWrapper;

Doc Comments +3 added lines

@@ -498,6 +498,9 @@
 		});
 	}
 
+	/**
+	 * @param string $path
+	 */
 	public function notify($path) {
 		$path = '/' . ltrim($path, '/');
 		$shareNotifyHandler = $this->share->notify($this->buildPath($path));

lib/private/Files/Node/File.php

Doc Comments +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
 	 * Creates a Folder that represents a non-existing path
 	 *
 	 * @param string $path path
-	 * @return string non-existing node class
+	 * @return NonExistingFile non-existing node class
 	 */
 	protected function createNonExistingNode($path) {
 		return new NonExistingFile($this->root, $this->view, $path);

lib/private/Files/Node/Folder.php

Doc Comments +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
 	 * Creates a Folder that represents a non-existing path
 	 *
 	 * @param string $path path
-	 * @return string non-existing node class
+	 * @return NonExistingFolder non-existing node class
 	 */
 	protected function createNonExistingNode($path) {
 		return new NonExistingFolder($this->root, $this->view, $path);

lib/private/AppFramework/DependencyInjection/DIContainer.php

Unused Use Statements -1 removed lines

@@ -46,7 +46,6 @@
 use OC\AppFramework\Utility\TimeFactory;
 use OC\Core\Middleware\TwoFactorMiddleware;
 use OC\RichObjectStrings\Validator;
-use OC\Security\Bruteforce\Throttler;
 use OCP\AppFramework\IApi;
 use OCP\AppFramework\IAppContainer;
 use OCP\Files\IAppData;

lib/public/Settings/IIconSection.php

Doc Comments +1 added lines

@@ -33,6 +33,7 @@
 	 *
 	 * @returns string
 	 * @since 12
+	 * @return string
 	 */
 	public function getIcon();
 }

lib/private/Updater.php

Doc Comments +2 added lines, -2 removed lines

@@ -157,7 +157,7 @@ 
 	/**
 	 * Return version from which this version is allowed to upgrade from
 	 *
-	 * @return array allowed previous versions per vendor
+	 * @return string allowed previous versions per vendor
 	 */
 	private function getAllowedPreviousVersions() {
 		// this should really be a JSON file
@@ -182,7 +182,7 @@ 
 	 * Whether an upgrade to a specified version is possible
 	 * @param string $oldVersion
 	 * @param string $newVersion
-	 * @param array $allowedPreviousVersions
+	 * @param string $allowedPreviousVersions
 	 * @return bool
 	 */
 	public function isUpgradePossible($oldVersion, $newVersion, array $allowedPreviousVersions) {

settings/Controller/UsersController.php

Unused Use Statements -1 removed lines

@@ -33,7 +33,6 @@
 use OC\Accounts\AccountManager;
 use OC\AppFramework\Http;
 use OC\ForbiddenException;
-use OC\User\User;
 use OCP\App\IAppManager;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http\DataResponse;