Completed
Push — master ( 424d62...2a7733 )
by Morris
11:53
created

CompFilter   A

Complexity

Total Complexity 2

Size/Duplication

Total Lines 20
Duplicated Lines 100 %

Coupling/Cohesion

Components 0
Dependencies 0

Importance

Changes 0
Metric Value
dl 20
loc 20
rs 10
c 0
b 0
f 0
wmc 2
lcom 0
cbo 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A xmlDeserialize() 12 12 2

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/**
3
 * @author Georg Ehrke <[email protected]>
4
 *
5
 * @copyright Copyright (c) 2017 Georg Ehrke <[email protected]>
6
 * @license GNU AGPL version 3 or any later version
7
 *
8
 * This code is free software: you can redistribute it and/or modify
9
 * it under the terms of the GNU Affero General Public License, version 3,
10
 * as published by the Free Software Foundation.
11
 *
12
 * This program is distributed in the hope that it will be useful,
13
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15
 * GNU Affero General Public License for more details.
16
 *
17
 * You should have received a copy of the GNU Affero General Public License, version 3,
18
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
19
 *
20
 */
21
namespace OCA\DAV\CalDAV\Search\Xml\Filter;
22
23
use Sabre\DAV\Exception\BadRequest;
24
use Sabre\Xml\Reader;
25
use Sabre\Xml\XmlDeserializable;
26
use OCA\DAV\CalDAV\Search\SearchPlugin;
27
28 View Code Duplication
class CompFilter implements XmlDeserializable {
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
29
30
	/**
31
	 * @param Reader $reader
32
	 * @throws BadRequest
33
	 * @return string
34
	 */
35
	static function xmlDeserialize(Reader $reader) {
0 ignored issues
show
Best Practice introduced by
It is generally recommended to explicitly declare the visibility for methods.

Adding explicit visibility (private, protected, or public) is generally recommend to communicate to other developers how, and from where this method is intended to be used.

Loading history...
36
		$att = $reader->parseAttributes();
37
		$componentName = $att['name'];
38
39
		$reader->parseInnerTree();
40
41
		if (!is_string($componentName)) {
42
			throw new BadRequest('The {' . SearchPlugin::NS_Nextcloud . '}comp-filter requires a valid name attribute');
43
		}
44
45
		return $componentName;
46
	}
47
}
48