nextcloud / server

tests/lib/DB/QueryBuilder/FunctionBuilderTest.php

Spacing +15 added lines, -15 removed lines

@@ -53,35 +53,35 @@
 	public static function providerTestConcatString(): array {
 		return [
 			'1 column: string param unicode'
-				=> [function ($q) {
+				=> [function($q) {
 					return [false, [$q->createNamedParameter('

tests/lib/ImageTest.php

Spacing +54 added lines, -54 removed lines

@@ -15,27 +15,27 @@ 
 
 class ImageTest extends \Test\TestCase {
 	public static function tearDownAfterClass(): void {
-		@unlink(OC::$SERVERROOT . '/tests/data/testimage2.png');
-		@unlink(OC::$SERVERROOT . '/tests/data/testimage2.jpg');
+		@unlink(OC::$SERVERROOT.'/tests/data/testimage2.png');
+		@unlink(OC::$SERVERROOT.'/tests/data/testimage2.jpg');
 
 		parent::tearDownAfterClass();
 	}
 
 	public function testConstructDestruct(): void {
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage.png');
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage.png');
 		$this->assertInstanceOf('\OC\Image', $img);
 		$this->assertInstanceOf('\OCP\IImage', $img);
 		unset($img);
 
-		$imgcreate = imagecreatefromjpeg(OC::$SERVERROOT . '/tests/data/testimage.jpg');
+		$imgcreate = imagecreatefromjpeg(OC::$SERVERROOT.'/tests/data/testimage.jpg');
 		$img = new Image();
 		$img->setResource($imgcreate);
 		$this->assertInstanceOf('\OC\Image', $img);
 		$this->assertInstanceOf('\OCP\IImage', $img);
 		unset($img);
 
-		$base64 = base64_encode(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.gif'));
+		$base64 = base64_encode(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.gif'));
 		$img = new Image();
 		$img->loadFromBase64($base64);
 		$this->assertInstanceOf('\OC\Image', $img);
@@ -50,7 +50,7 @@ 
 
 	public function testValid(): void {
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage.png');
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage.png');
 		$this->assertTrue($img->valid());
 
 		$text = base64_encode('Lorem ipsum dolor sir amet …');
@@ -64,32 +64,32 @@ 
 
 	public function testMimeType(): void {
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage.png');
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage.png');
 		$this->assertEquals('image/png', $img->mimeType());
 
 		$img = new Image();
 		$this->assertEquals('', $img->mimeType());
 
 		$img = new Image();
-		$img->loadFromData(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.jpg'));
+		$img->loadFromData(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.jpg'));
 		$this->assertEquals('image/jpeg', $img->mimeType());
 
 		$img = new Image();
-		$img->loadFromBase64(base64_encode(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.gif')));
+		$img->loadFromBase64(base64_encode(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.gif')));
 		$this->assertEquals('image/gif', $img->mimeType());
 	}
 
 	public function testWidth(): void {
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage.png');
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage.png');
 		$this->assertEquals(128, $img->width());
 
 		$img = new Image();
-		$img->loadFromData(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.jpg'));
+		$img->loadFromData(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.jpg'));
 		$this->assertEquals(1680, $img->width());
 
 		$img = new Image();
-		$img->loadFromBase64(base64_encode(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.gif')));
+		$img->loadFromBase64(base64_encode(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.gif')));
 		$this->assertEquals(64, $img->width());
 
 		$img = new Image();
@@ -98,15 +98,15 @@ 
 
 	public function testHeight(): void {
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage.png');
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage.png');
 		$this->assertEquals(128, $img->height());
 
 		$img = new Image();
-		$img->loadFromData(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.jpg'));
+		$img->loadFromData(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.jpg'));
 		$this->assertEquals(1050, $img->height());
 
 		$img = new Image();
-		$img->loadFromBase64(base64_encode(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.gif')));
+		$img->loadFromBase64(base64_encode(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.gif')));
 		$this->assertEquals(64, $img->height());
 
 		$img = new Image();
@@ -115,22 +115,22 @@ 
 
 	public function testSave(): void {
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage.png');
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage.png');
 		$img->resize(16);
-		$img->save(OC::$SERVERROOT . '/tests/data/testimage2.png');
-		$this->assertEquals(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage2.png'), $img->data());
+		$img->save(OC::$SERVERROOT.'/tests/data/testimage2.png');
+		$this->assertEquals(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage2.png'), $img->data());
 
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage.jpg');
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage.jpg');
 		$img->resize(128);
-		$img->save(OC::$SERVERROOT . '/tests/data/testimage2.jpg');
-		$this->assertEquals(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage2.jpg'), $img->data());
+		$img->save(OC::$SERVERROOT.'/tests/data/testimage2.jpg');
+		$this->assertEquals(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage2.jpg'), $img->data());
 	}
 
 	public function testData(): void {
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage.png');
-		$raw = imagecreatefromstring(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.png'));
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage.png');
+		$raw = imagecreatefromstring(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.png'));
 		// Preserve transparency
 		imagealphablending($raw, true);
 		imagesavealpha($raw, true);
@@ -150,8 +150,8 @@ 
 			->with('preview_max_memory', 256)
 			->willReturn(256);
 		$img = new Image(null, $appConfig, $config);
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage.jpg');
-		$raw = imagecreatefromstring(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.jpg'));
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage.jpg');
+		$raw = imagecreatefromstring(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.jpg'));
 		imageinterlace($raw, true);
 		ob_start();
 		imagejpeg($raw, null, 80);
@@ -159,8 +159,8 @@ 
 		$this->assertEquals($expected, $img->data());
 
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage.gif');
-		$raw = imagecreatefromstring(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.gif'));
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage.gif');
+		$raw = imagecreatefromstring(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.gif'));
 		ob_start();
 		imagegif($raw);
 		$expected = ob_get_clean();
@@ -175,36 +175,36 @@ 
 	#[\PHPUnit\Framework\Attributes\Depends('testData')]
 	public function testToString(): void {
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage.png');
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage.png');
 		$expected = base64_encode($img->data());
-		$this->assertEquals($expected, (string)$img);
+		$this->assertEquals($expected, (string) $img);
 
 		$img = new Image();
-		$img->loadFromData(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.jpg'));
+		$img->loadFromData(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.jpg'));
 		$expected = base64_encode($img->data());
-		$this->assertEquals($expected, (string)$img);
+		$this->assertEquals($expected, (string) $img);
 
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage.gif');
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage.gif');
 		$expected = base64_encode($img->data());
-		$this->assertEquals($expected, (string)$img);
+		$this->assertEquals($expected, (string) $img);
 	}
 
 	public function testResize(): void {
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage.png');
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage.png');
 		$this->assertTrue($img->resize(32));
 		$this->assertEquals(32, $img->width());
 		$this->assertEquals(32, $img->height());
 
 		$img = new Image();
-		$img->loadFromData(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.jpg'));
+		$img->loadFromData(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.jpg'));
 		$this->assertTrue($img->resize(840));
 		$this->assertEquals(840, $img->width());
 		$this->assertEquals(525, $img->height());
 
 		$img = new Image();
-		$img->loadFromBase64(base64_encode(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.gif')));
+		$img->loadFromBase64(base64_encode(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.gif')));
 		$this->assertTrue($img->resize(100));
 		$this->assertEquals(100, $img->width());
 		$this->assertEquals(100, $img->height());
@@ -212,19 +212,19 @@ 
 
 	public function testPreciseResize(): void {
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage.png');
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage.png');
 		$this->assertTrue($img->preciseResize(128, 512));
 		$this->assertEquals(128, $img->width());
 		$this->assertEquals(512, $img->height());
 
 		$img = new Image();
-		$img->loadFromData(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.jpg'));
+		$img->loadFromData(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.jpg'));
 		$this->assertTrue($img->preciseResize(64, 840));
 		$this->assertEquals(64, $img->width());
 		$this->assertEquals(840, $img->height());
 
 		$img = new Image();
-		$img->loadFromBase64(base64_encode(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.gif')));
+		$img->loadFromBase64(base64_encode(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.gif')));
 		$this->assertTrue($img->preciseResize(1000, 1337));
 		$this->assertEquals(1000, $img->width());
 		$this->assertEquals(1337, $img->height());
@@ -232,19 +232,19 @@ 
 
 	public function testCenterCrop(): void {
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage.png');
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage.png');
 		$img->centerCrop();
 		$this->assertEquals(128, $img->width());
 		$this->assertEquals(128, $img->height());
 
 		$img = new Image();
-		$img->loadFromData(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.jpg'));
+		$img->loadFromData(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.jpg'));
 		$img->centerCrop();
 		$this->assertEquals(1050, $img->width());
 		$this->assertEquals(1050, $img->height());
 
 		$img = new Image();
-		$img->loadFromBase64(base64_encode(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.gif')));
+		$img->loadFromBase64(base64_encode(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.gif')));
 		$img->centerCrop(512);
 		$this->assertEquals(512, $img->width());
 		$this->assertEquals(512, $img->height());
@@ -252,19 +252,19 @@ 
 
 	public function testCrop(): void {
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage.png');
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage.png');
 		$this->assertTrue($img->crop(0, 0, 50, 20));
 		$this->assertEquals(50, $img->width());
 		$this->assertEquals(20, $img->height());
 
 		$img = new Image();
-		$img->loadFromData(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.jpg'));
+		$img->loadFromData(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.jpg'));
 		$this->assertTrue($img->crop(500, 700, 550, 300));
 		$this->assertEquals(550, $img->width());
 		$this->assertEquals(300, $img->height());
 
 		$img = new Image();
-		$img->loadFromBase64(base64_encode(file_get_contents(OC::$SERVERROOT . '/tests/data/testimage.gif')));
+		$img->loadFromBase64(base64_encode(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.gif')));
 		$this->assertTrue($img->crop(10, 10, 15, 15));
 		$this->assertEquals(15, $img->width());
 		$this->assertEquals(15, $img->height());
@@ -287,7 +287,7 @@ 
 	#[\PHPUnit\Framework\Attributes\DataProvider('sampleProvider')]
 	public function testFitIn($filename, $asked, $expected): void {
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/' . $filename);
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/'.$filename);
 		$this->assertTrue($img->fitIn($asked[0], $asked[1]));
 		$this->assertEquals($expected[0], $img->width());
 		$this->assertEquals($expected[1], $img->height());
@@ -310,7 +310,7 @@ 
 	#[\PHPUnit\Framework\Attributes\DataProvider('sampleFilenamesProvider')]
 	public function testScaleDownToFitWhenSmallerAlready($filename): void {
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/' . $filename);
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/'.$filename);
 		$currentWidth = $img->width();
 		$currentHeight = $img->height();
 		// We pick something larger than the image we want to scale down
@@ -343,7 +343,7 @@ 
 	#[\PHPUnit\Framework\Attributes\DataProvider('largeSampleProvider')]
 	public function testScaleDownWhenBigger($filename, $asked, $expected): void {
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/' . $filename);
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/'.$filename);
 		//$this->assertTrue($img->scaleDownToFit($asked[0], $asked[1]));
 		$img->scaleDownToFit($asked[0], $asked[1]);
 		$this->assertEquals($expected[0], $img->width());
@@ -352,16 +352,16 @@ 
 
 	public static function convertDataProvider(): array {
 		return [
-			[ 'image/gif'],
-			[ 'image/jpeg'],
-			[ 'image/png'],
+			['image/gif'],
+			['image/jpeg'],
+			['image/png'],
 		];
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('convertDataProvider')]
 	public function testConvert($mimeType): void {
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage.png');
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage.png');
 		$tempFile = tempnam(sys_get_temp_dir(), 'img-test');
 
 		$img->save($tempFile, $mimeType);
@@ -370,12 +370,12 @@ 
 
 	public function testMemoryLimitFromFile(): void {
 		$img = new Image();
-		$img->loadFromFile(OC::$SERVERROOT . '/tests/data/testimage-badheader.jpg');
+		$img->loadFromFile(OC::$SERVERROOT.'/tests/data/testimage-badheader.jpg');
 		$this->assertFalse($img->valid());
 	}
 
 	public function testMemoryLimitFromData(): void {
-		$data = file_get_contents(OC::$SERVERROOT . '/tests/data/testimage-badheader.jpg');
+		$data = file_get_contents(OC::$SERVERROOT.'/tests/data/testimage-badheader.jpg');
 		$img = new Image();
 		$img->loadFromData($data);
 		$this->assertFalse($img->valid());

tests/lib/FilesMetadata/FilesMetadataManagerTest.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
 
 		$this->jobList = $this->createMock(JobList::class);
 		$this->eventDispatcher = $this->createMock(IEventDispatcher::class);
-		$this->eventDispatcher->method('dispatchTyped')->willReturnCallback(function (Event $event): void {
+		$this->eventDispatcher->method('dispatchTyped')->willReturnCallback(function(Event $event): void {
 			if ($event instanceof AMetadataEvent) {
 				$name = $event->getNode()->getName();
 				if (isset($this->metadata[$name])) {

tests/lib/AppFramework/Middleware/Security/RateLimitingMiddlewareTest.php

Spacing +12 added lines, -12 removed lines

@@ -27,13 +27,13 @@ 
 
 #[\PHPUnit\Framework\Attributes\Group('DB')]
 class RateLimitingMiddlewareTest extends TestCase {
-	private IRequest|MockObject $request;
-	private IUserSession|MockObject $userSession;
+	private IRequest | MockObject $request;
+	private IUserSession | MockObject $userSession;
 	private ControllerMethodReflector $reflector;
-	private Limiter|MockObject $limiter;
-	private ISession|MockObject $session;
-	private IAppConfig|MockObject $appConfig;
-	private BruteforceAllowList|MockObject $bruteForceAllowList;
+	private Limiter | MockObject $limiter;
+	private ISession | MockObject $session;
+	private IAppConfig | MockObject $appConfig;
+	private BruteforceAllowList | MockObject $bruteForceAllowList;
 	private RateLimitingMiddleware $rateLimitingMiddleware;
 
 	protected function setUp(): void {
@@ -112,7 +112,7 @@ 
 		$this->limiter
 			->expects($this->once())
 			->method('registerAnonRequest')
-			->with(get_class($controller) . '::testMethodWithAnnotation', '10', '100', '127.0.0.1');
+			->with(get_class($controller).'::testMethodWithAnnotation', '10', '100', '127.0.0.1');
 
 		$this->reflector->reflect($controller, 'testMethodWithAnnotation');
 		$this->rateLimitingMiddleware->beforeController($controller, 'testMethodWithAnnotation');
@@ -138,7 +138,7 @@ 
 		$this->limiter
 			->expects($this->once())
 			->method('registerUserRequest')
-			->with(get_class($controller) . '::testMethodWithAnnotation', '20', '200', $user);
+			->with(get_class($controller).'::testMethodWithAnnotation', '20', '200', $user);
 
 
 		$this->reflector->reflect($controller, 'testMethodWithAnnotation');
@@ -164,7 +164,7 @@ 
 		$this->limiter
 			->expects($this->once())
 			->method('registerAnonRequest')
-			->with(get_class($controller) . '::testMethodWithAnnotationFallback', '10', '100', '127.0.0.1');
+			->with(get_class($controller).'::testMethodWithAnnotationFallback', '10', '100', '127.0.0.1');
 
 		$this->reflector->reflect($controller, 'testMethodWithAnnotationFallback');
 		$this->rateLimitingMiddleware->beforeController($controller, 'testMethodWithAnnotationFallback');
@@ -188,7 +188,7 @@ 
 		$this->limiter
 			->expects($this->once())
 			->method('registerAnonRequest')
-			->with(get_class($controller) . '::testMethodWithAttributes', '10', '100', '127.0.0.1');
+			->with(get_class($controller).'::testMethodWithAttributes', '10', '100', '127.0.0.1');
 
 		$this->reflector->reflect($controller, 'testMethodWithAttributes');
 		$this->rateLimitingMiddleware->beforeController($controller, 'testMethodWithAttributes');
@@ -214,7 +214,7 @@ 
 		$this->limiter
 			->expects($this->once())
 			->method('registerUserRequest')
-			->with(get_class($controller) . '::testMethodWithAttributes', '20', '200', $user);
+			->with(get_class($controller).'::testMethodWithAttributes', '20', '200', $user);
 
 
 		$this->reflector->reflect($controller, 'testMethodWithAttributes');
@@ -240,7 +240,7 @@ 
 		$this->limiter
 			->expects($this->once())
 			->method('registerAnonRequest')
-			->with(get_class($controller) . '::testMethodWithAttributesFallback', '10', '100', '127.0.0.1');
+			->with(get_class($controller).'::testMethodWithAttributesFallback', '10', '100', '127.0.0.1');
 
 		$this->reflector->reflect($controller, 'testMethodWithAttributesFallback');
 		$this->rateLimitingMiddleware->beforeController($controller, 'testMethodWithAttributesFallback');

apps/user_ldap/tests/User_LDAPTest.php

Spacing +62 added lines, -62 removed lines

@@ -83,7 +83,7 @@ 
 	private function prepareMockForUserExists(): void {
 		$this->access->expects($this->any())
 			->method('username2dn')
-			->willReturnCallback(function ($uid) {
+			->willReturnCallback(function($uid) {
 				switch ($uid) {
 					case 'gunslinger':
 						return 'dnOfRoland,dc=test';
@@ -112,7 +112,7 @@ 
 	private function prepareAccessForCheckPassword(bool $noDisplayName = false): void {
 		$this->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				if ($name === 'ldapLoginFilter') {
 					return '%uid';
 				}
@@ -121,7 +121,7 @@ 
 
 		$this->access->expects($this->any())
 			->method('fetchListOfUsers')
-			->willReturnCallback(function ($filter) {
+			->willReturnCallback(function($filter) {
 				if ($filter === 'roland') {
 					return [['dn' => ['dnOfRoland,dc=test']]];
 				}
@@ -129,7 +129,7 @@ 
 			});
 		$this->access->expects($this->any())
 			->method('fetchUsersByLoginName')
-			->willReturnCallback(function ($uid) {
+			->willReturnCallback(function($uid) {
 				if ($uid === 'roland') {
 					return [['dn' => ['dnOfRoland,dc=test']]];
 				}
@@ -154,7 +154,7 @@ 
 			->willReturn(true);
 		$this->access->expects($this->any())
 			->method('areCredentialsValid')
-			->willReturnCallback(function ($dn, $pwd) {
+			->willReturnCallback(function($dn, $pwd) {
 				if ($pwd === 'dt19') {
 					return true;
 				}
@@ -348,22 +348,22 @@ 
 	private function prepareAccessForGetUsers() {
 		$this->access->expects($this->once())
 			->method('escapeFilterPart')
-			->willReturnCallback(function ($search) {
+			->willReturnCallback(function($search) {
 				return $search;
 			});
 		$this->access->expects($this->any())
 			->method('getFilterPartForUserSearch')
-			->willReturnCallback(function ($search) {
+			->willReturnCallback(function($search) {
 				return $search;
 			});
 		$this->access->expects($this->any())
 			->method('combineFilterWithAnd')
-			->willReturnCallback(function ($param) {
+			->willReturnCallback(function($param) {
 				return $param[2];
 			});
 		$this->access->expects($this->any())
 			->method('fetchListOfUsers')
-			->willReturnCallback(function ($search, $a, $l, $o) {
+			->willReturnCallback(function($search, $a, $l, $o) {
 				$users = ['gunslinger', 'newyorker', 'ladyofshadows'];
 				if (empty($search)) {
 					$result = $users;
@@ -433,7 +433,7 @@ 
 
 	private function getUsers($search = '', $limit = null, $offset = null) {
 		$users = Server::get(IUserManager::class)->search($search, $limit, $offset);
-		$uids = array_map(function (IUser $user) {
+		$uids = array_map(function(IUser $user) {
 			return $user->getUID();
 		}, $users);
 		return $uids;
@@ -535,7 +535,7 @@ 
 
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($dn) {
+			->willReturnCallback(function($dn) {
 				if ($dn === 'dnOfRoland,dc=test') {
 					return [];
 				}
@@ -560,7 +560,7 @@ 
 
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($dn) {
+			->willReturnCallback(function($dn) {
 				if ($dn === 'dnOfRoland,dc=test') {
 					return [];
 				}
@@ -595,7 +595,7 @@ 
 
 		$this->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				if ($name === 'homeFolderNamingRule') {
 					return 'attr:testAttribute';
 				}
@@ -604,7 +604,7 @@ 
 
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
+			->willReturnCallback(function($dn, $attr) {
 				switch ($dn) {
 					case 'dnOfRoland,dc=test':
 						if ($attr === 'testAttribute') {
@@ -648,11 +648,11 @@ 
 		$this->prepareMockForUserExists();
 
 		$dataDir = Server::get(IConfig::class)->getSystemValue(
-			'datadirectory', \OC::$SERVERROOT . '/data');
+			'datadirectory', \OC::$SERVERROOT.'/data');
 
 		$this->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				if ($name === 'homeFolderNamingRule') {
 					return 'attr:testAttribute';
 				}
@@ -661,7 +661,7 @@ 
 
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
+			->willReturnCallback(function($dn, $attr) {
 				switch ($dn) {
 					case 'dnOfLadyOfShadows,dc=test':
 						if ($attr === 'testAttribute') {
@@ -683,7 +683,7 @@ 
 			->willReturn('dnOfLadyOfShadows,dc=test');
 		$user->expects($this->any())
 			->method('getHomePath')
-			->willReturn($dataDir . '/susannah/');
+			->willReturn($dataDir.'/susannah/');
 
 		$this->userManager->expects($this->atLeastOnce())
 			->method('get')
@@ -695,7 +695,7 @@ 
 
 		/** @noinspection PhpUnhandledExceptionInspection */
 		$result = $backend->getHome('ladyofshadows');
-		$this->assertEquals($dataDir . '/susannah/', $result);
+		$this->assertEquals($dataDir.'/susannah/', $result);
 	}
 
 
@@ -707,7 +707,7 @@ 
 
 		$this->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				if ($name === 'homeFolderNamingRule') {
 					return 'attr:testAttribute';
 				}
@@ -715,7 +715,7 @@ 
 			});
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
+			->willReturnCallback(function($dn, $attr) {
 				switch ($dn) {
 					default:
 						return false;
@@ -752,7 +752,7 @@ 
 
 		$this->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				if ($name === 'homeFolderNamingRule') {
 					return 'attr:testAttribute';
 				}
@@ -799,7 +799,7 @@ 
 
 		$this->connection->expects($this->any())
 			->method('getFromCache')
-			->willReturnCallback(function ($uid) {
+			->willReturnCallback(function($uid) {
 				return true;
 			});
 
@@ -810,7 +810,7 @@ 
 	private function prepareAccessForGetDisplayName() {
 		$this->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) {
+			->willReturnCallback(function($name) {
 				if ($name === 'ldapUserDisplayName') {
 					return 'displayname';
 				} elseif ($name === 'ldapUserDisplayName2') {
@@ -821,7 +821,7 @@ 
 
 		$this->access->expects($this->any())
 			->method('readAttribute')
-			->willReturnCallback(function ($dn, $attr) {
+			->willReturnCallback(function($dn, $attr) {
 				switch ($dn) {
 					case 'dnOfRoland,dc=test':
 						if ($attr === 'displayname') {
@@ -845,7 +845,7 @@ 
 
 		$this->connection->expects($this->any())
 			->method('getConnectionResource')
-			->willReturnCallback(function () {
+			->willReturnCallback(function() {
 				return true;
 			});
 
@@ -867,13 +867,13 @@ 
 		$mapper = $this->createMock(UserMapping::class);
 		$mapper->expects($this->any())
 			->method('getUUIDByDN')
-			->willReturnCallback(function ($dn) {
+			->willReturnCallback(function($dn) {
 				return $dn;
 			});
 
 		$this->userManager->expects($this->any())
 			->method('get')
-			->willReturnCallback(function ($uid) use ($user1, $user2) {
+			->willReturnCallback(function($uid) use ($user1, $user2) {
 				if ($uid === 'gunslinger') {
 					return $user1;
 				} elseif ($uid === 'newyorker') {
@@ -883,7 +883,7 @@ 
 			});
 		$this->userManager->expects($this->any())
 			->method('exists')
-			->willReturnCallback(function ($uid) use ($user1, $user2) {
+			->willReturnCallback(function($uid) use ($user1, $user2) {
 				if ($uid === 'gunslinger') {
 					return true;
 				} elseif ($uid === 'newyorker') {
@@ -896,8 +896,8 @@ 
 			->willReturn($mapper);
 		$this->access->expects($this->any())
 			->method('getUserDnByUuid')
-			->willReturnCallback(function ($uuid) {
-				return $uuid . '1';
+			->willReturnCallback(function($uuid) {
+				return $uuid.'1';
 			});
 
 		//with displayName
@@ -912,7 +912,7 @@ 
 	public function testGetDisplayNamePublicAPI(): void {
 		$this->access->expects($this->any())
 			->method('username2dn')
-			->willReturnCallback(function ($uid) {
+			->willReturnCallback(function($uid) {
 				switch ($uid) {
 					case 'gunslinger':
 						return 'dnOfRoland,dc=test';
@@ -936,7 +936,7 @@ 
 
 		$this->connection->expects($this->any())
 			->method('getConnectionResource')
-			->willReturnCallback(function () {
+			->willReturnCallback(function() {
 				return true;
 			});
 
@@ -960,13 +960,13 @@ 
 		$mapper = $this->createMock(UserMapping::class);
 		$mapper->expects($this->any())
 			->method('getUUIDByDN')
-			->willReturnCallback(function ($dn) {
+			->willReturnCallback(function($dn) {
 				return $dn;
 			});
 
 		$this->userManager->expects($this->any())
 			->method('get')
-			->willReturnCallback(function ($uid) use ($user1, $user2) {
+			->willReturnCallback(function($uid) use ($user1, $user2) {
 				if ($uid === 'gunslinger') {
 					return $user1;
 				} elseif ($uid === 'newyorker') {
@@ -976,7 +976,7 @@ 
 			});
 		$this->userManager->expects($this->any())
 			->method('exists')
-			->willReturnCallback(function ($uid) use ($user1, $user2) {
+			->willReturnCallback(function($uid) use ($user1, $user2) {
 				if ($uid === 'gunslinger') {
 					return true;
 				} elseif ($uid === 'newyorker') {
@@ -989,8 +989,8 @@ 
 			->willReturn($mapper);
 		$this->access->expects($this->any())
 			->method('getUserDnByUuid')
-			->willReturnCallback(function ($uuid) {
-				return $uuid . '1';
+			->willReturnCallback(function($uuid) {
+				return $uuid.'1';
 			});
 
 		//with displayName
@@ -1072,11 +1072,11 @@ 
 
 		$this->connection->expects($this->exactly(2))
 			->method('getFromCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName))
+			->with($this->equalTo('loginName2UserName-'.$loginName))
 			->willReturnOnConsecutiveCalls(null, $username);
 		$this->connection->expects($this->once())
 			->method('writeToCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName), $this->equalTo($username));
+			->with($this->equalTo('loginName2UserName-'.$loginName), $this->equalTo($username));
 
 		$backend = new User_LDAP($this->access, $this->notificationManager, $this->pluginManager, $this->logger, $this->deletedUsersIndex);
 		$user = $this->createMock(User::class);
@@ -1115,11 +1115,11 @@ 
 
 		$this->connection->expects($this->exactly(2))
 			->method('getFromCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName))
+			->with($this->equalTo('loginName2UserName-'.$loginName))
 			->willReturnOnConsecutiveCalls(null, false);
 		$this->connection->expects($this->once())
 			->method('writeToCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName), false);
+			->with($this->equalTo('loginName2UserName-'.$loginName), false);
 
 		$this->userManager->expects($this->any())
 			->method('getAttributes')
@@ -1148,11 +1148,11 @@ 
 
 		$this->connection->expects($this->exactly(2))
 			->method('getFromCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName))
+			->with($this->equalTo('loginName2UserName-'.$loginName))
 			->willReturnOnConsecutiveCalls(null, false);
 		$this->connection->expects($this->once())
 			->method('writeToCache')
-			->with($this->equalTo('loginName2UserName-' . $loginName), $this->equalTo(false));
+			->with($this->equalTo('loginName2UserName-'.$loginName), $this->equalTo(false));
 
 		$this->userManager->expects($this->any())
 			->method('get')
@@ -1176,19 +1176,19 @@ 
 	private function prepareAccessForSetPassword($enablePasswordChange = true) {
 		$this->connection->expects($this->any())
 			->method('__get')
-			->willReturnCallback(function ($name) use (&$enablePasswordChange) {
+			->willReturnCallback(function($name) use (&$enablePasswordChange) {
 				if ($name === 'ldapLoginFilter') {
 					return '%uid';
 				}
 				if ($name === 'turnOnPasswordChange') {
-					return $enablePasswordChange?1:0;
+					return $enablePasswordChange ? 1 : 0;
 				}
 				return null;
 			});
 		$this->connection->expects($this->any())
 			->method('getFromCache')
-			->willReturnCallback(function ($uid) {
-				if ($uid === 'userExists' . 'roland') {
+			->willReturnCallback(function($uid) {
+				if ($uid === 'userExists'.'roland') {
 					return true;
 				}
 				return null;
@@ -1196,7 +1196,7 @@ 
 
 		$this->access->expects($this->any())
 			->method('fetchListOfUsers')
-			->willReturnCallback(function ($filter) {
+			->willReturnCallback(function($filter) {
 				if ($filter === 'roland') {
 					return [['dn' => ['dnOfRoland,dc=test']]];
 				}
@@ -1204,7 +1204,7 @@ 
 			});
 		$this->access->expects($this->any())
 			->method('fetchUsersByLoginName')
-			->willReturnCallback(function ($uid) {
+			->willReturnCallback(function($uid) {
 				if ($uid === 'roland') {
 					return [['dn' => ['dnOfRoland,dc=test']]];
 				}
@@ -1220,7 +1220,7 @@ 
 			->willReturn(true);
 		$this->access->expects($this->any())
 			->method('setPassword')
-			->willReturnCallback(function ($uid, $password) {
+			->willReturnCallback(function($uid, $password) {
 				if (strlen($password) <= 5) {
 					throw new HintException('Password fails quality checking policy', '', 19);
 				}
@@ -1318,15 +1318,15 @@ 
 
 	public static function avatarDataProvider(): array {
 		return [
-			[ 'validImageData', false ],
-			[ 'corruptImageData', true ],
-			[ false, true]
+			['validImageData', false],
+			['corruptImageData', true],
+			[false, true]
 		];
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('avatarDataProvider')]
-	public function testCanChangeAvatar(string|bool $imageData, bool $expected): void {
-		$isValidImage = str_starts_with((string)$imageData, 'valid');
+	public function testCanChangeAvatar(string | bool $imageData, bool $expected): void {
+		$isValidImage = str_starts_with((string) $imageData, 'valid');
 
 		$user = $this->createMock(User::class);
 		$user->expects($this->once())
@@ -1441,16 +1441,16 @@ 
 
 	public static function actionProvider(): array {
 		return [
-			[ 'ldapUserAvatarRule', 'default', Backend::PROVIDE_AVATAR, true],
-			[ 'ldapUserAvatarRule', 'data:selfiePhoto', Backend::PROVIDE_AVATAR, true],
-			[ 'ldapUserAvatarRule', 'none', Backend::PROVIDE_AVATAR, false],
-			[ 'turnOnPasswordChange', 0, Backend::SET_PASSWORD, false],
-			[ 'turnOnPasswordChange', 1, Backend::SET_PASSWORD, true],
+			['ldapUserAvatarRule', 'default', Backend::PROVIDE_AVATAR, true],
+			['ldapUserAvatarRule', 'data:selfiePhoto', Backend::PROVIDE_AVATAR, true],
+			['ldapUserAvatarRule', 'none', Backend::PROVIDE_AVATAR, false],
+			['turnOnPasswordChange', 0, Backend::SET_PASSWORD, false],
+			['turnOnPasswordChange', 1, Backend::SET_PASSWORD, true],
 		];
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('actionProvider')]
-	public function testImplementsAction(string $configurable, string|int $value, int $actionCode, bool $expected): void {
+	public function testImplementsAction(string $configurable, string | int $value, int $actionCode, bool $expected): void {
 		$this->pluginManager->expects($this->once())
 			->method('getImplementedActions')
 			->willReturn(0);

apps/files_sharing/tests/ApiTest.php

Spacing +48 added lines, -48 removed lines

@@ -78,10 +78,10 @@ 
 		// save file with content
 		$this->view->file_put_contents($this->filename, $this->data);
 		$this->view->mkdir($this->folder);
-		$this->view->mkdir($this->folder . $this->subfolder);
-		$this->view->mkdir($this->folder . $this->subfolder . $this->subsubfolder);
-		$this->view->file_put_contents($this->folder . $this->filename, $this->data);
-		$this->view->file_put_contents($this->folder . $this->subfolder . $this->filename, $this->data);
+		$this->view->mkdir($this->folder.$this->subfolder);
+		$this->view->mkdir($this->folder.$this->subfolder.$this->subsubfolder);
+		$this->view->file_put_contents($this->folder.$this->filename, $this->data);
+		$this->view->file_put_contents($this->folder.$this->subfolder.$this->filename, $this->data);
 		$mount = $this->view->getMount($this->filename);
 		$mount->getStorage()->getScanner()->scan('', Scanner::SCAN_RECURSIVE);
 
@@ -108,7 +108,7 @@ 
 	private function createOCS($userId) {
 		$l = $this->getMockBuilder(IL10N::class)->getMock();
 		$l->method('t')
-			->willReturnCallback(function ($text, $parameters = []) {
+			->willReturnCallback(function($text, $parameters = []) {
 				return vsprintf($text, $parameters);
 			});
 		$config = $this->createMock(IConfig::class);
@@ -160,7 +160,7 @@ 
 		$this->assertEquals(19, $data['permissions']);
 		$this->assertEmpty($data['expiration']);
 
-		$this->shareManager->getShareById('ocinternal:' . $data['id']);
+		$this->shareManager->getShareById('ocinternal:'.$data['id']);
 
 		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
 		$ocs->deleteShare($data['id']);
@@ -177,7 +177,7 @@ 
 		$this->assertEquals(31, $data['permissions']);
 		$this->assertEmpty($data['expiration']);
 
-		$this->shareManager->getShareById('ocinternal:' . $data['id']);
+		$this->shareManager->getShareById('ocinternal:'.$data['id']);
 
 		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
 		$ocs->deleteShare($data['id']);
@@ -193,7 +193,7 @@ 
 		$this->assertEquals(19, $data['permissions']);
 		$this->assertEmpty($data['expiration']);
 
-		$this->shareManager->getShareById('ocinternal:' . $data['id']);
+		$this->shareManager->getShareById('ocinternal:'.$data['id']);
 
 		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
 		$ocs->deleteShare($data['id']);
@@ -209,7 +209,7 @@ 
 		$this->assertEquals(31, $data['permissions']);
 		$this->assertEmpty($data['expiration']);
 
-		$this->shareManager->getShareById('ocinternal:' . $data['id']);
+		$this->shareManager->getShareById('ocinternal:'.$data['id']);
 
 		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
 		$ocs->deleteShare($data['id']);
@@ -229,10 +229,10 @@ 
 		$this->assertTrue(is_string($data['token']));
 
 		// check for correct link
-		$url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/' . $data['token']);
+		$url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/'.$data['token']);
 		$this->assertEquals($url, $data['url']);
 
-		$this->shareManager->getShareById('ocinternal:' . $data['id']);
+		$this->shareManager->getShareById('ocinternal:'.$data['id']);
 
 		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
 		$ocs->deleteShare($data['id']);
@@ -262,10 +262,10 @@ 
 		$this->assertTrue(is_string($data['token']));
 
 		// check for correct link
-		$url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/' . $data['token']);
+		$url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/'.$data['token']);
 		$this->assertEquals($url, $data['url']);
 
-		$this->shareManager->getShareById('ocinternal:' . $data['id']);
+		$this->shareManager->getShareById('ocinternal:'.$data['id']);
 
 		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
 		$ocs->deleteShare($data['id']);
@@ -334,7 +334,7 @@ 
 
 		$data = $result->getData();
 
-		$this->shareManager->getShareById('ocinternal:' . $data['id']);
+		$this->shareManager->getShareById('ocinternal:'.$data['id']);
 
 		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
 		$ocs->deleteShare($data['id']);
@@ -350,7 +350,7 @@ 
 
 		$data = $result->getData();
 
-		$this->shareManager->getShareById('ocinternal:' . $data['id']);
+		$this->shareManager->getShareById('ocinternal:'.$data['id']);
 
 		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
 		$ocs->deleteShare($data['id']);
@@ -440,7 +440,7 @@ 
 		$id = $data['id'];
 
 		// check for correct link
-		$url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/' . $data['token']);
+		$url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/'.$data['token']);
 		$this->assertEquals($url, $data['url']);
 
 		// check for link in getall shares
@@ -573,7 +573,7 @@ 
 			->setPermissions(19);
 		$share1 = $this->shareManager->createShare($share1);
 
-		$node2 = $this->userFolder->get($this->folder . '/' . $this->filename);
+		$node2 = $this->userFolder->get($this->folder.'/'.$this->filename);
 		$share2 = $this->shareManager->newShare();
 		$share2->setNode($node2)
 			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
@@ -629,7 +629,7 @@ 
 		$share1->setStatus(IShare::STATUS_ACCEPTED);
 		$this->shareManager->updateShare($share1);
 
-		$node2 = $this->userFolder->get($this->folder . '/' . $this->filename);
+		$node2 = $this->userFolder->get($this->folder.'/'.$this->filename);
 		$share2 = $this->shareManager->newShare();
 		$share2->setNode($node2)
 			->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
@@ -639,7 +639,7 @@ 
 		$share2->setStatus(IShare::STATUS_ACCEPTED);
 		$this->shareManager->updateShare($share2);
 
-		$node3 = $this->userFolder->get($this->folder . '/' . $this->subfolder . '/' . $this->filename);
+		$node3 = $this->userFolder->get($this->folder.'/'.$this->subfolder.'/'.$this->filename);
 		$share3 = $this->shareManager->newShare();
 		$share3->setNode($node3)
 			->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
@@ -651,9 +651,9 @@ 
 
 		$testValues = [
 			['query' => $this->folder,
-				'expectedResult' => $this->folder . $this->filename],
-			['query' => $this->folder . $this->subfolder,
-				'expectedResult' => $this->folder . $this->subfolder . $this->filename],
+				'expectedResult' => $this->folder.$this->filename],
+			['query' => $this->folder.$this->subfolder,
+				'expectedResult' => $this->folder.$this->subfolder.$this->filename],
 		];
 
 		foreach ($testValues as $value) {
@@ -677,7 +677,7 @@ 
 	 * reshare a sub folder and check if we get the correct path
 	 */
 	public function testGetShareFromSubFolderReShares(): void {
-		$node1 = $this->userFolder->get($this->folder . $this->subfolder);
+		$node1 = $this->userFolder->get($this->folder.$this->subfolder);
 		$share1 = $this->shareManager->newShare();
 		$share1->setNode($node1)
 			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
@@ -718,7 +718,7 @@ 
 	 * test re-re-share of folder if the path gets constructed correctly
 	 */
 	public function XtestGetShareFromFolderReReShares() {
-		$node1 = $this->userFolder->get($this->folder . $this->subfolder);
+		$node1 = $this->userFolder->get($this->folder.$this->subfolder);
 		$share1 = $this->shareManager->newShare();
 		$share1->setNode($node1)
 			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
@@ -727,7 +727,7 @@ 
 			->setPermissions(31);
 		$share1 = $this->shareManager->createShare($share1);
 
-		$node2 = $this->userFolder->get($this->folder . $this->subfolder . $this->subsubfolder);
+		$node2 = $this->userFolder->get($this->folder.$this->subfolder.$this->subsubfolder);
 		$share2 = $this->shareManager->newShare();
 		$share2->setNode($node2)
 			->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
@@ -769,7 +769,7 @@ 
 
 		// we should get exactly one result
 		$this->assertCount(1, $data);
-		$this->assertEquals($this->folder . $this->subfolder, $data[0]['path']);
+		$this->assertEquals($this->folder.$this->subfolder, $data[0]['path']);
 
 		/*
 		 * Test for second initiator
@@ -783,7 +783,7 @@ 
 
 		// we should get exactly one result
 		$this->assertCount(1, $data);
-		$this->assertEquals($this->subfolder . $this->subsubfolder, $data[0]['path']);
+		$this->assertEquals($this->subfolder.$this->subsubfolder, $data[0]['path']);
 
 		$this->shareManager->deleteShare($share1);
 		$this->shareManager->deleteShare($share2);
@@ -795,7 +795,7 @@ 
 	 */
 	public function testGetShareMultipleSharedFolder(): void {
 		$this->setUp();
-		$node1 = $this->userFolder->get($this->folder . $this->subfolder);
+		$node1 = $this->userFolder->get($this->folder.$this->subfolder);
 		$share1 = $this->shareManager->newShare();
 		$share1->setNode($node1)
 			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
@@ -838,7 +838,7 @@ 
 
 		//$request = $this->createRequest(['path' => $this->folder.$this->subfolder]);
 		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER2);
-		$result2 = $ocs->getShares('false', 'false', 'false', $this->folder . $this->subfolder);
+		$result2 = $ocs->getShares('false', 'false', 'false', $this->folder.$this->subfolder);
 		$ocs->cleanup();
 
 		// test should return one share within $this->folder
@@ -847,7 +847,7 @@ 
 		$s2 = reset($data2);
 
 		$this->assertEquals($this->subfolder, $s1['path']);
-		$this->assertEquals($this->folder . $this->subfolder, $s2['path']);
+		$this->assertEquals($this->folder.$this->subfolder, $s2['path']);
 
 		$this->shareManager->deleteShare($share1);
 		$this->shareManager->deleteShare($share2);
@@ -858,7 +858,7 @@ 
 	 * test re-re-share of folder if the path gets constructed correctly
 	 */
 	public function testGetShareFromFileReReShares(): void {
-		$node1 = $this->userFolder->get($this->folder . $this->subfolder);
+		$node1 = $this->userFolder->get($this->folder.$this->subfolder);
 		$share1 = $this->shareManager->newShare();
 		$share1->setNode($node1)
 			->setSharedBy(self::TEST_FILES_SHARING_API_USER1)
@@ -870,7 +870,7 @@ 
 		$this->shareManager->updateShare($share1);
 
 		$user2Folder = \OC::$server->getUserFolder(self::TEST_FILES_SHARING_API_USER2);
-		$node2 = $user2Folder->get($this->subfolder . $this->filename);
+		$node2 = $user2Folder->get($this->subfolder.$this->filename);
 		$share2 = $this->shareManager->newShare();
 		$share2->setNode($node2)
 			->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
@@ -954,7 +954,7 @@ 
 		);
 		$ocs->cleanup();
 
-		$share1 = $this->shareManager->getShareById('ocinternal:' . $share1->getId());
+		$share1 = $this->shareManager->getShareById('ocinternal:'.$share1->getId());
 		$this->assertEquals(1, $share1->getPermissions());
 		$this->assertEquals(true, $share1->getAttributes()->getAttribute('app1', 'attr1'));
 
@@ -965,14 +965,14 @@ 
 		$ocs->updateShare($share2->getId(), null, $password);
 		$ocs->cleanup();
 
-		$share2 = $this->shareManager->getShareById('ocinternal:' . $share2->getId());
+		$share2 = $this->shareManager->getShareById('ocinternal:'.$share2->getId());
 		$this->assertNotNull($share2->getPassword());
 
 		$ocs = $this->createOCS(self::TEST_FILES_SHARING_API_USER1);
 		$ocs->updateShare($share2->getId(), null, '');
 		$ocs->cleanup();
 
-		$share2 = $this->shareManager->getShareById('ocinternal:' . $share2->getId());
+		$share2 = $this->shareManager->getShareById('ocinternal:'.$share2->getId());
 		$this->assertNull($share2->getPassword());
 
 		$this->shareManager->deleteShare($share1);
@@ -1133,7 +1133,7 @@ 
 		$this->shareManager->updateShare($share1);
 
 		$user2folder = \OC::$server->getUserFolder(self::TEST_FILES_SHARING_API_USER2);
-		$node2 = $user2folder->get($this->folder . '/' . $this->filename);
+		$node2 = $user2folder->get($this->folder.'/'.$this->filename);
 		$share2 = $this->shareManager->newShare();
 		$share2->setNode($node2)
 			->setSharedBy(self::TEST_FILES_SHARING_API_USER2)
@@ -1172,11 +1172,11 @@ 
 		// user2 shares a file from the folder as link
 		self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
 
-		$view = new View('/' . self::TEST_FILES_SHARING_API_USER2 . '/files');
+		$view = new View('/'.self::TEST_FILES_SHARING_API_USER2.'/files');
 		$view->mkdir('localDir');
 
 		// move mount point to the folder "localDir"
-		$result = $view->rename($this->folder, 'localDir/' . $this->folder);
+		$result = $view->rename($this->folder, 'localDir/'.$this->folder);
 		$this->assertTrue($result !== false);
 
 		// try to share "localDir"
@@ -1201,7 +1201,7 @@ 
 
 		//cleanup
 
-		$result = $view->rename('localDir/' . $this->folder, $this->folder);
+		$result = $view->rename('localDir/'.$this->folder, $this->folder);
 		$this->assertTrue($result !== false);
 		$view->unlink('localDir');
 
@@ -1215,7 +1215,7 @@ 
 	 */
 	public static function initTestMountPointsHook($data) {
 		if ($data['user'] === self::TEST_FILES_SHARING_API_USER1) {
-			Filesystem::mount(self::$tempStorage, [], '/' . self::TEST_FILES_SHARING_API_USER1 . '/files' . self::TEST_FOLDER_NAME);
+			Filesystem::mount(self::$tempStorage, [], '/'.self::TEST_FILES_SHARING_API_USER1.'/files'.self::TEST_FOLDER_NAME);
 		}
 	}
 
@@ -1227,7 +1227,7 @@ 
 		$tempStorage->file_put_contents('test.txt', 'abcdef');
 		$tempStorage->getScanner()->scan('');
 
-		$this->registerMount(self::TEST_FILES_SHARING_API_USER1, $tempStorage, self::TEST_FILES_SHARING_API_USER1 . '/files' . self::TEST_FOLDER_NAME);
+		$this->registerMount(self::TEST_FILES_SHARING_API_USER1, $tempStorage, self::TEST_FILES_SHARING_API_USER1.'/files'.self::TEST_FOLDER_NAME);
 
 		// logging in will auto-mount the temp storage for user1 as well
 		self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
@@ -1246,10 +1246,10 @@ 
 		// user2: check that mount point name appears correctly
 		self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
 
-		$view = new View('/' . self::TEST_FILES_SHARING_API_USER2 . '/files');
+		$view = new View('/'.self::TEST_FILES_SHARING_API_USER2.'/files');
 
 		$this->assertTrue($view->file_exists($this->folder));
-		$this->assertTrue($view->file_exists($this->folder . '/test.txt'));
+		$this->assertTrue($view->file_exists($this->folder.'/test.txt'));
 
 		self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
 
@@ -1268,7 +1268,7 @@ 
 		return [
 			[$date->format('Y-m-d H:i:s'), true],
 			['abc', false],
-			[$date->format('Y-m-d H:i:s') . 'xyz', false],
+			[$date->format('Y-m-d H:i:s').'xyz', false],
 		];
 	}
 
@@ -1296,10 +1296,10 @@ 
 		$this->assertEquals(substr($date, 0, 10), substr($data['expiration'], 0, 10));
 
 		// check for correct link
-		$url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/' . $data['token']);
+		$url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/'.$data['token']);
 		$this->assertEquals($url, $data['url']);
 
-		$share = $this->shareManager->getShareById('ocinternal:' . $data['id']);
+		$share = $this->shareManager->getShareById('ocinternal:'.$data['id']);
 
 		$this->assertEquals($date, $share->getExpirationDate()->format('Y-m-d H:i:s'));
 
@@ -1326,10 +1326,10 @@ 
 		$this->assertEquals($date->format('Y-m-d 00:00:00'), $data['expiration']);
 
 		// check for correct link
-		$url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/' . $data['token']);
+		$url = Server::get(IURLGenerator::class)->getAbsoluteURL('/index.php/s/'.$data['token']);
 		$this->assertEquals($url, $data['url']);
 
-		$share = $this->shareManager->getShareById('ocinternal:' . $data['id']);
+		$share = $this->shareManager->getShareById('ocinternal:'.$data['id']);
 		$date->setTime(0, 0, 0);
 		$this->assertEquals($date, $share->getExpirationDate());
 

cron.php

Spacing +5 added lines, -5 removed lines

@@ -12,10 +12,10 @@ 
  * SPDX-License-Identifier: AGPL-3.0-only
  */
 
-require_once __DIR__ . '/lib/versioncheck.php';
+require_once __DIR__.'/lib/versioncheck.php';
 
 try {
-	require_once __DIR__ . '/lib/base.php';
+	require_once __DIR__.'/lib/base.php';
 
 	if (isset($argv[1]) && ($argv[1] === '-h' || $argv[1] === '--help')) {
 		echo 'Description:
@@ -41,8 +41,8 @@ 
 		$jobClasses = empty($jobClasses) ? null : $jobClasses;
 
 		if ($verbose) {
-			$cronService->registerVerboseCallback(function (string $message): void {
-				echo $message . PHP_EOL;
+			$cronService->registerVerboseCallback(function(string $message): void {
+				echo $message.PHP_EOL;
 			});
 		}
 	} else {
@@ -64,7 +64,7 @@ 
 		['app' => 'cron', 'exception' => $e]
 	);
 	if (OC::$CLI) {
-		echo $e->getMessage() . PHP_EOL;
+		echo $e->getMessage().PHP_EOL;
 	} else {
 		$data = [
 			'status' => 'error',