Passed
Push — master ( 1fd674...707cb6 )
by Jan-Christoph
15:26 queued 10s
created
lib/public/AppFramework/Http/FileDisplayResponse.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -43,12 +43,12 @@  discard block
 block discarded – undo
43 43
 	 * @param array $headers
44 44
 	 * @since 11.0.0
45 45
 	 */
46
-	public function __construct($file, $statusCode=Http::STATUS_OK,
47
-								$headers=[]) {
46
+	public function __construct($file, $statusCode = Http::STATUS_OK,
47
+								$headers = []) {
48 48
 		$this->file = $file;
49 49
 		$this->setStatus($statusCode);
50 50
 		$this->setHeaders(array_merge($this->getHeaders(), $headers));
51
-		$this->addHeader('Content-Disposition', 'inline; filename="' . rawurldecode($file->getName()) . '"');
51
+		$this->addHeader('Content-Disposition', 'inline; filename="'.rawurldecode($file->getName()).'"');
52 52
 
53 53
 		$this->setETag($file->getEtag());
54 54
 		$lastModified = new \DateTime();
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 	 */
63 63
 	public function callback(IOutput $output) {
64 64
 		if ($output->getHttpResponseCode() !== Http::STATUS_NOT_MODIFIED) {
65
-			$output->setHeader('Content-Length: ' . $this->file->getSize());
65
+			$output->setHeader('Content-Length: '.$this->file->getSize());
66 66
 			$output->setOutput($this->file->getContent());
67 67
 		}
68 68
 	}
Please login to merge, or discard this patch.
lib/public/AppFramework/Http/TemplateResponse.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -70,8 +70,8 @@  discard block
 block discarded – undo
70 70
 	 * @param string $renderAs how the page should be rendered, defaults to user
71 71
 	 * @since 6.0.0 - parameters $params and $renderAs were added in 7.0.0
72 72
 	 */
73
-	public function __construct($appName, $templateName, array $params=array(),
74
-	                            $renderAs='user') {
73
+	public function __construct($appName, $templateName, array $params = array(),
74
+	                            $renderAs = 'user') {
75 75
 		$this->templateName = $templateName;
76 76
 		$this->appName = $appName;
77 77
 		$this->params = $params;
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 	 * @return TemplateResponse Reference to this object
87 87
 	 * @since 6.0.0 - return value was added in 7.0.0
88 88
 	 */
89
-	public function setParams(array $params){
89
+	public function setParams(array $params) {
90 90
 		$this->params = $params;
91 91
 
92 92
 		return $this;
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 	 * @return array the params
99 99
 	 * @since 6.0.0
100 100
 	 */
101
-	public function getParams(){
101
+	public function getParams() {
102 102
 		return $this->params;
103 103
 	}
104 104
 
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 	 * @return string the name of the used template
109 109
 	 * @since 6.0.0
110 110
 	 */
111
-	public function getTemplateName(){
111
+	public function getTemplateName() {
112 112
 		return $this->templateName;
113 113
 	}
114 114
 
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 	 * @return TemplateResponse Reference to this object
123 123
 	 * @since 6.0.0 - return value was added in 7.0.0
124 124
 	 */
125
-	public function renderAs($renderAs){
125
+	public function renderAs($renderAs) {
126 126
 		$this->renderAs = $renderAs;
127 127
 
128 128
 		return $this;
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 	 * @return string the renderAs value
135 135
 	 * @since 6.0.0
136 136
 	 */
137
-	public function getRenderAs(){
137
+	public function getRenderAs() {
138 138
 		return $this->renderAs;
139 139
 	}
140 140
 
@@ -144,13 +144,13 @@  discard block
 block discarded – undo
144 144
 	 * @return string the rendered html
145 145
 	 * @since 6.0.0
146 146
 	 */
147
-	public function render(){
147
+	public function render() {
148 148
 		// \OCP\Template needs an empty string instead of 'blank' for an unwrapped response
149 149
 		$renderAs = $this->renderAs === 'blank' ? '' : $this->renderAs;
150 150
 
151 151
 		$template = new \OCP\Template($this->appName, $this->templateName, $renderAs);
152 152
 
153
-		foreach($this->params as $key => $value){
153
+		foreach ($this->params as $key => $value) {
154 154
 			$template->assign($key, $value);
155 155
 		}
156 156
 
Please login to merge, or discard this patch.
lib/public/AppFramework/Http/StreamResponse.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 	 * @param string|resource $filePath the path to the file or a file handle which should be streamed
41 41
 	 * @since 8.1.0
42 42
 	 */
43
-	public function __construct ($filePath) {
43
+	public function __construct($filePath) {
44 44
 		$this->filePath = $filePath;
45 45
 	}
46 46
 
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 	 * @param IOutput $output a small wrapper that handles output
52 52
 	 * @since 8.1.0
53 53
 	 */
54
-	public function callback (IOutput $output) {
54
+	public function callback(IOutput $output) {
55 55
 		// handle caching
56 56
 		if ($output->getHttpResponseCode() !== Http::STATUS_NOT_MODIFIED) {
57 57
 			if (!(is_resource($this->filePath) || file_exists($this->filePath))) {
Please login to merge, or discard this patch.
lib/public/AppFramework/Http/DownloadResponse.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
 		$this->filename = $filename;
46 46
 		$this->contentType = $contentType;
47 47
 
48
-		$this->addHeader('Content-Disposition', 'attachment; filename="' . $filename . '"');
48
+		$this->addHeader('Content-Disposition', 'attachment; filename="'.$filename.'"');
49 49
 		$this->addHeader('Content-Type', $contentType);
50 50
 	}
51 51
 
Please login to merge, or discard this patch.
lib/public/AppFramework/Middleware.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 	 *                           the controller
54 54
 	 * @since 6.0.0
55 55
 	 */
56
-	public function beforeController($controller, $methodName){
56
+	public function beforeController($controller, $methodName) {
57 57
 
58 58
 	}
59 59
 
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	 * @return Response a Response object in case that the exception was handled
74 74
 	 * @since 6.0.0
75 75
 	 */
76
-	public function afterException($controller, $methodName, \Exception $exception){
76
+	public function afterException($controller, $methodName, \Exception $exception) {
77 77
 		throw $exception;
78 78
 	}
79 79
 
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 	 * @return Response a Response object
90 90
 	 * @since 6.0.0
91 91
 	 */
92
-	public function afterController($controller, $methodName, Response $response){
92
+	public function afterController($controller, $methodName, Response $response) {
93 93
 		return $response;
94 94
 	}
95 95
 
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 	 * @return string the output that should be printed
106 106
 	 * @since 6.0.0
107 107
 	 */
108
-	public function beforeOutput($controller, $methodName, $output){
108
+	public function beforeOutput($controller, $methodName, $output) {
109 109
 		return $output;
110 110
 	}
111 111
 
Please login to merge, or discard this patch.
lib/public/AppFramework/Db/MultipleObjectsReturnedException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
 	 * @param string $msg the error message
38 38
 	 * @since 7.0.0
39 39
 	 */
40
-	public function __construct($msg){
40
+	public function __construct($msg) {
41 41
 		parent::__construct($msg);
42 42
 	}
43 43
 
Please login to merge, or discard this patch.
lib/public/AppFramework/Db/Entity.php 1 patch
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -47,8 +47,8 @@  discard block
 block discarded – undo
47 47
 	public static function fromParams(array $params) {
48 48
 		$instance = new static();
49 49
 
50
-		foreach($params as $key => $value) {
51
-			$method = 'set' . ucfirst($key);
50
+		foreach ($params as $key => $value) {
51
+			$method = 'set'.ucfirst($key);
52 52
 			$instance->$method($value);
53 53
 		}
54 54
 
@@ -61,12 +61,12 @@  discard block
 block discarded – undo
61 61
 	 * @param array $row the row to map onto the entity
62 62
 	 * @since 7.0.0
63 63
 	 */
64
-	public static function fromRow(array $row){
64
+	public static function fromRow(array $row) {
65 65
 		$instance = new static();
66 66
 
67
-		foreach($row as $key => $value){
67
+		foreach ($row as $key => $value) {
68 68
 			$prop = ucfirst($instance->columnToProperty($key));
69
-			$setter = 'set' . $prop;
69
+			$setter = 'set'.$prop;
70 70
 			$instance->$setter($value);
71 71
 		}
72 72
 
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 	 * Marks the entity as clean needed for setting the id after the insertion
90 90
 	 * @since 7.0.0
91 91
 	 */
92
-	public function resetUpdatedFields(){
92
+	public function resetUpdatedFields() {
93 93
 		$this->_updatedFields = array();
94 94
 	}
95 95
 
@@ -99,20 +99,20 @@  discard block
 block discarded – undo
99 99
 	 */
100 100
 	protected function setter($name, $args) {
101 101
 		// setters should only work for existing attributes
102
-		if(property_exists($this, $name)){
103
-			if($this->$name === $args[0]) {
102
+		if (property_exists($this, $name)) {
103
+			if ($this->$name === $args[0]) {
104 104
 				return;
105 105
 			}
106 106
 			$this->markFieldUpdated($name);
107 107
 
108 108
 			// if type definition exists, cast to correct type
109
-			if($args[0] !== null && array_key_exists($name, $this->_fieldTypes)) {
109
+			if ($args[0] !== null && array_key_exists($name, $this->_fieldTypes)) {
110 110
 				settype($args[0], $this->_fieldTypes[$name]);
111 111
 			}
112 112
 			$this->$name = $args[0];
113 113
 
114 114
 		} else {
115
-			throw new \BadFunctionCallException($name . 
115
+			throw new \BadFunctionCallException($name. 
116 116
 				' is not a valid attribute');
117 117
 		}
118 118
 	}
@@ -123,10 +123,10 @@  discard block
 block discarded – undo
123 123
 	 */
124 124
 	protected function getter($name) {
125 125
 		// getters should only work for existing attributes
126
-		if(property_exists($this, $name)){
126
+		if (property_exists($this, $name)) {
127 127
 			return $this->$name;
128 128
 		} else {
129
-			throw new \BadFunctionCallException($name . 
129
+			throw new \BadFunctionCallException($name. 
130 130
 				' is not a valid attribute');
131 131
 		}
132 132
 	}
@@ -139,15 +139,15 @@  discard block
 block discarded – undo
139 139
 	 * getter method
140 140
 	 * @since 7.0.0
141 141
 	 */
142
-	public function __call($methodName, $args){
143
-		$attr = lcfirst( substr($methodName, 3) );
142
+	public function __call($methodName, $args) {
143
+		$attr = lcfirst(substr($methodName, 3));
144 144
 
145
-		if(strpos($methodName, 'set') === 0){
145
+		if (strpos($methodName, 'set') === 0) {
146 146
 			$this->setter($attr, $args);
147
-		} elseif(strpos($methodName, 'get') === 0) {
147
+		} elseif (strpos($methodName, 'get') === 0) {
148 148
 			return $this->getter($attr);
149 149
 		} else {
150
-			throw new \BadFunctionCallException($methodName . 
150
+			throw new \BadFunctionCallException($methodName. 
151 151
 					' does not exist');
152 152
 		}
153 153
 
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
 	 * @param string $attribute the name of the attribute
160 160
 	 * @since 7.0.0
161 161
 	 */
162
-	protected function markFieldUpdated($attribute){
162
+	protected function markFieldUpdated($attribute) {
163 163
 		$this->_updatedFields[$attribute] = true;
164 164
 	}
165 165
 
@@ -170,12 +170,12 @@  discard block
 block discarded – undo
170 170
 	 * @return string the property name
171 171
 	 * @since 7.0.0
172 172
 	 */
173
-	public function columnToProperty($columnName){
173
+	public function columnToProperty($columnName) {
174 174
 		$parts = explode('_', $columnName);
175 175
 		$property = null;
176 176
 
177
-		foreach($parts as $part){
178
-			if($property === null){
177
+		foreach ($parts as $part) {
178
+			if ($property === null) {
179 179
 				$property = $part;
180 180
 			} else {
181 181
 				$property .= ucfirst($part);
@@ -192,15 +192,15 @@  discard block
 block discarded – undo
192 192
 	 * @return string the column name
193 193
 	 * @since 7.0.0
194 194
 	 */
195
-	public function propertyToColumn($property){
195
+	public function propertyToColumn($property) {
196 196
 		$parts = preg_split('/(?=[A-Z])/', $property);
197 197
 		$column = null;
198 198
 
199
-		foreach($parts as $part){
200
-			if($column === null){
199
+		foreach ($parts as $part) {
200
+			if ($column === null) {
201 201
 				$column = $part;
202 202
 			} else {
203
-				$column .= '_' . lcfirst($part);
203
+				$column .= '_'.lcfirst($part);
204 204
 			}
205 205
 		}
206 206
 
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
 	 * @return array array of updated fields for update query
213 213
 	 * @since 7.0.0
214 214
 	 */
215
-	public function getUpdatedFields(){
215
+	public function getUpdatedFields() {
216 216
 		return $this->_updatedFields;
217 217
 	}
218 218
 
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 	 * @param string $type the type which will be used to call settype()
225 225
 	 * @since 7.0.0
226 226
 	 */
227
-	protected function addType($fieldName, $type){
227
+	protected function addType($fieldName, $type) {
228 228
 		$this->_fieldTypes[$fieldName] = $type;
229 229
 	}
230 230
 
@@ -236,9 +236,9 @@  discard block
 block discarded – undo
236 236
 	 * @return string slugified value
237 237
 	 * @since 7.0.0
238 238
 	 */
239
-	public function slugify($attributeName){
239
+	public function slugify($attributeName) {
240 240
 		// toSlug should only work for existing attributes
241
-		if(property_exists($this, $attributeName)){
241
+		if (property_exists($this, $attributeName)) {
242 242
 			$value = $this->$attributeName;
243 243
 			// replace everything except alphanumeric with a single '-'
244 244
 			$value = preg_replace('/[^A-Za-z0-9]+/', '-', $value);
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
 			// trim '-'
247 247
 			return trim($value, '-');
248 248
 		} else {
249
-			throw new \BadFunctionCallException($attributeName .
249
+			throw new \BadFunctionCallException($attributeName.
250 250
 				' is not a valid attribute');
251 251
 		}
252 252
 	}
Please login to merge, or discard this patch.
lib/public/DB/QueryBuilder/IExpressionBuilder.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 	/**
36 36
 	 * @since 9.0.0
37 37
 	 */
38
-	const EQ  = ExpressionBuilder::EQ;
38
+	const EQ = ExpressionBuilder::EQ;
39 39
 	/**
40 40
 	 * @since 9.0.0
41 41
 	 */
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 	/**
44 44
 	 * @since 9.0.0
45 45
 	 */
46
-	const LT  = ExpressionBuilder::LT;
46
+	const LT = ExpressionBuilder::LT;
47 47
 	/**
48 48
 	 * @since 9.0.0
49 49
 	 */
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 	/**
52 52
 	 * @since 9.0.0
53 53
 	 */
54
-	const GT  = ExpressionBuilder::GT;
54
+	const GT = ExpressionBuilder::GT;
55 55
 	/**
56 56
 	 * @since 9.0.0
57 57
 	 */
Please login to merge, or discard this patch.
lib/public/App/ManagerEvent.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@
 block discarded – undo
84 84
 	 * @since 9.0.0
85 85
 	 */
86 86
 	public function getGroups() {
87
-		return array_map(function ($group) {
87
+		return array_map(function($group) {
88 88
 			/** @var \OCP\IGroup $group */
89 89
 			return $group->getGID();
90 90
 		}, $this->groups);
Please login to merge, or discard this patch.