Completed
Pull Request — master (#4212)
by Individual IT
13:52
created
apps/files/templates/admin.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -2,17 +2,17 @@
 block discarded – undo
2 2
 
3 3
 	<div class="section">
4 4
 		<h2><?php p($l->t('File handling')); ?></h2>
5
-		<label for="maxUploadSize"><?php p($l->t( 'Maximum upload size' )); ?> </label>
5
+		<label for="maxUploadSize"><?php p($l->t('Maximum upload size')); ?> </label>
6 6
 		<span id="maxUploadSizeSettingsMsg" class="msg"></span>
7 7
 		<br />
8
-		<input type="text" name='maxUploadSize' id="maxUploadSize" value='<?php p($_['uploadMaxFilesize']) ?>' <?php if(!$_['uploadChangable']) { p('disabled'); } ?> />
9
-		<?php if($_['displayMaxPossibleUploadSize']):?>
8
+		<input type="text" name='maxUploadSize' id="maxUploadSize" value='<?php p($_['uploadMaxFilesize']) ?>' <?php if (!$_['uploadChangable']) { p('disabled'); } ?> />
9
+		<?php if ($_['displayMaxPossibleUploadSize']):?>
10 10
 			(<?php p($l->t('max. possible: ')); p($_['maxPossibleUploadSize']) ?>)
11
-		<?php endif;?>
11
+		<?php endif; ?>
12 12
 		<input type="hidden" value="<?php p($_['requesttoken']); ?>" name="requesttoken" />
13
-		<?php if($_['uploadChangable']): ?>
13
+		<?php if ($_['uploadChangable']): ?>
14 14
 			<input type="submit" id="submitMaxUpload"
15
-				   value="<?php p($l->t( 'Save' )); ?>"/>
15
+				   value="<?php p($l->t('Save')); ?>"/>
16 16
 			<p><em><?php p($l->t('With PHP-FPM it might take 5 minutes for changes to be applied.')); ?></em></p>
17 17
 		<?php else: ?>
18 18
 			<p><em><?php p($l->t('Missing permissions to edit from here.')); ?></em></p>
Please login to merge, or discard this patch.
apps/files/templates/list.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -2,7 +2,7 @@  discard block
 block discarded – undo
2 2
 		<div class="actions creatable hidden">
3 3
 			<div id="uploadprogresswrapper">
4 4
 				<div id="uploadprogressbar">
5
-					<em class="label outer" style="display:none"><span class="desktop"><?php p($l->t('Uploading...'));?></span><span class="mobile"><?php p($l->t('...'));?></span></em>
5
+					<em class="label outer" style="display:none"><span class="desktop"><?php p($l->t('Uploading...')); ?></span><span class="mobile"><?php p($l->t('...')); ?></span></em>
6 6
 				</div>
7 7
 				<input type="button" class="stop icon-close" style="display:none" value="" />
8 8
 			</div>
@@ -16,10 +16,10 @@  discard block
 block discarded – undo
16 16
 	*/ ?>
17 17
 	<input type="hidden" name="permissions" value="" id="permissions">
18 18
 	<input type="hidden" id="free_space" value="<?php isset($_['freeSpace']) ? p($_['freeSpace']) : '' ?>">
19
-	<?php if(isset($_['dirToken'])):?>
19
+	<?php if (isset($_['dirToken'])):?>
20 20
 	<input type="hidden" id="publicUploadRequestToken" name="requesttoken" value="<?php p($_['requesttoken']) ?>" />
21 21
 	<input type="hidden" id="dirToken" name="dirToken" value="<?php p($_['dirToken']) ?>" />
22
-	<?php endif;?>
22
+	<?php endif; ?>
23 23
 	<input type="hidden" class="max_human_file_size"
24 24
 		   value="(max <?php isset($_['uploadMaxHumanFilesize']) ? p($_['uploadMaxHumanFilesize']) : ''; ?>)">
25 25
 </div>
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 					<label for="select_all_files">
46 46
 						<span class="hidden-visually"><?php p($l->t('Select all'))?></span>
47 47
 					</label>
48
-					<a class="name sort columntitle" data-sort="name"><span><?php p($l->t( 'Name' )); ?></span><span class="sort-indicator"></span></a>
48
+					<a class="name sort columntitle" data-sort="name"><span><?php p($l->t('Name')); ?></span><span class="sort-indicator"></span></a>
49 49
 					<span id="selectedActionsList" class="selectedActions">
50 50
 						<a href="" class="download">
51 51
 							<span class="icon icon-download"></span>
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 				<a class="size sort columntitle" data-sort="size"><span><?php p($l->t('Size')); ?></span><span class="sort-indicator"></span></a>
59 59
 			</th>
60 60
 			<th id="headerDate" class="hidden column-mtime">
61
-				<a id="modified" class="columntitle" data-sort="mtime"><span><?php p($l->t( 'Modified' )); ?></span><span class="sort-indicator"></span></a>
61
+				<a id="modified" class="columntitle" data-sort="mtime"><span><?php p($l->t('Modified')); ?></span><span class="sort-indicator"></span></a>
62 62
 					<span class="selectedActions"><a href="" class="delete-selected">
63 63
 						<span><?php p($l->t('Delete'))?></span>
64 64
 						<span class="icon icon-delete"></span>
@@ -78,6 +78,6 @@  discard block
 block discarded – undo
78 78
 <div id="editor"></div><!-- FIXME Do not use this div in your app! It is deprecated and will be removed in the future! -->
79 79
 <div id="uploadsize-message" title="<?php p($l->t('Upload too large'))?>">
80 80
 	<p>
81
-	<?php p($l->t('The files you are trying to upload exceed the maximum size for file uploads on this server.'));?>
81
+	<?php p($l->t('The files you are trying to upload exceed the maximum size for file uploads on this server.')); ?>
82 82
 	</p>
83 83
 </div>
Please login to merge, or discard this patch.
apps/files/templates/simplelist.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,14 +19,14 @@
 block discarded – undo
19 19
 		<tr>
20 20
 			<th id='headerName' class="hidden column-name">
21 21
 				<div id="headerName-container">
22
-					<a class="name sort columntitle" data-sort="name"><span><?php p($l->t( 'Name' )); ?></span><span class="sort-indicator"></span></a>
22
+					<a class="name sort columntitle" data-sort="name"><span><?php p($l->t('Name')); ?></span><span class="sort-indicator"></span></a>
23 23
 				</div>
24 24
 			</th>
25 25
 			<th id="headerSize" class="hidden column-size">
26 26
 				<a class="size sort columntitle" data-sort="size"><span><?php p($l->t('Size')); ?></span><span class="sort-indicator"></span></a>
27 27
 			</th>
28 28
 			<th id="headerDate" class="hidden column-mtime">
29
-				<a id="modified" class="columntitle" data-sort="mtime"><span><?php p($l->t( 'Modified' )); ?></span><span class="sort-indicator"></span></a>
29
+				<a id="modified" class="columntitle" data-sort="mtime"><span><?php p($l->t('Modified')); ?></span><span class="sort-indicator"></span></a>
30 30
 					<span class="selectedActions"><a href="" class="delete-selected">
31 31
 						<?php p($l->t('Delete'))?>
32 32
 						<img class="svg" alt="<?php p($l->t('Delete'))?>"
Please login to merge, or discard this patch.
apps/files/templates/appnavigation.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
 		<li data-id="<?php p($item['id']) ?>" class="nav-<?php p($item['id']) ?>">
5 5
 			<a href="<?php p(isset($item['href']) ? $item['href'] : '#') ?>"
6 6
 				class="nav-icon-<?php p($item['icon'] !== '' ? $item['icon'] : $item['id']) ?> svg">
7
-				<?php p($item['name']);?>
7
+				<?php p($item['name']); ?>
8 8
 			</a>
9 9
 		</li>
10 10
 		<?php } ?>
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
 	<div id="app-settings">
13 13
 		<div id="app-settings-header">
14 14
 			<button class="settings-button" data-apps-slide-toggle="#app-settings-content">
15
-				<?php p($l->t('Settings'));?>
15
+				<?php p($l->t('Settings')); ?>
16 16
 			</button>
17 17
 		</div>
18 18
 		<div id="app-settings-content">
@@ -20,9 +20,9 @@  discard block
 block discarded – undo
20 20
 				<input class="checkbox" id="showhiddenfilesToggle" checked="checked" type="checkbox">
21 21
 				<label for="showhiddenfilesToggle"><?php p($l->t('Show hidden files')); ?></label>
22 22
 			</div>
23
-			<label for="webdavurl"><?php p($l->t('WebDAV'));?></label>
23
+			<label for="webdavurl"><?php p($l->t('WebDAV')); ?></label>
24 24
 			<input id="webdavurl" type="text" readonly="readonly" value="<?php p(\OCP\Util::linkToRemote('webdav')); ?>" />
25
-			<em><?php print_unescaped($l->t('Use this address to <a href="%s" target="_blank" rel="noreferrer">access your Files via WebDAV</a>', array(link_to_docs('user-webdav'))));?></em>
25
+			<em><?php print_unescaped($l->t('Use this address to <a href="%s" target="_blank" rel="noreferrer">access your Files via WebDAV</a>', array(link_to_docs('user-webdav')))); ?></em>
26 26
 		</div>
27 27
 	</div>
28 28
 </div>
Please login to merge, or discard this patch.
apps/files/ajax/getstoragestats.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 $dir = '/';
27 27
 
28 28
 if (isset($_GET['dir'])) {
29
-	$dir = (string)$_GET['dir'];
29
+    $dir = (string)$_GET['dir'];
30 30
 }
31 31
 
32 32
 OCP\JSON::checkLoggedIn();
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 
35 35
 // send back json
36 36
 try {
37
-	OCP\JSON::success(array('data' => \OCA\Files\Helper::buildFileStorageStatistics($dir)));
37
+    OCP\JSON::success(array('data' => \OCA\Files\Helper::buildFileStorageStatistics($dir)));
38 38
 } catch (\OCP\Files\NotFoundException $e) {
39
-	OCP\JSON::error(['data' => ['message' => 'Folder not found']]);
39
+    OCP\JSON::error(['data' => ['message' => 'Folder not found']]);
40 40
 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 $dir = '/';
27 27
 
28 28
 if (isset($_GET['dir'])) {
29
-	$dir = (string)$_GET['dir'];
29
+	$dir = (string) $_GET['dir'];
30 30
 }
31 31
 
32 32
 OCP\JSON::checkLoggedIn();
Please login to merge, or discard this patch.
apps/files/ajax/list.php 2 patches
Indentation   +57 added lines, -57 removed lines patch added patch discarded remove patch
@@ -32,73 +32,73 @@
 block discarded – undo
32 32
 $dir = \OC\Files\Filesystem::normalizePath($dir);
33 33
 
34 34
 try {
35
-	$dirInfo = \OC\Files\Filesystem::getFileInfo($dir);
36
-	if (!$dirInfo || !$dirInfo->getType() === 'dir') {
37
-		header("HTTP/1.0 404 Not Found");
38
-		exit();
39
-	}
35
+    $dirInfo = \OC\Files\Filesystem::getFileInfo($dir);
36
+    if (!$dirInfo || !$dirInfo->getType() === 'dir') {
37
+        header("HTTP/1.0 404 Not Found");
38
+        exit();
39
+    }
40 40
 
41
-	$data = array();
42
-	$baseUrl = OCP\Util::linkTo('files', 'index.php') . '?dir=';
41
+    $data = array();
42
+    $baseUrl = OCP\Util::linkTo('files', 'index.php') . '?dir=';
43 43
 
44
-	$permissions = $dirInfo->getPermissions();
44
+    $permissions = $dirInfo->getPermissions();
45 45
 
46
-	$sortAttribute = isset($_GET['sort']) ? (string)$_GET['sort'] : 'name';
47
-	$sortDirection = isset($_GET['sortdirection']) ? ($_GET['sortdirection'] === 'desc') : false;
48
-	$mimetypeFilters = isset($_GET['mimetypes']) ? json_decode($_GET['mimetypes']) : '';
46
+    $sortAttribute = isset($_GET['sort']) ? (string)$_GET['sort'] : 'name';
47
+    $sortDirection = isset($_GET['sortdirection']) ? ($_GET['sortdirection'] === 'desc') : false;
48
+    $mimetypeFilters = isset($_GET['mimetypes']) ? json_decode($_GET['mimetypes']) : '';
49 49
 
50
-	$files = [];
51
-	// Clean up duplicates from array
52
-	if (is_array($mimetypeFilters) && count($mimetypeFilters)) {
53
-		$mimetypeFilters = array_unique($mimetypeFilters);
50
+    $files = [];
51
+    // Clean up duplicates from array
52
+    if (is_array($mimetypeFilters) && count($mimetypeFilters)) {
53
+        $mimetypeFilters = array_unique($mimetypeFilters);
54 54
 
55
-		if (!in_array('httpd/unix-directory', $mimetypeFilters)) {
56
-			// append folder filter to be able to browse folders
57
-			$mimetypeFilters[] = 'httpd/unix-directory';
58
-		}
55
+        if (!in_array('httpd/unix-directory', $mimetypeFilters)) {
56
+            // append folder filter to be able to browse folders
57
+            $mimetypeFilters[] = 'httpd/unix-directory';
58
+        }
59 59
 
60
-		// create filelist with mimetype filter - as getFiles only supports on
61
-		// mimetype filter at once we will filter this folder for each
62
-		// mimetypeFilter
63
-		foreach ($mimetypeFilters as $mimetypeFilter) {
64
-			$files = array_merge($files, \OCA\Files\Helper::getFiles($dir, $sortAttribute, $sortDirection, $mimetypeFilter));
65
-		}
60
+        // create filelist with mimetype filter - as getFiles only supports on
61
+        // mimetype filter at once we will filter this folder for each
62
+        // mimetypeFilter
63
+        foreach ($mimetypeFilters as $mimetypeFilter) {
64
+            $files = array_merge($files, \OCA\Files\Helper::getFiles($dir, $sortAttribute, $sortDirection, $mimetypeFilter));
65
+        }
66 66
 
67
-		// sort the files accordingly
68
-		$files = \OCA\Files\Helper::sortFiles($files, $sortAttribute, $sortDirection);
69
-	} else {
70
-		// create file list without mimetype filter
71
-		$files = \OCA\Files\Helper::getFiles($dir, $sortAttribute, $sortDirection);
72
-	}
67
+        // sort the files accordingly
68
+        $files = \OCA\Files\Helper::sortFiles($files, $sortAttribute, $sortDirection);
69
+    } else {
70
+        // create file list without mimetype filter
71
+        $files = \OCA\Files\Helper::getFiles($dir, $sortAttribute, $sortDirection);
72
+    }
73 73
 
74
-	$files = \OCA\Files\Helper::populateTags($files);
75
-	$data['directory'] = $dir;
76
-	$data['files'] = \OCA\Files\Helper::formatFileInfos($files);
77
-	$data['permissions'] = $permissions;
74
+    $files = \OCA\Files\Helper::populateTags($files);
75
+    $data['directory'] = $dir;
76
+    $data['files'] = \OCA\Files\Helper::formatFileInfos($files);
77
+    $data['permissions'] = $permissions;
78 78
 
79
-	OCP\JSON::success(array('data' => $data));
79
+    OCP\JSON::success(array('data' => $data));
80 80
 } catch (\OCP\Files\StorageNotAvailableException $e) {
81
-	\OCP\Util::logException('files', $e);
82
-	OCP\JSON::error([
83
-		'data' => [
84
-			'exception' => '\OCP\Files\StorageNotAvailableException',
85
-			'message' => $l->t('Storage is temporarily not available')
86
-		]
87
-	]);
81
+    \OCP\Util::logException('files', $e);
82
+    OCP\JSON::error([
83
+        'data' => [
84
+            'exception' => '\OCP\Files\StorageNotAvailableException',
85
+            'message' => $l->t('Storage is temporarily not available')
86
+        ]
87
+    ]);
88 88
 } catch (\OCP\Files\StorageInvalidException $e) {
89
-	\OCP\Util::logException('files', $e);
90
-	OCP\JSON::error(array(
91
-		'data' => array(
92
-			'exception' => '\OCP\Files\StorageInvalidException',
93
-			'message' => $l->t('Storage invalid')
94
-		)
95
-	));
89
+    \OCP\Util::logException('files', $e);
90
+    OCP\JSON::error(array(
91
+        'data' => array(
92
+            'exception' => '\OCP\Files\StorageInvalidException',
93
+            'message' => $l->t('Storage invalid')
94
+        )
95
+    ));
96 96
 } catch (\Exception $e) {
97
-	\OCP\Util::logException('files', $e);
98
-	OCP\JSON::error(array(
99
-		'data' => array(
100
-			'exception' => '\Exception',
101
-			'message' => $l->t('Unknown error')
102
-		)
103
-	));
97
+    \OCP\Util::logException('files', $e);
98
+    OCP\JSON::error(array(
99
+        'data' => array(
100
+            'exception' => '\Exception',
101
+            'message' => $l->t('Unknown error')
102
+        )
103
+    ));
104 104
 }
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 $l = \OC::$server->getL10N('files');
29 29
 
30 30
 // Load the files
31
-$dir = isset($_GET['dir']) ? (string)$_GET['dir'] : '';
31
+$dir = isset($_GET['dir']) ? (string) $_GET['dir'] : '';
32 32
 $dir = \OC\Files\Filesystem::normalizePath($dir);
33 33
 
34 34
 try {
@@ -39,11 +39,11 @@  discard block
 block discarded – undo
39 39
 	}
40 40
 
41 41
 	$data = array();
42
-	$baseUrl = OCP\Util::linkTo('files', 'index.php') . '?dir=';
42
+	$baseUrl = OCP\Util::linkTo('files', 'index.php').'?dir=';
43 43
 
44 44
 	$permissions = $dirInfo->getPermissions();
45 45
 
46
-	$sortAttribute = isset($_GET['sort']) ? (string)$_GET['sort'] : 'name';
46
+	$sortAttribute = isset($_GET['sort']) ? (string) $_GET['sort'] : 'name';
47 47
 	$sortDirection = isset($_GET['sortdirection']) ? ($_GET['sortdirection'] === 'desc') : false;
48 48
 	$mimetypeFilters = isset($_GET['mimetypes']) ? json_decode($_GET['mimetypes']) : '';
49 49
 
Please login to merge, or discard this patch.
apps/files/ajax/download.php 2 patches
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 $files_list = json_decode($files);
38 38
 // in case we get only a single file
39 39
 if (!is_array($files_list)) {
40
-	$files_list = array($files);
40
+    $files_list = array($files);
41 41
 }
42 42
 
43 43
 /**
@@ -46,9 +46,9 @@  discard block
 block discarded – undo
46 46
  * alphanumeric characters
47 47
  */
48 48
 if(isset($_GET['downloadStartSecret'])
49
-	&& !isset($_GET['downloadStartSecret'][32])
50
-	&& preg_match('!^[a-zA-Z0-9]+$!', $_GET['downloadStartSecret']) === 1) {
51
-	setcookie('ocDownloadStarted', $_GET['downloadStartSecret'], time() + 20, '/');
49
+    && !isset($_GET['downloadStartSecret'][32])
50
+    && preg_match('!^[a-zA-Z0-9]+$!', $_GET['downloadStartSecret']) === 1) {
51
+    setcookie('ocDownloadStarted', $_GET['downloadStartSecret'], time() + 20, '/');
52 52
 }
53 53
 
54 54
 $server_params = array( 'head' => \OC::$server->getRequest()->getMethod() == 'HEAD' );
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
  * Http range requests support
58 58
  */
59 59
 if (isset($_SERVER['HTTP_RANGE'])) {
60
-	$server_params['range'] = \OC::$server->getRequest()->getHeader('Range');
60
+    $server_params['range'] = \OC::$server->getRequest()->getHeader('Range');
61 61
 }
62 62
 
63 63
 OC_Files::get($dir, $files_list, $server_params);
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
31 31
 OCP\User::checkLoggedIn();
32 32
 \OC::$server->getSession()->close();
33 33
 
34
-$files = isset($_GET['files']) ? (string)$_GET['files'] : '';
35
-$dir = isset($_GET['dir']) ? (string)$_GET['dir'] : '';
34
+$files = isset($_GET['files']) ? (string) $_GET['files'] : '';
35
+$dir = isset($_GET['dir']) ? (string) $_GET['dir'] : '';
36 36
 
37 37
 $files_list = json_decode($files);
38 38
 // in case we get only a single file
@@ -45,13 +45,13 @@  discard block
 block discarded – undo
45 45
  * the content must not be longer than 32 characters and must only contain
46 46
  * alphanumeric characters
47 47
  */
48
-if(isset($_GET['downloadStartSecret'])
48
+if (isset($_GET['downloadStartSecret'])
49 49
 	&& !isset($_GET['downloadStartSecret'][32])
50 50
 	&& preg_match('!^[a-zA-Z0-9]+$!', $_GET['downloadStartSecret']) === 1) {
51 51
 	setcookie('ocDownloadStarted', $_GET['downloadStartSecret'], time() + 20, '/');
52 52
 }
53 53
 
54
-$server_params = array( 'head' => \OC::$server->getRequest()->getMethod() == 'HEAD' );
54
+$server_params = array('head' => \OC::$server->getRequest()->getMethod() == 'HEAD');
55 55
 
56 56
 /**
57 57
  * Http range requests support
Please login to merge, or discard this patch.
apps/files/lib/Activity/Provider.php 2 patches
Indentation   +272 added lines, -272 removed lines patch added patch discarded remove patch
@@ -33,276 +33,276 @@
 block discarded – undo
33 33
 
34 34
 class Provider implements IProvider {
35 35
 
36
-	/** @var IFactory */
37
-	protected $languageFactory;
38
-
39
-	/** @var IL10N */
40
-	protected $l;
41
-
42
-	/** @var IURLGenerator */
43
-	protected $url;
44
-
45
-	/** @var IManager */
46
-	protected $activityManager;
47
-
48
-	/** @var IUserManager */
49
-	protected $userManager;
50
-
51
-	/** @var IEventMerger */
52
-	protected $eventMerger;
53
-
54
-	/** @var string[] cached displayNames - key is the UID and value the displayname */
55
-	protected $displayNames = [];
56
-
57
-	/**
58
-	 * @param IFactory $languageFactory
59
-	 * @param IURLGenerator $url
60
-	 * @param IManager $activityManager
61
-	 * @param IUserManager $userManager
62
-	 * @param IEventMerger $eventMerger
63
-	 */
64
-	public function __construct(IFactory $languageFactory, IURLGenerator $url, IManager $activityManager, IUserManager $userManager, IEventMerger $eventMerger) {
65
-		$this->languageFactory = $languageFactory;
66
-		$this->url = $url;
67
-		$this->activityManager = $activityManager;
68
-		$this->userManager = $userManager;
69
-		$this->eventMerger = $eventMerger;
70
-	}
71
-
72
-	/**
73
-	 * @param string $language
74
-	 * @param IEvent $event
75
-	 * @param IEvent|null $previousEvent
76
-	 * @return IEvent
77
-	 * @throws \InvalidArgumentException
78
-	 * @since 11.0.0
79
-	 */
80
-	public function parse($language, IEvent $event, IEvent $previousEvent = null) {
81
-		if ($event->getApp() !== 'files') {
82
-			throw new \InvalidArgumentException();
83
-		}
84
-
85
-		$this->l = $this->languageFactory->get('files', $language);
86
-
87
-		if ($this->activityManager->isFormattingFilteredObject()) {
88
-			try {
89
-				return $this->parseShortVersion($event, $previousEvent);
90
-			} catch (\InvalidArgumentException $e) {
91
-				// Ignore and simply use the long version...
92
-			}
93
-		}
94
-
95
-		return $this->parseLongVersion($event, $previousEvent);
96
-	}
97
-
98
-	/**
99
-	 * @param IEvent $event
100
-	 * @param IEvent|null $previousEvent
101
-	 * @return IEvent
102
-	 * @throws \InvalidArgumentException
103
-	 * @since 11.0.0
104
-	 */
105
-	public function parseShortVersion(IEvent $event, IEvent $previousEvent = null) {
106
-		$parsedParameters = $this->getParameters($event);
107
-
108
-		if ($event->getSubject() === 'created_by') {
109
-			$subject = $this->l->t('Created by {user}');
110
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'add-color.svg')));
111
-		} else if ($event->getSubject() === 'changed_by') {
112
-			$subject = $this->l->t('Changed by {user}');
113
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
114
-		} else if ($event->getSubject() === 'deleted_by') {
115
-			$subject = $this->l->t('Deleted by {user}');
116
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'delete-color.svg')));
117
-		} else if ($event->getSubject() === 'restored_by') {
118
-			$subject = $this->l->t('Restored by {user}');
119
-		} else if ($event->getSubject() === 'renamed_by') {
120
-			$subject = $this->l->t('Renamed by {user}');
121
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
122
-		} else if ($event->getSubject() === 'moved_by') {
123
-			$subject = $this->l->t('Moved by {user}');
124
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
125
-		} else {
126
-			throw new \InvalidArgumentException();
127
-		}
128
-
129
-		$this->setSubjects($event, $subject, $parsedParameters);
130
-
131
-		return $this->eventMerger->mergeEvents('user', $event, $previousEvent);
132
-	}
133
-
134
-	/**
135
-	 * @param IEvent $event
136
-	 * @param IEvent|null $previousEvent
137
-	 * @return IEvent
138
-	 * @throws \InvalidArgumentException
139
-	 * @since 11.0.0
140
-	 */
141
-	public function parseLongVersion(IEvent $event, IEvent $previousEvent = null) {
142
-		$parsedParameters = $this->getParameters($event);
143
-
144
-		if ($event->getSubject() === 'created_self') {
145
-			$subject = $this->l->t('You created {file}');
146
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'add-color.svg')));
147
-		} else if ($event->getSubject() === 'created_by') {
148
-			$subject = $this->l->t('{user} created {file}');
149
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'add-color.svg')));
150
-		} else if ($event->getSubject() === 'created_public') {
151
-			$subject = $this->l->t('{file} was created in a public folder');
152
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'add-color.svg')));
153
-		} else if ($event->getSubject() === 'changed_self') {
154
-			$subject = $this->l->t('You changed {file}');
155
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
156
-		} else if ($event->getSubject() === 'changed_by') {
157
-			$subject = $this->l->t('{user} changed {file}');
158
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
159
-		} else if ($event->getSubject() === 'deleted_self') {
160
-			$subject = $this->l->t('You deleted {file}');
161
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'delete-color.svg')));
162
-		} else if ($event->getSubject() === 'deleted_by') {
163
-			$subject = $this->l->t('{user} deleted {file}');
164
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'delete-color.svg')));
165
-		} else if ($event->getSubject() === 'restored_self') {
166
-			$subject = $this->l->t('You restored {file}');
167
-		} else if ($event->getSubject() === 'restored_by') {
168
-			$subject = $this->l->t('{user} restored {file}');
169
-		} else if ($event->getSubject() === 'renamed_self') {
170
-			$subject = $this->l->t('You renamed {oldfile} to {newfile}');
171
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
172
-		} else if ($event->getSubject() === 'renamed_by') {
173
-			$subject = $this->l->t('{user} renamed {oldfile} to {newfile}');
174
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
175
-		} else if ($event->getSubject() === 'moved_self') {
176
-			$subject = $this->l->t('You moved {oldfile} to {newfile}');
177
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
178
-		} else if ($event->getSubject() === 'moved_by') {
179
-			$subject = $this->l->t('{user} moved {oldfile} to {newfile}');
180
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
181
-		} else {
182
-			throw new \InvalidArgumentException();
183
-		}
184
-
185
-		$this->setSubjects($event, $subject, $parsedParameters);
186
-
187
-		$event = $this->eventMerger->mergeEvents('file', $event, $previousEvent);
188
-
189
-		if ($event->getChildEvent() === null) {
190
-			// Couldn't group by file, maybe we can group by user
191
-			$event = $this->eventMerger->mergeEvents('user', $event, $previousEvent);
192
-		}
193
-
194
-		return $event;
195
-	}
196
-
197
-	protected function setSubjects(IEvent $event, $subject, array $parameters) {
198
-		$placeholders = $replacements = [];
199
-		foreach ($parameters as $placeholder => $parameter) {
200
-			$placeholders[] = '{' . $placeholder . '}';
201
-			if ($parameter['type'] === 'file') {
202
-				$replacements[] = $parameter['path'];
203
-			} else {
204
-				$replacements[] = $parameter['name'];
205
-			}
206
-		}
207
-
208
-		$event->setParsedSubject(str_replace($placeholders, $replacements, $subject))
209
-			->setRichSubject($subject, $parameters);
210
-	}
211
-
212
-	/**
213
-	 * @param IEvent $event
214
-	 * @return array
215
-	 * @throws \InvalidArgumentException
216
-	 */
217
-	protected function getParameters(IEvent $event) {
218
-		$parameters = $event->getSubjectParameters();
219
-		switch ($event->getSubject()) {
220
-			case 'created_self':
221
-			case 'created_public':
222
-			case 'changed_self':
223
-			case 'deleted_self':
224
-			case 'restored_self':
225
-				return [
226
-					'file' => $this->getFile($parameters[0], $event),
227
-				];
228
-			case 'created_by':
229
-			case 'changed_by':
230
-			case 'deleted_by':
231
-			case 'restored_by':
232
-				return [
233
-					'file' => $this->getFile($parameters[0], $event),
234
-					'user' => $this->getUser($parameters[1]),
235
-				];
236
-			case 'renamed_self':
237
-			case 'moved_self':
238
-				return [
239
-					'newfile' => $this->getFile($parameters[0]),
240
-					'oldfile' => $this->getFile($parameters[1]),
241
-				];
242
-			case 'renamed_by':
243
-			case 'moved_by':
244
-				return [
245
-					'newfile' => $this->getFile($parameters[0]),
246
-					'user' => $this->getUser($parameters[1]),
247
-					'oldfile' => $this->getFile($parameters[2]),
248
-				];
249
-		}
250
-		return [];
251
-	}
252
-
253
-	/**
254
-	 * @param array|string $parameter
255
-	 * @param IEvent|null $event
256
-	 * @return array
257
-	 * @throws \InvalidArgumentException
258
-	 */
259
-	protected function getFile($parameter, IEvent $event = null) {
260
-		if (is_array($parameter)) {
261
-			$path = reset($parameter);
262
-			$id = (string) key($parameter);
263
-		} else if ($event !== null) {
264
-			// Legacy from before ownCloud 8.2
265
-			$path = $parameter;
266
-			$id = $event->getObjectId();
267
-		} else {
268
-			throw new \InvalidArgumentException('Could not generate file parameter');
269
-		}
270
-
271
-		return [
272
-			'type' => 'file',
273
-			'id' => $id,
274
-			'name' => basename($path),
275
-			'path' => trim($path, '/'),
276
-			'link' => $this->url->linkToRouteAbsolute('files.viewcontroller.showFile', ['fileid' => $id]),
277
-		];
278
-	}
279
-
280
-	/**
281
-	 * @param string $uid
282
-	 * @return array
283
-	 */
284
-	protected function getUser($uid) {
285
-		if (!isset($this->displayNames[$uid])) {
286
-			$this->displayNames[$uid] = $this->getDisplayName($uid);
287
-		}
288
-
289
-		return [
290
-			'type' => 'user',
291
-			'id' => $uid,
292
-			'name' => $this->displayNames[$uid],
293
-		];
294
-	}
295
-
296
-	/**
297
-	 * @param string $uid
298
-	 * @return string
299
-	 */
300
-	protected function getDisplayName($uid) {
301
-		$user = $this->userManager->get($uid);
302
-		if ($user instanceof IUser) {
303
-			return $user->getDisplayName();
304
-		} else {
305
-			return $uid;
306
-		}
307
-	}
36
+    /** @var IFactory */
37
+    protected $languageFactory;
38
+
39
+    /** @var IL10N */
40
+    protected $l;
41
+
42
+    /** @var IURLGenerator */
43
+    protected $url;
44
+
45
+    /** @var IManager */
46
+    protected $activityManager;
47
+
48
+    /** @var IUserManager */
49
+    protected $userManager;
50
+
51
+    /** @var IEventMerger */
52
+    protected $eventMerger;
53
+
54
+    /** @var string[] cached displayNames - key is the UID and value the displayname */
55
+    protected $displayNames = [];
56
+
57
+    /**
58
+     * @param IFactory $languageFactory
59
+     * @param IURLGenerator $url
60
+     * @param IManager $activityManager
61
+     * @param IUserManager $userManager
62
+     * @param IEventMerger $eventMerger
63
+     */
64
+    public function __construct(IFactory $languageFactory, IURLGenerator $url, IManager $activityManager, IUserManager $userManager, IEventMerger $eventMerger) {
65
+        $this->languageFactory = $languageFactory;
66
+        $this->url = $url;
67
+        $this->activityManager = $activityManager;
68
+        $this->userManager = $userManager;
69
+        $this->eventMerger = $eventMerger;
70
+    }
71
+
72
+    /**
73
+     * @param string $language
74
+     * @param IEvent $event
75
+     * @param IEvent|null $previousEvent
76
+     * @return IEvent
77
+     * @throws \InvalidArgumentException
78
+     * @since 11.0.0
79
+     */
80
+    public function parse($language, IEvent $event, IEvent $previousEvent = null) {
81
+        if ($event->getApp() !== 'files') {
82
+            throw new \InvalidArgumentException();
83
+        }
84
+
85
+        $this->l = $this->languageFactory->get('files', $language);
86
+
87
+        if ($this->activityManager->isFormattingFilteredObject()) {
88
+            try {
89
+                return $this->parseShortVersion($event, $previousEvent);
90
+            } catch (\InvalidArgumentException $e) {
91
+                // Ignore and simply use the long version...
92
+            }
93
+        }
94
+
95
+        return $this->parseLongVersion($event, $previousEvent);
96
+    }
97
+
98
+    /**
99
+     * @param IEvent $event
100
+     * @param IEvent|null $previousEvent
101
+     * @return IEvent
102
+     * @throws \InvalidArgumentException
103
+     * @since 11.0.0
104
+     */
105
+    public function parseShortVersion(IEvent $event, IEvent $previousEvent = null) {
106
+        $parsedParameters = $this->getParameters($event);
107
+
108
+        if ($event->getSubject() === 'created_by') {
109
+            $subject = $this->l->t('Created by {user}');
110
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'add-color.svg')));
111
+        } else if ($event->getSubject() === 'changed_by') {
112
+            $subject = $this->l->t('Changed by {user}');
113
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
114
+        } else if ($event->getSubject() === 'deleted_by') {
115
+            $subject = $this->l->t('Deleted by {user}');
116
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'delete-color.svg')));
117
+        } else if ($event->getSubject() === 'restored_by') {
118
+            $subject = $this->l->t('Restored by {user}');
119
+        } else if ($event->getSubject() === 'renamed_by') {
120
+            $subject = $this->l->t('Renamed by {user}');
121
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
122
+        } else if ($event->getSubject() === 'moved_by') {
123
+            $subject = $this->l->t('Moved by {user}');
124
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
125
+        } else {
126
+            throw new \InvalidArgumentException();
127
+        }
128
+
129
+        $this->setSubjects($event, $subject, $parsedParameters);
130
+
131
+        return $this->eventMerger->mergeEvents('user', $event, $previousEvent);
132
+    }
133
+
134
+    /**
135
+     * @param IEvent $event
136
+     * @param IEvent|null $previousEvent
137
+     * @return IEvent
138
+     * @throws \InvalidArgumentException
139
+     * @since 11.0.0
140
+     */
141
+    public function parseLongVersion(IEvent $event, IEvent $previousEvent = null) {
142
+        $parsedParameters = $this->getParameters($event);
143
+
144
+        if ($event->getSubject() === 'created_self') {
145
+            $subject = $this->l->t('You created {file}');
146
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'add-color.svg')));
147
+        } else if ($event->getSubject() === 'created_by') {
148
+            $subject = $this->l->t('{user} created {file}');
149
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'add-color.svg')));
150
+        } else if ($event->getSubject() === 'created_public') {
151
+            $subject = $this->l->t('{file} was created in a public folder');
152
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'add-color.svg')));
153
+        } else if ($event->getSubject() === 'changed_self') {
154
+            $subject = $this->l->t('You changed {file}');
155
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
156
+        } else if ($event->getSubject() === 'changed_by') {
157
+            $subject = $this->l->t('{user} changed {file}');
158
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
159
+        } else if ($event->getSubject() === 'deleted_self') {
160
+            $subject = $this->l->t('You deleted {file}');
161
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'delete-color.svg')));
162
+        } else if ($event->getSubject() === 'deleted_by') {
163
+            $subject = $this->l->t('{user} deleted {file}');
164
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'delete-color.svg')));
165
+        } else if ($event->getSubject() === 'restored_self') {
166
+            $subject = $this->l->t('You restored {file}');
167
+        } else if ($event->getSubject() === 'restored_by') {
168
+            $subject = $this->l->t('{user} restored {file}');
169
+        } else if ($event->getSubject() === 'renamed_self') {
170
+            $subject = $this->l->t('You renamed {oldfile} to {newfile}');
171
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
172
+        } else if ($event->getSubject() === 'renamed_by') {
173
+            $subject = $this->l->t('{user} renamed {oldfile} to {newfile}');
174
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
175
+        } else if ($event->getSubject() === 'moved_self') {
176
+            $subject = $this->l->t('You moved {oldfile} to {newfile}');
177
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
178
+        } else if ($event->getSubject() === 'moved_by') {
179
+            $subject = $this->l->t('{user} moved {oldfile} to {newfile}');
180
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('files', 'change.svg')));
181
+        } else {
182
+            throw new \InvalidArgumentException();
183
+        }
184
+
185
+        $this->setSubjects($event, $subject, $parsedParameters);
186
+
187
+        $event = $this->eventMerger->mergeEvents('file', $event, $previousEvent);
188
+
189
+        if ($event->getChildEvent() === null) {
190
+            // Couldn't group by file, maybe we can group by user
191
+            $event = $this->eventMerger->mergeEvents('user', $event, $previousEvent);
192
+        }
193
+
194
+        return $event;
195
+    }
196
+
197
+    protected function setSubjects(IEvent $event, $subject, array $parameters) {
198
+        $placeholders = $replacements = [];
199
+        foreach ($parameters as $placeholder => $parameter) {
200
+            $placeholders[] = '{' . $placeholder . '}';
201
+            if ($parameter['type'] === 'file') {
202
+                $replacements[] = $parameter['path'];
203
+            } else {
204
+                $replacements[] = $parameter['name'];
205
+            }
206
+        }
207
+
208
+        $event->setParsedSubject(str_replace($placeholders, $replacements, $subject))
209
+            ->setRichSubject($subject, $parameters);
210
+    }
211
+
212
+    /**
213
+     * @param IEvent $event
214
+     * @return array
215
+     * @throws \InvalidArgumentException
216
+     */
217
+    protected function getParameters(IEvent $event) {
218
+        $parameters = $event->getSubjectParameters();
219
+        switch ($event->getSubject()) {
220
+            case 'created_self':
221
+            case 'created_public':
222
+            case 'changed_self':
223
+            case 'deleted_self':
224
+            case 'restored_self':
225
+                return [
226
+                    'file' => $this->getFile($parameters[0], $event),
227
+                ];
228
+            case 'created_by':
229
+            case 'changed_by':
230
+            case 'deleted_by':
231
+            case 'restored_by':
232
+                return [
233
+                    'file' => $this->getFile($parameters[0], $event),
234
+                    'user' => $this->getUser($parameters[1]),
235
+                ];
236
+            case 'renamed_self':
237
+            case 'moved_self':
238
+                return [
239
+                    'newfile' => $this->getFile($parameters[0]),
240
+                    'oldfile' => $this->getFile($parameters[1]),
241
+                ];
242
+            case 'renamed_by':
243
+            case 'moved_by':
244
+                return [
245
+                    'newfile' => $this->getFile($parameters[0]),
246
+                    'user' => $this->getUser($parameters[1]),
247
+                    'oldfile' => $this->getFile($parameters[2]),
248
+                ];
249
+        }
250
+        return [];
251
+    }
252
+
253
+    /**
254
+     * @param array|string $parameter
255
+     * @param IEvent|null $event
256
+     * @return array
257
+     * @throws \InvalidArgumentException
258
+     */
259
+    protected function getFile($parameter, IEvent $event = null) {
260
+        if (is_array($parameter)) {
261
+            $path = reset($parameter);
262
+            $id = (string) key($parameter);
263
+        } else if ($event !== null) {
264
+            // Legacy from before ownCloud 8.2
265
+            $path = $parameter;
266
+            $id = $event->getObjectId();
267
+        } else {
268
+            throw new \InvalidArgumentException('Could not generate file parameter');
269
+        }
270
+
271
+        return [
272
+            'type' => 'file',
273
+            'id' => $id,
274
+            'name' => basename($path),
275
+            'path' => trim($path, '/'),
276
+            'link' => $this->url->linkToRouteAbsolute('files.viewcontroller.showFile', ['fileid' => $id]),
277
+        ];
278
+    }
279
+
280
+    /**
281
+     * @param string $uid
282
+     * @return array
283
+     */
284
+    protected function getUser($uid) {
285
+        if (!isset($this->displayNames[$uid])) {
286
+            $this->displayNames[$uid] = $this->getDisplayName($uid);
287
+        }
288
+
289
+        return [
290
+            'type' => 'user',
291
+            'id' => $uid,
292
+            'name' => $this->displayNames[$uid],
293
+        ];
294
+    }
295
+
296
+    /**
297
+     * @param string $uid
298
+     * @return string
299
+     */
300
+    protected function getDisplayName($uid) {
301
+        $user = $this->userManager->get($uid);
302
+        if ($user instanceof IUser) {
303
+            return $user->getDisplayName();
304
+        } else {
305
+            return $uid;
306
+        }
307
+    }
308 308
 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -197,7 +197,7 @@
 block discarded – undo
197 197
 	protected function setSubjects(IEvent $event, $subject, array $parameters) {
198 198
 		$placeholders = $replacements = [];
199 199
 		foreach ($parameters as $placeholder => $parameter) {
200
-			$placeholders[] = '{' . $placeholder . '}';
200
+			$placeholders[] = '{'.$placeholder.'}';
201 201
 			if ($parameter['type'] === 'file') {
202 202
 				$replacements[] = $parameter['path'];
203 203
 			} else {
Please login to merge, or discard this patch.
apps/files/lib/Activity/FavoriteProvider.php 1 patch
Indentation   +127 added lines, -127 removed lines patch added patch discarded remove patch
@@ -31,131 +31,131 @@
 block discarded – undo
31 31
 
32 32
 class FavoriteProvider implements IProvider {
33 33
 
34
-	const SUBJECT_ADDED = 'added_favorite';
35
-	const SUBJECT_REMOVED = 'removed_favorite';
36
-
37
-	/** @var IFactory */
38
-	protected $languageFactory;
39
-
40
-	/** @var IL10N */
41
-	protected $l;
42
-
43
-	/** @var IURLGenerator */
44
-	protected $url;
45
-
46
-	/** @var IManager */
47
-	protected $activityManager;
48
-
49
-	/** @var IEventMerger */
50
-	protected $eventMerger;
51
-
52
-	/**
53
-	 * @param IFactory $languageFactory
54
-	 * @param IURLGenerator $url
55
-	 * @param IManager $activityManager
56
-	 * @param IEventMerger $eventMerger
57
-	 */
58
-	public function __construct(IFactory $languageFactory, IURLGenerator $url, IManager $activityManager, IEventMerger $eventMerger) {
59
-		$this->languageFactory = $languageFactory;
60
-		$this->url = $url;
61
-		$this->activityManager = $activityManager;
62
-		$this->eventMerger = $eventMerger;
63
-	}
64
-
65
-	/**
66
-	 * @param string $language
67
-	 * @param IEvent $event
68
-	 * @param IEvent|null $previousEvent
69
-	 * @return IEvent
70
-	 * @throws \InvalidArgumentException
71
-	 * @since 11.0.0
72
-	 */
73
-	public function parse($language, IEvent $event, IEvent $previousEvent = null) {
74
-		if ($event->getApp() !== 'files' || $event->getType() !== 'favorite') {
75
-			throw new \InvalidArgumentException();
76
-		}
77
-
78
-		$this->l = $this->languageFactory->get('files', $language);
79
-
80
-		if ($this->activityManager->isFormattingFilteredObject()) {
81
-			try {
82
-				return $this->parseShortVersion($event);
83
-			} catch (\InvalidArgumentException $e) {
84
-				// Ignore and simply use the long version...
85
-			}
86
-		}
87
-
88
-		return $this->parseLongVersion($event, $previousEvent);
89
-	}
90
-
91
-	/**
92
-	 * @param IEvent $event
93
-	 * @return IEvent
94
-	 * @throws \InvalidArgumentException
95
-	 * @since 11.0.0
96
-	 */
97
-	public function parseShortVersion(IEvent $event) {
98
-
99
-		if ($event->getSubject() === self::SUBJECT_ADDED) {
100
-			$event->setParsedSubject($this->l->t('Added to favorites'))
101
-				->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/starred.svg')));
102
-		} else if ($event->getSubject() === self::SUBJECT_REMOVED) {
103
-			$event->setParsedSubject($this->l->t('Removed from favorites'))
104
-				->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/star.svg')));
105
-		} else {
106
-			throw new \InvalidArgumentException();
107
-		}
108
-
109
-		return $event;
110
-	}
111
-
112
-	/**
113
-	 * @param IEvent $event
114
-	 * @param IEvent|null $previousEvent
115
-	 * @return IEvent
116
-	 * @throws \InvalidArgumentException
117
-	 * @since 11.0.0
118
-	 */
119
-	public function parseLongVersion(IEvent $event, IEvent $previousEvent = null) {
120
-
121
-		if ($event->getSubject() === self::SUBJECT_ADDED) {
122
-			$subject = $this->l->t('You added {file} to your favorites');
123
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/starred.svg')));
124
-		} else if ($event->getSubject() === self::SUBJECT_REMOVED) {
125
-			$subject = $this->l->t('You removed {file} from your favorites');
126
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/star.svg')));
127
-		} else {
128
-			throw new \InvalidArgumentException();
129
-		}
130
-
131
-		$this->setSubjects($event, $subject);
132
-		$event = $this->eventMerger->mergeEvents('file', $event, $previousEvent);
133
-		return $event;
134
-	}
135
-
136
-	/**
137
-	 * @param IEvent $event
138
-	 * @param string $subject
139
-	 */
140
-	protected function setSubjects(IEvent $event, $subject) {
141
-		$subjectParams = $event->getSubjectParameters();
142
-		if (empty($subjectParams)) {
143
-			// Try to fall back to the old way, but this does not work for emails.
144
-			// But at least old activities still work.
145
-			$subjectParams = [
146
-				'id' => $event->getObjectId(),
147
-				'path' => $event->getObjectName(),
148
-			];
149
-		}
150
-		$parameter = [
151
-			'type' => 'file',
152
-			'id' => $subjectParams['id'],
153
-			'name' => basename($subjectParams['path']),
154
-			'path' => trim($subjectParams['path'], '/'),
155
-			'link' => $this->url->linkToRouteAbsolute('files.viewcontroller.showFile', ['fileid' => $subjectParams['id']]),
156
-		];
157
-
158
-		$event->setParsedSubject(str_replace('{file}', $parameter['path'], $subject))
159
-			->setRichSubject($subject, ['file' => $parameter]);
160
-	}
34
+    const SUBJECT_ADDED = 'added_favorite';
35
+    const SUBJECT_REMOVED = 'removed_favorite';
36
+
37
+    /** @var IFactory */
38
+    protected $languageFactory;
39
+
40
+    /** @var IL10N */
41
+    protected $l;
42
+
43
+    /** @var IURLGenerator */
44
+    protected $url;
45
+
46
+    /** @var IManager */
47
+    protected $activityManager;
48
+
49
+    /** @var IEventMerger */
50
+    protected $eventMerger;
51
+
52
+    /**
53
+     * @param IFactory $languageFactory
54
+     * @param IURLGenerator $url
55
+     * @param IManager $activityManager
56
+     * @param IEventMerger $eventMerger
57
+     */
58
+    public function __construct(IFactory $languageFactory, IURLGenerator $url, IManager $activityManager, IEventMerger $eventMerger) {
59
+        $this->languageFactory = $languageFactory;
60
+        $this->url = $url;
61
+        $this->activityManager = $activityManager;
62
+        $this->eventMerger = $eventMerger;
63
+    }
64
+
65
+    /**
66
+     * @param string $language
67
+     * @param IEvent $event
68
+     * @param IEvent|null $previousEvent
69
+     * @return IEvent
70
+     * @throws \InvalidArgumentException
71
+     * @since 11.0.0
72
+     */
73
+    public function parse($language, IEvent $event, IEvent $previousEvent = null) {
74
+        if ($event->getApp() !== 'files' || $event->getType() !== 'favorite') {
75
+            throw new \InvalidArgumentException();
76
+        }
77
+
78
+        $this->l = $this->languageFactory->get('files', $language);
79
+
80
+        if ($this->activityManager->isFormattingFilteredObject()) {
81
+            try {
82
+                return $this->parseShortVersion($event);
83
+            } catch (\InvalidArgumentException $e) {
84
+                // Ignore and simply use the long version...
85
+            }
86
+        }
87
+
88
+        return $this->parseLongVersion($event, $previousEvent);
89
+    }
90
+
91
+    /**
92
+     * @param IEvent $event
93
+     * @return IEvent
94
+     * @throws \InvalidArgumentException
95
+     * @since 11.0.0
96
+     */
97
+    public function parseShortVersion(IEvent $event) {
98
+
99
+        if ($event->getSubject() === self::SUBJECT_ADDED) {
100
+            $event->setParsedSubject($this->l->t('Added to favorites'))
101
+                ->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/starred.svg')));
102
+        } else if ($event->getSubject() === self::SUBJECT_REMOVED) {
103
+            $event->setParsedSubject($this->l->t('Removed from favorites'))
104
+                ->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/star.svg')));
105
+        } else {
106
+            throw new \InvalidArgumentException();
107
+        }
108
+
109
+        return $event;
110
+    }
111
+
112
+    /**
113
+     * @param IEvent $event
114
+     * @param IEvent|null $previousEvent
115
+     * @return IEvent
116
+     * @throws \InvalidArgumentException
117
+     * @since 11.0.0
118
+     */
119
+    public function parseLongVersion(IEvent $event, IEvent $previousEvent = null) {
120
+
121
+        if ($event->getSubject() === self::SUBJECT_ADDED) {
122
+            $subject = $this->l->t('You added {file} to your favorites');
123
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/starred.svg')));
124
+        } else if ($event->getSubject() === self::SUBJECT_REMOVED) {
125
+            $subject = $this->l->t('You removed {file} from your favorites');
126
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/star.svg')));
127
+        } else {
128
+            throw new \InvalidArgumentException();
129
+        }
130
+
131
+        $this->setSubjects($event, $subject);
132
+        $event = $this->eventMerger->mergeEvents('file', $event, $previousEvent);
133
+        return $event;
134
+    }
135
+
136
+    /**
137
+     * @param IEvent $event
138
+     * @param string $subject
139
+     */
140
+    protected function setSubjects(IEvent $event, $subject) {
141
+        $subjectParams = $event->getSubjectParameters();
142
+        if (empty($subjectParams)) {
143
+            // Try to fall back to the old way, but this does not work for emails.
144
+            // But at least old activities still work.
145
+            $subjectParams = [
146
+                'id' => $event->getObjectId(),
147
+                'path' => $event->getObjectName(),
148
+            ];
149
+        }
150
+        $parameter = [
151
+            'type' => 'file',
152
+            'id' => $subjectParams['id'],
153
+            'name' => basename($subjectParams['path']),
154
+            'path' => trim($subjectParams['path'], '/'),
155
+            'link' => $this->url->linkToRouteAbsolute('files.viewcontroller.showFile', ['fileid' => $subjectParams['id']]),
156
+        ];
157
+
158
+        $event->setParsedSubject(str_replace('{file}', $parameter['path'], $subject))
159
+            ->setRichSubject($subject, ['file' => $parameter]);
160
+    }
161 161
 }
Please login to merge, or discard this patch.