Completed
Pull Request — master (#4212)
by Individual IT
13:52
created
core/Controller/LostController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -132,7 +132,7 @@
 block discarded – undo
132 132
 	}
133 133
 
134 134
 	/**
135
-	 * @param $message
135
+	 * @param string $message
136 136
 	 * @param array $additional
137 137
 	 * @return array
138 138
 	 */
Please login to merge, or discard this patch.
apps/user_ldap/lib/Access.php 1 patch
Doc Comments   +8 added lines, -6 removed lines patch added patch discarded remove patch
@@ -361,7 +361,7 @@  discard block
 block discarded – undo
361 361
 
362 362
 	/**
363 363
 	 * returns the internal ownCloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
364
-	 * @param string $dn the dn of the user object
364
+	 * @param string $fdn the dn of the user object
365 365
 	 * @param string $ldapName optional, the display name of the object
366 366
 	 * @return string|false with with the name to use in ownCloud
367 367
 	 */
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
 
379 379
 	/**
380 380
 	 * returns an internal ownCloud name for the given LDAP DN, false on DN outside of search DN
381
-	 * @param string $dn the dn of the user object
381
+	 * @param string $fdn the dn of the user object
382 382
 	 * @param string $ldapName optional, the display name of the object
383 383
 	 * @param bool $isUser optional, whether it is a user object (otherwise group assumed)
384 384
 	 * @return string|false with with the name to use in ownCloud
@@ -638,7 +638,7 @@  discard block
 block discarded – undo
638 638
 	 * the login filter.
639 639
 	 *
640 640
 	 * @param string $loginName
641
-	 * @param array $attributes optional, list of attributes to read
641
+	 * @param string[] $attributes optional, list of attributes to read
642 642
 	 * @return array
643 643
 	 */
644 644
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -711,7 +711,7 @@  discard block
 block discarded – undo
711 711
 
712 712
 	/**
713 713
 	 * @param string $filter
714
-	 * @param string|string[] $attr
714
+	 * @param string[] $attr
715 715
 	 * @param int $limit
716 716
 	 * @param int $offset
717 717
 	 * @return array
@@ -759,7 +759,7 @@  discard block
 block discarded – undo
759 759
 
760 760
 	/**
761 761
 	 * @param string $filter
762
-	 * @param string|string[] $attr
762
+	 * @param string[] $attr
763 763
 	 * @param int $limit
764 764
 	 * @param int $offset
765 765
 	 * @return false|int
@@ -809,6 +809,7 @@  discard block
 block discarded – undo
809 809
 	 * retrieved. Results will according to the order in the array.
810 810
 	 * @param int $limit optional, maximum results to be counted
811 811
 	 * @param int $offset optional, a starting point
812
+	 * @param string $filter
812 813
 	 * @return array|false array with the search result as first value and pagedSearchOK as
813 814
 	 * second | false if not successful
814 815
 	 */
@@ -1063,7 +1064,7 @@  discard block
 block discarded – undo
1063 1064
 
1064 1065
 	/**
1065 1066
 	 * @param string $name
1066
-	 * @return bool|mixed|string
1067
+	 * @return string
1067 1068
 	 */
1068 1069
 	public function sanitizeUsername($name) {
1069 1070
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -1087,6 +1088,7 @@  discard block
 block discarded – undo
1087 1088
 	* escapes (user provided) parts for LDAP filter
1088 1089
 	* @param string $input, the provided value
1089 1090
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
1091
+	* @param string $input
1090 1092
 	* @return string the escaped string
1091 1093
 	*/
1092 1094
 	public function escapeFilterPart($input, $allowAsterisk = false) {
Please login to merge, or discard this patch.
apps/theming/lib/Util.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 	/**
53 53
 	 * get color for on-page elements:
54 54
 	 * theme color by default, grey if theme color is to bright
55
-	 * @param $color
55
+	 * @param string $color
56 56
 	 * @return string
57 57
 	 */
58 58
 	public function elementColor($color) {
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 	}
84 84
 
85 85
 	/**
86
-	 * @param $color
86
+	 * @param string $color
87 87
 	 * @return string base64 encoded radio button svg
88 88
 	 */
89 89
 	public function generateRadioButton($color) {
@@ -152,8 +152,8 @@  discard block
 block discarded – undo
152 152
 	/**
153 153
 	 * replace default color with a custom one
154 154
 	 *
155
-	 * @param $svg string content of a svg file
156
-	 * @param $color string color to match
155
+	 * @param string $svg string content of a svg file
156
+	 * @param string $color string color to match
157 157
 	 * @return string
158 158
 	 */
159 159
 	public function colorizeSvg($svg, $color) {
Please login to merge, or discard this patch.
apps/files_external/lib/Service/DBConfigService.php 1 patch
Doc Comments   +16 added lines patch added patch discarded remove patch
@@ -89,6 +89,9 @@  discard block
 block discarded – undo
89 89
 		return $this->getMountsFromQuery($query);
90 90
 	}
91 91
 
92
+	/**
93
+	 * @param string $userId
94
+	 */
92 95
 	public function getMountsForUser($userId, $groupIds) {
93 96
 		$builder = $this->connection->getQueryBuilder();
94 97
 		$query = $builder->select(['m.mount_id', 'mount_point', 'storage_backend', 'auth_backend', 'priority', 'm.type'])
@@ -125,6 +128,10 @@  discard block
 block discarded – undo
125 128
 		return $this->getMountsFromQuery($query);
126 129
 	}
127 130
 
131
+	/**
132
+	 * @param integer $type
133
+	 * @param string|null $value
134
+	 */
128 135
 	protected function getForQuery(IQueryBuilder $builder, $type, $value) {
129 136
 		$query = $builder->select(['m.mount_id', 'mount_point', 'storage_backend', 'auth_backend', 'priority', 'm.type'])
130 137
 			->from('external_mounts', 'm')
@@ -332,6 +339,9 @@  discard block
 block discarded – undo
332 339
 		}
333 340
 	}
334 341
 
342
+	/**
343
+	 * @param integer $mountId
344
+	 */
335 345
 	public function addApplicable($mountId, $type, $value) {
336 346
 		$this->connection->insertIfNotExist('*PREFIX*external_applicable', [
337 347
 			'mount_id' => $mountId,
@@ -340,6 +350,9 @@  discard block
 block discarded – undo
340 350
 		], ['mount_id', 'type', 'value']);
341 351
 	}
342 352
 
353
+	/**
354
+	 * @param integer $mountId
355
+	 */
343 356
 	public function removeApplicable($mountId, $type, $value) {
344 357
 		$builder = $this->connection->getQueryBuilder();
345 358
 		$query = $builder->delete('external_applicable')
@@ -473,6 +486,9 @@  discard block
 block discarded – undo
473 486
 		return array_combine($keys, $values);
474 487
 	}
475 488
 
489
+	/**
490
+	 * @param string $value
491
+	 */
476 492
 	private function encryptValue($value) {
477 493
 		return $this->crypto->encrypt($value);
478 494
 	}
Please login to merge, or discard this patch.
lib/private/AppFramework/OCS/BaseResponse.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 	/**
25 25
 	 * BaseResponse constructor.
26 26
 	 *
27
-	 * @param DataResponse|null $dataResponse
27
+	 * @param DataResponse $dataResponse
28 28
 	 * @param string $format
29 29
 	 * @param string|null $statusMessage
30 30
 	 * @param int|null $itemsCount
Please login to merge, or discard this patch.
lib/private/Server.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1143,7 +1143,7 @@  discard block
 block discarded – undo
1143 1143
 	 * Get the certificate manager for the user
1144 1144
 	 *
1145 1145
 	 * @param string $userId (optional) if not specified the current loggedin user is used, use null to get the system certificate manager
1146
-	 * @return \OCP\ICertificateManager | null if $uid is null and no user is logged in
1146
+	 * @return null|CertificateManager | null if $uid is null and no user is logged in
1147 1147
 	 */
1148 1148
 	public function getCertificateManager($userId = '') {
1149 1149
 		if ($userId === '') {
@@ -1464,6 +1464,7 @@  discard block
 block discarded – undo
1464 1464
 	}
1465 1465
 
1466 1466
 	/**
1467
+	 * @param string $app
1467 1468
 	 * @return \OCP\Files\IAppData
1468 1469
 	 */
1469 1470
 	public function getAppDataDir($app) {
Please login to merge, or discard this patch.
lib/public/AppFramework/Http/Response.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
 
227 227
 	/**
228 228
 	 * By default renders no output
229
-	 * @return null
229
+	 * @return string
230 230
 	 * @since 6.0.0
231 231
 	 */
232 232
 	public function render() {
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 
260 260
 	/**
261 261
 	 * Get the currently used Content-Security-Policy
262
-	 * @return EmptyContentSecurityPolicy|null Used Content-Security-Policy or null if
262
+	 * @return ContentSecurityPolicy|null Used Content-Security-Policy or null if
263 263
 	 *                                    none specified.
264 264
 	 * @since 8.1.0
265 265
 	 */
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/Publishing/PublishPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@
 block discarded – undo
134 134
 	 * @param RequestInterface $request
135 135
 	 * @param ResponseInterface $response
136 136
 	 *
137
-	 * @return void|bool
137
+	 * @return null|false
138 138
 	 */
139 139
 	public function httpPost(RequestInterface $request, ResponseInterface $response) {
140 140
 		$path = $request->getPath();
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/AddressBookRoot.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
 
31 31
 	/**
32 32
 	 * @param \Sabre\DAVACL\PrincipalBackend\BackendInterface $principalBackend
33
-	 * @param \Sabre\CardDAV\Backend\BackendInterface $carddavBackend
33
+	 * @param CardDavBackend $carddavBackend
34 34
 	 * @param string $principalPrefix
35 35
 	 */
36 36
 	public function __construct(\Sabre\DAVACL\PrincipalBackend\BackendInterface $principalBackend, \Sabre\CardDAV\Backend\BackendInterface $carddavBackend, $principalPrefix = 'principals') {
Please login to merge, or discard this patch.